30598 2009-10-20 13:44:06 -0700 LayoutTests/editing/selection/editable-html-element.html is flaky on Chrome bots 2009-10-21 14:44:42 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned eric jparent mjs ojan oldest_to_newest 156279 0 evan 2009-10-20 13:44:06 -0700 This test has had only mixed success on the Chromium builders. http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests%2Fediting%2Fselection%2Feditable-html-element.html The symptom when it fails is that runTest() is not defined. I haven't been able to reproduce the failure locally, but the JS experts suggest that perhaps these floating <script> tags are creating the body element too early. 156281 1 41521 evan 2009-10-20 13:46:20 -0700 Created attachment 41521 guess at a fix for the test 156336 2 evan 2009-10-20 16:34:10 -0700 The test in question, for those following at home http://trac.webkit.org/browser/trunk/LayoutTests/editing/selection/editable-html-element.html 156337 3 mjs 2009-10-20 16:42:44 -0700 I think it's almost impossible for this patch to affect the outcome of the test. <script> inside <html> will create an implicit <head>, and <body> will implicitly close the <head>. 156338 4 41521 evan 2009-10-20 16:42:58 -0700 Comment on attachment 41521 guess at a fix for the test maciej looked at this on IRC and suggested some other ideas. removing review bits. 156339 5 evan 2009-10-20 16:47:27 -0700 Chrome-side bug: http://code.google.com/p/chromium/issues/detail?id=25355 156503 6 41571 eric 2009-10-21 09:48:36 -0700 Created attachment 41571 results when the test fails 156504 7 eric 2009-10-21 09:49:04 -0700 I got those results by going to: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests%2Fediting%2Fselection%2Feditable-html-element.html and clicking on one of the red bars and downloading the layout-test-results.zip 156506 8 eric 2009-10-21 09:56:41 -0700 It looks like the only difference in results is the extra "runTest() is not defined". See the mac results: http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/editing/selection/editable-html-element-expected.txt?format=txt I wonder if this could be some sort of v8 bug where it's logging an non-sensical error. 156507 9 eric 2009-10-21 09:57:08 -0700 Could the runTest() not defined log be coming from a previous test? 156508 10 evan 2009-10-21 10:00:48 -0700 Wow, I fail. Eric is implicitly noting that runTest is clearly still running because the rest of the test output is still ok. There's just the extra line. 156512 11 eric 2009-10-21 10:12:17 -0700 I'm not sure if the output is "still OK", but it does look identical. I did a quick visual-inspection diff, I did not run "diff" against the two output files to confirm that they're exactly the same besides that line. 156524 12 jparent 2009-10-21 10:32:50 -0700 Another data point: LayoutTests/editing/selection/drag-to-contenteditable-iframe.html is doing the same thing. It fails with the extra runTest is not defined message, but clearly it is running properly since the rest of the output is ok. 156555 13 evan 2009-10-21 11:11:52 -0700 I had diffed the fail/pass tests before, and that (In reply to comment #11) > I'm not sure if the output is "still OK", but it does look identical. I did a > quick visual-inspection diff, I did not run "diff" against the two output files > to confirm that they're exactly the same besides that line. Yes, it's identical (I had run diff before when trying to figure out what was going wrong) other than the extra line. 156647 14 ojan 2009-10-21 14:26:34 -0700 There seems to be two bugs here. 1. Errors that occur after a notifyDone call get output to the next test run in TestShell. Will fix this in TestShell. 2. There's a race between document teardown and an images onload handler. Namely, the image's onload handler is called after the runTest function has be destroyed. It's not clear to me whether this is a V8 or a WebCore bug. Here's what's going on: LayoutTests/editing/selection/drag-to-contenteditable-iframe.html drags an image with onload="runTest()" into a contentEditable region, creating a new image element with it's own onload handler. There's a race between the document teardown and the load event of the dragged in image. The reason LayoutTests/editing/selection/editable-html-element.html is involved is that it happens to run after drag-to-contenteditable-iframe.html. Since the racy onload handler fires after we've called notifyDone, the logged error gets inserted into editable-html-element.html's results. 156654 15 ojan 2009-10-21 14:44:42 -0700 OK. Nevermind. There's just the TestShell bug. runTest is undefined because it's run in the context of the iframe. 41521 2009-10-20 13:46:20 -0700 2009-10-20 16:42:58 -0700 guess at a fix for the test bug-30598-20091020134619.patch text/plain 1457 evan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyYjYyY2QyLi5mOGQ2NjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAt MjAgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3Vlc3MgYXQgYSBmaXggZm9yIGEgdGVzdCB0 aGF0IG9jY2FzaW9uYWxseSBmYWlscy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzA1OTgKKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2Vk aXRhYmxlLWh0bWwtZWxlbWVudC5odG1sOiBhZGQgPGhlYWQ+LgorCiAyMDA5LTEwLTIwICBYYW4g TG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBTa2lwIDMgZmFpbGluZyB4bWxo dHRwcmVxdWVzdCB0ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0 aW9uL2VkaXRhYmxlLWh0bWwtZWxlbWVudC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxl Y3Rpb24vZWRpdGFibGUtaHRtbC1lbGVtZW50Lmh0bWwKaW5kZXggZTE4NjUxMS4uM2Y3ODdjYiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZWRpdGFibGUtaHRtbC1l bGVtZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZWRpdGFibGUt aHRtbC1lbGVtZW50Lmh0bWwKQEAgLTEsMTAgKzEsOSBAQAogPGh0bWwgY29udGVudGVkaXRhYmxl PSJ0cnVlIiBpZD0idGVzdCI+Cis8aGVhZD4KIDxzY3JpcHQ+CiBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQogICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wRWRpdGluZ0NhbGxi YWNrcygpOwotPC9zY3JpcHQ+CiAKLTxzY3JpcHQ+CiBmdW5jdGlvbiBydW5UZXN0KCkgewogICAg IHZhciBzID0gd2luZG93LmdldFNlbGVjdGlvbigpOwogICAgIHZhciBlID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInRlc3QiKTsKQEAgLTE1LDYgKzE0LDcgQEAgZnVuY3Rpb24gcnVuVGVzdCgp IHsKICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SFRNTCIsIGZhbHNlLCAiPGJyPldl IHNldCBpdCBpbnNpZGUgdGhlIGJvZHkgYmVjYXVzZSB3ZSBkb24ndCB3YW50IHRvIGFsbG93IGVk aXRpbmcgb3V0c2lkZSB0aGUgYm9keS4gIFRoaXMgdGVzdCBhbHNvIGRvZXMgc29tZSBlZGl0aW5n IHRvIG1ha2Ugc3VyZSBpdCBoYXBwZW5zIGluIHRoZSBib2R5LiIpOwogfQogPC9zY3JpcHQ+Cis8 L2hlYWQ+CiA8Ym9keSBvbkxvYWQ9InJ1blRlc3QoKTsiPgogPC9ib2R5PgotPC9odG1sPgpcIE5v IG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKKzwvaHRtbD4= 41571 2009-10-21 09:48:36 -0700 2009-10-21 09:48:36 -0700 results when the test fails editable-html-element-actual.txt text/plain 2848 eric Q09OU09MRSBNRVNTQUdFOiBsaW5lIDE6IFVuY2F1Z2h0IFJlZmVyZW5jZUVycm9yOiBydW5UZXN0 IGlzIG5vdCBkZWZpbmVkCkVESVRJTkcgREVMRUdBVEU6IHNob3VsZEJlZ2luRWRpdGluZ0luRE9N UmFuZ2U6cmFuZ2UgZnJvbSAwIG9mIEhUTUwgPiAjZG9jdW1lbnQgdG8gMiBvZiBIVE1MID4gI2Rv Y3VtZW50CkVESVRJTkcgREVMRUdBVEU6IHdlYlZpZXdEaWRCZWdpbkVkaXRpbmc6V2ViVmlld0Rp ZEJlZ2luRWRpdGluZ05vdGlmaWNhdGlvbgpFRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VT ZWxlY3RlZERPTVJhbmdlOihudWxsKSB0b0RPTVJhbmdlOnJhbmdlIGZyb20gMCBvZiBCT0RZID4g SFRNTCA+ICNkb2N1bWVudCB0byAwIG9mIEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IGFmZmluaXR5 Ok5TU2VsZWN0aW9uQWZmaW5pdHlEb3duc3RyZWFtIHN0aWxsU2VsZWN0aW5nOkZBTFNFCkVESVRJ TkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmlld0RpZENoYW5nZVNl bGVjdGlvbk5vdGlmaWNhdGlvbgpFRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VTZWxlY3Rl ZERPTVJhbmdlOnJhbmdlIGZyb20gMCBvZiBCT0RZID4gSFRNTCA+ICNkb2N1bWVudCB0byAwIG9m IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IHRvRE9NUmFuZ2U6cmFuZ2UgZnJvbSAxIG9mICN0ZXh0 ID4gU1BBTiA+IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IHRvIDEgb2YgI3RleHQgPiBTUEFOID4g Qk9EWSA+IEhUTUwgPiAjZG9jdW1lbnQgYWZmaW5pdHk6TlNTZWxlY3Rpb25BZmZpbml0eURvd25z dHJlYW0gc3RpbGxTZWxlY3Rpbmc6RkFMU0UKRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZENo YW5nZVNlbGVjdGlvbjpXZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uTm90aWZpY2F0aW9uCkVESVRJ TkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2U6V2ViVmlld0RpZENoYW5nZU5vdGlmaWNhdGlv bgpFRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VTZWxlY3RlZERPTVJhbmdlOnJhbmdlIGZy b20gMSBvZiAjdGV4dCA+IFNQQU4gPiBCT0RZID4gSFRNTCA+ICNkb2N1bWVudCB0byAxIG9mICN0 ZXh0ID4gU1BBTiA+IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IHRvRE9NUmFuZ2U6cmFuZ2UgZnJv bSA3NyBvZiAjdGV4dCA+IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IHRvIDc3IG9mICN0ZXh0ID4g Qk9EWSA+IEhUTUwgPiAjZG9jdW1lbnQgYWZmaW5pdHk6TlNTZWxlY3Rpb25BZmZpbml0eURvd25z dHJlYW0gc3RpbGxTZWxlY3Rpbmc6RkFMU0UKRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZENo YW5nZVNlbGVjdGlvbjpXZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uTm90aWZpY2F0aW9uCkVESVRJ TkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2U6V2ViVmlld0RpZENoYW5nZU5vdGlmaWNhdGlv bgpFRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VTZWxlY3RlZERPTVJhbmdlOnJhbmdlIGZy b20gNzcgb2YgI3RleHQgPiBCT0RZID4gSFRNTCA+ICNkb2N1bWVudCB0byA3NyBvZiAjdGV4dCA+ IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IHRvRE9NUmFuZ2U6cmFuZ2UgZnJvbSAxNTMgb2YgI3Rl eHQgPiBCT0RZID4gSFRNTCA+ICNkb2N1bWVudCB0byAxNTMgb2YgI3RleHQgPiBCT0RZID4gSFRN TCA+ICNkb2N1bWVudCBhZmZpbml0eTpOU1NlbGVjdGlvbkFmZmluaXR5RG93bnN0cmVhbSBzdGls bFNlbGVjdGluZzpGQUxTRQpFRElUSU5HIERFTEVHQVRFOiB3ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0 aW9uOldlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb25Ob3RpZmljYXRpb24KRURJVElORyBERUxFR0FU RTogd2ViVmlld0RpZENoYW5nZTpXZWJWaWV3RGlkQ2hhbmdlTm90aWZpY2F0aW9uCmxheWVyIGF0 ICgwLDApIHNpemUgODAweDYwMAogIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCmxh eWVyIGF0ICgwLDApIHNpemUgODAweDYwMAogIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBz aXplIDgwMHg2MDAKICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAog ICAgICBSZW5kZXJJbmxpbmUge1NQQU59IGF0ICgwLDApIHNpemUgMzJ4MTgKICAgICAgICBSZW5k ZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAzMngxOAogICAgICAgICAgdGV4dCBydW4gYXQg KDAsMCkgd2lkdGggMzI6ICJceHs5fSIKICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgzMiww KSBzaXplIDQ3M3gxOAogICAgICAgIHRleHQgcnVuIGF0ICgzMiwwKSB3aWR0aCA0NzM6ICJUaGlz IHRlc3RzIHRvIHNlZSB3aGVyZSB0aGUgc2VsZWN0aW9uIGlzIHNldCB3aGVuIGFuIGh0bWwgZWxl bWVudCBpcyBmb2N1c2VkLiIKICAgICAgUmVuZGVyQlIge0JSfSBhdCAoNTA1LDE0KSBzaXplIDB4 MAogICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMTgpIHNpemUgNzc3eDM2CiAgICAgICAg dGV4dCBydW4gYXQgKDAsMTgpIHdpZHRoIDUyMDogIldlIHNldCBpdCBpbnNpZGUgdGhlIGJvZHkg YmVjYXVzZSB3ZSBkb24ndCB3YW50IHRvIGFsbG93IGVkaXRpbmcgb3V0c2lkZSB0aGUgYm9keS4g IgogICAgICAgIHRleHQgcnVuIGF0ICg1MjAsMTgpIHdpZHRoIDI1MzogIlRoaXMgdGVzdCBhbHNv IGRvZXMgc29tZSBlZGl0aW5nIHRvIG1ha2UiCiAgICAgICAgdGV4dCBydW4gYXQgKDc3MywxOCkg d2lkdGggNDogIiAiCiAgICAgICAgdGV4dCBydW4gYXQgKDAsMzYpIHdpZHRoIDE3MzogInN1cmUg aXQgaGFwcGVucyBpbiB0aGUgYm9keS4iCmNhcmV0OiBwb3NpdGlvbiAxNTMgb2YgY2hpbGQgMyB7 I3RleHR9IG9mIGNoaWxkIDEge0JPRFl9IG9mIGNoaWxkIDAge0hUTUx9IG9mIGRvY3VtZW50Cg==