30592 2009-10-20 12:44:28 -0700 [Qt] keepWebHistory undefined while executing Layouttests fast/history/clicked-link-is-visited.html 2009-10-21 12:19:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Linux RESOLVED FIXED P3 Normal --- 30574 0 cshu webkit-unassigned commit-queue oldest_to_newest 156262 0 cshu 2009-10-20 12:44:28 -0700 The following shows when executing LayoutTests: fast/history/clicked-link-is-visited.html CONSOLE MESSAGE: line 6: TypeError: Result of expression 'layoutTestController.keepWebHistory' [undefined] is not a function. 156264 1 41519 cshu 2009-10-20 12:57:52 -0700 Created attachment 41519 fix patch Just added dummy implementation as it's implemented only on Mac. 156527 2 41519 eric 2009-10-21 10:34:32 -0700 Comment on attachment 41519 fix patch OK. The ChangeLog should really mention which tests this affects. If you want this auto-committed, you'll need to set cq? 156533 3 cshu 2009-10-21 10:39:07 -0700 (In reply to comment #2) > (From update of attachment 41519 [details]) > OK. The ChangeLog should really mention which tests this affects. If you want > this auto-committed, you'll need to set cq? Thank you. Just did cq? 156603 4 41519 commit-queue 2009-10-21 12:18:57 -0700 Comment on attachment 41519 fix patch Clearing flags on attachment: 41519 Committed r49915: <http://trac.webkit.org/changeset/49915> 156604 5 commit-queue 2009-10-21 12:19:00 -0700 All reviewed patches have been landed. Closing bug. 41519 2009-10-20 12:57:52 -0700 2009-10-21 12:18:57 -0700 fix patch bug30592_1.patch text/plain 1816 cshu SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5ODc4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMjAgIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBBZGRlZCBkdW1teSBpbXBsZW1lbnRhdGlvbiBmb3Iga2VlcFdlYkhpc3Rv cnkoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA1 OTIKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQu Y3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OmtlZXBXZWJIaXN0b3J5KToKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0Lmg6CisKIDIw MDktMTAtMjAgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAJKHJldmlzaW9uIDQ5 Nzc4KQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xs ZXJRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOCw2ICsxMDgsMTEgQEAgdm9pZCBMYXlvdXRU ZXN0Q29udHJvbGxlcjo6d2FpdFVudGlsRG9uZQogICAgIG1fdGltZW91dFRpbWVyLnN0YXJ0KDEx MDAwLCB0aGlzKTsKIH0KIAordm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6a2VlcFdlYkhpc3Rv cnkoKQoreworICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKK30KKwogdm9pZCBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6bm90aWZ5RG9uZSgpCiB7CiAgICAgcURlYnVnKCkgPDwgIj4+Pj5ub3RpZnlEb25l IjsKSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9s bGVyUXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlv dXRUZXN0Q29udHJvbGxlclF0LmgJKHJldmlzaW9uIDQ5Nzc4KQorKysgV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oCSh3b3JraW5nIGNvcHkpCkBA IC04Myw2ICs4Myw3IEBAIHB1YmxpYyBzbG90czoKICAgICB2b2lkIGR1bXBTdGF0dXNDYWxsYmFj a3MoKSB7IG1fZHVtcFN0YXR1c0NhbGxiYWNrcyA9IHRydWU7IH0KICAgICB2b2lkIHNldENhbk9w ZW5XaW5kb3dzKCkgeyBtX2Nhbk9wZW5XaW5kb3dzID0gdHJ1ZTsgfQogICAgIHZvaWQgd2FpdFVu dGlsRG9uZSgpOworICAgIHZvaWQga2VlcFdlYkhpc3RvcnkoKTsKICAgICB2b2lkIG5vdGlmeURv bmUoKTsKICAgICB2b2lkIGR1bXBCYWNrRm9yd2FyZExpc3QoKSB7IG1fZHVtcEJhY2tGb3J3YXJk TGlzdCA9IHRydWU7IH0KICAgICB2b2lkIGR1bXBFZGl0aW5nQ2FsbGJhY2tzKCk7Cg==