30589 2009-10-20 11:59:32 -0700 [GTK] Failing media/video-played-reset.html 2009-11-02 12:14:45 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned commit-queue oldest_to_newest 156234 0 xan.lopez 2009-10-20 11:59:32 -0700 Seems to jump between failing and timing out. 159819 1 42321 pnormand 2009-11-02 09:51:00 -0800 Created attachment 42321 proposed patch Our GStreamer-based player does seeking by sending a seek event to playbin2. Current position is not immediately updated so we can end up in a state where currentTime() is called while a seek is in progress. The patch adds a new private attribute in the player class, used to cache the seek time position during seeking so currentTime reports the correct position. 159820 2 42322 pnormand 2009-11-02 09:51:58 -0800 Created attachment 42322 unskip fixed test 159856 3 42321 jmalonzo 2009-11-02 11:15:22 -0800 Comment on attachment 42321 proposed patch r=me. 159860 4 42321 commit-queue 2009-11-02 11:34:24 -0800 Comment on attachment 42321 proposed patch Clearing flags on attachment: 42321 Committed r50424: <http://trac.webkit.org/changeset/50424> 159886 5 42322 commit-queue 2009-11-02 12:14:42 -0800 Comment on attachment 42322 unskip fixed test Clearing flags on attachment: 42322 Committed r50425: <http://trac.webkit.org/changeset/50425> 159887 6 commit-queue 2009-11-02 12:14:45 -0800 All reviewed patches have been landed. Closing bug. 42321 2009-11-02 09:51:00 -0800 2009-11-02 11:34:24 -0800 proposed patch 0001-new-m_seekTime-attribute-to-keep-track-of-the-seek-p.patch text/plain 3227 pnormand RnJvbSBiYjgzZGIzMzhhNGE1Y2M1NDU1MzZjN2FjNjAxOGE4ZGU0YWU1NThiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDIgTm92IDIwMDkgMTg6MzM6MjEgKzAxMDAKU3ViamVjdDogW1BBVENIIDEv Ml0gbmV3IG1fc2Vla1RpbWUgYXR0cmlidXRlIHRvIGtlZXAgdHJhY2sgb2YgdGhlIHNlZWsgcG9z aXRpb24KCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8ICAgIDggKysrKysrKy0KIC4uLi9ncmFwaGljcy9ndGsv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggICAgIHwgICAgMiArKwogMyBmaWxlcyBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGNlNGYyOC4uZmE2ZDA1MCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAwOS0xMS0wMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gRmFpbGluZyBtZWRpYS92aWRlby1wbGF5ZWQtcmVzZXQuaHRtbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA1ODkKKworICAgICAgICBu ZXcgbV9zZWVrVGltZSBhdHRyaWJ1dGUgdG8ga2VlcCB0cmFjayBvZiB0aGUgc2VlayBwb3NpdGlv bgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OmN1cnJl bnRUaW1lKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6c2Vlayk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5oOgorCiAyMDA5LTExLTAxICBLZWxseSBOb3J0b24gIDxrbm9ydG9uQGdvb2dsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5jcHAKaW5kZXggNjY4ODA1ZC4uMTFlYjRkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3Bw CkBAIC0xMzYsNiArMTM2LDcgQEAgTWVkaWFQbGF5ZXJQcml2YXRlOjpNZWRpYVBsYXllclByaXZh dGUoTWVkaWFQbGF5ZXIqIHBsYXllcikKICAgICAsIG1fcGxheUJpbigwKQogICAgICwgbV92aWRl b1NpbmsoMCkKICAgICAsIG1fc291cmNlKDApCisgICAgLCBtX3NlZWtUaW1lKDApCiAgICAgLCBt X2VuZFRpbWUobnVtZXJpY19saW1pdHM8ZmxvYXQ+OjppbmZpbml0eSgpKQogICAgICwgbV9uZXR3 b3JrU3RhdGUoTWVkaWFQbGF5ZXI6OkVtcHR5KQogICAgICwgbV9yZWFkeVN0YXRlKE1lZGlhUGxh eWVyOjpIYXZlTm90aGluZykKQEAgLTIyNSw2ICsyMjYsOSBAQCBmbG9hdCBNZWRpYVBsYXllclBy aXZhdGU6OmN1cnJlbnRUaW1lKCkgY29uc3QKICAgICBpZiAobV9lcnJvck9jY3VyZWQpCiAgICAg ICAgIHJldHVybiAwOwogCisgICAgaWYgKG1fc2Vla2luZykKKyAgICAgICAgcmV0dXJuIG1fc2Vl a1RpbWU7CisKICAgICBmbG9hdCByZXQgPSAwLjA7CiAKICAgICBHc3RRdWVyeSogcXVlcnkgPSBn c3RfcXVlcnlfbmV3X3Bvc2l0aW9uKEdTVF9GT1JNQVRfVElNRSk7CkBAIC0yNjQsOCArMjY4LDEw IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpzZWVrKGZsb2F0IHRpbWUpCiAgICAgICAgICAg ICBHU1RfU0VFS19UWVBFX1NFVCwgc2VjLAogICAgICAgICAgICAgR1NUX1NFRUtfVFlQRV9OT05F LCBHU1RfQ0xPQ0tfVElNRV9OT05FKSkKICAgICAgICAgTE9HX1ZFUkJPU0UoTWVkaWEsICJTZWVr IHRvICVmIGZhaWxlZCIsIHRpbWUpOwotICAgIGVsc2UKKyAgICBlbHNlIHsKICAgICAgICAgbV9z ZWVraW5nID0gdHJ1ZTsKKyAgICAgICAgbV9zZWVrVGltZSA9IHNlYzsKKyAgICB9CiB9CiAKIHZv aWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpzZXRFbmRUaW1lKGZsb2F0IHRpbWUpCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5oCmluZGV4IDU0ZGE0MjAuLjNmMGYyOWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5o CkBAIC0yOSw2ICsyOSw3IEBACiAKICNpbmNsdWRlIDxjYWlyby5oPgogI2luY2x1ZGUgPGdsaWIu aD4KKyNpbmNsdWRlIDxnc3QvZ3N0Lmg+CiAKIHR5cGVkZWYgc3RydWN0IF9XZWJLaXRWaWRlb1Np bmsgV2ViS2l0VmlkZW9TaW5rOwogdHlwZWRlZiBzdHJ1Y3QgX0dzdEJ1ZmZlciBHc3RCdWZmZXI7 CkBAIC0xMjQsNiArMTI1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgR3N0 RWxlbWVudCogbV9wbGF5QmluOwogICAgICAgICAgICAgR3N0RWxlbWVudCogbV92aWRlb1Npbms7 CiAgICAgICAgICAgICBHc3RFbGVtZW50KiBtX3NvdXJjZTsKKyAgICAgICAgICAgIEdzdENsb2Nr VGltZSBtX3NlZWtUaW1lOwogICAgICAgICAgICAgZmxvYXQgbV9lbmRUaW1lOwogICAgICAgICAg ICAgYm9vbCBtX2lzRW5kUmVhY2hlZDsKICAgICAgICAgICAgIE1lZGlhUGxheWVyOjpOZXR3b3Jr U3RhdGUgbV9uZXR3b3JrU3RhdGU7Ci0tIAoxLjYuMy4zCgo= 42322 2009-11-02 09:51:58 -0800 2009-11-02 12:14:42 -0800 unskip fixed test 0002-unskip-fixed-test.patch text/plain 1434 pnormand RnJvbSAwOTQ1ZjZlZjY1NGU2ZmQ4MmM5MjJlNTIxMjYwZmY1M2IwNTk4MGJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDIgTm92IDIwMDkgMTg6NDA6MjAgKzAxMDAKU3ViamVjdDogW1BBVENIIDIv Ml0gdW5za2lwIGZpeGVkIHRlc3QKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAg ICAgfCAgICA5ICsrKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgfCAg ICAzIC0tLQogMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IGY4MGRmZjguLmI0NTIxZTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0x MS0wMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRmFpbGluZyBtZWRp YS92aWRlby1wbGF5ZWQtcmVzZXQuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzA1ODkKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVk OiBVbnNraXAgZml4ZWQgdGVzdC4KKwogMjAwOS0xMS0wMiAgUm9sYW5kIFN0ZWluZXIgIDxyb2xh bmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0 LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCBiYzBkMmFkLi40YWM0NzU3IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTUyMiw5ICs1NTIyLDYgQEAgZmFzdC9ldmVudHMvbm9k ZS1ldmVudC1hbmNob3ItbG9jay5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5L21peGVkQ29udGVu dC9pbnNlY3VyZS1wbHVnaW4taW4taWZyYW1lLmh0bWwKIGh0dHAvdGVzdHMvbG9hZGluZy9iYXNp Yy1hdXRoLXJlc2VuZC13cm9uZy1jcmVkZW50aWFscy5odG1sIAogCi0jIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDU4OQotbWVkaWEvdmlkZW8tcGxheWVkLXJlc2V0 Lmh0bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA2ODAK IG1lZGlhL2F1ZGlvLWRlbGV0ZS13aGlsZS1zdGVwLWJ1dHRvbi1jbGlja2VkLmh0bWwKIAotLSAK MS42LjMuMwoK