30581 2009-10-20 10:36:37 -0700 Add getter for FrameLoader::m_suppressOpenerInNewFrame 2009-10-21 14:34:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth ap oldest_to_newest 156188 0 japhet 2009-10-20 10:36:37 -0700 Forgot to include a getter method in http://trac.webkit.org/changeset/49809 for m_suppressOpenerInNewFrame. 156191 1 41512 japhet 2009-10-20 10:39:51 -0700 Created attachment 41512 patch 156195 2 41512 abarth 2009-10-20 10:46:39 -0700 Comment on attachment 41512 patch The ChangeLog does not explain why we need this getter. Why do we need it? 156201 3 japhet 2009-10-20 10:57:45 -0700 You're right, oops. Chromium is looking for a definitive way to determine whether a link was noreferrer and therefore is safe to open in a new process. If the opener is being suppressed, that should be a good indication (better than any heuristic) that an entirely new context is the correct decision. 156203 4 abarth 2009-10-20 11:01:03 -0700 Ugg. The problem is that this isn't really a property of the FrameLoader but a property of the current FrameLoadTask (which is a concept that doesn't really exist at the moment). I guess it's ok to dig this hole a bit deeper... I'll try to remember not to review this getter even though it looks like dead code. If you post an updated patch with a better ChangeLog, I can review it again. 156206 5 41515 japhet 2009-10-20 11:08:10 -0700 Created attachment 41515 added more descriptive changelog entry Yeah, sorry to make the FrameLoader mess worse :-( If you would like me to help at all with cleanup of FrameLoader, I think I'm now on the hook. 156207 6 41515 abarth 2009-10-20 11:11:26 -0700 Comment on attachment 41515 added more descriptive changelog entry Ok. Thanks for offering to help with FrameLoader. The next step is somewhat involved (splitting out the document-specific processing), but there might be parallelizable tasks after that. 156650 7 japhet 2009-10-21 14:34:19 -0700 This was landed in http://trac.webkit.org/changeset/49872. 41512 2009-10-20 10:39:51 -0700 2009-10-20 11:08:10 -0700 patch patch.txt text/plain 1191 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTg2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMjAgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBnZXR0ZXIgZm9yIEZyYW1lTG9hZGVyOm1fc3VwcHJlc3NPcGVuZXJJbk5ld0ZyYW1lLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDU4MQor CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZUxvYWRlcjo6c3VwcHJlc3NPcGVuZXJJbk5ld0ZyYW1lKTogQWRkZWQuCisKIDIwMDktMTAtMjAg IFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgJKHJldmlzaW9uIDQ5ODYxKQor KysgV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzIyLDYg KzMyMiw4IEBAIHB1YmxpYzoKICAgICAvLyB1c2VzIHRoZSBwb2xpY3kgbWFjaGluZXJ5IChhbmQg dGhlcmVmb3JlIGlzIGNhbGxlZCB2aWEgdGhlIFBvbGljeUNoZWNrZXIpLiAgT25jZSB3ZQogICAg IC8vIGludHJvZHVjZSBhIHByb3BlciBjYWxsYmFjayB0eXBlIGZvciB0aGlzIGZ1bmN0aW9uLCB3 ZSBzaG91bGQgbWFrZSBpdCBwcml2YXRlIGFnYWluLgogICAgIHZvaWQgY29udGludWVMb2FkQWZ0 ZXJXaWxsU3VibWl0Rm9ybSgpOworICAgIAorICAgIGJvb2wgc3VwcHJlc3NPcGVuZXJJbk5ld0Zy YW1lKCkgY29uc3QgeyByZXR1cm4gbV9zdXBwcmVzc09wZW5lckluTmV3RnJhbWU7IH0KIAogcHJp dmF0ZToKICAgICBib29sIGNhbkNhY2hlUGFnZUNvbnRhaW5pbmdUaGlzRnJhbWUoKTsK 41515 2009-10-20 11:08:10 -0700 2009-10-20 11:11:26 -0700 added more descriptive changelog entry patch.txt text/plain 1322 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTg2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMjAgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBnZXR0ZXIgZm9yIEZyYW1lTG9hZGVyOm1fc3VwcHJlc3NPcGVuZXJJbk5ld0ZyYW1lLgor ICAgICAgICBUaGlzIHdpbGwgYWxsb3cgQ2hyb21pdW0gdG8gbW9yZSBpbnRlbGxpZ2VudGx5IGRl dGVjdAorICAgICAgICBub3JlZmVycmVyIGxpbmtzIGFuZCB0aGVyZWZvcmUgb3BlbiB0aGVtIGlu IGEgbmV3IHByb2Nlc3MuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMwNTgxCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpzdXBwcmVzc09wZW5lckluTmV3RnJhbWUpOiBBZGRl ZC4KKwogMjAwOS0xMC0yMCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAko cmV2aXNpb24gNDk4NjEpCisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMjIsNiArMzIyLDggQEAgcHVibGljOgogICAgIC8vIHVzZXMgdGhlIHBvbGlj eSBtYWNoaW5lcnkgKGFuZCB0aGVyZWZvcmUgaXMgY2FsbGVkIHZpYSB0aGUgUG9saWN5Q2hlY2tl cikuICBPbmNlIHdlCiAgICAgLy8gaW50cm9kdWNlIGEgcHJvcGVyIGNhbGxiYWNrIHR5cGUgZm9y IHRoaXMgZnVuY3Rpb24sIHdlIHNob3VsZCBtYWtlIGl0IHByaXZhdGUgYWdhaW4uCiAgICAgdm9p ZCBjb250aW51ZUxvYWRBZnRlcldpbGxTdWJtaXRGb3JtKCk7CisgICAgCisgICAgYm9vbCBzdXBw cmVzc09wZW5lckluTmV3RnJhbWUoKSBjb25zdCB7IHJldHVybiBtX3N1cHByZXNzT3BlbmVySW5O ZXdGcmFtZTsgfQogCiBwcml2YXRlOgogICAgIGJvb2wgY2FuQ2FjaGVQYWdlQ29udGFpbmluZ1Ro aXNGcmFtZSgpOwo=