30575 2009-10-20 09:26:38 -0700 [GTK] eventSender.zoomPageOut() bug? 2012-05-05 09:26:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez mrobinson eric gustavo mrobinson zan oldest_to_newest 156171 0 xan.lopez 2009-10-20 09:26:38 -0700 These tests: fast/events/clientXY-in-zoom-and-scroll.html fast/dom/elementFromPoint-relative-to-viewport.html are both failing. The only thing in common they seem to have is that both are using eventSender.zoomPageOut(), which might not be working correctly. 202235 1 mrobinson 2010-03-20 13:54:02 -0700 *** Bug 35862 has been marked as a duplicate of this bug. *** 202236 2 51231 mrobinson 2010-03-20 13:56:41 -0700 Created attachment 51231 Patch for this issue It seems that DRT wasn't respecting the 1.2f zoom factor for full page zooms (only text zooms curiously). I've fixed this, removed some duplicate code and unskipped some failing tests. Some tests that used EventSender.zoomPage{Out/In}() are still failing. My intuition says these are probably valid bugs, but I think we should keep this bug open until we can get to the bottom of it. 202240 3 51231 xan.lopez 2010-03-20 14:12:35 -0700 Comment on attachment 51231 Patch for this issue Looks good! 202304 4 mrobinson 2010-03-21 12:09:57 -0700 Committed r56316: <http://trac.webkit.org/changeset/56316> 203590 5 eric 2010-03-24 14:32:29 -0700 Attachment 51231 was posted by a committer and has review+, assigning to Martin Robinson for commit. 203600 6 mrobinson 2010-03-24 14:35:59 -0700 Committed as of r56316. I guess it makes sense to close this bug and open a new bug for the tests that are still failing. 616993 7 zan 2012-05-05 09:26:46 -0700 The tests covered by this bug were found to be passing consistently after moving from using the Skipped list to using test_expectations.txt. Their expectations were removed in r116122[1] (covered by bug #85591). Nothing to close, moving on. 1: http://trac.webkit.org/changeset/116122 51231 2010-03-20 13:56:41 -0700 2010-06-01 05:07:04 -0700 Patch for this issue 0001-GTK-eventSender.zoomPageOut-bug.patch text/plain 6762 mrobinson RnJvbSBlODk0OTFiYmI0ZTJiMmQ4MTUyOWEyZGQ5ZTE3MjAwODQzYTQxNzlmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1yb2JpbnNvbkBhcHBjZWxlcmF0 b3IuY29tPgpEYXRlOiBTYXQsIDIwIE1hciAyMDEwIDEzOjQ5OjA2IC0wNzAwClN1YmplY3Q6IFtQ QVRDSF0gW0dUS10gZXZlbnRTZW5kZXIuem9vbVBhZ2VPdXQoKSBidWc/CiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA1NzUKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKwogTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQgICAgICAgICAgICAgICB8ICAgIDYgLS0tLQogV2ViS2l0VG9v bHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysr CiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwIHwgICAzNCAr KysrKysrKysrKystLS0tLS0tLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCsp LCAyMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzVkZWMzMi4uZmExODI3NyAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDEwLTAzLTIwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AYXBwY2Vs ZXJhdG9yLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXSBldmVudFNlbmRlci56b29tUGFnZU91dCgpIGJ1Zz8KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNTc1CisKKyAgICAgICAgVW5za2lw IHNvbWUgdGVzdHMgdGhhdCB3ZXJlIGZhaWxpbmcgYmVjYXVzZSBvZiB0aGUgYnVnIGluIERSVC4K KworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAyMDEwLTAzLTIwICBEaW1pdHJp IEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg ZXhwZWN0YXRpb25zIHR3ZWFrLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCBlZTc2ODUw Li5iZWNjYmQ5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtMTI3OCw3ICsxMjc4LDYg QEAgZmFzdC9jYW52YXMvdG9EYXRhVVJMLXN1cHBvcnRlZFR5cGVzLmh0bWwKIGZhc3QvY3NzL2Nz czFfZm9yd2FyZF9jb21wYXRpYmxlX3BhcnNpbmcuaHRtbAogZmFzdC9jc3MvaW52YWxpZC1wZXJj ZW50YWdlLXByb3BlcnR5Lmh0bWwKIGZhc3QvY3NzL3RleHQtYWxpZ24uaHRtbAotZmFzdC9jc3Mv em9vbS1ib2R5LXNjcm9sbC5odG1sCiBmYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2NvbXB1dGVk LXN0eWxlLXdpdGhvdXQtcmVuZGVyZXIuaHRtbAogZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9j b21wdXRlZC1zdHlsZS5odG1sCiBmYXN0L2RvbS9jbGllbnQtd2lkdGgtaGVpZ2h0LXF1aXJrcy5o dG1sCkBAIC0xNDY0LDcgKzE0NjMsNiBAQCBzdmcvY3NzL2NvbXBvc2l0ZS1zaGFkb3ctd2l0aC1v cGFjaXR5Lmh0bWwKIHN2Zy9jdXN0b20vZ2V0UHJlc2VudGF0aW9uQXR0cmlidXRlLW1vZGlmeS5z dmcKIAogIyBQb3NzaWJsZSBidWcgaW4gZXZlbnRTZW5kZXIuem9vbVBhZ2VPdXQoKSA/IGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDU3NQotZmFzdC9ldmVudHMvY2xp ZW50WFktaW4tem9vbS1hbmQtc2Nyb2xsLmh0bWwKIGZhc3QvZG9tL2VsZW1lbnRGcm9tUG9pbnQt cmVsYXRpdmUtdG8tdmlld3BvcnQuaHRtbAogCiAjIERuRCBmYWlsdXJlcyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA1NzYKQEAgLTU4MDgsMTAgKzU4MDYsNiBAQCBm YXN0L2RvbS9HZW9sb2NhdGlvbi9wZXJtaXNzaW9uLWRlbmllZC5odG1sCiAjIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTgyNCAtIERvZXNuJ3QgYXBwbHkgdG8gcGxh dGZvcm1zIHRoYXQgZG9uJ3QgZW5mb3JjZSB0aGUgQ0ZOZXR3b3JrLXN0eWxlIDNyZCBwYXJ0eSBj b29raWUgcG9saWN5CiBodHRwL3Rlc3RzL2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2llLXJlbGF4 aW5nLmh0bWwKIAotIyBOZWVkcyBkb3VibGUgY2xpY2sgc3VwcG9ydCBpbiBEUlQKLSMgU2VlIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTg2MgotZmFzdC9ldmVudHMv em9vbS1kYmxjbGljay5odG1sCi0KICMgRm9yIHNvbWUgcmVhc29uIGNyYXNoZXMgd2hlbiBydW4g d2l0aCBhbGwgdGVzdHMuIFBhc3NlcyBpbmRpdmlkdWFsbHkuCiBmYXN0L2Zvcm1zL211bHRpcGxl LWZvcm0tc3VibWlzc2lvbi1wcm90ZWN0aW9uLW1vdXNlLmh0bWwKIApkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDUyMDliOTUu LjMzY2VmZDcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMy0yMCAgTWFydGluIFJvYmlu c29uICA8bXJvYmluc29uQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0dUS10gZXZlbnRTZW5kZXIuem9vbVBhZ2VPdXQoKSBidWc/ CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDU3NQor CisgICAgICAgIE1ha2Ugem9vbVBhZ2V7SW4vT3V0fUNhbGxiYWNrIHJlc3BlY3QgdGhlIDEuMmYg em9vbSBmYWN0b3IgdGhhdCBEUlQgc2hvdWxkIGJlIHVzaW5nLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcDoKKyAgICAgICAgKHpvb21Jbik6IEFkZGVkLgor ICAgICAgICAoem9vbU91dCk6IEFkZGVkLgorICAgICAgICAodGV4dFpvb21JbkNhbGxiYWNrKTog VXNlIHpvb21JbiBoZWxwZXIgZnVuY3Rpb24uCisgICAgICAgICh0ZXh0Wm9vbU91dENhbGxiYWNr KTogVXNlIHpvb21PdXQgaGVscGVyIGZ1bmN0aW9uLgorICAgICAgICAoem9vbVBhZ2VJbkNhbGxi YWNrKTogVXNlIHpvb21JbiBoZWxwZXIgZnVuY3Rpb24sIHdoaWNoIHJlc3BlY3RzIHpvb20gZmFj dG9yLgorICAgICAgICAoem9vbVBhZ2VPdXRDYWxsYmFjayk6IFVzZSB6b29tT3V0IGhlbHBlciBm dW5jdGlvbiwgd2hpY2ggcmVzcGVjdHMgem9vbSBmYWN0b3IuCisKIDIwMTAtMDMtMjAgIEtldmlu IE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgW3d4XSBCdWls ZCBmaXhlcyBmb3IgbmV3IG1ldGhvZCBpbiBMYXlvdXRUZXN0Q29udHJvbGxlci4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAgYi9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCmluZGV4IDVhNjQ5MmEu LjljMjdkOGMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVu dFNlbmRlci5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2Vu ZGVyLmNwcApAQCAtNTc3LDQ3ICs1NzcsNDkgQEAgc3RhdGljIEpTVmFsdWVSZWYga2V5RG93bkNh bGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlMKICAg ICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CiB9CiAKLXN0YXRpYyBKU1Zh bHVlUmVmIHRleHRab29tSW5DYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RS ZWYgZnVuY3Rpb24sIEpTT2JqZWN0UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENvdW50 LCBjb25zdCBKU1ZhbHVlUmVmIGFyZ3VtZW50c1tdLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCitz dGF0aWMgdm9pZCB6b29tSW4oZ2Jvb2xlYW4gZnVsbENvbnRlbnRzWm9vbSkKIHsKICAgICBXZWJL aXRXZWJWaWV3KiB2aWV3ID0gd2Via2l0X3dlYl9mcmFtZV9nZXRfd2ViX3ZpZXcobWFpbkZyYW1l KTsKICAgICBpZiAoIXZpZXcpCi0gICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChj b250ZXh0KTsKKyAgICAgICAgcmV0dXJuOwogCisgICAgd2Via2l0X3dlYl92aWV3X3NldF9mdWxs X2NvbnRlbnRfem9vbSh2aWV3LCBmdWxsQ29udGVudHNab29tKTsKICAgICBnZmxvYXQgY3VycmVu dFpvb20gPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3pvb21fbGV2ZWwodmlldyk7CiAgICAgd2Via2l0 X3dlYl92aWV3X3NldF96b29tX2xldmVsKHZpZXcsIGN1cnJlbnRab29tICogem9vbU11bHRpcGxp ZXJSYXRpbyk7Ci0KLSAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CiB9 CiAKLXN0YXRpYyBKU1ZhbHVlUmVmIHRleHRab29tT3V0Q2FsbGJhY2soSlNDb250ZXh0UmVmIGNv bnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVjdFJlZiB0aGlzT2JqZWN0LCBzaXpl X3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNWYWx1ZVJl ZiogZXhjZXB0aW9uKQorc3RhdGljIHZvaWQgem9vbU91dChnYm9vbGVhbiBmdWxsQ29udGVudHNa b29tKQogewogICAgIFdlYktpdFdlYlZpZXcqIHZpZXcgPSB3ZWJraXRfd2ViX2ZyYW1lX2dldF93 ZWJfdmlldyhtYWluRnJhbWUpOwogICAgIGlmICghdmlldykKLSAgICAgICAgcmV0dXJuIEpTVmFs dWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOworICAgICAgICByZXR1cm47CiAKKyAgICB3ZWJraXRf d2ViX3ZpZXdfc2V0X2Z1bGxfY29udGVudF96b29tKHZpZXcsIGZ1bGxDb250ZW50c1pvb20pOwog ICAgIGdmbG9hdCBjdXJyZW50Wm9vbSA9IHdlYmtpdF93ZWJfdmlld19nZXRfem9vbV9sZXZlbCh2 aWV3KTsKICAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3pvb21fbGV2ZWwodmlldywgY3VycmVudFpv b20gLyB6b29tTXVsdGlwbGllclJhdGlvKTsKK30KIAorc3RhdGljIEpTVmFsdWVSZWYgdGV4dFpv b21JbkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwg SlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFs dWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikKK3sKKyAgICB6b29tSW4o RkFMU0UpOwogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKIH0KIAot c3RhdGljIEpTVmFsdWVSZWYgem9vbVBhZ2VJbkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0 LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFy Z3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4 Y2VwdGlvbikKK3N0YXRpYyBKU1ZhbHVlUmVmIHRleHRab29tT3V0Q2FsbGJhY2soSlNDb250ZXh0 UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVjdFJlZiB0aGlzT2JqZWN0 LCBzaXplX3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNW YWx1ZVJlZiogZXhjZXB0aW9uKQogewotICAgIFdlYktpdFdlYlZpZXcqIHZpZXcgPSB3ZWJraXRf d2ViX2ZyYW1lX2dldF93ZWJfdmlldyhtYWluRnJhbWUpOwotICAgIGlmICghdmlldykKLSAgICAg ICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOworICAgIHpvb21PdXQoRkFM U0UpOworICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKK30KIAotICAg IHdlYmtpdF93ZWJfdmlld196b29tX2luKHZpZXcpOworc3RhdGljIEpTVmFsdWVSZWYgem9vbVBh Z2VJbkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwg SlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFs dWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikKK3sKKyAgICB6b29tSW4o VFJVRSk7CiAgICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOwogfQogCiBz dGF0aWMgSlNWYWx1ZVJlZiB6b29tUGFnZU91dENhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0 LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFy Z3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4 Y2VwdGlvbikKIHsKLSAgICBXZWJLaXRXZWJWaWV3KiB2aWV3ID0gd2Via2l0X3dlYl9mcmFtZV9n ZXRfd2ViX3ZpZXcobWFpbkZyYW1lKTsKLSAgICBpZiAoIXZpZXcpCi0gICAgICAgIHJldHVybiBK U1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKLQotICAgIHdlYmtpdF93ZWJfdmlld196b29t X291dCh2aWV3KTsKKyAgICB6b29tT3V0KFRSVUUpOwogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVu ZGVmaW5lZChjb250ZXh0KTsKIH0KIAotLSAKMS42LjMuMwoK