30569 2009-10-20 06:41:58 -0700 [Qt] webcore.pro incorrect linking of sqlite3 on Symbian 2009-10-23 12:14:38 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Critical --- 27065 0 koshuin webkit-unassigned commit-queue laszlo.gombos oldest_to_newest 156145 0 koshuin 2009-10-20 06:41:58 -0700 Sqlite3 should be dynamically linked in Symbian as the sqlite3.dll is now provided by the system or as an additional installed library depending on platform/target device version. webcore.pro will try make the linker to try link it statically due to ".lib" in LIBS statement and in Symbian environment will cause sqlite3.lib to be searched from wrong path causing build break if the file is not manually copied to that directory. With copying you end up with static linking. 156146 1 41504 koshuin 2009-10-20 06:46:17 -0700 Created attachment 41504 proposed fix for webcore.pro 156532 2 41504 eric 2009-10-21 10:39:02 -0700 Comment on attachment 41504 proposed fix for webcore.pro This looks fine to me. Seems a qt person would be a better reviewer though. 157152 3 41504 vestbo 2009-10-23 06:36:37 -0700 Comment on attachment 41504 proposed fix for webcore.pro LGTM 157154 4 41504 commit-queue 2009-10-23 06:44:12 -0700 Comment on attachment 41504 proposed fix for webcore.pro Rejecting patch 41504 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 139.03s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157230 5 41504 eric 2009-10-23 12:01:48 -0700 Comment on attachment 41504 proposed fix for webcore.pro Sorry about the commit-queue trouble. Should work fine now. 157247 6 41504 commit-queue 2009-10-23 12:14:35 -0700 Comment on attachment 41504 proposed fix for webcore.pro Clearing flags on attachment: 41504 Committed r49986: <http://trac.webkit.org/changeset/49986> 157248 7 commit-queue 2009-10-23 12:14:38 -0700 All reviewed patches have been landed. Closing bug. 41504 2009-10-20 06:46:17 -0700 2009-10-23 12:14:34 -0700 proposed fix for webcore.pro sqlite_webcore.diff text/plain 1121 koshuin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTEwNzNhOC4uOTQ0NmZjZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0yMCAgSmFubmUgS29za2lu ZW4gIDxqYW5uZS5wLmtvc2tpbmVuQGRpZ2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENvcnJlY3QgbGlua2luZyBvZiBzcWxpdGUz IGZvciBTeW1iaWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDU2OQorCisgICAgICAgICIubGliIiB3aWxsIHRyeSB0byBpbmNsdWRlIGxpYnJhcnkg YXMgc3RhdGljIGxpYnJhcnkKKyAgICAgICAgY2F1c2luZyB0aGUgbGlicmFyeSB0byBiZSBzZWFy Y2hlZCBmcm9tIHdyb25nIGRpcmVjdG9yeSBhbmQgaWYgZm91bmQKKyAgICAgICAgd2lsbCBiZSBz dGF0aWNhbGx5IGxpbmtlZCBpbnN0ZWFkIG9mIHRoZSBpbnRlZGVkIGR5bmFtaWMgbGlua2luZy4K KworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDA5LTEwLTIwICBBbmRyYXMgQmVjc2kgIDxi ZWNzaS5hbmRyYXNAc3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxk Zml4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBiL1dlYkNvcmUvV2ViQ29yZS5w cm8KaW5kZXggMDBiNDY3ZC4uZDlhNzA1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnBy bworKysgYi9XZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0yNTYwLDggKzI1NjAsNyBAQCBjb250YWlu cyhERUZJTkVTLCBFTkFCTEVfU1FMSVRFPTEpIHsKICAgICAgICAgICAgIExJQlMgKj0gJCRRVF9M RkxBR1NfU1FMSVRFCiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBJTkNMVURFUEFUSCAr PSAkJHtTUUxJVEUzU1JDRElSfQotICAgICAgICAgICAgc3ltYmlhbjogTElCUyArPSAtbHNxbGl0 ZTMubGliCi0gICAgICAgICAgICBlbHNlOiBMSUJTICs9IC1sc3FsaXRlMworICAgICAgICAgICAg TElCUyArPSAtbHNxbGl0ZTMKICAgICAgICAgfQogICAgIH0KIAo=