<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>30539</bug_id>
          
          <creation_ts>2009-10-19 15:13:22 -0700</creation_ts>
          <short_desc>Tightened up some put_by_id_transition code generation.</short_desc>
          <delta_ts>2009-10-19 16:03:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Geoffrey Garen">ggaren</reporter>
          <assigned_to name="Geoffrey Garen">ggaren</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>155940</commentid>
    <comment_count>0</comment_count>
      <attachid>41457</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2009-10-19 15:13:22 -0700</bug_when>
    <thetext>Created attachment 41457
patch

Patch coming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155974</commentid>
    <comment_count>1</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2009-10-19 16:03:29 -0700</bug_when>
    <thetext>Committed revision 49820.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>41457</attachid>
            <date>2009-10-19 15:13:22 -0700</date>
            <delta_ts>2009-10-19 15:31:13 -0700</delta_ts>
            <desc>patch</desc>
            <filename>ro.txt</filename>
            <type>text/plain</type>
            <size>5563</size>
            <attacher name="Geoffrey Garen">ggaren</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ5ODAyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMTkgIEdlb2ZmcmV5
IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBUaWdodGVuZWQgdXAgc29tZSBwdXRfYnlfaWRfdHJhbnNpdGlv
biBjb2RlIGdlbmVyYXRpb24uCisKKyAgICAgICAgKiBqaXQvSklULmg6CisgICAgICAgICogaml0
L0pJVFByb3BlcnR5QWNjZXNzLmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjp0ZXN0UHJvdG90eXBl
KToKKyAgICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGlsZVB1dEJ5SWRUcmFuc2l0aW9uKTog
Tm8gbmVlZCB0byBkbyBvYmplY3QgdHlwZQorICAgICAgICBjaGVja3Mgb3IgcmVhZCBTdHJ1Y3R1
cmVzIGFuZCBwcm90b3R5cGVzIGZyb20gb2JqZWN0czogdGhleSdyZSBhbGwga25vd24KKyAgICAg
ICAgY29uc3RhbnRzIGF0IGNvbXBpbGUgdGltZS4KKwogMjAwOS0xMC0xOSAgR2VvZmZyZXkgR2Fy
ZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcu
CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9qaXQvSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlw
dENvcmUvaml0L0pJVC5oCShyZXZpc2lvbiA0OTc5NCkKKysrIEphdmFTY3JpcHRDb3JlL2ppdC9K
SVQuaAkod29ya2luZyBjb3B5KQpAQCAtMzg2LDYgKzM4Niw4IEBAIG5hbWVzcGFjZSBKU0Mgewog
CiAgICAgICAgIEFkZHJlc3MgYWRkcmVzc0Zvcih1bnNpZ25lZCBpbmRleCwgUmVnaXN0ZXJJRCBi
YXNlID0gY2FsbEZyYW1lUmVnaXN0ZXIpOwogCisgICAgICAgIHZvaWQgdGVzdFByb3RvdHlwZShT
dHJ1Y3R1cmUqLCBKdW1wTGlzdCYgZmFpbHVyZUNhc2VzKTsKKwogI2lmIFVTRShKU1ZBTFVFMzJf
NjQpCiAgICAgICAgIEFkZHJlc3MgdGFnRm9yKHVuc2lnbmVkIGluZGV4LCBSZWdpc3RlcklEIGJh
c2UgPSBjYWxsRnJhbWVSZWdpc3Rlcik7CiAgICAgICAgIEFkZHJlc3MgcGF5bG9hZEZvcih1bnNp
Z25lZCBpbmRleCwgUmVnaXN0ZXJJRCBiYXNlID0gY2FsbEZyYW1lUmVnaXN0ZXIpOwpJbmRleDog
SmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK
YXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCShyZXZpc2lvbiA0OTc5NCkK
KysrIEphdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJKHdvcmtpbmcgY29w
eSkKQEAgLTUyMSwyMiArNTIxLDI2IEBAIHZvaWQgSklUOjpjb21waWxlR2V0RGlyZWN0T2Zmc2V0
KEpTT2JqZWMKICAgICBsb2FkMzIoQWRkcmVzcyh0ZW1wLCBvZmZzZXQgKyA0KSwgcmVzdWx0VGFn
KTsKIH0KIAordm9pZCBKSVQ6OnRlc3RQcm90b3R5cGUoU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEp1
bXBMaXN0JiBmYWlsdXJlQ2FzZXMpCit7CisgICAgaWYgKHN0cnVjdHVyZS0+bV9wcm90b3R5cGUu
aXNOdWxsKCkpCisgICAgICAgIHJldHVybjsKKworICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoYnJh
bmNoUHRyKE5vdEVxdWFsLCBBYnNvbHV0ZUFkZHJlc3MoJmFzQ2VsbChzdHJ1Y3R1cmUtPm1fcHJv
dG90eXBlKS0+bV9zdHJ1Y3R1cmUpLCBJbW1QdHIoYXNDZWxsKHN0cnVjdHVyZS0+bV9wcm90b3R5
cGUpLT5tX3N0cnVjdHVyZSkpKTsKK30KKwogdm9pZCBKSVQ6OnByaXZhdGVDb21waWxlUHV0QnlJ
ZFRyYW5zaXRpb24oU3RydWN0dXJlU3R1YkluZm8qIHN0dWJJbmZvLCBTdHJ1Y3R1cmUqIG9sZFN0
cnVjdHVyZSwgU3RydWN0dXJlKiBuZXdTdHJ1Y3R1cmUsIHNpemVfdCBjYWNoZWRPZmZzZXQsIFN0
cnVjdHVyZUNoYWluKiBjaGFpbiwgUmV0dXJuQWRkcmVzc1B0ciByZXR1cm5BZGRyZXNzKQogewog
ICAgIC8vIEl0IGlzIGFzc3VtZWQgdGhhdCByZWdUMCBjb250YWlucyB0aGUgYmFzZVBheWxvYWQg
YW5kIHJlZ1QxIGNvbnRhaW5zIHRoZSBiYXNlVGFnLiAgVGhlIHZhbHVlIGNhbiBiZSBmb3VuZCBv
biB0aGUgc3RhY2suCiAKICAgICBKdW1wTGlzdCBmYWlsdXJlQ2FzZXM7CiAgICAgZmFpbHVyZUNh
c2VzLmFwcGVuZChicmFuY2gzMihOb3RFcXVhbCwgcmVnVDEsIEltbTMyKEpTVmFsdWU6OkNlbGxU
YWcpKSk7Ci0KLSAgICBsb2FkUHRyKEFkZHJlc3MocmVnVDAsIE9CSkVDVF9PRkZTRVRPRihKU0Nl
bGwsIG1fc3RydWN0dXJlKSksIHJlZ1QyKTsKLSAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGJyYW5j
aFB0cihOb3RFcXVhbCwgcmVnVDIsIEltbVB0cihvbGRTdHJ1Y3R1cmUpKSk7CisgICAgZmFpbHVy
ZUNhc2VzLmFwcGVuZChicmFuY2hQdHIoTm90RXF1YWwsIEFkZHJlc3MocmVnVDAsIE9CSkVDVF9P
RkZTRVRPRihKU0NlbGwsIG1fc3RydWN0dXJlKSksIEltbVB0cihvbGRTdHJ1Y3R1cmUpKSk7Cisg
ICAgdGVzdFByb3RvdHlwZShvbGRTdHJ1Y3R1cmUsIGZhaWx1cmVDYXNlcyk7CiAKICAgICAvLyBW
ZXJpZnkgdGhhdCBub3RoaW5nIGluIHRoZSBwcm90b3R5cGUgY2hhaW4gaGFzIGEgc2V0dGVyIGZv
ciB0aGlzIHByb3BlcnR5LiAKLSAgICBmb3IgKFJlZlB0cjxTdHJ1Y3R1cmU+KiBpdCA9IGNoYWlu
LT5oZWFkKCk7ICppdDsgKytpdCkgewotICAgICAgICBsb2FkUHRyKEFkZHJlc3MocmVnVDIsIE9C
SkVDVF9PRkZTRVRPRihTdHJ1Y3R1cmUsIG1fcHJvdG90eXBlKSksIHJlZ1QyKTsKLSAgICAgICAg
bG9hZFB0cihBZGRyZXNzKHJlZ1QyLCBPQkpFQ1RfT0ZGU0VUT0YoSlNDZWxsLCBtX3N0cnVjdHVy
ZSkpLCByZWdUMik7Ci0gICAgICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoYnJhbmNoUHRyKE5vdEVx
dWFsLCByZWdUMiwgSW1tUHRyKGl0LT5nZXQoKSkpKTsKLSAgICB9CisgICAgZm9yIChSZWZQdHI8
U3RydWN0dXJlPiogaXQgPSBjaGFpbi0+aGVhZCgpOyAqaXQ7ICsraXQpCisgICAgICAgIHRlc3RQ
cm90b3R5cGUoaXQtPmdldCgpLCBmYWlsdXJlQ2FzZXMpOwogCiAgICAgLy8gUmVhbGxvY2F0ZSBw
cm9wZXJ0eSBzdG9yYWdlIGlmIG5lZWRlZC4KICAgICBDYWxsIGNhbGxUYXJnZXQ7CkBAIC0xMzQ3
LDM1ICsxMzUxLDI3IEBAIHZvaWQgSklUOjpjb21waWxlR2V0RGlyZWN0T2Zmc2V0KEpTT2JqZWMK
ICAgICB9IAogfQogCit2b2lkIEpJVDo6dGVzdFByb3RvdHlwZShTdHJ1Y3R1cmUqIHN0cnVjdHVy
ZSwgSnVtcExpc3QmIGZhaWx1cmVDYXNlcykKK3sKKyAgICBpZiAoc3RydWN0dXJlLT5tX3Byb3Rv
dHlwZS5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbW92ZShJbW1QdHIoJmFzQ2Vs
bChzdHJ1Y3R1cmUtPm1fcHJvdG90eXBlKS0+bV9zdHJ1Y3R1cmUpLCByZWdUMik7CisgICAgbW92
ZShJbW1QdHIoYXNDZWxsKHN0cnVjdHVyZS0+bV9wcm90b3R5cGUpLT5tX3N0cnVjdHVyZSksIHJl
Z1QzKTsKKyAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGJyYW5jaFB0cihOb3RFcXVhbCwgQWRkcmVz
cyhyZWdUMiksIHJlZ1QzKSk7Cit9CisKIHZvaWQgSklUOjpwcml2YXRlQ29tcGlsZVB1dEJ5SWRU
cmFuc2l0aW9uKFN0cnVjdHVyZVN0dWJJbmZvKiBzdHViSW5mbywgU3RydWN0dXJlKiBvbGRTdHJ1
Y3R1cmUsIFN0cnVjdHVyZSogbmV3U3RydWN0dXJlLCBzaXplX3QgY2FjaGVkT2Zmc2V0LCBTdHJ1
Y3R1cmVDaGFpbiogY2hhaW4sIFJldHVybkFkZHJlc3NQdHIgcmV0dXJuQWRkcmVzcykKIHsKICAg
ICBKdW1wTGlzdCBmYWlsdXJlQ2FzZXM7CiAgICAgLy8gQ2hlY2sgZWF4IGlzIGFuIG9iamVjdCBv
ZiB0aGUgcmlnaHQgU3RydWN0dXJlLgogICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoZW1pdEp1bXBJ
Zk5vdEpTQ2VsbChyZWdUMCkpOwogICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoYnJhbmNoUHRyKE5v
dEVxdWFsLCBBZGRyZXNzKHJlZ1QwLCBPQkpFQ1RfT0ZGU0VUT0YoSlNDZWxsLCBtX3N0cnVjdHVy
ZSkpLCBJbW1QdHIob2xkU3RydWN0dXJlKSkpOwotICAgIEp1bXBMaXN0IHN1Y2Nlc3NDYXNlczsK
LQotICAgIC8vIGVjeCA9IGJhc2VPYmplY3QKLSAgICBsb2FkUHRyKEFkZHJlc3MocmVnVDAsIE9C
SkVDVF9PRkZTRVRPRihKU0NlbGwsIG1fc3RydWN0dXJlKSksIHJlZ1QyKTsKLSAgICAvLyBwcm90
byhlY3gpID0gYmFzZU9iamVjdC0+c3RydWN0dXJlKCktPnByb3RvdHlwZSgpCi0gICAgZmFpbHVy
ZUNhc2VzLmFwcGVuZChicmFuY2gzMihOb3RFcXVhbCwgQWRkcmVzcyhyZWdUMiwgT0JKRUNUX09G
RlNFVE9GKFN0cnVjdHVyZSwgbV90eXBlSW5mbykgKyBPQkpFQ1RfT0ZGU0VUT0YoVHlwZUluZm8s
IG1fdHlwZSkpLCBJbW0zMihPYmplY3RUeXBlKSkpOworICAgIHRlc3RQcm90b3R5cGUob2xkU3Ry
dWN0dXJlLCBmYWlsdXJlQ2FzZXMpOwogCi0gICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QyLCBPQkpF
Q1RfT0ZGU0VUT0YoU3RydWN0dXJlLCBtX3Byb3RvdHlwZSkpLCByZWdUMik7Ci0gICAgCiAgICAg
Ly8gZWN4ID0gYmFzZU9iamVjdC0+bV9zdHJ1Y3R1cmUKLSAgICBmb3IgKFJlZlB0cjxTdHJ1Y3R1
cmU+KiBpdCA9IGNoYWluLT5oZWFkKCk7ICppdDsgKytpdCkgewotICAgICAgICAvLyBudWxsIGNo
ZWNrIHRoZSBwcm90b3R5cGUKLSAgICAgICAgc3VjY2Vzc0Nhc2VzLmFwcGVuZChicmFuY2hQdHIo
RXF1YWwsIHJlZ1QyLCBJbW1QdHIoSlNWYWx1ZTo6ZW5jb2RlKGpzTnVsbCgpKSkpKTsKLQotICAg
ICAgICAvLyBDaGVjayB0aGUgc3RydWN0dXJlIGlkCi0gICAgICAgIGZhaWx1cmVDYXNlcy5hcHBl
bmQoYnJhbmNoUHRyKE5vdEVxdWFsLCBBZGRyZXNzKHJlZ1QyLCBPQkpFQ1RfT0ZGU0VUT0YoSlND
ZWxsLCBtX3N0cnVjdHVyZSkpLCBJbW1QdHIoaXQtPmdldCgpKSkpOwotICAgICAgICAKLSAgICAg
ICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QyLCBPQkpFQ1RfT0ZGU0VUT0YoSlNDZWxsLCBtX3N0cnVj
dHVyZSkpLCByZWdUMik7Ci0gICAgICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoYnJhbmNoMzIoTm90
RXF1YWwsIEFkZHJlc3MocmVnVDIsIE9CSkVDVF9PRkZTRVRPRihTdHJ1Y3R1cmUsIG1fdHlwZUlu
Zm8pICsgT0JKRUNUX09GRlNFVE9GKFR5cGVJbmZvLCBtX3R5cGUpKSwgSW1tMzIoT2JqZWN0VHlw
ZSkpKTsKLSAgICAgICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QyLCBPQkpFQ1RfT0ZGU0VUT0YoU3Ry
dWN0dXJlLCBtX3Byb3RvdHlwZSkpLCByZWdUMik7Ci0gICAgfQotCi0gICAgc3VjY2Vzc0Nhc2Vz
LmxpbmsodGhpcyk7CisgICAgZm9yIChSZWZQdHI8U3RydWN0dXJlPiogaXQgPSBjaGFpbi0+aGVh
ZCgpOyAqaXQ7ICsraXQpCisgICAgICAgIHRlc3RQcm90b3R5cGUoaXQtPmdldCgpLCBmYWlsdXJl
Q2FzZXMpOwogCiAgICAgQ2FsbCBjYWxsVGFyZ2V0OwogCg==
</data>
<flag name="review"
          id="22853"
          type_id="1"
          status="+"
          setter="oliver"
    />
    <flag name="commit-queue"
          id="22854"
          type_id="3"
          status="-"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>