30531 2009-10-19 13:38:46 -0700 Move sendRemainingDelegateMessages to ResourceLoadNotifier 2009-10-19 18:28:56 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 29947 1 abarth abarth darin eric oldest_to_newest 155864 0 abarth 2009-10-19 13:38:46 -0700 As request by Darin Adler. 155870 1 41445 abarth 2009-10-19 13:41:27 -0700 Created attachment 41445 Patch v1 155889 2 41445 eric 2009-10-19 14:08:02 -0700 Comment on attachment 41445 Patch v1 179 m_frame->loader()->client()->dispatchDidFailLoading(loader, identifier, error); seems a little odd, but looks OK. Are those all known to be non-null? 156014 3 abarth 2009-10-19 18:28:56 -0700 Committed r49828: <http://trac.webkit.org/changeset/49828> 41445 2009-10-19 13:41:27 -0700 2009-10-19 14:08:01 -0700 Patch v1 bug-30531-20091019134125.patch text/plain 6495 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjcxMDkzZS4uMDVlNGMzZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOS0xMC0xNyAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1vdmUgc2VuZFJlbWFpbmluZ0RlbGVnYXRlTWVzc2FnZXMgdG8gUmVzb3Vy Y2VMb2FkTm90aWZpZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMwNTMxCisKKyAgICAgICAgVGhpcyBtZXRob2QgaXMgYWJvdXQgbm90aWZ5aW5nIGZv bGtzIGFuZCBkb2Vzbid0IGludGVyYWN0IHdpdGggdGhlIHJlc3QKKyAgICAgICAgb2YgRnJhbWVM b2FkZXIuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVMb2FkZXI6OndpbGxMb2FkTWVkaWFFbGVtZW50VVJMKToKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lTG9hZGVyOjpjb21taXRQcm92aXNpb25hbExvYWQpOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVMb2FkZXI6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkpOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWVMb2FkZXI6OmxvYWRlZFJlc291cmNlRnJvbU1lbW9yeUNhY2hlKToKKyAg ICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuaDoKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VM b2FkTm90aWZpZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkTm90aWZpZXI6 OnNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3NhZ2VzKToKKyAgICAgICAgKiBsb2FkZXIvUmVzb3Vy Y2VMb2FkTm90aWZpZXIuaDoKKwogMjAwOS0xMC0xOSAgQWxwaGEgTGFtICA8aGNsYW1AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdiAoZGdsYXprb3ZA Y2hyb21pdW0ub3JnKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCA1YzI3Yzg1Li4xMjU5OWI1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0yMDM0LDcgKzIwMzQsNyBAQCBib29sIEZyYW1l TG9hZGVyOjp3aWxsTG9hZE1lZGlhRWxlbWVudFVSTChLVVJMJiB1cmwpCiAgICAgdW5zaWduZWQg bG9uZyBpZGVudGlmaWVyOwogICAgIFJlc291cmNlRXJyb3IgZXJyb3I7CiAgICAgcmVxdWVzdEZy b21EZWxlZ2F0ZShyZXF1ZXN0LCBpZGVudGlmaWVyLCBlcnJvcik7Ci0gICAgc2VuZFJlbWFpbmlu Z0RlbGVnYXRlTWVzc2FnZXMoaWRlbnRpZmllciwgUmVzb3VyY2VSZXNwb25zZSh1cmwsIFN0cmlu ZygpLCAtMSwgU3RyaW5nKCksIFN0cmluZygpKSwgLTEsIGVycm9yKTsKKyAgICBub3RpZmllci0+ c2VuZFJlbWFpbmluZ0RlbGVnYXRlTWVzc2FnZXMobV9kb2N1bWVudExvYWRlci5nZXQoKSwgaWRl bnRpZmllciwgUmVzb3VyY2VSZXNwb25zZSh1cmwsIFN0cmluZygpLCAtMSwgU3RyaW5nKCksIFN0 cmluZygpKSwgLTEsIGVycm9yKTsKIAogICAgIHVybCA9IHJlcXVlc3QudXJsKCk7CiAKQEAgLTI0 MDIsNyArMjQwMiw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFsTG9hZChQ YXNzUmVmUHRyPENhY2hlZFBhZ2U+IHBycENhY2hlZFBhZ2UpCiAgICAgICAgICAgICAvLyBGSVhN RTogSWYgd2UgZ2V0IGEgcmVzb3VyY2Ugd2l0aCBtb3JlIHRoYW4gMkIgYnl0ZXMsIHRoaXMgY29k ZSB3b24ndCBkbyB0aGUgcmlnaHQgdGhpbmcuCiAgICAgICAgICAgICAvLyBIb3dldmVyLCB3aXRo IHRvZGF5J3MgY29tcHV0ZXJzIGFuZCBuZXR3b3JraW5nIHNwZWVkcywgdGhpcyB3b24ndCBoYXBw ZW4gaW4gcHJhY3RpY2UuCiAgICAgICAgICAgICAvLyBDb3VsZCBiZSBhbiBpc3N1ZSB3aXRoIGEg Z2lhbnQgbG9jYWwgZmlsZS4KLSAgICAgICAgICAgIHNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3Nh Z2VzKGlkZW50aWZpZXIsIHJlc3BvbnNlLCBzdGF0aWNfY2FzdDxpbnQ+KHJlc3BvbnNlLmV4cGVj dGVkQ29udGVudExlbmd0aCgpKSwgZXJyb3IpOworICAgICAgICAgICAgbm90aWZpZXIoKS0+c2Vu ZFJlbWFpbmluZ0RlbGVnYXRlTWVzc2FnZXMobV9kb2N1bWVudExvYWRlci5nZXQoKSwgaWRlbnRp ZmllciwgcmVzcG9uc2UsIHN0YXRpY19jYXN0PGludD4ocmVzcG9uc2UuZXhwZWN0ZWRDb250ZW50 TGVuZ3RoKCkpLCBlcnJvcik7CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIHBhZ2VDYWNo ZSgpLT5yZW1vdmUoaGlzdG9yeSgpLT5jdXJyZW50SXRlbSgpKTsKQEAgLTMyNTQsOCArMzI1NCw4 IEBAIHVuc2lnbmVkIGxvbmcgRnJhbWVMb2FkZXI6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHko Y29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1CiAgICAgICAgIH0KICNlbmRpZgogICAgIH0KLSAg ICAKLSAgICBzZW5kUmVtYWluaW5nRGVsZWdhdGVNZXNzYWdlcyhpZGVudGlmaWVyLCByZXNwb25z ZSwgZGF0YS5zaXplKCksIGVycm9yKTsKKworICAgIG5vdGlmaWVyKCktPnNlbmRSZW1haW5pbmdE ZWxlZ2F0ZU1lc3NhZ2VzKG1fZG9jdW1lbnRMb2FkZXIuZ2V0KCksIGlkZW50aWZpZXIsIHJlc3Bv bnNlLCBkYXRhLnNpemUoKSwgZXJyb3IpOwogICAgIHJldHVybiBpZGVudGlmaWVyOwogfQogCkBA IC0zNDY4LDIwICszNDY4LDYgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y29udGludWVMb2FkQWZ0ZXJO ZXdXaW5kb3dQb2xpY3koY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXMKICAgICBtYWluRnJh bWUtPmxvYWRlcigpLT5sb2FkV2l0aE5hdmlnYXRpb25BY3Rpb24ocmVxdWVzdCwgTmF2aWdhdGlv bkFjdGlvbigpLCBmYWxzZSwgRnJhbWVMb2FkVHlwZVN0YW5kYXJkLCBmb3JtU3RhdGUpOwogfQog Ci12b2lkIEZyYW1lTG9hZGVyOjpzZW5kUmVtYWluaW5nRGVsZWdhdGVNZXNzYWdlcyh1bnNpZ25l ZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlLCBpbnQg bGVuZ3RoLCBjb25zdCBSZXNvdXJjZUVycm9yJiBlcnJvcikKLXsgICAgCi0gICAgaWYgKCFyZXNw b25zZS5pc051bGwoKSkKLSAgICAgICAgbm90aWZpZXIoKS0+ZGlzcGF0Y2hEaWRSZWNlaXZlUmVz cG9uc2UobV9kb2N1bWVudExvYWRlci5nZXQoKSwgaWRlbnRpZmllciwgcmVzcG9uc2UpOwotICAg IAotICAgIGlmIChsZW5ndGggPiAwKQotICAgICAgICBub3RpZmllcigpLT5kaXNwYXRjaERpZFJl Y2VpdmVDb250ZW50TGVuZ3RoKG1fZG9jdW1lbnRMb2FkZXIuZ2V0KCksIGlkZW50aWZpZXIsIGxl bmd0aCk7Ci0gICAgCi0gICAgaWYgKGVycm9yLmlzTnVsbCgpKQotICAgICAgICBub3RpZmllcigp LT5kaXNwYXRjaERpZEZpbmlzaExvYWRpbmcobV9kb2N1bWVudExvYWRlci5nZXQoKSwgaWRlbnRp Zmllcik7Ci0gICAgZWxzZQotICAgICAgICBtX2NsaWVudC0+ZGlzcGF0Y2hEaWRGYWlsTG9hZGlu ZyhtX2RvY3VtZW50TG9hZGVyLmdldCgpLCBpZGVudGlmaWVyLCBlcnJvcik7Ci19Ci0KIHZvaWQg RnJhbWVMb2FkZXI6OnJlcXVlc3RGcm9tRGVsZWdhdGUoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0 LCB1bnNpZ25lZCBsb25nJiBpZGVudGlmaWVyLCBSZXNvdXJjZUVycm9yJiBlcnJvcikKIHsKICAg ICBBU1NFUlQoIXJlcXVlc3QuaXNOdWxsKCkpOwpAQCAtMzUzMSw3ICszNTE3LDcgQEAgdm9pZCBG cmFtZUxvYWRlcjo6bG9hZGVkUmVzb3VyY2VGcm9tTWVtb3J5Q2FjaGUoY29uc3QgQ2FjaGVkUmVz b3VyY2UqIHJlc291cmNlKQogICAgIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllcjsKICAgICBSZXNv dXJjZUVycm9yIGVycm9yOwogICAgIHJlcXVlc3RGcm9tRGVsZWdhdGUocmVxdWVzdCwgaWRlbnRp ZmllciwgZXJyb3IpOwotICAgIHNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3NhZ2VzKGlkZW50aWZp ZXIsIHJlc291cmNlLT5yZXNwb25zZSgpLCByZXNvdXJjZS0+ZW5jb2RlZFNpemUoKSwgZXJyb3Ip OworICAgIG5vdGlmaWVyKCktPnNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3NhZ2VzKG1fZG9jdW1l bnRMb2FkZXIuZ2V0KCksIGlkZW50aWZpZXIsIHJlc291cmNlLT5yZXNwb25zZSgpLCByZXNvdXJj ZS0+ZW5jb2RlZFNpemUoKSwgZXJyb3IpOwogfQogCiB2b2lkIEZyYW1lTG9hZGVyOjphcHBseVVz ZXJBZ2VudChSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xv YWRlci9GcmFtZUxvYWRlci5oIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAppbmRleCBl ZWNhYmNhLi4zNDYyN2I1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5o CisrKyBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKQEAgLTQwMyw3ICs0MDMsNiBAQCBw cml2YXRlOgogCiAgICAgYm9vbCBzaG91bGRSZWxvYWQoY29uc3QgS1VSTCYgY3VycmVudFVSTCwg Y29uc3QgS1VSTCYgZGVzdGluYXRpb25VUkwpOwogCi0gICAgdm9pZCBzZW5kUmVtYWluaW5nRGVs ZWdhdGVNZXNzYWdlcyh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IFJlc291cmNlUmVz cG9uc2UmLCBpbnQgbGVuZ3RoLCBjb25zdCBSZXNvdXJjZUVycm9yJik7CiAgICAgdm9pZCByZXF1 ZXN0RnJvbURlbGVnYXRlKFJlc291cmNlUmVxdWVzdCYsIHVuc2lnbmVkIGxvbmcmIGlkZW50aWZp ZXIsIFJlc291cmNlRXJyb3ImKTsKIAogICAgIHZvaWQgcmVjdXJzaXZlQ2hlY2tMb2FkQ29tcGxl dGUoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE5vdGlmaWVyLmNw cCBiL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE5vdGlmaWVyLmNwcAppbmRleCAyY2Q1MWQx Li43YzFhYTQwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWROb3RpZmll ci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkTm90aWZpZXIuY3BwCkBAIC0x NjUsNiArMTY1LDIwIEBAIHZvaWQgUmVzb3VyY2VMb2FkTm90aWZpZXI6OmRpc3BhdGNoRGlkRmlu aXNoTG9hZGluZyhEb2N1bWVudExvYWRlciogbG9hZGVyLCB1bnNpCiAjZW5kaWYKIH0KIAordm9p ZCBSZXNvdXJjZUxvYWROb3RpZmllcjo6c2VuZFJlbWFpbmluZ0RlbGVnYXRlTWVzc2FnZXMoRG9j dW1lbnRMb2FkZXIqIGxvYWRlciwgdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBjb25zdCBSZXNv dXJjZVJlc3BvbnNlJiByZXNwb25zZSwgaW50IGxlbmd0aCwgY29uc3QgUmVzb3VyY2VFcnJvciYg ZXJyb3IpCit7CisgICAgaWYgKCFyZXNwb25zZS5pc051bGwoKSkKKyAgICAgICAgZGlzcGF0Y2hE aWRSZWNlaXZlUmVzcG9uc2UobG9hZGVyLCBpZGVudGlmaWVyLCByZXNwb25zZSk7CisKKyAgICBp ZiAobGVuZ3RoID4gMCkKKyAgICAgICAgZGlzcGF0Y2hEaWRSZWNlaXZlQ29udGVudExlbmd0aChs b2FkZXIsIGlkZW50aWZpZXIsIGxlbmd0aCk7CisKKyAgICBpZiAoZXJyb3IuaXNOdWxsKCkpCisg ICAgICAgIGRpc3BhdGNoRGlkRmluaXNoTG9hZGluZyhsb2FkZXIsIGlkZW50aWZpZXIpOworICAg IGVsc2UKKyAgICAgICAgbV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpLT5kaXNwYXRjaERpZEZh aWxMb2FkaW5nKGxvYWRlciwgaWRlbnRpZmllciwgZXJyb3IpOworfQorCiBEb2N1bWVudExvYWRl ciogUmVzb3VyY2VMb2FkTm90aWZpZXI6OmFjdGl2ZURvY3VtZW50TG9hZGVyKCkgY29uc3QKIHsK ICAgICByZXR1cm4gbV9mcmFtZS0+bG9hZGVyKCktPmFjdGl2ZURvY3VtZW50TG9hZGVyKCk7CmRp ZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWROb3RpZmllci5oIGIvV2ViQ29y ZS9sb2FkZXIvUmVzb3VyY2VMb2FkTm90aWZpZXIuaAppbmRleCA2MDVkM2U0Li4yZDk0MTJjIDEw MDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWROb3RpZmllci5oCisrKyBiL1dl YkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE5vdGlmaWVyLmgKQEAgLTY0LDYgKzY0LDggQEAgcHVi bGljOgogICAgIHZvaWQgZGlzcGF0Y2hEaWRSZWNlaXZlQ29udGVudExlbmd0aChEb2N1bWVudExv YWRlciosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgaW50IGxlbmd0aCk7CiAgICAgdm9pZCBk aXNwYXRjaERpZEZpbmlzaExvYWRpbmcoRG9jdW1lbnRMb2FkZXIqLCB1bnNpZ25lZCBsb25nIGlk ZW50aWZpZXIpOwogCisgICAgdm9pZCBzZW5kUmVtYWluaW5nRGVsZWdhdGVNZXNzYWdlcyhEb2N1 bWVudExvYWRlciosIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgY29uc3QgUmVzb3VyY2VSZXNw b25zZSYsIGludCBsZW5ndGgsIGNvbnN0IFJlc291cmNlRXJyb3ImKTsKKwogcHJpdmF0ZToKICAg ICBpbmxpbmUgRG9jdW1lbnRMb2FkZXIqIGFjdGl2ZURvY3VtZW50TG9hZGVyKCkgY29uc3Q7