30529 2009-10-19 12:51:12 -0700 Hide Chromium's media slider thumb if no source has been loaded. 2009-10-20 12:08:31 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 scherkus webkit-unassigned commit-queue eric.carlson oldest_to_newest 155846 0 scherkus 2009-10-19 12:51:12 -0700 Since the slider is non-interactive, it does not make sense to display an active-appearing slider thumb. 155847 1 41440 scherkus 2009-10-19 12:53:38 -0700 Created attachment 41440 Round 1 155861 2 41440 eric 2009-10-19 13:37:01 -0700 Comment on attachment 41440 Round 1 It is much better to list the layout tests rather than just saying "there are some". Eventually all of chromiums tests will be upstream and we won't have untestable patches like this. :( I thought "false" here meant "no theme-specific painting, webcore should paint if it want to"? 155863 3 41440 eric 2009-10-19 13:37:51 -0700 Comment on attachment 41440 Round 1 It seems there was at least one other: if (mediaElement->networkState() == HTMLMediaElement::NETWORK_EMPTY || 154 mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE) check, maybe this check should be unified into a static method which can be used in multiple places in this file? 155867 4 scherkus 2009-10-19 13:40:20 -0700 I like the suggestions -- I'll upload something new. 155886 5 41440 levin 2009-10-19 14:02:16 -0700 Comment on attachment 41440 Round 1 r- to move out of the queue since Andrew said he is uploading something new. > diff --git a/WebCore/rendering/RenderMediaControlsChromium.cpp b/WebCore/rendering/RenderMediaControlsChromium.cpp > + if (mediaElement->networkState() == HTMLMediaElement::NETWORK_EMPTY || > + mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE) fyi, the || should be on the next line. 155896 6 41449 scherkus 2009-10-19 14:17:49 -0700 Created attachment 41449 Round 2 Here ya go! P.S. I can't wait for the layout tests to be in WebKit... doing two-sided change + rebaselines are killing me! 156232 7 41449 eric 2009-10-20 11:59:20 -0700 Comment on attachment 41449 Round 2 LGTM. 156241 8 41449 commit-queue 2009-10-20 12:08:27 -0700 Comment on attachment 41449 Round 2 Clearing flags on attachment: 41449 Committed r49878: <http://trac.webkit.org/changeset/49878> 156242 9 commit-queue 2009-10-20 12:08:31 -0700 All reviewed patches have been landed. Closing bug. 41440 2009-10-19 12:53:38 -0700 2009-10-19 14:17:49 -0700 Round 1 hide_slider.patch text/plain 1554 scherkus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjVlZGYzNi4uNGY2MWU5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0xOSAgQW5kcmV3IFNjaGVy a3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhpZGUgQ2hyb21pdW0ncyBtZWRpYSBzbGlkZXIgdGh1bWIg aWYgbm8gc291cmNlIGhhcyBiZWVuIGxvYWRlZC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA1MjkKKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0 aW5nIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRy b2xzQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFpbnRNZWRpYVNsaWRlclRodW1i KTogQWRkZWQgY2hlY2sgZm9yIE5FVFdPUktfRU1QVFkvTkVUV09SS19OT19TT1VSQ0UuCisKIDIw MDktMTAtMTggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgTm90IHJldmlld2VkOiB0b3VjaGluZyBXZWJDb3JlIHNvIHRoYXQgaXQKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHAgYi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwCmluZGV4IDlkNjc1 ZWEuLjZmNzU1MjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29u dHJvbHNDaHJvbWl1bS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFDb250 cm9sc0Nocm9taXVtLmNwcApAQCAtMTQ2LDYgKzE0NiwxNCBAQCBzdGF0aWMgYm9vbCBwYWludE1l ZGlhU2xpZGVyVGh1bWIoUmVuZGVyT2JqZWN0KiBvYmplY3QsIGNvbnN0IFJlbmRlck9iamVjdDo6 UGFpbgogICAgIGlmICghb2JqZWN0LT5wYXJlbnQoKS0+aXNTbGlkZXIoKSkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCisgICAgSFRNTE1lZGlhRWxlbWVudCogbWVkaWFFbGVtZW50ID0gdG9QYXJl bnRNZWRpYUVsZW1lbnQob2JqZWN0LT5wYXJlbnQoKSk7CisgICAgaWYgKCFtZWRpYUVsZW1lbnQp CisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmIChtZWRpYUVsZW1lbnQtPm5ldHdvcmtT dGF0ZSgpID09IEhUTUxNZWRpYUVsZW1lbnQ6Ok5FVFdPUktfRU1QVFkgfHwKKyAgICAgICAgbWVk aWFFbGVtZW50LT5uZXR3b3JrU3RhdGUoKSA9PSBIVE1MTWVkaWFFbGVtZW50OjpORVRXT1JLX05P X1NPVVJDRSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgc3RhdGljIEltYWdlKiBtZWRp YVNsaWRlclRodW1iID0gcGxhdGZvcm1SZXNvdXJjZSgibWVkaWFTbGlkZXJUaHVtYiIpOwogICAg IHJldHVybiBwYWludE1lZGlhQnV0dG9uKHBhaW50SW5mby5jb250ZXh0LCByZWN0LCBtZWRpYVNs aWRlclRodW1iKTsKIH0K 41449 2009-10-19 14:17:49 -0700 2009-10-20 12:08:27 -0700 Round 2 hide_slider.patch text/plain 3490 scherkus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjVlZGYzNi4uYmE3NmE4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMC0xOSAgQW5kcmV3IFNjaGVy a3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhpZGUgQ2hyb21pdW0ncyBtZWRpYSBzbGlkZXIgdGh1bWIg aWYgbm8gc291cmNlIGhhcyBiZWVuIGxvYWRlZC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA1MjkKKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0 aW5nIGxheW91dCB0ZXN0cywgbm90YWJseToKKyAgICAgICAgICAgIExheW91dFRlc3RzL21lZGlh L2NvbnRyb2xzLXJlbmRlcmluZy5odG1sCisgICAgICAgICAgICBMYXlvdXRUZXN0cy9tZWRpYS91 bnN1cHBvcnRlZC10cmFja3MuaHRtbAorICAgICAgICAgICAgTGF5b3V0VGVzdHMvbWVkaWEvdmlk ZW8tc3JjLW5vbmUuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJv bHNDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYXNTb3VyY2UpOiBSZXR1cm5zIHRy dWUgaWYgYW4gSFRNTE1lZGlhRWxlbWVudCBoYXMgYSB2YWxpZCBzb3VyY2Ugc2V0LgorICAgICAg ICAoV2ViQ29yZTo6cGFpbnRNZWRpYU11dGVCdXR0b24pOiBSZWZhY3RvcmVkIHRvIHVzZSBoYXNT b3VyY2UoKS4KKyAgICAgICAgKFdlYkNvcmU6OnBhaW50TWVkaWFQbGF5QnV0dG9uKTogRGl0dG8u CisgICAgICAgIChXZWJDb3JlOjpwYWludE1lZGlhU2xpZGVyVGh1bWIpOiBBZGQgY2FsbCB0byBo YXNTb3VyY2UoKSB0byBkZXRlcm1pbmUgaWYgd2Ugc2hvdWxkIHBhaW50IHRoZSB0aHVtYi4KKwog MjAwOS0xMC0xOCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBOb3QgcmV2aWV3ZWQ6IHRvdWNoaW5nIFdlYkNvcmUgc28gdGhhdCBpdApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFDb250cm9sc0Nocm9taXVtLmNwcCBiL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHAKaW5kZXggOWQ2 NzVlYS4uN2MwMDVhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFD b250cm9sc0Nocm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYUNv bnRyb2xzQ2hyb21pdW0uY3BwCkBAIC01NCw2ICs1NCwxMiBAQCBzdGF0aWMgSW1hZ2UqIHBsYXRm b3JtUmVzb3VyY2UoY29uc3QgY2hhciogbmFtZSkKICAgICByZXR1cm4gMDsKIH0KIAorc3RhdGlj IGJvb2wgaGFzU291cmNlKGNvbnN0IEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCkKK3sK KyAgICByZXR1cm4gbWVkaWFFbGVtZW50LT5uZXR3b3JrU3RhdGUoKSAhPSBIVE1MTWVkaWFFbGVt ZW50OjpORVRXT1JLX0VNUFRZCisgICAgICAgICYmIG1lZGlhRWxlbWVudC0+bmV0d29ya1N0YXRl KCkgIT0gSFRNTE1lZGlhRWxlbWVudDo6TkVUV09SS19OT19TT1VSQ0U7Cit9CisKIHN0YXRpYyBi b29sIHBhaW50TWVkaWFCdXR0b24oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRS ZWN0JiByZWN0LCBJbWFnZSogaW1hZ2UpCiB7CiAgICAgSW50UmVjdCBpbWFnZVJlY3QgPSBpbWFn ZS0+cmVjdCgpOwpAQCAtNzEsNyArNzcsNyBAQCBzdGF0aWMgYm9vbCBwYWludE1lZGlhTXV0ZUJ1 dHRvbihSZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUmVuZGVyT2JqZWN0OjpQYWludAogICAg IHN0YXRpYyBJbWFnZSogc291bmROb25lID0gcGxhdGZvcm1SZXNvdXJjZSgibWVkaWFTb3VuZE5v bmUiKTsKICAgICBzdGF0aWMgSW1hZ2UqIHNvdW5kRGlzYWJsZWQgPSBwbGF0Zm9ybVJlc291cmNl KCJtZWRpYVNvdW5kRGlzYWJsZWQiKTsKIAotICAgIGlmIChtZWRpYUVsZW1lbnQtPm5ldHdvcmtT dGF0ZSgpID09IEhUTUxNZWRpYUVsZW1lbnQ6Ok5FVFdPUktfTk9fU09VUkNFIHx8ICFtZWRpYUVs ZW1lbnQtPmhhc0F1ZGlvKCkpCisgICAgaWYgKCFoYXNTb3VyY2UobWVkaWFFbGVtZW50KSB8fCAh bWVkaWFFbGVtZW50LT5oYXNBdWRpbygpKQogICAgICAgICByZXR1cm4gcGFpbnRNZWRpYUJ1dHRv bihwYWludEluZm8uY29udGV4dCwgcmVjdCwgc291bmREaXNhYmxlZCk7CiAKICAgICByZXR1cm4g cGFpbnRNZWRpYUJ1dHRvbihwYWludEluZm8uY29udGV4dCwgcmVjdCwgbWVkaWFFbGVtZW50LT5t dXRlZCgpID8gc291bmROb25lOiBzb3VuZEZ1bGwpOwpAQCAtODcsOCArOTMsNyBAQCBzdGF0aWMg Ym9vbCBwYWludE1lZGlhUGxheUJ1dHRvbihSZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUmVu ZGVyT2JqZWN0OjpQYWludAogICAgIHN0YXRpYyBJbWFnZSogbWVkaWFQYXVzZSA9IHBsYXRmb3Jt UmVzb3VyY2UoIm1lZGlhUGF1c2UiKTsKICAgICBzdGF0aWMgSW1hZ2UqIG1lZGlhUGxheURpc2Fi bGVkID0gcGxhdGZvcm1SZXNvdXJjZSgibWVkaWFQbGF5RGlzYWJsZWQiKTsKIAotICAgIGlmICht ZWRpYUVsZW1lbnQtPm5ldHdvcmtTdGF0ZSgpID09IEhUTUxNZWRpYUVsZW1lbnQ6Ok5FVFdPUktf RU1QVFkgfHwKLSAgICAgICAgbWVkaWFFbGVtZW50LT5uZXR3b3JrU3RhdGUoKSA9PSBIVE1MTWVk aWFFbGVtZW50OjpORVRXT1JLX05PX1NPVVJDRSkKKyAgICBpZiAoIWhhc1NvdXJjZShtZWRpYUVs ZW1lbnQpKQogICAgICAgICByZXR1cm4gcGFpbnRNZWRpYUJ1dHRvbihwYWludEluZm8uY29udGV4 dCwgcmVjdCwgbWVkaWFQbGF5RGlzYWJsZWQpOwogCiAgICAgcmV0dXJuIHBhaW50TWVkaWFCdXR0 b24ocGFpbnRJbmZvLmNvbnRleHQsIHJlY3QsIG1lZGlhRWxlbWVudC0+cGF1c2VkKCkgPyBtZWRp YVBsYXkgOiBtZWRpYVBhdXNlKTsKQEAgLTE0Niw2ICsxNTEsMTMgQEAgc3RhdGljIGJvb2wgcGFp bnRNZWRpYVNsaWRlclRodW1iKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBSZW5kZXJPYmpl Y3Q6OlBhaW4KICAgICBpZiAoIW9iamVjdC0+cGFyZW50KCktPmlzU2xpZGVyKCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAorICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCA9IHRv UGFyZW50TWVkaWFFbGVtZW50KG9iamVjdC0+cGFyZW50KCkpOworICAgIGlmICghbWVkaWFFbGVt ZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoIWhhc1NvdXJjZShtZWRpYUVs ZW1lbnQpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAgIHN0YXRpYyBJbWFnZSogbWVkaWFT bGlkZXJUaHVtYiA9IHBsYXRmb3JtUmVzb3VyY2UoIm1lZGlhU2xpZGVyVGh1bWIiKTsKICAgICBy ZXR1cm4gcGFpbnRNZWRpYUJ1dHRvbihwYWludEluZm8uY29udGV4dCwgcmVjdCwgbWVkaWFTbGlk ZXJUaHVtYik7CiB9Cg==