30506 2009-10-19 03:10:28 -0700 Resources that the server sent as 304 not modified are not shown in the inspectors resource pane 2009-10-22 17:02:07 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 spamfaenger ap ap koivisto timothy wdm oldest_to_newest 155629 0 spamfaenger 2009-10-19 03:10:28 -0700 Which is unfortunate, as I often want to inspec them - even if Safari pulled them from it's internal cache. Interestingly this behaviour persists even if you deactivate all caches from the "developer" menu. 155771 1 ap 2009-10-19 10:28:46 -0700 What nightly build revision are you seeing this with? Is this a regression? I understand you're saying this happens everywhere, but nonetheless, do you have a specific example of a page we could refer to when investigating this bug? 155972 2 spamfaenger 2009-10-19 15:52:39 -0700 I've seen it with builds for at least the last several months, the latest with build 49764. I have also seen it with Safari 4.0.3 so if it is a regression it probably was in 4 already. For reference, it mostly annoys me when I am debugging our web application that we develop in-house. Here's the homepage http://www.agile42.com/cms/pages/agilo/ and the accompanying trac instance: https://dev.agile42.com/ It is open source, so you could get it to test with, I do suspect that this error is so widespread that you can test it with any page that sends 304s for objects. I would advise to try it with javascript files, because it becomes really apparant if you hit a breakpoint in a file that is just displayed as empty or step into a function just to be shown an empty screen. Something I just noticed: sometimes reloading the page and trying again helps (but its more a 1 out of 10 tries works) scenario and it almost always means that other files will then be hidden. Still this points to the theory that this could also be a timing issue (which I hope it's not). Regards, Martin 156258 3 ap 2009-10-20 12:38:57 -0700 <rdar://problem/7319845> 156363 4 ap 2009-10-20 17:35:59 -0700 Looks like the main culprit here is preloading logic (I'm not even sure if this only happens for 304 Not Modified responses). Here is what happens: 1. As a document is loaded, preload scanner is invoked, requesting subresources while HTML parser is blocked waiting for the first script to download. 2. These preloads result in InspectorController::addResource being called, but cache->requestResource() returns null, thus the resource is never added to document resource set in DocLoader. 3. Once a response for preload is received, Inspector asks DocLoader about it (in InspectorResource::updateScriptObject), but DocLoader says that there is no such resource. It's no good that DocLoader doesn't know about resources that were revalidated by preloader. 156728 5 ap 2009-10-21 16:59:27 -0700 Seems related to FrameLoader::loadedResourceFromMemoryCache() not being called in this case. 157030 6 41692 ap 2009-10-22 16:12:43 -0700 Created attachment 41692 proposed fix This isn't exactly the kind of fix I was trying to make - as mentioned above, it seems that client callbacks are messed up when preloading meets revalidation, which this doesn't correct. But it is a simple and hopefully safe fix. 157047 7 ap 2009-10-22 17:02:07 -0700 Committed <http://trac.webkit.org/changeset/49960>. 41692 2009-10-22 16:12:43 -0700 2009-10-22 16:19:35 -0700 proposed fix Preload304.txt text/plain 4372 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTk1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMDktMTAtMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNTA2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MzE5ODQ1PiBSZXNvdXJjZXMgdGhhdCB0aGUgc2VydmVyIHNlbnQgYXMg MzA0IG5vdCBtb2RpZmllZCBhcmUgbm90IHNob3duCisgICAgICAgIGluIHRoZSBpbnNwZWN0b3Jz IHJlc291cmNlIHBhbmUKKworICAgICAgICBJIGRvbid0IGtub3cgaG93IHRvIG1ha2UgYSB0ZXN0 IGZvciB0aGlzLgorCisgICAgICAgIFRoZSBpc3N1ZSBoZXJlIHdhcyB0aGF0IHByZWxvYWRlZCBy ZXNvdXJjZXMgd2VyZW4ndCBhZGRlZCB0byBEb2NMb2FkZXIgZG9jdW1lbnQgcmVzb3VyY2Ugc2V0 LAorICAgICAgICBidXQgV2ViIEluc3BlY3RvciBhc2tlZCBEb2NMb2FkZXIgdG8gZmV0Y2ggZGF0 YSBmcm9tIENhY2hlZFJlc291cmNlLiBFdmVuIHdoZW4gKGlmKSBkb2N1bWVudAorICAgICAgICBw YXJzZXIgZXZlbnR1YWxseSByZXF1ZXN0ZWQgdGhlIHNhbWUgcmVzb3VyY2UgZm9yIHJlYWwgYW5k IGl0IGdvdCBhZGRlZCB0byByZXNvdXJjZSBzZXQsIGl0CisgICAgICAgIHdhcyB0b28gbGF0ZSAt IHRoZSBJbnNwZWN0b3Igd2Fzbid0IHVwZGF0ZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5z cGVjdG9yUmVzb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUmVzb3VyY2U6 OmNhY2hlZFJlc291cmNlKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclJlc291cmNlOjp0 eXBlKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclJlc291cmNlOjpyZXNvdXJjZURhdGEp OgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZS5oOgorICAgICAgICBGaXgg dGhlIGlzc3VlIGJ5IHRyeWluZyB0byBmZXRjaCBjb3JyZXNwb25kaW5nIENhY2hlZFJlc291cmNl IGhhcmRlciAtIGFsc28gbG9vayBpbiBnbG9iYWwKKyAgICAgICAgY2FjaGUuIFRoaXMgc2VlbXMg c2FmZSwgYW5kIGVhc2llciB0aGFuIHVwZGF0aW5nIHRoZSBJbnNwZWN0b3Igb24gdHJhbnNpdGlv bnMgYmV0d2VlbgorICAgICAgICByZXNvdXJjZSBzdGF0ZXMgKHJldmFsaWRhdGUgdnMuIHJldmFs aWRhdGUgZG9uZSBhbmQgcHJlbG9hZCB2cy4gbm9uLXByZWxvYWQpLgorCiAyMDA5LTEwLTIyICBK b3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVz b3VyY2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291 cmNlLmNwcAkocmV2aXNpb24gNDk5NTUpCisrKyBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JS ZXNvdXJjZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDcgQEAKIAogI2lmIEVOQUJM RShJTlNQRUNUT1IpCiAKKyNpbmNsdWRlICJDYWNoZS5oIgogI2luY2x1ZGUgIkNhY2hlZFJlc291 cmNlLmgiCiAjaW5jbHVkZSAiRG9jTG9hZGVyLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRMb2FkZXIu aCIKQEAgLTIyNyw2ICsyMjgsMTggQEAgdm9pZCBJbnNwZWN0b3JSZXNvdXJjZTo6cmVsZWFzZVNj cmlwdE9iagogICAgIGZyb250ZW5kLT5yZW1vdmVSZXNvdXJjZShtX2lkZW50aWZpZXIpOwogfQog CitDYWNoZWRSZXNvdXJjZSogSW5zcGVjdG9yUmVzb3VyY2U6OmNhY2hlZFJlc291cmNlKCkgY29u c3QKK3sKKyAgICAvLyBUcnkgaGFyZCB0byBmaW5kIGEgY29ycmVzcG9uZGluZyBDYWNoZWRSZXNv dXJjZS4gRHVyaW5nIHByZWxvYWRpbmcsIERvY0xvYWRlciBtYXkgbm90IGhhdmUgdGhlIHJlc291 cmNlIGluIGRvY3VtZW50IHJlc291cmNlcyBzZXQgeWV0LAorICAgIC8vIGJ1dCBJbnNwZWN0b3Ig d2lsbCBhbHJlYWR5IHRyeSB0byBmZXRjaCBkYXRhIHRoYXQgaXMgb25seSBhdmFpbGFibGUgdmlh IENhY2hlZFJlc291cmNlIChhbmQgaXQgd29uJ3QgdXBkYXRlIG9uY2UgdGhlIHJlc291cmNlIGlz IGFkZGVkLAorICAgIC8vIGJlY2F1c2UgbV9jaGFuZ2VzIHdpbGwgbm90IGhhdmUgdGhlIGFwcHJv cHJpYXRlIGJpdHMgc2V0KS4KKyAgICBjb25zdCBTdHJpbmcmIHVybCA9IHJlcXVlc3RVUkwoKTsK KyAgICBDYWNoZWRSZXNvdXJjZSogY2FjaGVkUmVzb3VyY2UgPSBtX2ZyYW1lLT5kb2N1bWVudCgp LT5kb2NMb2FkZXIoKS0+Y2FjaGVkUmVzb3VyY2UodXJsKTsKKyAgICBpZiAoIWNhY2hlZFJlc291 cmNlKQorICAgICAgICBjYWNoZWRSZXNvdXJjZSA9IGNhY2hlKCktPnJlc291cmNlRm9yVVJMKHVy bCk7CisgICAgcmV0dXJuIGNhY2hlZFJlc291cmNlOworfQorCiBJbnNwZWN0b3JSZXNvdXJjZTo6 VHlwZSBJbnNwZWN0b3JSZXNvdXJjZTo6dHlwZSgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX3htbEh0 dHBSZXNwb25zZVRleHQuaXNOdWxsKCkpCkBAIC0yMzgsNyArMjUxLDcgQEAgSW5zcGVjdG9yUmVz b3VyY2U6OlR5cGUgSW5zcGVjdG9yUmVzb3VyYwogICAgIGlmIChtX2xvYWRlci0+ZnJhbWVMb2Fk ZXIoKSAmJiBtX3JlcXVlc3RVUkwgPT0gbV9sb2FkZXItPmZyYW1lTG9hZGVyKCktPmljb25VUkwo KSkKICAgICAgICAgcmV0dXJuIEltYWdlOwogCi0gICAgQ2FjaGVkUmVzb3VyY2UqIGNhY2hlZFJl c291cmNlID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZG9jTG9hZGVyKCktPmNhY2hlZFJlc291cmNl KHJlcXVlc3RVUkwoKSk7CisgICAgQ2FjaGVkUmVzb3VyY2UqIGNhY2hlZFJlc291cmNlID0gdGhp cy0+Y2FjaGVkUmVzb3VyY2UoKTsKICAgICBpZiAoIWNhY2hlZFJlc291cmNlKQogICAgICAgICBy ZXR1cm4gT3RoZXI7CiAKQEAgLTI4MSwxMyArMjk0LDE0IEBAIFN0cmluZyBJbnNwZWN0b3JSZXNv dXJjZTo6c291cmNlU3RyaW5nKCkKICAgICByZXR1cm4gZW5jb2RpbmcuZGVjb2RlKGJ1ZmZlci0+ ZGF0YSgpLCBidWZmZXItPnNpemUoKSk7CiB9CiAKLVBhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBJ bnNwZWN0b3JSZXNvdXJjZTo6cmVzb3VyY2VEYXRhKFN0cmluZyogdGV4dEVuY29kaW5nTmFtZSkg Y29uc3QgeworUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IEluc3BlY3RvclJlc291cmNlOjpyZXNv dXJjZURhdGEoU3RyaW5nKiB0ZXh0RW5jb2RpbmdOYW1lKSBjb25zdAorewogICAgIGlmIChtX3Jl cXVlc3RVUkwgPT0gbV9sb2FkZXItPnJlcXVlc3RVUkwoKSkgewogICAgICAgICAqdGV4dEVuY29k aW5nTmFtZSA9IG1fZnJhbWUtPmRvY3VtZW50KCktPmlucHV0RW5jb2RpbmcoKTsKICAgICAgICAg cmV0dXJuIG1fbG9hZGVyLT5tYWluUmVzb3VyY2VEYXRhKCk7CiAgICAgfQogCi0gICAgQ2FjaGVk UmVzb3VyY2UqIGNhY2hlZFJlc291cmNlID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZG9jTG9hZGVy KCktPmNhY2hlZFJlc291cmNlKHJlcXVlc3RVUkwoKSk7CisgICAgQ2FjaGVkUmVzb3VyY2UqIGNh Y2hlZFJlc291cmNlID0gdGhpcy0+Y2FjaGVkUmVzb3VyY2UoKTsKICAgICBpZiAoIWNhY2hlZFJl c291cmNlKQogICAgICAgICByZXR1cm4gMDsKIApJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yUmVzb3VyY2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JSZXNvdXJjZS5oCShyZXZpc2lvbiA0OTk1NSkKKysrIFdlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvclJlc291cmNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NSw2ICsxNDUsOCBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgICAgIEluc3BlY3RvclJlc291cmNlKGxvbmcgbG9uZyBpZGVudGlm aWVyLCBEb2N1bWVudExvYWRlciopOwogICAgICAgICBUeXBlIHR5cGUoKSBjb25zdDsKIAorICAg ICAgICBDYWNoZWRSZXNvdXJjZSogY2FjaGVkUmVzb3VyY2UoKSBjb25zdDsKKwogICAgICAgICBs b25nIGxvbmcgbV9pZGVudGlmaWVyOwogICAgICAgICBSZWZQdHI8RG9jdW1lbnRMb2FkZXI+IG1f bG9hZGVyOwogICAgICAgICBSZWZQdHI8RnJhbWU+IG1fZnJhbWU7Cg==