30486 2009-10-17 14:35:21 -0700 Web Inspector: Title of dir(["test", "test2"]) should be Array 2009-10-18 16:18:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy pfeldman aroben joepeck pfeldman rik timothy oldest_to_newest 155424 0 timothy 2009-10-17 14:35:21 -0700 We use the toString value when printing the title of the expandable tree for arrays. But we don't do this for other objects (from what I can tell.) dir(["test", "test1,test2"]) results in: [test,test1,test2] This shows the poor toString support for Arrays. We should just say Array for the title. 155469 1 41376 pfeldman 2009-10-18 07:54:00 -0700 Created attachment 41376 patch 155470 2 41377 pfeldman 2009-10-18 08:13:46 -0700 Created attachment 41377 same with "NodeList" as node list title. 155489 3 41377 timothy 2009-10-18 09:08:35 -0700 Comment on attachment 41377 same with "NodeList" as node list title. Yay. Tests! 155492 4 joepeck 2009-10-18 09:14:14 -0700 In context: > case "object" > case "node": > return type2; > case "array": > return type2; How about adding "array" to the fall-through cases above? 155493 5 timothy 2009-10-18 09:15:46 -0700 (In reply to comment #4) > In context: > > > case "object" > > case "node": > > return type2; > > case "array": > > return type2; > > How about adding "array" to the fall-through cases above? Good point, that would be better. 155529 6 pfeldman 2009-10-18 16:14:31 -0700 > How about adding "array" to the fall-through cases above? Done. 155530 7 pfeldman 2009-10-18 16:18:05 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/inspector/console-tests-expected.txt M LayoutTests/inspector/console-tests.html M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r49758 41376 2009-10-18 07:54:00 -0700 2009-10-18 08:13:46 -0700 patch array_title text/plain 2477 pfeldman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlLXRlc3RzLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlLXRlc3RzLWV4cGVjdGVkLnR4dApp bmRleCA5NDE0MWI1Li5jMzAwZWU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y29uc29sZS10ZXN0cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nv bnNvbGUtdGVzdHMtZXhwZWN0ZWQudHh0CkBAIC0xMyw2ICsxMyw3IEBAIENPTlNPTEUgTUVTU0FH RTogbGluZSAxNzogcmVwZWF0ZWQKIENPTlNPTEUgTUVTU0FHRTogbGluZSAxNzogcmVwZWF0ZWQK IENPTlNPTEUgTUVTU0FHRTogbGluZSAyMjogMQogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBb b2JqZWN0IEhUTUxEb2N1bWVudF0KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAyNDogdGVzdDEsdGVz dDIKIFRlc3RzIHRoYXQgY29uc29sZSBsb2dnaW5nIGR1bXBzIHByb3BlciBtZXNzYWdlcy4KIAog Y29uc29sZS10ZXN0cy5odG1sOjhsb2cgY29uc29sZS1tZXNzYWdlIGNvbnNvbGUtanMtc291cmNl IGNvbnNvbGUtbG9nLWxldmVsCkBAIC0zMCw0ICszMSw1IEBAIGNvbnNvbGUtdGVzdHMuaHRtbDoy MGdyb3VwIGNvbnNvbGUtbWVzc2FnZSBjb25zb2xlLWpzLXNvdXJjZSBjb25zb2xlLWxvZy1sZXZl bCBjCiBjb25zb2xlLW1lc3NhZ2UgY29uc29sZS1qcy1zb3VyY2UgY29uc29sZS1sb2ctbGV2ZWwK IGNvbnNvbGUtdGVzdHMuaHRtbDoyMjEgMiAzIGNvbnNvbGUtbWVzc2FnZSBjb25zb2xlLWpzLXNv dXJjZSBjb25zb2xlLWxvZy1sZXZlbAogY29uc29sZS10ZXN0cy5odG1sOjIzSFRNTERvY3VtZW50 IGNvbnNvbGUtbWVzc2FnZSBjb25zb2xlLWpzLXNvdXJjZSBjb25zb2xlLWxvZy1sZXZlbAorY29u c29sZS10ZXN0cy5odG1sOjI0QXJyYXkgY29uc29sZS1tZXNzYWdlIGNvbnNvbGUtanMtc291cmNl IGNvbnNvbGUtbG9nLWxldmVsCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9j b25zb2xlLXRlc3RzLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS10ZXN0cy5o dG1sCmluZGV4IGU5OWUwZTQuLmNiNzk0OTEgMTAwNzU1Ci0tLSBhL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9jb25zb2xlLXRlc3RzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNv bGUtdGVzdHMuaHRtbApAQCAtMjEsNiArMjEsNyBAQCBmdW5jdGlvbiBkb2l0KCkKICAgICBjb25z b2xlLmdyb3VwRW5kKCk7CiAgICAgY29uc29sZS5sb2coJzEnLCAnMicsICczJyk7CiAgICAgY29u c29sZS5kaXIoZG9jdW1lbnQpOworICAgIGNvbnNvbGUuZGlyKFsidGVzdDEiLCAidGVzdDIiXSk7 CiAKICAgICBmdW5jdGlvbiBjYWxsYmFjayhyZXN1bHQpCiAgICAgewpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZDViOTk1Li5kMzViYmQx IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDA5LTEwLTE4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFRpdGxlIG9mIGRpcihbInRlc3QiLCAidGVzdDIiXSkgc2hvdWxk IGJlIEFycmF5CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMwNDg2CisKKyAgICAgICAgVGVzdDogaW5zcGVjdG9yL2NvbnNvbGUtdGVzdHMuaHRtbAor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qczoKKwogMjAw OS0xMC0xNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9JbmplY3RlZFNjcmlwdC5qcwppbmRleCA1ZDNjMDQyLi41M2EwYTAxIDEwMDY0NAotLS0g YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCkBAIC0xMTQ0LDcgKzEx NDQsNyBAQCBPYmplY3QuZGVzY3JpYmUgPSBmdW5jdGlvbihvYmosIGFiYnJldmlhdGVkKQogICAg IGNhc2UgIm5vZGUiOgogICAgICAgICByZXR1cm4gdHlwZTI7CiAgICAgY2FzZSAiYXJyYXkiOgot ICAgICAgICByZXR1cm4gIlsiICsgb2JqLnRvU3RyaW5nKCkgKyAiXSI7CisgICAgICAgIHJldHVy biAiQXJyYXkiOwogICAgIGNhc2UgInN0cmluZyI6CiAgICAgICAgIGlmICghYWJicmV2aWF0ZWQp CiAgICAgICAgICAgICByZXR1cm4gb2JqOwo= 41377 2009-10-18 08:13:46 -0700 2009-10-18 09:08:35 -0700 same with "NodeList" as node list title. array_title text/plain 2642 pfeldman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlLXRlc3RzLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlLXRlc3RzLWV4cGVjdGVkLnR4dApp bmRleCA5NDE0MWI1Li44ZTk3MWIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y29uc29sZS10ZXN0cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nv bnNvbGUtdGVzdHMtZXhwZWN0ZWQudHh0CkBAIC0xMyw2ICsxMyw4IEBAIENPTlNPTEUgTUVTU0FH RTogbGluZSAxNzogcmVwZWF0ZWQKIENPTlNPTEUgTUVTU0FHRTogbGluZSAxNzogcmVwZWF0ZWQK IENPTlNPTEUgTUVTU0FHRTogbGluZSAyMjogMQogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBb b2JqZWN0IEhUTUxEb2N1bWVudF0KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAyNDogdGVzdDEsdGVz dDIKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAyNTogW29iamVjdCBOb2RlTGlzdF0KIFRlc3RzIHRo YXQgY29uc29sZSBsb2dnaW5nIGR1bXBzIHByb3BlciBtZXNzYWdlcy4KIAogY29uc29sZS10ZXN0 cy5odG1sOjhsb2cgY29uc29sZS1tZXNzYWdlIGNvbnNvbGUtanMtc291cmNlIGNvbnNvbGUtbG9n LWxldmVsCkBAIC0zMCw0ICszMiw2IEBAIGNvbnNvbGUtdGVzdHMuaHRtbDoyMGdyb3VwIGNvbnNv bGUtbWVzc2FnZSBjb25zb2xlLWpzLXNvdXJjZSBjb25zb2xlLWxvZy1sZXZlbCBjCiBjb25zb2xl LW1lc3NhZ2UgY29uc29sZS1qcy1zb3VyY2UgY29uc29sZS1sb2ctbGV2ZWwKIGNvbnNvbGUtdGVz dHMuaHRtbDoyMjEgMiAzIGNvbnNvbGUtbWVzc2FnZSBjb25zb2xlLWpzLXNvdXJjZSBjb25zb2xl LWxvZy1sZXZlbAogY29uc29sZS10ZXN0cy5odG1sOjIzSFRNTERvY3VtZW50IGNvbnNvbGUtbWVz c2FnZSBjb25zb2xlLWpzLXNvdXJjZSBjb25zb2xlLWxvZy1sZXZlbAorY29uc29sZS10ZXN0cy5o dG1sOjI0QXJyYXkgY29uc29sZS1tZXNzYWdlIGNvbnNvbGUtanMtc291cmNlIGNvbnNvbGUtbG9n LWxldmVsCitjb25zb2xlLXRlc3RzLmh0bWw6MjVOb2RlTGlzdCBjb25zb2xlLW1lc3NhZ2UgY29u c29sZS1qcy1zb3VyY2UgY29uc29sZS1sb2ctbGV2ZWwKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2NvbnNvbGUtdGVzdHMuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9j b25zb2xlLXRlc3RzLmh0bWwKaW5kZXggZTk5ZTBlNC4uMmE2M2QwYSAxMDA3NTUKLS0tIGEvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtdGVzdHMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvY29uc29sZS10ZXN0cy5odG1sCkBAIC0yMSw2ICsyMSw4IEBAIGZ1bmN0aW9uIGRv aXQoKQogICAgIGNvbnNvbGUuZ3JvdXBFbmQoKTsKICAgICBjb25zb2xlLmxvZygnMScsICcyJywg JzMnKTsKICAgICBjb25zb2xlLmRpcihkb2N1bWVudCk7CisgICAgY29uc29sZS5kaXIoWyJ0ZXN0 MSIsICJ0ZXN0MiJdKTsKKyAgICBjb25zb2xlLmRpcihkb2N1bWVudC5jaGlsZE5vZGVzKTsKIAog ICAgIGZ1bmN0aW9uIGNhbGxiYWNrKHJlc3VsdCkKICAgICB7CmRpZmYgLS1naXQgYS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGFkNWI5OTUuLmQzNWJiZDEgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMDktMTAtMTggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2ViIEluc3BlY3RvcjogVGl0bGUgb2YgZGlyKFsidGVzdCIsICJ0ZXN0MiJdKSBzaG91bGQgYmUg QXJyYXkKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzA0ODYKKworICAgICAgICBUZXN0OiBpbnNwZWN0b3IvY29uc29sZS10ZXN0cy5odG1sCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzOgorCiAyMDA5LTEw LTE3ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0luamVjdGVkU2NyaXB0LmpzCmluZGV4IDVkM2MwNDIuLjIwNzhhNmMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcworKysgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKQEAgLTExNDQsNyArMTE0NCw3 IEBAIE9iamVjdC5kZXNjcmliZSA9IGZ1bmN0aW9uKG9iaiwgYWJicmV2aWF0ZWQpCiAgICAgY2Fz ZSAibm9kZSI6CiAgICAgICAgIHJldHVybiB0eXBlMjsKICAgICBjYXNlICJhcnJheSI6Ci0gICAg ICAgIHJldHVybiAiWyIgKyBvYmoudG9TdHJpbmcoKSArICJdIjsKKyAgICAgICAgcmV0dXJuIHR5 cGUyOwogICAgIGNhc2UgInN0cmluZyI6CiAgICAgICAgIGlmICghYWJicmV2aWF0ZWQpCiAgICAg ICAgICAgICByZXR1cm4gb2JqOwo=