30477 2009-10-17 08:46:20 -0700 Web Inspector: Add more stop characters into console completions. 2009-10-19 15:01:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman timothy oldest_to_newest 155393 0 pfeldman 2009-10-17 08:46:20 -0700 Currently "dir(docu" does not trigger completion. I'd like to extend stop character set to " =:[({;,!+-*/&|^<>" 155394 1 41357 pfeldman 2009-10-17 08:53:48 -0700 Created attachment 41357 patch 155878 2 41357 eric 2009-10-19 13:51:04 -0700 Comment on attachment 41357 patch Can we test this? 155928 3 pfeldman 2009-10-19 15:01:12 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js Committed r49815 155929 4 pfeldman 2009-10-19 15:01:44 -0700 (In reply to comment #2) > (From update of attachment 41357 [details]) > Can we test this? Let me investigate this. 41357 2009-10-17 08:53:48 -0700 2009-10-19 13:59:51 -0700 patch completions text/plain 2712 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzA5ZjNhZS4uYWQ1Yjk5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0xNyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgbW9yZSBzdG9wIGNoYXJhY3Rl cnMgaW50byBjb25zb2xlIGNvbXBsZXRpb25zLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDQ3NworCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9Db25zb2xlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5w cm90b3R5cGUuY29tcGxldGlvbnMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZS5fcmVwb3J0Q29tcGxldGlvbnMpOgorCiAyMDA5LTEwLTE3ICBMYXN6bG8gR29t Ym9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCmluZGV4IDgwNjhhZDQu LmQ0Njc3ZjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xl Vmlldy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMK QEAgLTI3LDYgKzI3LDggQEAKICAqIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAorY29uc3QgRXhwcmVzc2lvblN0 b3BDaGFyYWN0ZXJzID0gIiA9OlsoezssISstKi8mfF48PiI7CisKIFdlYkluc3BlY3Rvci5Db25z b2xlVmlldyA9IGZ1bmN0aW9uKGRyYXdlcikKIHsKICAgICBXZWJJbnNwZWN0b3IuVmlldy5jYWxs KHRoaXMsIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlLXZpZXciKSk7CkBAIC00NCw3 ICs0Niw3IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlVmlldyA9IGZ1bmN0aW9uKGRyYXdlcikKIAog ICAgIHRoaXMucHJvbXB0RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xl LXByb21wdCIpOwogICAgIHRoaXMucHJvbXB0RWxlbWVudC5oYW5kbGVLZXlFdmVudCA9IHRoaXMu X3Byb21wdEtleURvd24uYmluZCh0aGlzKTsKLSAgICB0aGlzLnByb21wdCA9IG5ldyBXZWJJbnNw ZWN0b3IuVGV4dFByb21wdCh0aGlzLnByb21wdEVsZW1lbnQsIHRoaXMuY29tcGxldGlvbnMuYmlu ZCh0aGlzKSwgIiAuPTpbKHs7Iik7CisgICAgdGhpcy5wcm9tcHQgPSBuZXcgV2ViSW5zcGVjdG9y LlRleHRQcm9tcHQodGhpcy5wcm9tcHRFbGVtZW50LCB0aGlzLmNvbXBsZXRpb25zLmJpbmQodGhp cyksIEV4cHJlc3Npb25TdG9wQ2hhcmFjdGVycyArICIuIik7CiAKICAgICB0aGlzLnRvcEdyb3Vw ID0gbmV3IFdlYkluc3BlY3Rvci5Db25zb2xlR3JvdXAobnVsbCwgMCk7CiAgICAgdGhpcy5tZXNz YWdlc0VsZW1lbnQuaW5zZXJ0QmVmb3JlKHRoaXMudG9wR3JvdXAuZWxlbWVudCwgdGhpcy5wcm9t cHRFbGVtZW50KTsKQEAgLTI3NCw4ICsyNzYsNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcu cHJvdG90eXBlID0gewogICAgIGNvbXBsZXRpb25zOiBmdW5jdGlvbih3b3JkUmFuZ2UsIGJlc3RN YXRjaE9ubHksIGNvbXBsZXRpb25zUmVhZHlDYWxsYmFjaykKICAgICB7CiAgICAgICAgIC8vIFBh c3MgbGVzcyBzdG9wIGNoYXJhY3RlcnMgdG8gcmFuZ2VPZldvcmQgc28gdGhlIHJhbmdlIHdpbGwg YmUgYSBtb3JlIGNvbXBsZXRlIGV4cHJlc3Npb24uCi0gICAgICAgIGNvbnN0IGV4cHJlc3Npb25T dG9wQ2hhcmFjdGVycyA9ICIgPTp7OyI7Ci0gICAgICAgIHZhciBleHByZXNzaW9uUmFuZ2UgPSB3 b3JkUmFuZ2Uuc3RhcnRDb250YWluZXIucmFuZ2VPZldvcmQod29yZFJhbmdlLnN0YXJ0T2Zmc2V0 LCBleHByZXNzaW9uU3RvcENoYXJhY3RlcnMsIHRoaXMucHJvbXB0RWxlbWVudCwgImJhY2t3YXJk Iik7CisgICAgICAgIHZhciBleHByZXNzaW9uUmFuZ2UgPSB3b3JkUmFuZ2Uuc3RhcnRDb250YWlu ZXIucmFuZ2VPZldvcmQod29yZFJhbmdlLnN0YXJ0T2Zmc2V0LCBFeHByZXNzaW9uU3RvcENoYXJh Y3RlcnMsIHRoaXMucHJvbXB0RWxlbWVudCwgImJhY2t3YXJkIik7CiAgICAgICAgIHZhciBleHBy ZXNzaW9uU3RyaW5nID0gZXhwcmVzc2lvblJhbmdlLnRvU3RyaW5nKCk7CiAgICAgICAgIHZhciBs YXN0SW5kZXggPSBleHByZXNzaW9uU3RyaW5nLmxlbmd0aCAtIDE7CiAKQEAgLTMzMyw3ICszMzQs NyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICAgICAg aWYgKGJlc3RNYXRjaE9ubHkpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAg ICAgICAgc2V0VGltZW91dChjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2ssIDAsIHJlc3VsdHMpOwor ICAgICAgICBjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2socmVzdWx0cyk7CiAgICAgfSwKIAogICAg IF9jbGVhckJ1dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKCkK