30474 2009-10-16 20:50:34 -0700 Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp. 2009-10-18 23:43:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned aroben commit-queue darin eric sfalken oldest_to_newest 155353 0 skyul 2009-10-16 20:50:34 -0700 POSIX function such as stricmp and strnicmp are deprecated beginning in Visual C++ 2005. Use ISO C++ conformant _stricmp and _strnicmp instead in StringExtras.h. 155355 1 41350 skyul 2009-10-16 20:53:50 -0700 Created attachment 41350 Use ISO C++ conformant _stricmp and _strnicmp 155375 2 eric 2009-10-16 23:36:32 -0700 darin, arboen or sfalken are likely better reviewers for this than I. 155381 3 mrowe 2009-10-17 00:07:27 -0700 The bug title, ChangeLog, and Visual Studio warning are incredibly misleading. strnicmp is not part of POSIX and _strnicmp is certainly not part part of the ISO C++ standard. They’re both Microsoft extensions. The change itself is probably fine but IMO the ChangeLog should be corrected. 155383 4 skyul 2009-10-17 00:41:46 -0700 Change the title. 155384 5 41354 skyul 2009-10-17 00:43:37 -0700 Created attachment 41354 Update ChangeLog Update the ChangeLog because stricmp and strnicmp are not POSIX functions but Microsfot extensions. 155585 6 41354 commit-queue 2009-10-18 23:43:51 -0700 Comment on attachment 41354 Update ChangeLog Clearing flags on attachment: 41354 Committed r49765: <http://trac.webkit.org/changeset/49765> 155586 7 commit-queue 2009-10-18 23:43:55 -0700 All reviewed patches have been landed. Closing bug. 41350 2009-10-16 20:53:50 -0700 2009-10-17 00:43:37 -0700 Use ISO C++ conformant _stricmp and _strnicmp stricmp.patch text/plain 1326 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ5NzI5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMTYgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgSVNPIEMrKyBjb25mb3JtYW50IF9zdHJpY21wIGFu ZCBfc3RybmljbXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMwNDc0CisKKyAgICAgICAgUE9TSVggZnVuY3Rpb24gc3VjaCBhcyBzdHJpY21wIGFuZCBz dHJuaWNtcCBhcmUgZGVwcmVjYXRlZCBiZWdpbm5pbmcgaW4gVmlzdWFsCisgICAgICAgIEMrKyAy MDA1LiBVc2UgSVNPIEMrKyBjb25mb3JtYW50IF9zdHJpY21wIGFuZCBfc3RybmljbXAgaW5zdGVh ZCBpbgorICAgICAgICBTdHJpbmdFeHRyYXMuaC4KKworICAgICAgICAqIHd0Zi9TdHJpbmdFeHRy YXMuaDoKKyAgICAgICAgKHN0cm5jYXNlY21wKToKKyAgICAgICAgKHN0cmNhc2VjbXApOgorCiAy MDA5LTEwLTE2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvU3Ry aW5nRXh0cmFzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJh cy5oCShyZXZpc2lvbiA0OTcyNykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9TdHJpbmdFeHRyYXMu aAkod29ya2luZyBjb3B5KQpAQCAtNzUsMTIgKzc1LDEyIEBAIGlubGluZSBjaGFyKiBzdHJkdXAo Y29uc3QgY2hhciogc3RyU291cmMKIAogaW5saW5lIGludCBzdHJuY2FzZWNtcChjb25zdCBjaGFy KiBzMSwgY29uc3QgY2hhciogczIsIHNpemVfdCBsZW4pCiB7Ci0gICAgcmV0dXJuIHN0cm5pY21w KHMxLCBzMiwgbGVuKTsKKyAgICByZXR1cm4gX3N0cm5pY21wKHMxLCBzMiwgbGVuKTsKIH0KIAog aW5saW5lIGludCBzdHJjYXNlY21wKGNvbnN0IGNoYXIqIHMxLCBjb25zdCBjaGFyKiBzMikKIHsK LSAgICByZXR1cm4gc3RyaWNtcChzMSwgczIpOworICAgIHJldHVybiBfc3RyaWNtcChzMSwgczIp OwogfQogCiAjZW5kaWYK 41354 2009-10-17 00:43:37 -0700 2009-10-18 23:43:51 -0700 Update ChangeLog stricmp.patch text/plain 1300 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ5NzI5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMTYgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgX3N0cmljbXAgYW5kIF9zdHJuaWNtcCBpbnN0ZWFk IG9mIGRlcHJlY2F0ZWQgc3RyaWNtcCBhbmQgc3RybmljbXAuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDQ3NAorCisgICAgICAgIHN0cmljbXAgYW5k IHN0cm5pY21wIGFyZSBkZXByZWNhdGVkIGJlZ2lubmluZyBpbiBWaXN1YWwKKyAgICAgICAgQysr IDIwMDUuIFVzZSBfc3RyaWNtcCBhbmQgX3N0cm5pY21wIGluc3RlYWQgaW4gU3RyaW5nRXh0cmFz LmguCisKKyAgICAgICAgKiB3dGYvU3RyaW5nRXh0cmFzLmg6CisgICAgICAgIChzdHJuY2FzZWNt cCk6CisgICAgICAgIChzdHJjYXNlY21wKToKKwogMjAwOS0xMC0xNiAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdo LgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJhcy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEphdmFTY3JpcHRDb3JlL3d0Zi9TdHJpbmdFeHRyYXMuaAkocmV2aXNpb24gNDk3MjcpCisrKyBK YXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nRXh0cmFzLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1LDEy ICs3NSwxMiBAQCBpbmxpbmUgY2hhciogc3RyZHVwKGNvbnN0IGNoYXIqIHN0clNvdXJjCiAKIGlu bGluZSBpbnQgc3RybmNhc2VjbXAoY29uc3QgY2hhciogczEsIGNvbnN0IGNoYXIqIHMyLCBzaXpl X3QgbGVuKQogewotICAgIHJldHVybiBzdHJuaWNtcChzMSwgczIsIGxlbik7CisgICAgcmV0dXJu IF9zdHJuaWNtcChzMSwgczIsIGxlbik7CiB9CiAKIGlubGluZSBpbnQgc3RyY2FzZWNtcChjb25z dCBjaGFyKiBzMSwgY29uc3QgY2hhciogczIpCiB7Ci0gICAgcmV0dXJuIHN0cmljbXAoczEsIHMy KTsKKyAgICByZXR1cm4gX3N0cmljbXAoczEsIHMyKTsKIH0KIAogI2VuZGlmCg==