30473 2009-10-16 20:28:39 -0700 Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf. 2019-02-06 09:04:19 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 skyul skyul abarth aroben cdumez eric mrowe oldest_to_newest 155351 0 skyul 2009-10-16 20:28:39 -0700 vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of PLALTFORM(WIN_OS) guards. 155352 1 41349 skyul 2009-10-16 20:30:16 -0700 Created attachment 41349 Use COMPILER(MSVC) guards to avoid vasprintf 155376 2 eric 2009-10-16 23:37:32 -0700 So you're saying that vasprintf works fine in gcc (or any other compiler) on WIN_OS? 155382 3 skyul 2009-10-17 00:36:26 -0700 I use MSVC to build WebKit for BREW simulator and I undefined WTF_PLATFORM WIN_OS in Platform.h in favor of WTF_PLATFORM_BREW. vasprintf is not related to WIN_OS but to MSVC. vasprintf works fine in cygwin or mingw gcc anyway. 155874 4 eric 2009-10-19 13:46:04 -0700 I could have sworn bdash commented on this bug already, but I don't see it. 155875 5 41349 eric 2009-10-19 13:47:59 -0700 Comment on attachment 41349 Use COMPILER(MSVC) guards to avoid vasprintf + No new tests. (OOPS!) the OOPS will cause the commit to fail. The one in "reviewed by" is OK, because the commit-queue will substitute in the right thing. BUt the no new tests line should be replaced by something explaingin why this does not need testing or why testing is impossible. Something simple like: Build fix only, no tests possible. would be fine. cq- since the commit-queue can't handle this as-is. If you post a new patch w/o the second OOPS! that can be r+/cq+'d though. 156061 6 abarth 2009-10-19 21:39:36 -0700 Committed r49838: <http://trac.webkit.org/changeset/49838> 1503149 7 lforschler 2019-02-06 09:04:19 -0800 Mass moving XML DOM bugs to the "DOM" Component. 41349 2009-10-16 20:30:16 -0700 2009-10-19 13:47:58 -0700 Use COMPILER(MSVC) guards to avoid vasprintf vasprintf.patch text/plain 1391 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTcyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMTYgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDaGVjayBDT01QSUxFUihNU1ZDKSBpbnN0ZWFkIG9mIFBMQVRGT1JNKFdJTl9PUykgdG8gYXZv aWQgdGhlIHVzZSBvZiB2YXNwcmludGYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDQ3MworCisgICAgICAgIHZhc3ByaW50ZiBpcyBtaXNzaW5nIGlu IE1TVkMuIFVzZSBDT01QSUxFUihNU1ZDKSBndWFyZHMgaW5zdGVhZCBvZgorICAgICAgICBQTEFM VEZPUk0oV0lOX09TKSBndWFyZHMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisK KyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyTGlieG1sMi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpYTUxUb2tlbml6ZXI6OmVycm9yKToKKwogMjAwOS0xMC0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3Yu CkluZGV4OiBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXJMaWJ4bWwyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXJMaWJ4bWwyLmNwcAkocmV2aXNpb24gNDk3MjcpCisr KyBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXJMaWJ4bWwyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt ODg3LDcgKzg4Nyw3IEBAIHZvaWQgWE1MVG9rZW5pemVyOjplcnJvcihFcnJvclR5cGUgdHlwZSwK ICAgICBpZiAobV9wYXJzZXJTdG9wcGVkKQogICAgICAgICByZXR1cm47CiAKLSNpZiBQTEFURk9S TShXSU5fT1MpCisjaWYgQ09NUElMRVIoTVNWQykKICAgICBjaGFyIG1bMTAyNF07CiAgICAgdnNu cHJpbnRmKG0sIHNpemVvZihtKSAtIDEsIG1lc3NhZ2UsIGFyZ3MpOwogI2Vsc2UKQEAgLTkwMSw3 ICs5MDEsNyBAQCB2b2lkIFhNTFRva2VuaXplcjo6ZXJyb3IoRXJyb3JUeXBlIHR5cGUsCiAgICAg ZWxzZQogICAgICAgICBoYW5kbGVFcnJvcih0eXBlLCBtLCBsaW5lTnVtYmVyKCksIGNvbHVtbk51 bWJlcigpKTsKIAotI2lmICFQTEFURk9STShXSU5fT1MpCisjaWYgIUNPTVBJTEVSKE1TVkMpCiAg ICAgZnJlZShtKTsKICNlbmRpZgogfQo=