30472 2009-10-16 20:13:28 -0700 EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards 2009-10-17 08:54:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned commit-queue dbates eric oliver oldest_to_newest 155347 0 skyul 2009-10-16 20:13:28 -0700 There are ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged in EventHandler.h, but missing in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT is not enabled. 155348 1 41346 skyul 2009-10-16 20:17:29 -0700 Created attachment 41346 ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged 155373 2 41346 eric 2009-10-16 23:34:48 -0700 Comment on attachment 41346 ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged Makes no sense that that is marked "inline". But this looks OK. The latter #endif really should have a comment explaingin which #if its ending. 155374 3 eric 2009-10-16 23:35:39 -0700 CCing drag and drop folks so they see this go by. 155395 4 41346 commit-queue 2009-10-17 08:54:32 -0700 Comment on attachment 41346 ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged Clearing flags on attachment: 41346 Committed r49742: <http://trac.webkit.org/changeset/49742> 155396 5 commit-queue 2009-10-17 08:54:41 -0700 All reviewed patches have been landed. Closing bug. 41346 2009-10-16 20:17:29 -0700 2009-10-17 08:54:32 -0700 ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged guards.patch text/plain 1175 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTcyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMTYgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBFdmVudEhhbmRsZXI6OmV2ZW50TG9vcEhhbmRsZU1vdXNlRHJhZ2dlZCBuZWVkcyBFTkFCTEUo RFJBR19TVVBQT1JUKSBndWFyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMwNDcyCisKKyAgICAgICAgUHV0IEVOQUJMRShEUkFHX1NVUFBPUlQpIGd1 YXJkcyBhcm91bmQgRXZlbnRIYW5kbGVyOjpldmVudExvb3BIYW5kbGVNb3VzZURyYWdnZWQKKyAg ICAgICAgaW4gRXZlbnRIYW5kbGVyLmNwcC4gTVNWQyBmYWlscyB0byBjb21waWxlIHdoZW4gRFJB R19TVVBQT1JUIG5vdCBlbmFibGVkLgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3Bw OgorCiAyMDA5LTEwLTE2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IFdlYkNvcmUvcGFnZS9F dmVudEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwCShyZXZpc2lvbiA0OTcyNSkKKysrIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjcsMTAgKzEyNywxMiBAQCBpbmxpbmUgYm9vbCBFdmVudEhhbmRs ZXI6OmV2ZW50TG9vcEhhbmRsCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCisjaWYgRU5BQkxFKERS QUdfU1VQUE9SVCkKIGlubGluZSBib29sIEV2ZW50SGFuZGxlcjo6ZXZlbnRMb29wSGFuZGxlTW91 c2VEcmFnZ2VkKGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmKQogewogICAgIHJl dHVybiBmYWxzZTsKIH0KKyNlbmRpZgogCiAjZW5kaWYKIAo=