30465 2009-10-16 15:10:44 -0700 [Qt] QGLauncher leaks WebPage object 2009-10-16 20:56:42 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 tonikitoo tonikitoo kenneth oldest_to_newest 155275 0 tonikitoo 2009-10-16 15:10:44 -0700 object is created and never deleted. m_item->setPage(new WebPage()); 155276 1 41334 tonikitoo 2009-10-16 15:14:38 -0700 Created attachment 41334 (committed in r49730) patch 0.1 - make it not leak 155278 2 kenneth 2009-10-16 15:16:48 -0700 Yes, when a page is created by the app, the app has the ownership and should destroy it. so LGTM, though I do not like the (m_page = new WebPage) part very much, but that is just a nit. 155332 3 41334 hausmann 2009-10-16 18:13:23 -0700 Comment on attachment 41334 (committed in r49730) patch 0.1 - make it not leak You could also make it a child of the mainwindow or the view, to get Qt automatically delete it. But this is okay, too :-) 155358 4 tonikitoo 2009-10-16 20:55:57 -0700 r49730 155359 5 41334 tonikitoo 2009-10-16 20:56:42 -0700 Comment on attachment 41334 (committed in r49730) patch 0.1 - make it not leak thx simon and kenneth 41334 2009-10-16 15:14:38 -0700 2009-10-16 20:56:42 -0700 (committed in r49730) patch 0.1 - make it not leak 0002--Qt-QGLauncher-leaks-WebPage-object.patch text/plain 2341 tonikitoo RnJvbSA1NmI1NTdhMTNiZDE4ODY1YmVhODIxNDYyMWQ0YTE5ZjFkYmQ3Y2ZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogRnJpLCAxNiBPY3QgMjAwOSAxODoxMzozNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gUUdMYXVuY2hlciBsZWFrcyBXZWJQYWdlIG9iamVjdAogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMwNDY1CgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDx0b25pa2l0 b29Ad2Via2l0Lm9yZz4gb24gMjAwOS0xMC0xNgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K Ck1ha2UgJ1NoYXJlZFNjZW5lJyB0byBvd24gJ1dlYlBhZ2UnIHJlZmVyZW5jZSBhbmQgZGVsZXRl IGl0IGF0IGl0cyBkZXN0cnVjdG9yLgoKKiBBcGkvcXdlYnBhZ2UuY3BwOgooUVdlYlBhZ2U6OnZp ZXcpOgoqIEFwaS9xd2VicGFnZV9wLmg6CiogUUdWTGF1bmNoZXIvbWFpbi5jcHA6CihTaGFyZWRT Y2VuZTo6U2hhcmVkU2NlbmUpOgooU2hhcmVkU2NlbmU6On5TaGFyZWRTY2VuZSk6Ci0tLQogV2Vi S2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBXZWJL aXQvcXQvUUdWTGF1bmNoZXIvbWFpbi5jcHAgfCAgICA1ICsrKy0tCiAyIGZpbGVzIGNoYW5nZWQs IDE5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggNjliNmYzOC4uYmRiZjExYiAx MDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9n CkBAIC0yLDYgKzIsMjIgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K IAorICAgICAgICBbUXRdIFFHTGF1bmNoZXIgbGVha3MgV2ViUGFnZSBvYmplY3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNDY1CisKKyAgICAgICAg TWFrZSAnU2hhcmVkU2NlbmUnIHRvIG93biAnV2ViUGFnZScgcmVmZXJlbmNlIGFuZCBkZWxldGUg aXQgYXQgaXRzIGRlc3RydWN0b3IuCisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAg ICAgICAoUVdlYlBhZ2U6OnZpZXcpOgorICAgICAgICAqIEFwaS9xd2VicGFnZV9wLmg6CisgICAg ICAgICogUUdWTGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChTaGFyZWRTY2VuZTo6U2hhcmVk U2NlbmUpOgorICAgICAgICAoU2hhcmVkU2NlbmU6On5TaGFyZWRTY2VuZSk6CisKKzIwMDktMTAt MTYgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBbUXRdICJkYW5nbGluZyIgcG9pbnRl ciB0byBxd2VicGFnZSdzIHZpZXcgb2JqZWN0IGNhbiBsZWFkcyBRR0xhdW5jaGVyIHRvIGNyYXNo CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDQ1OQog CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvUUdWTGF1bmNoZXIvbWFpbi5jcHAgYi9XZWJLaXQvcXQv UUdWTGF1bmNoZXIvbWFpbi5jcHAKaW5kZXggZDc1ZWE3NS4uNTgwMGI3OCAxMDA2NDQKLS0tIGEv V2ViS2l0L3F0L1FHVkxhdW5jaGVyL21haW4uY3BwCisrKyBiL1dlYktpdC9xdC9RR1ZMYXVuY2hl ci9tYWluLmNwcApAQCAtMTI1LDkgKzEyNSw4IEBAIHB1YmxpYzoKICAgICBTaGFyZWRTY2VuZSgp CiAgICAgewogICAgICAgICBtX3NjZW5lID0gbmV3IFFHcmFwaGljc1NjZW5lOwotCiAgICAgICAg IG1faXRlbSA9IG5ldyBRR3JhcGhpY3NXZWJWaWV3OwotICAgICAgICBtX2l0ZW0tPnNldFBhZ2Uo bmV3IFdlYlBhZ2UoKSk7CisgICAgICAgIG1faXRlbS0+c2V0UGFnZSgobV9wYWdlID0gbmV3IFdl YlBhZ2UpKTsKIAogICAgICAgICBtX3NjZW5lLT5hZGRJdGVtKG1faXRlbSk7CiAgICAgICAgIG1f c2NlbmUtPnNldEFjdGl2ZVdpbmRvdyhtX2l0ZW0pOwpAQCAtMTM3LDYgKzEzNiw3IEBAIHB1Ymxp YzoKICAgICB7CiAgICAgICAgIGRlbGV0ZSBtX2l0ZW07CiAgICAgICAgIGRlbGV0ZSBtX3NjZW5l OworICAgICAgICBkZWxldGUgbV9wYWdlOwogICAgIH0KIAogICAgIFFHcmFwaGljc1NjZW5lKiBz Y2VuZSgpIGNvbnN0IHsgcmV0dXJuIG1fc2NlbmU7IH0KQEAgLTE0NSw2ICsxNDUsNyBAQCBwdWJs aWM6CiBwcml2YXRlOgogICAgIFFHcmFwaGljc1NjZW5lKiBtX3NjZW5lOwogICAgIFFHcmFwaGlj c1dlYlZpZXcqIG1faXRlbTsKKyAgICBXZWJQYWdlKiBtX3BhZ2U7CiB9OwogCiAKLS0gCjEuNi4w LjQKCg==