30461 2009-10-16 14:35:04 -0700 [chromium] Video controls not zoomed / transformed correctly 2009-10-17 08:45:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 hclam webkit-unassigned commit-queue dglazkov eric.carlson eric oldest_to_newest 155250 0 hclam 2009-10-16 14:35:04 -0700 The following two layout tests are failing in Chromium: LayoutTests/media/video-controls-zoomed.html LayoutTests/media/video-controls-transformed.html They are failing because the images for play / pause / mute / slider thumb are not scaled correctly. 155340 1 41345 hclam 2009-10-16 18:48:45 -0700 Created attachment 41345 Patch This patch will scale the images correctly. 155371 2 eric 2009-10-16 23:32:45 -0700 CCing mr. media. 155372 3 41345 eric 2009-10-16 23:33:04 -0700 Comment on attachment 41345 Patch Looks sane to me. 155391 4 41345 commit-queue 2009-10-17 08:45:41 -0700 Comment on attachment 41345 Patch Clearing flags on attachment: 41345 Committed r49740: <http://trac.webkit.org/changeset/49740> 155392 5 commit-queue 2009-10-17 08:45:46 -0700 All reviewed patches have been landed. Closing bug. 41345 2009-10-16 18:48:45 -0700 2009-10-17 08:45:41 -0700 Patch webkit-controls-rendering.patch text/plain 2516 hclam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTFjMzNhYi4uMTg5YWViYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMC0xNiAgQWxwaGEgTGFtICA8 aGNsYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtjaHJvbWl1bV0gVmlkZW8gY29udHJvbHMgbm90IHpvb21lZCAvIHRyYW5z Zm9ybWVkIGNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzA0NjEKKworICAgICAgICBEcmF3IHRoZSBpbWFnZXMgaW4gdGhlIGNvbnRyb2xz IHNjYWxlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFdpdGggdGhpcyBjaGFuZ2UgQ2hyb21p dW0gd2lsbCBwYXNzIHRoZSBmb2xsb3dpbmcgdGVzdHM6CisgICAgICAgIExheW91dFRlc3RzL21l ZGlhL3ZpZGVvLWNvbnRyb2xzLXpvb21lZC5odG1sCisgICAgICAgIExheW91dFRlc3RzL21lZGlh L3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFpbnRN ZWRpYUJ1dHRvbik6CisgICAgICAgIFBhc3MgYWxvbmcgdGhlIHRhcmdldCByZWN0IGRpcmVjdGx5 LgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTWVkaWFDb250cm9sc0Nocm9taXVtOjphZGp1c3RN ZWRpYVNsaWRlclRodW1iU2l6ZSk6CisgICAgICAgIEFkanVzdCB0aGUgdGh1bWIgc2xpZGUgYXBw bGllZCB3aXRoIHRoZSBzY2FsZSBmYWN0b3IuCisKIDIwMDktMTAtMTIgIERpbWl0cmkgR2xhemtv diAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBObyByZXZpZXcsIHJvbGxpbmcg b3V0IHI0OTQyOSwgYmVjYXVzZSBpdCBicm9rZSBsYXlvdXQgdGVzdHMuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwIGIvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFDb250cm9sc0Nocm9taXVtLmNwcAppbmRleCBiYmEyZmEy Li41NTI4NzM1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRy b2xzQ2hyb21pdW0uY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJv bHNDaHJvbWl1bS5jcHAKQEAgLTU2LDEyICs1Niw4IEBAIHN0YXRpYyBJbWFnZSogcGxhdGZvcm1S ZXNvdXJjZShjb25zdCBjaGFyKiBuYW1lKQogCiBzdGF0aWMgYm9vbCBwYWludE1lZGlhQnV0dG9u KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCwgSW1hZ2UqIGlt YWdlKQogewotICAgIC8vIENyZWF0ZSBhIGRlc3RpbmF0aW9uIHJlY3RhbmdsZSBmb3IgdGhlIGlt YWdlIHRoYXQgaXMgY2VudGVyZWQgaW4gdGhlIGRyYXdpbmcgcmVjdGFuZ2xlLCByb3VuZGVkIGxl ZnQsIGFuZCBkb3duLgogICAgIEludFJlY3QgaW1hZ2VSZWN0ID0gaW1hZ2UtPnJlY3QoKTsKLSAg ICBpbWFnZVJlY3Quc2V0WShyZWN0LnkoKSArIChyZWN0LmhlaWdodCgpIC0gaW1hZ2UtPmhlaWdo dCgpICsgMSkgLyAyKTsKLSAgICBpbWFnZVJlY3Quc2V0WChyZWN0LngoKSArIChyZWN0LndpZHRo KCkgLSBpbWFnZS0+d2lkdGgoKSArIDEpIC8gMik7Ci0KLSAgICBjb250ZXh0LT5kcmF3SW1hZ2Uo aW1hZ2UsIGltYWdlUmVjdCk7CisgICAgY29udGV4dC0+ZHJhd0ltYWdlKGltYWdlLCByZWN0KTsK ICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtMjc4LDkgKzI3NCwxMCBAQCB2b2lkIFJlbmRlck1l ZGlhQ29udHJvbHNDaHJvbWl1bTo6YWRqdXN0TWVkaWFTbGlkZXJUaHVtYlNpemUoUmVuZGVyT2Jq ZWN0KiBvYmplYwogICAgIGVsc2UgaWYgKG9iamVjdC0+c3R5bGUoKS0+YXBwZWFyYW5jZSgpID09 IE1lZGlhVm9sdW1lU2xpZGVyVGh1bWJQYXJ0KQogICAgICAgICB0aHVtYkltYWdlID0gbWVkaWFW b2x1bWVTbGlkZXJUaHVtYjsKIAorICAgIGZsb2F0IHpvb21MZXZlbCA9IG9iamVjdC0+c3R5bGUo KS0+ZWZmZWN0aXZlWm9vbSgpOwogICAgIGlmICh0aHVtYkltYWdlKSB7Ci0gICAgICAgIG9iamVj dC0+c3R5bGUoKS0+c2V0V2lkdGgoTGVuZ3RoKHRodW1iSW1hZ2UtPndpZHRoKCksIEZpeGVkKSk7 Ci0gICAgICAgIG9iamVjdC0+c3R5bGUoKS0+c2V0SGVpZ2h0KExlbmd0aCh0aHVtYkltYWdlLT5o ZWlnaHQoKSwgRml4ZWQpKTsKKyAgICAgICAgb2JqZWN0LT5zdHlsZSgpLT5zZXRXaWR0aChMZW5n dGgoc3RhdGljX2Nhc3Q8aW50Pih0aHVtYkltYWdlLT53aWR0aCgpICogem9vbUxldmVsKSwgRml4 ZWQpKTsKKyAgICAgICAgb2JqZWN0LT5zdHlsZSgpLT5zZXRIZWlnaHQoTGVuZ3RoKHN0YXRpY19j YXN0PGludD4odGh1bWJJbWFnZS0+aGVpZ2h0KCkgKiB6b29tTGV2ZWwpLCBGaXhlZCkpOwogICAg IH0KIH0KIAo=