<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>30440</bug_id>
          
          <creation_ts>2009-10-16 09:04:31 -0700</creation_ts>
          <short_desc>[GTK] Fails new test fast/js/navigator-language.html</short_desc>
          <delta_ts>2009-10-29 12:11:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gustavo Noronha (kov)">gustavo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>cshu</cc>
    
    <cc>eric</cc>
    
    <cc>evan</cc>
    
    <cc>jmalonzo</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>155098</commentid>
    <comment_count>0</comment_count>
      <attachid>41288</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-16 09:04:31 -0700</bug_when>
    <thetext>Created attachment 41288
reimplementation of defaultLanguage

This test is failing because GTK+/Pango don&apos;t support changing locale after the first gtk_init() call, thus our defaultLanguage() implementation always returns whatever you had when you first started. I am not really sure about the patch. WebKit&apos;s notion of locale will diverge from GTK+&apos;s in case the application changes setlocale(). If the application doing that expects WebKit to behave like GTK+ (ignore setlocale changes), this may be bad. The other way of making this test pass is to run an instance of DRT for it exclusively, which sounds like complex and FAIL to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155101</commentid>
    <comment_count>1</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2009-10-16 09:12:20 -0700</bug_when>
    <thetext>This bug relates to bug 30439. Please check if we should set 30439 as a duplicate if necessary. Btw, I thought GTK will pass the current navigator-language test if running in English environment as it only checks language code not country code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155229</commentid>
    <comment_count>2</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-16 14:17:20 -0700</bug_when>
    <thetext>*** Bug 30439 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155230</commentid>
    <comment_count>3</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-16 14:21:13 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; This bug relates to bug 30439. Please check if we should set 30439 as a
&gt; duplicate if necessary. Btw, I thought GTK will pass the current
&gt; navigator-language test if running in English environment as it only checks
&gt; language code not country code.

Yeah, I market that one as duplicate, thanks! Yeah, the problem is that DRT runs under C locale, and GTK+ doesn&apos;t want to notice the fact that the locale changed. I&apos;m starting to think this patch I posted is indeed a good idea, since it should fix the problem you described in the other bug.

Let me quote the important part here:

Open a GTK-based browser and load page:
http://testsuite.nokia-boston.com/content/esmp_nonESMP/navigatorObject/language1.asp
actual result: language translation shows &quot;en&quot;
expected result: language translation should show &quot;en-US&quot; or &quot;en-us&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155234</commentid>
    <comment_count>4</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2009-10-16 14:25:32 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #1)
&gt; &gt; This bug relates to bug 30439. Please check if we should set 30439 as a
&gt; &gt; duplicate if necessary. Btw, I thought GTK will pass the current
&gt; &gt; navigator-language test if running in English environment as it only checks
&gt; &gt; language code not country code.
&gt; 
&gt; Yeah, I market that one as duplicate, thanks! Yeah, the problem is that DRT
&gt; runs under C locale, and GTK+ doesn&apos;t want to notice the fact that the locale
&gt; changed. I&apos;m starting to think this patch I posted is indeed a good idea, since
&gt; it should fix the problem you described in the other bug.
&gt; 
&gt; Let me quote the important part here:
&gt; 
&gt; Open a GTK-based browser and load page:
&gt; http://testsuite.nokia-boston.com/content/esmp_nonESMP/navigatorObject/language1.asp
&gt; actual result: language translation shows &quot;en&quot;
&gt; expected result: language translation should show &quot;en-US&quot; or &quot;en-us&quot;

Is it ok I attach the patch that will update the test case to this bug? Is it possible we commit the patch but keeps this bug open until your patches are done?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155271</commentid>
    <comment_count>5</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-16 15:06:10 -0700</bug_when>
    <thetext>Also, it looks like these tests are failing when this test is run (if I skip it, the failures go away):

+fast/workers/worker-context-multi-port.html
+fast/workers/worker-multi-port.html
+fast/xmlhttprequest/xmlhttprequest-invalid-values.html
+fast/xpath/attr-namespace.html
+fast/xpath/detached-subtree-invalidate-iterator.html
+fast/xpath/py-dom-xpath/nodetests.html
+http/tests/misc/canvas-pattern-from-incremental-image.html
+http/tests/security/canvas-remote-read-remote-image.html
+http/tests/security/postMessage/invalid-origin-throws-exception.html
+http/tests/security/postMessage/target-origin.html
+http/tests/workers/shared-worker-redirect.html
+http/tests/workers/worker-redirect.html
+http/tests/xmlhttprequest/inject-header.html
+fast/forms/textarea-setvalue-submit.html

I don&apos;t know why, yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155272</commentid>
    <comment_count>6</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-16 15:06:38 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Is it ok I attach the patch that will update the test case to this bug? Is it
&gt; possible we commit the patch but keeps this bug open until your patches are
&gt; done?

Sure, go ahead!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155337</commentid>
    <comment_count>7</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2009-10-16 18:20:12 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Also, it looks like these tests are failing when this test is run (if I skip
&gt; it, the failures go away):
&gt; 
&gt; +fast/workers/worker-context-multi-port.html
&gt; +fast/workers/worker-multi-port.html
&gt; +fast/xmlhttprequest/xmlhttprequest-invalid-values.html
&gt; +fast/xpath/attr-namespace.html
&gt; +fast/xpath/detached-subtree-invalidate-iterator.html
&gt; +fast/xpath/py-dom-xpath/nodetests.html
&gt; +http/tests/misc/canvas-pattern-from-incremental-image.html
&gt; +http/tests/security/canvas-remote-read-remote-image.html
&gt; +http/tests/security/postMessage/invalid-origin-throws-exception.html
&gt; +http/tests/security/postMessage/target-origin.html
&gt; +http/tests/workers/shared-worker-redirect.html
&gt; +http/tests/workers/worker-redirect.html
&gt; +http/tests/xmlhttprequest/inject-header.html
&gt; +fast/forms/textarea-setvalue-submit.html
&gt; 
&gt; I don&apos;t know why, yet.

Only thing I can think of is the Locale setting affects the following tests but it was supposed be reset... What will happen if you run them individually? And on what platform did you run? GTK? I ran a couple of above individually on qt-linux too and they all failed. I haven&apos;t tried if I reverted my change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155435</commentid>
    <comment_count>8</comment_count>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2009-10-17 19:18:20 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; 
&gt; Let me quote the important part here:
&gt; 
&gt; Open a GTK-based browser and load page:
&gt; http://testsuite.nokia-boston.com/content/esmp_nonESMP/navigatorObject/language1.asp
&gt; actual result: language translation shows &quot;en&quot;
&gt; expected result: language translation should show &quot;en-US&quot; or &quot;en-us&quot;

When I try to go to the site above, I get the expected &quot;en-us&quot; (LANG=en_US.UTF-8). When I switch it to LANG=pl_PL.UTF-8, I get &quot;pl-pl&quot;, which is expected. 

(In reply to comment #0)
&gt; Created an attachment (id=41288) [details]
&gt; reimplementation of defaultLanguage
&gt; 
&gt; This test is failing because GTK+/Pango don&apos;t support changing locale after the
&gt; first gtk_init() call, thus our defaultLanguage() implementation always returns
&gt; whatever you had when you first started. I am not really sure about the patch.

I think the test case needs to be expanded to include multiple calls to setPOSIXLocale (which calls setlocale()) to be sure that defaultLanguage() is doing the right thing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155673</commentid>
    <comment_count>9</comment_count>
      <attachid>41415</attachid>
    <who name="Chang Shu">cshu</who>
    <bug_when>2009-10-19 06:41:42 -0700</bug_when>
    <thetext>Created attachment 41415
update test case to check against &quot;en-us&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155676</commentid>
    <comment_count>10</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2009-10-19 06:56:24 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; When I try to go to the site above, I get the expected &quot;en-us&quot;
&gt; (LANG=en_US.UTF-8). When I switch it to LANG=pl_PL.UTF-8, I get &quot;pl-pl&quot;, which
&gt; is expected. 
&gt; 

Good that it worked as expected. Maybe the browser or the version I was running was out of date. Running WebKitTools/Scripts/run-webkit-tests could still cause trouble to GTK as the script does not pass LC_* or LANG envs to DumpRenderTree and GTK may set to default &quot;C&quot; and as you guys said, it cannot be updated later.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155893</commentid>
    <comment_count>11</comment_count>
      <attachid>41415</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-19 14:16:47 -0700</bug_when>
    <thetext>Comment on attachment 41415
update test case to check against &quot;en-us&quot;

I am confused by there being two unrelated patches on this bug.

This line is confusing:
 11 Language tags should follow the specification below:

What you&apos;re quoting is a piece of a spec, so you either need to provide a link to the original spec, or at least some description of where you got that snippet.  In this case it&apos;s from the RFC I mentioned.

Otherwise looks fine.  Won&apos;t this cause failures on qt or gtk?  OK to land w/ modifications.  If you need the commit-queue to land this, please post a new bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155894</commentid>
    <comment_count>12</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-19 14:17:17 -0700</bug_when>
    <thetext>By &quot;new bug&quot; I meant &quot;new patch&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155909</commentid>
    <comment_count>13</comment_count>
    <who name="Chang Shu">cshu</who>
    <bug_when>2009-10-19 14:32:35 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 41415 [details])
&gt; I am confused by there being two unrelated patches on this bug.
&gt; 
&gt; This line is confusing:
&gt;  11 Language tags should follow the specification below:
&gt; 
&gt; What you&apos;re quoting is a piece of a spec, so you either need to provide a link
&gt; to the original spec, or at least some description of where you got that
&gt; snippet.  In this case it&apos;s from the RFC I mentioned.

I will load a new patch with link to RFC.
&gt; 
&gt; Otherwise looks fine.  Won&apos;t this cause failures on qt or gtk?  OK to land w/
&gt; modifications.  If you need the commit-queue to land this, please post a new
&gt; bug.

Qt should work as it returns &quot;en-US&quot; and then converted to &quot;en-us&quot; in the test case. GTK fails even before this change because of other issues and Gustavo&apos;s patch should fix this, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155921</commentid>
    <comment_count>14</comment_count>
      <attachid>41455</attachid>
    <who name="Chang Shu">cshu</who>
    <bug_when>2009-10-19 14:46:24 -0700</bug_when>
    <thetext>Created attachment 41455
update description</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155955</commentid>
    <comment_count>15</comment_count>
      <attachid>41455</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-19 15:23:56 -0700</bug_when>
    <thetext>Comment on attachment 41455
update description

LGTM.  I&apos;m assuming you want this cq+ as well since you&apos;re not a committer yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155963</commentid>
    <comment_count>16</comment_count>
      <attachid>41455</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-19 15:36:39 -0700</bug_when>
    <thetext>Comment on attachment 41455
update description

Clearing flags on attachment: 41455

Committed r49818: &lt;http://trac.webkit.org/changeset/49818&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>155964</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-19 15:36:43 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156441</commentid>
    <comment_count>18</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-21 02:33:21 -0700</bug_when>
    <thetext>There&apos;s still my patch, so reopenning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>156442</commentid>
    <comment_count>19</comment_count>
      <attachid>41415</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-21 02:34:04 -0700</bug_when>
    <thetext>Comment on attachment 41415
update test case to check against &quot;en-us&quot;

Clearing review flag from committed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158129</commentid>
    <comment_count>20</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-27 02:49:03 -0700</bug_when>
    <thetext>Tiger is failing this test too:
http://build.webkit.org/results/Tiger%20Intel%20Release/r50133%20(5583)/results.html
I&apos;ll file a separate bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158553</commentid>
    <comment_count>21</comment_count>
      <attachid>42026</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-28 07:14:43 -0700</bug_when>
    <thetext>Created attachment 42026
reimplementation of defaultLanguage</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158563</commentid>
    <comment_count>22</comment_count>
      <attachid>42026</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-10-28 08:17:19 -0700</bug_when>
    <thetext>Comment on attachment 42026
reimplementation of defaultLanguage

Looks good to me. r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158564</commentid>
    <comment_count>23</comment_count>
      <attachid>42026</attachid>
    <who name="Evan Martin">evan</who>
    <bug_when>2009-10-28 08:20:04 -0700</bug_when>
    <thetext>Comment on attachment 42026
reimplementation of defaultLanguage

&gt; +    if (!localeDefault)
&gt; +        return String(&quot;c&quot;);
&gt; +
&gt; +    GOwnPtr&lt;gchar&gt; normalizedDefault(g_ascii_strdown(localeDefault, -1));
&gt; +    char* ptr = strchr(normalizedDefault.get(), &apos;_&apos;);
&gt; +
&gt; +    if(ptr)
&gt; +        *ptr = &apos;-&apos;;

The spacing after &quot;if&quot; here doesn&apos;t match the spacing after the one above.

&gt; +
&gt; +    ptr = strchr(normalizedDefault.get(), &apos;.&apos;);
&gt; +
&gt; +    if(ptr)
&gt; +        *ptr = &apos;\0&apos;;

This one too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158754</commentid>
    <comment_count>24</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-28 15:44:26 -0700</bug_when>
    <thetext>Landed as r50244.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>158870</commentid>
    <comment_count>25</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-10-29 05:45:48 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; (From update of attachment 42026 [details])
&gt; &gt; +    if (!localeDefault)
&gt; &gt; +        return String(&quot;c&quot;);
&gt; &gt; +
&gt; &gt; +    GOwnPtr&lt;gchar&gt; normalizedDefault(g_ascii_strdown(localeDefault, -1));
&gt; &gt; +    char* ptr = strchr(normalizedDefault.get(), &apos;_&apos;);
&gt; &gt; +
&gt; &gt; +    if(ptr)
&gt; &gt; +        *ptr = &apos;-&apos;;
&gt; 
&gt; The spacing after &quot;if&quot; here doesn&apos;t match the spacing after the one above.
&gt; 
&gt; &gt; +
&gt; &gt; +    ptr = strchr(normalizedDefault.get(), &apos;.&apos;);
&gt; &gt; +
&gt; &gt; +    if(ptr)
&gt; &gt; +        *ptr = &apos;\0&apos;;
&gt; 
&gt; This one too.

Sorry, had not seen your comments! I&apos;ll make a new commit fixing these.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>159007</commentid>
    <comment_count>26</comment_count>
      <attachid>41288</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-10-29 12:11:56 -0700</bug_when>
    <thetext>Comment on attachment 41288
reimplementation of defaultLanguage

Clearing r? on this patch since the bug is closed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>41288</attachid>
            <date>2009-10-16 09:04:31 -0700</date>
            <delta_ts>2009-10-29 12:11:56 -0700</delta_ts>
            <desc>reimplementation of defaultLanguage</desc>
            <filename>0001-Reimplement-defaultLanguage-to-account-for-locale-ch.patch</filename>
            <type>text/plain</type>
            <size>2538</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">RnJvbSA3NWFmNmUxZGExNTY5ZjA0OTI2NTNiYjIyNzg2NDEzNmZkZDlkMjcyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o
YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMTYgT2N0IDIwMDkgMTM6MDE6MzAgLTAzMDAK
U3ViamVjdDogW1BBVENIXSBSZWltcGxlbWVudCBkZWZhdWx0TGFuZ3VhZ2UgdG8gYWNjb3VudCBm
b3IgbG9jYWxlIGNoYW5nZXMKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg
IHwgICAxNSArKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0xhbmd1YWdlLmNw
cCB8ICAgMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQogMiBmaWxlcyBjaGFu
Z2VkLCA0OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv
cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjJiN2I1MC4uYzg2NTdkZiAx
MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxOCBAQAorMjAwOS0xMC0xNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2
by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwg
KE9PUFMhKQorCisgICAgICAgIEltcGxlbWVudCBhIGNhY2hpbmcgaGFzaCB0YWJsZSB0byBjb252
ZXJ0IHZhbHVlcyByZXR1cm5lZCBieQorICAgICAgICBzZXRsb2NhbGUoTENfQ1RZUEUsIE5VTEwp
IHRvIHRoZSBsYW5ndWFnZSBjb2RlcyBleHBlY3RlZCBmcm9tIGEKKyAgICAgICAgYnJvd3Nlci4K
KworICAgICAgICBBbHJlYWR5IGV4aXN0aW5nIHRlc3Q6IGZhc3QvanMvbmF2aWdhdG9yLWxhbmd1
YWdlLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9MYW5ndWFnZS5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpkZWZhdWx0TGFuZ3VhZ2UpOgorCiAyMDA5LTEwLTE2ICBUb3IgQXJuZSBWZXN0
YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBB
cml5YSBIaWRheWF0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTGFuZ3VhZ2Uu
Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTGFuZ3VhZ2UuY3BwCmluZGV4IDE3MWNkODQuLmQ3
MGNmOWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xhbmd1YWdlLmNwcAorKysg
Yi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9MYW5ndWFnZS5jcHAKQEAgLTI0LDEzICsyNCw0NSBAQAog
I2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKICNpbmNsdWRlIDxndGsvZ3RrLmg+CisjaW5j
bHVkZSA8bG9jYWxlLmg+CiAjaW5jbHVkZSA8cGFuZ28vcGFuZ28uaD4KIAogbmFtZXNwYWNlIFdl
YkNvcmUgewogCisvLyBVc2luZyBwYW5nb19sYW5ndWFnZV9nZXRfZGVmYXVsdCgpIGhlcmUgaXMg
bm90IGFuIG9wdGlvbiwgYmVjYXVzZQorLy8gaXQgZG9lc24ndCBzdXBwb3J0IGNoYW5naW5nIHRo
ZSBsb2NhbGUgaW4gcnVudGltZSwgc28gaXQgcmV0dXJucworLy8gYWx3YXlzIHRoZSBzYW1lIHZh
bHVlLgogU3RyaW5nIGRlZmF1bHRMYW5ndWFnZSgpCiB7Ci0gICAgcmV0dXJuIHBhbmdvX2xhbmd1
YWdlX3RvX3N0cmluZyhndGtfZ2V0X2RlZmF1bHRfbGFuZ3VhZ2UoKSk7CisgICAgc3RhdGljIEdI
YXNoVGFibGUqIGtub3duTGFuZ3VhZ2VzID0gMDsKKworICAgIGlmICgha25vd25MYW5ndWFnZXMp
CisgICAgICAgIGtub3duTGFuZ3VhZ2VzID0gZ19oYXNoX3RhYmxlX25ld19mdWxsKGdfc3RyX2hh
c2gsIGdfc3RyX2VxdWFsLCBnX2ZyZWUsIGdfZnJlZSk7CisKKyAgICBjaGFyKiBsb2NhbGVEZWZh
dWx0ID0gc2V0bG9jYWxlKExDX0NUWVBFLCBOVUxMKTsKKworICAgIGlmICghbG9jYWxlRGVmYXVs
dCkKKyAgICAgICAgcmV0dXJuICJjIjsKKworICAgIGNoYXIqIGxvb2tlZFVwID0gc3RhdGljX2Nh
c3Q8Y2hhcio+KGdfaGFzaF90YWJsZV9sb29rdXAoa25vd25MYW5ndWFnZXMsIGxvY2FsZURlZmF1
bHQpKTsKKworICAgIGlmIChsb29rZWRVcCkKKyAgICAgICAgcmV0dXJuIGxvb2tlZFVwOworCisg
ICAgY2hhciogbm9ybWFsaXplZERlZmF1bHQgPSBnX2FzY2lpX3N0cmRvd24obG9jYWxlRGVmYXVs
dCwgLTEpOworICAgIGNoYXIqIHB0ciA9IHN0cmNocihub3JtYWxpemVkRGVmYXVsdCwgJ18nKTsK
KworICAgIGlmKHB0cikKKyAgICAgICAgKnB0ciA9ICctJzsKKworICAgIHB0ciA9IHN0cmNocihu
b3JtYWxpemVkRGVmYXVsdCwgJy4nKTsKKworICAgIGlmKHB0cikKKyAgICAgICAgKnB0ciA9ICdc
MCc7CisKKyAgICBnX2hhc2hfdGFibGVfaW5zZXJ0KGtub3duTGFuZ3VhZ2VzLCBnX3N0cmR1cChs
b2NhbGVEZWZhdWx0KSwgbm9ybWFsaXplZERlZmF1bHQpOworCisgICAgcmV0dXJuIG5vcm1hbGl6
ZWREZWZhdWx0OwogfQogCiB9Ci0tIAoxLjYuNQoK
</data>
<flag name="commit-queue"
          id="22641"
          type_id="3"
          status="-"
          setter="gustavo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>41415</attachid>
            <date>2009-10-19 06:41:42 -0700</date>
            <delta_ts>2009-10-21 02:34:03 -0700</delta_ts>
            <desc>update test case to check against &quot;en-us&quot;</desc>
            <filename>bug30440_1.patch</filename>
            <type>text/plain</type>
            <size>3201</size>
            <attacher name="Chang Shu">cshu</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ5Nzc4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMTkgIFNodSBDaGFuZyAgPENoYW5n
LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgTGFuZ3VhZ2UgdGFnIHNob3VsZCBpbmNsdWRlIGJvdGggbGFuZ3VhZ2UgYW5kIGNv
dW50cnkgc3ViLXRhZ3MsCisgICAgICAgIGNhc2UgaW5zZW5zaXRpdmUuCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDQ0MAorCisgICAgICAgICogZmFz
dC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvanMv
bmF2aWdhdG9yLWxhbmd1YWdlLmh0bWw6CisKIDIwMDktMTAtMTkgIEFuZHJhcyBCZWNzaSAgPGJl
Y3NpLmFuZHJhc0BzdHVkLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBB
cm5lIFZlc3Riw7guCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL25hdmlnYXRvci1sYW5ndWFn
ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9uYXZpZ2F0
b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA0OTY4MCkKKysrIExheW91dFRlc3Rz
L2Zhc3QvanMvbmF2aWdhdG9yLWxhbmd1YWdlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA
QCAtMSwxNSArMSw4IEBACiBUZXN0IGZvciBidWcgMjk2NTM6IFtRdF0gUXQtYmFzZWQgYnJvd3Nl
ciBmYWlscyB0byBzaG93IHRoZSByaWdodCBsYW5ndWFnZSB0cmFuc2xhdGlvbi4KLUxhbmd1YWdl
IHRhZ3Mgc2hvdWxkIGZvbGxvdyB0aGUgc3BlY2lmaWNhdGlvbiBiZWxvdzoKLTIuMS4xLiAgRm9y
bWF0dGluZyBvZiBMYW5ndWFnZSBUYWdzCi0KLSAgIEF0IGFsbCB0aW1lcywgbGFuZ3VhZ2UgdGFn
cyBhbmQgdGhlaXIgc3VidGFncywgaW5jbHVkaW5nIHByaXZhdGUgdXNlCi0gICBhbmQgZXh0ZW5z
aW9ucywgYXJlIHRvIGJlIHRyZWF0ZWQgYXMgY2FzZSBpbnNlbnNpdGl2ZTogdGhlcmUgZXhpc3QK
LSAgIGNvbnZlbnRpb25zIGZvciB0aGUgY2FwaXRhbGl6YXRpb24gb2Ygc29tZSBvZiB0aGUgc3Vi
dGFncywgYnV0IHRoZXNlCi0gICBNVVNUIE5PVCBiZSB0YWtlbiB0byBjYXJyeSBtZWFuaW5nLgog
T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s
bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgbmF2aWdhdG9yLmxhbmd1YWdlLnN1
YnN0cmluZygwLDIpIGlzICdlbicKK1BBU1MgbmF2aWdhdG9yLmxhbmd1YWdlLnRvTG93ZXJDYXNl
KCkgaXMgJ2VuLXVzJwogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENP
TVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL25hdmlnYXRvci1sYW5ndWFnZS5odG1s
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvbmF2aWdhdG9yLWxhbmd1YWdlLmh0
bWwJKHJldmlzaW9uIDQ5NjgwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9uYXZpZ2F0b3ItbGFu
Z3VhZ2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNywxNiArNywxOCBAQAogPGJvZHk+CiA8cCBp
ZD0iZGVzY3JpcHRpb24iPjwvcD4KIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPCEtLQorTGFu
Z3VhZ2UgdGFncyBzaG91bGQgZm9sbG93IHRoZSBzcGVjaWZpY2F0aW9uIGJlbG93OgorMi4xLjEu
ICBGb3JtYXR0aW5nIG9mIExhbmd1YWdlIFRhZ3MKKworICAgQXQgYWxsIHRpbWVzLCBsYW5ndWFn
ZSB0YWdzIGFuZCB0aGVpciBzdWJ0YWdzLCBpbmNsdWRpbmcgcHJpdmF0ZSB1c2UKKyAgIGFuZCBl
eHRlbnNpb25zLCBhcmUgdG8gYmUgdHJlYXRlZCBhcyBjYXNlIGluc2Vuc2l0aXZlOiB0aGVyZSBl
eGlzdAorICAgY29udmVudGlvbnMgZm9yIHRoZSBjYXBpdGFsaXphdGlvbiBvZiBzb21lIG9mIHRo
ZSBzdWJ0YWdzLCBidXQgdGhlc2UKKyAgIE1VU1QgTk9UIGJlIHRha2VuIHRvIGNhcnJ5IG1lYW5p
bmcuCistLT4KIDxzY3JpcHQ+CiBkZXNjcmlwdGlvbigKLSI8cHJlPlRlc3QgZm9yIGJ1ZyAyOTY1
MzogW1F0XSBRdC1iYXNlZCBicm93c2VyIGZhaWxzIHRvIHNob3cgdGhlIHJpZ2h0IGxhbmd1YWdl
IHRyYW5zbGF0aW9uLlxuXAotTGFuZ3VhZ2UgdGFncyBzaG91bGQgZm9sbG93IHRoZSBzcGVjaWZp
Y2F0aW9uIGJlbG93OlxuXAotMi4xLjEuICBGb3JtYXR0aW5nIG9mIExhbmd1YWdlIFRhZ3NcblwK
LVxuXAotICAgQXQgYWxsIHRpbWVzLCBsYW5ndWFnZSB0YWdzIGFuZCB0aGVpciBzdWJ0YWdzLCBp
bmNsdWRpbmcgcHJpdmF0ZSB1c2VcblwKLSAgIGFuZCBleHRlbnNpb25zLCBhcmUgdG8gYmUgdHJl
YXRlZCBhcyBjYXNlIGluc2Vuc2l0aXZlOiB0aGVyZSBleGlzdFxuXAotICAgY29udmVudGlvbnMg
Zm9yIHRoZSBjYXBpdGFsaXphdGlvbiBvZiBzb21lIG9mIHRoZSBzdWJ0YWdzLCBidXQgdGhlc2Vc
blwKLSAgIE1VU1QgTk9UIGJlIHRha2VuIHRvIGNhcnJ5IG1lYW5pbmcuPC9wcmU+IgorIjxwcmU+
VGVzdCBmb3IgYnVnIDI5NjUzOiBbUXRdIFF0LWJhc2VkIGJyb3dzZXIgZmFpbHMgdG8gc2hvdyB0
aGUgcmlnaHQgbGFuZ3VhZ2UgdHJhbnNsYXRpb24uIgogKTsKIAogaWYgKHdpbmRvdy5sYXlvdXRU
ZXN0Q29udHJvbGxlcikgewpAQCAtMjQsNyArMjYsNyBAQCBpZiAod2luZG93LmxheW91dFRlc3RD
b250cm9sbGVyKSB7CiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0UE9TSVhMb2NhbGUoImVu
X1VTLmlzbzg4NTkxIik7CiB9CiAKLXNob3VsZEJlKCJuYXZpZ2F0b3IubGFuZ3VhZ2Uuc3Vic3Ry
aW5nKDAsMikiLCAiJ2VuJyIpOworc2hvdWxkQmUoIm5hdmlnYXRvci5sYW5ndWFnZS50b0xvd2Vy
Q2FzZSgpIiwgIidlbi11cyciKTsKIAogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CiA8
L3NjcmlwdD4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>41455</attachid>
            <date>2009-10-19 14:46:24 -0700</date>
            <delta_ts>2009-10-19 15:36:39 -0700</delta_ts>
            <desc>update description</desc>
            <filename>bug30440_2.patch</filename>
            <type>text/plain</type>
            <size>3235</size>
            <attacher name="Chang Shu">cshu</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ5Nzc4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMTkgIFNodSBDaGFuZyAgPENoYW5n
LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgTGFuZ3VhZ2UgdGFnIHNob3VsZCBpbmNsdWRlIGJvdGggbGFuZ3VhZ2UgYW5kIGNv
dW50cnkgc3ViLXRhZ3MsCisgICAgICAgIGNhc2UgaW5zZW5zaXRpdmUuCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDQ0MAorCisgICAgICAgICogZmFz
dC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvanMv
bmF2aWdhdG9yLWxhbmd1YWdlLmh0bWw6CisKIDIwMDktMTAtMTkgIEFuZHJhcyBCZWNzaSAgPGJl
Y3NpLmFuZHJhc0BzdHVkLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBB
cm5lIFZlc3Riw7guCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL25hdmlnYXRvci1sYW5ndWFn
ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9uYXZpZ2F0
b3ItbGFuZ3VhZ2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA0OTc3OCkKKysrIExheW91dFRlc3Rz
L2Zhc3QvanMvbmF2aWdhdG9yLWxhbmd1YWdlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA
QCAtMSwxNSArMSw4IEBACiBUZXN0IGZvciBidWcgMjk2NTM6IFtRdF0gUXQtYmFzZWQgYnJvd3Nl
ciBmYWlscyB0byBzaG93IHRoZSByaWdodCBsYW5ndWFnZSB0cmFuc2xhdGlvbi4KLUxhbmd1YWdl
IHRhZ3Mgc2hvdWxkIGZvbGxvdyB0aGUgc3BlY2lmaWNhdGlvbiBiZWxvdzoKLTIuMS4xLiAgRm9y
bWF0dGluZyBvZiBMYW5ndWFnZSBUYWdzCi0KLSAgIEF0IGFsbCB0aW1lcywgbGFuZ3VhZ2UgdGFn
cyBhbmQgdGhlaXIgc3VidGFncywgaW5jbHVkaW5nIHByaXZhdGUgdXNlCi0gICBhbmQgZXh0ZW5z
aW9ucywgYXJlIHRvIGJlIHRyZWF0ZWQgYXMgY2FzZSBpbnNlbnNpdGl2ZTogdGhlcmUgZXhpc3QK
LSAgIGNvbnZlbnRpb25zIGZvciB0aGUgY2FwaXRhbGl6YXRpb24gb2Ygc29tZSBvZiB0aGUgc3Vi
dGFncywgYnV0IHRoZXNlCi0gICBNVVNUIE5PVCBiZSB0YWtlbiB0byBjYXJyeSBtZWFuaW5nLgog
T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s
bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgbmF2aWdhdG9yLmxhbmd1YWdlLnN1
YnN0cmluZygwLDIpIGlzICdlbicKK1BBU1MgbmF2aWdhdG9yLmxhbmd1YWdlLnRvTG93ZXJDYXNl
KCkgaXMgJ2VuLXVzJwogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENP
TVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL25hdmlnYXRvci1sYW5ndWFnZS5odG1s
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvbmF2aWdhdG9yLWxhbmd1YWdlLmh0
bWwJKHJldmlzaW9uIDQ5Nzc4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9uYXZpZ2F0b3ItbGFu
Z3VhZ2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNywxNiArNywxOSBAQAogPGJvZHk+CiA8cCBp
ZD0iZGVzY3JpcHRpb24iPjwvcD4KIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPCEtLQorTGFu
Z3VhZ2UgdGFncyBzaG91bGQgZm9sbG93IHNwZWNpZmljYXRpb24gUkZDNTY0NjoKK2h0dHA6Ly90
b29scy5pZXRmLm9yZy9odG1sL3JmYzU2NDYKKzIuMS4xLiAgRm9ybWF0dGluZyBvZiBMYW5ndWFn
ZSBUYWdzCisKKyAgIEF0IGFsbCB0aW1lcywgbGFuZ3VhZ2UgdGFncyBhbmQgdGhlaXIgc3VidGFn
cywgaW5jbHVkaW5nIHByaXZhdGUgdXNlCisgICBhbmQgZXh0ZW5zaW9ucywgYXJlIHRvIGJlIHRy
ZWF0ZWQgYXMgY2FzZSBpbnNlbnNpdGl2ZTogdGhlcmUgZXhpc3QKKyAgIGNvbnZlbnRpb25zIGZv
ciB0aGUgY2FwaXRhbGl6YXRpb24gb2Ygc29tZSBvZiB0aGUgc3VidGFncywgYnV0IHRoZXNlCisg
ICBNVVNUIE5PVCBiZSB0YWtlbiB0byBjYXJyeSBtZWFuaW5nLgorLS0+CiA8c2NyaXB0PgogZGVz
Y3JpcHRpb24oCi0iPHByZT5UZXN0IGZvciBidWcgMjk2NTM6IFtRdF0gUXQtYmFzZWQgYnJvd3Nl
ciBmYWlscyB0byBzaG93IHRoZSByaWdodCBsYW5ndWFnZSB0cmFuc2xhdGlvbi5cblwKLUxhbmd1
YWdlIHRhZ3Mgc2hvdWxkIGZvbGxvdyB0aGUgc3BlY2lmaWNhdGlvbiBiZWxvdzpcblwKLTIuMS4x
LiAgRm9ybWF0dGluZyBvZiBMYW5ndWFnZSBUYWdzXG5cCi1cblwKLSAgIEF0IGFsbCB0aW1lcywg
bGFuZ3VhZ2UgdGFncyBhbmQgdGhlaXIgc3VidGFncywgaW5jbHVkaW5nIHByaXZhdGUgdXNlXG5c
Ci0gICBhbmQgZXh0ZW5zaW9ucywgYXJlIHRvIGJlIHRyZWF0ZWQgYXMgY2FzZSBpbnNlbnNpdGl2
ZTogdGhlcmUgZXhpc3RcblwKLSAgIGNvbnZlbnRpb25zIGZvciB0aGUgY2FwaXRhbGl6YXRpb24g
b2Ygc29tZSBvZiB0aGUgc3VidGFncywgYnV0IHRoZXNlXG5cCi0gICBNVVNUIE5PVCBiZSB0YWtl
biB0byBjYXJyeSBtZWFuaW5nLjwvcHJlPiIKKyI8cHJlPlRlc3QgZm9yIGJ1ZyAyOTY1MzogW1F0
XSBRdC1iYXNlZCBicm93c2VyIGZhaWxzIHRvIHNob3cgdGhlIHJpZ2h0IGxhbmd1YWdlIHRyYW5z
bGF0aW9uLiIKICk7CiAKIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKQEAgLTI0
LDcgKzI3LDcgQEAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91
dFRlc3RDb250cm9sbGVyLnNldFBPU0lYTG9jYWxlKCJlbl9VUy5pc284ODU5MSIpOwogfQogCi1z
aG91bGRCZSgibmF2aWdhdG9yLmxhbmd1YWdlLnN1YnN0cmluZygwLDIpIiwgIidlbiciKTsKK3No
b3VsZEJlKCJuYXZpZ2F0b3IubGFuZ3VhZ2UudG9Mb3dlckNhc2UoKSIsICInZW4tdXMnIik7CiAK
IHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwogPC9zY3JpcHQ+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>42026</attachid>
            <date>2009-10-28 07:14:43 -0700</date>
            <delta_ts>2009-10-28 08:20:04 -0700</delta_ts>
            <desc>reimplementation of defaultLanguage</desc>
            <filename>0001-reimplement-defaultLanguage-to-account-for-locale-ch.patch</filename>
            <type>text/plain</type>
            <size>3425</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">RnJvbSBmMDFlN2RjMDM4OGJjZWMwYzgyNWE5Y2Y3OGM4MDE5ZDQ2ZTk3NzdmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o
YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFdlZCwgMjggT2N0IDIwMDkgMTI6MTM6MzEgLTAyMDAK
U3ViamVjdDogW1BBVENIXSByZWltcGxlbWVudCBkZWZhdWx0TGFuZ3VhZ2UgdG8gYWNjb3VudCBm
b3IgbG9jYWxlIGNoYW5nZXMKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAg
IHwgICAxMSArKysrKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgIHwg
ICAgMyAtLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysr
KysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9MYW5ndWFnZS5jcHAgfCAgIDIzICsrKysr
KysrKysrKysrKysrKysrKystCiA0IGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDQg
ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0
VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDkwMTkxOGUuLjk2MzIzYmMgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
NCBAQAorMjAwOS0xMC0yOCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3Jvbmhh
QGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBbR1RLXSBGYWlscyBuZXcgdGVzdCBmYXN0L2pzL25hdmlnYXRvci1sYW5ndWFn
ZS5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z
MDQ0MAorCisgICAgICAgIFVuc2tpcCB0aGUgdGVzdCB0aGF0IG5vdyBwYXNzZXMuCisKKyAgICAg
ICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDoKKwogMjAwOS0xMC0yNyAgUnlvc3VrZSBOaXdhICA8
cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlm
ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv
cGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggNGJiZjVhZi4uMmE4MGY3MCAxMDA2NDQKLS0tIGEv
TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vZ3RrL1NraXBwZWQKQEAgLTE0NTgsOSArMTQ1OCw2IEBAIGZhc3QvZXZlbnRzL2RyYWctYW5k
LWRyb3Atbm9uZS5odG1sCiBmYXN0L2V2ZW50cy9kcmFnLWFuZC1kcm9wLmh0bWwKIGZhc3QvZXZl
bnRzL2RyYWctcGFyZW50LW5vZGUuaHRtbAogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0zMDQ0MAotZmFzdC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UuaHRtbAotCiBm
YXN0L3htbGh0dHByZXF1ZXN0L251bGwtZG9jdW1lbnQteG1saHR0cHJlcXVlc3Qtb3Blbi5odG1s
CiAjICAgVGVzdHMgdGltaW5nIG91dAogZmFzdC9sb2FkZXIvbnVsbC1yZXF1ZXN0LWFmdGVyLXdp
bGxTZW5kUmVxdWVzdC5odG1sCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNv
cmUvQ2hhbmdlTG9nCmluZGV4IDVjZmQ5MzguLmVkNGZlYzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv
Q2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDkt
MTAtMjggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEu
Y28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
W0dUS10gRmFpbHMgbmV3IHRlc3QgZmFzdC9qcy9uYXZpZ2F0b3ItbGFuZ3VhZ2UuaHRtbAorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA0NDAKKworICAg
ICAgICBSZWltcGxlbWVudCBXZWJDb3JlOjpkZWZhdWx0TGFuZ3VhZ2UgdG8gYWNjb3VudCBmb3Ig
Y2hhbmdlcyBpbgorICAgICAgICBsb2NhbGUgZG9uZSBieSBzZXRMb2NhbGUuCisKKyAgICAgICAg
QWxyZWFkeSBleGlzdGluZyB0ZXN0OiBmYXN0L2pzL25hdmlnYXRvci1sYW5ndWFnZS5odG1sCisK
KyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvTGFuZ3VhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
ZGVmYXVsdExhbmd1YWdlKToKKwogMjAwOS0xMC0yNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi
a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBh
L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xhbmd1YWdlLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr
L0xhbmd1YWdlLmNwcAppbmRleCAxNzFjZDg0Li5mZWEyZGY2IDEwMDY0NAotLS0gYS9XZWJDb3Jl
L3BsYXRmb3JtL2d0ay9MYW5ndWFnZS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTGFu
Z3VhZ2UuY3BwCkBAIC0yMSwxNiArMjEsMzcgQEAKICNpbmNsdWRlICJMYW5ndWFnZS5oIgogCiAj
aW5jbHVkZSAiQ1N0cmluZy5oIgorI2luY2x1ZGUgIkdPd25QdHIuaCIKICNpbmNsdWRlICJQbGF0
Zm9ybVN0cmluZy5oIgogCiAjaW5jbHVkZSA8Z3RrL2d0ay5oPgorI2luY2x1ZGUgPGxvY2FsZS5o
PgogI2luY2x1ZGUgPHBhbmdvL3BhbmdvLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorLy8g
VXNpbmcgcGFuZ29fbGFuZ3VhZ2VfZ2V0X2RlZmF1bHQoKSBoZXJlIGlzIG5vdCBhbiBvcHRpb24s
IGJlY2F1c2UKKy8vIGl0IGRvZXNuJ3Qgc3VwcG9ydCBjaGFuZ2luZyB0aGUgbG9jYWxlIGluIHJ1
bnRpbWUsIHNvIGl0IHJldHVybnMKKy8vIGFsd2F5cyB0aGUgc2FtZSB2YWx1ZS4KIFN0cmluZyBk
ZWZhdWx0TGFuZ3VhZ2UoKQogewotICAgIHJldHVybiBwYW5nb19sYW5ndWFnZV90b19zdHJpbmco
Z3RrX2dldF9kZWZhdWx0X2xhbmd1YWdlKCkpOworICAgIGNoYXIqIGxvY2FsZURlZmF1bHQgPSBz
ZXRsb2NhbGUoTENfQ1RZUEUsIE5VTEwpOworCisgICAgaWYgKCFsb2NhbGVEZWZhdWx0KQorICAg
ICAgICByZXR1cm4gU3RyaW5nKCJjIik7CisKKyAgICBHT3duUHRyPGdjaGFyPiBub3JtYWxpemVk
RGVmYXVsdChnX2FzY2lpX3N0cmRvd24obG9jYWxlRGVmYXVsdCwgLTEpKTsKKyAgICBjaGFyKiBw
dHIgPSBzdHJjaHIobm9ybWFsaXplZERlZmF1bHQuZ2V0KCksICdfJyk7CisKKyAgICBpZihwdHIp
CisgICAgICAgICpwdHIgPSAnLSc7CisKKyAgICBwdHIgPSBzdHJjaHIobm9ybWFsaXplZERlZmF1
bHQuZ2V0KCksICcuJyk7CisKKyAgICBpZihwdHIpCisgICAgICAgICpwdHIgPSAnXDAnOworCisg
ICAgcmV0dXJuIFN0cmluZyhub3JtYWxpemVkRGVmYXVsdC5nZXQoKSk7CiB9CiAKIH0KLS0gCjEu
Ni41Cgo=
</data>
<flag name="review"
          id="23517"
          type_id="1"
          status="+"
          setter="xan.lopez"
    />
    <flag name="commit-queue"
          id="23518"
          type_id="3"
          status="-"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>