304348 2025-12-17 12:02:17 -0800 clean up WebFoundTextRangeController 2026-01-19 21:53:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ccarley2 csaavedra dpino webkit-bug-importer oldest_to_newest 2166685 0 ccarley2 2025-12-17 12:02:17 -0800 Some of the code in WebFoundTextRangeController is difficult to read and could use some modernization 2166686 1 webkit-bug-importer 2025-12-17 12:02:24 -0800 <rdar://problem/166726139> 2166689 2 ccarley2 2025-12-17 12:06:23 -0800 Pull request: https://github.com/WebKit/WebKit/pull/55577 2167111 3 ews-feeder 2025-12-18 16:05:17 -0800 Committed 304713@main (8b622d23c65b): <https://commits.webkit.org/304713@main> Reviewed commits have been landed. Closing PR #55577 and removing active labels. 2168002 4 dpino 2025-12-23 14:23:07 -0800 After this patch, 'GTK-Linux-64-bit-Release-Debian-Stable-Build' s is failing with the following error: https://build.webkit.org/#/builders/46/builds/58814 ``` In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-30.cpp:8: ../../../Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp: In member function ‘void WebKit::WebFoundTextRangeController::findTextRangesForStringMatches(const WTF::String&, WTF::OptionSet<WebKit::FindOptions>, uint32_t, WTF::CompletionHandler<void(WTF::HashMap<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<long unsigned int>, long unsigned int>, WTF::Vector<WebKit::WebFoundTextRange> >&&)>&&)’: ../../../Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:136:66: error: ‘zip’ is not a member of ‘std::views’ 136 | for (const auto& [foundTextRange, simpleRange] : std::views::zip(webFoundTextRanges, validSimpleRanges)) { | ^~~ ninja: build stopped: subcommand failed. ``` The issue is that this bot uses GCC12 which uses a libstdc++ version which doesn't implement `std::views:zip`. This is the only use of this function in the entire codebase. A potential fix could be to implement std::view:zip in StdLibExtras.h. Another possibility is to rewrite this code so it doesn't use `std::views::zip`. 2168005 5 dpino 2025-12-23 14:30:09 -0800 Re-opening for pull request https://github.com/WebKit/WebKit/pull/55840 2173058 6 csaavedra 2026-01-19 09:14:41 -0800 Pull request: https://github.com/WebKit/WebKit/pull/56839 2173204 7 ews-feeder 2026-01-19 21:53:19 -0800 Committed 305851@main (bea9084bbebd): <https://commits.webkit.org/305851@main> Reviewed commits have been landed. Closing PR #56839 and removing active labels.