30429 2009-10-15 22:07:35 -0700 Web Inspector: [REGRESSION] Tabbing Through Element Attributes Loses Focus Immediately 2009-10-29 14:59:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck timothy aroben bweinstein joepeck pfeldman rik timothy oldest_to_newest 155010 0 joepeck 2009-10-15 22:07:35 -0700 This is bizarre. When tabbing to create a new element it loses focus immediately. I don't know when this regression happened I haven't looked into the past. Stepping through the code the following happens: Start editing an attribute and push tab: 1. It properly adds a new attribute or starts editing the next attribute 2. It seems to set the focus on the new node 3. It properly sets the selection in the new node 4. The moment it returns from the blur event listener in WebInspector.startEditing() the focus on the new node disappears. I haven't seen anything like this. Any ideas? 158966 1 timothy 2009-10-29 11:02:22 -0700 This happens because commiting an attribute edit causes a delayed callback to happen (WebInspector.DOMAgent.prototype._didApplyDomChange) which then calls _updateTitle on the ElementsTreeElement that changed, which sets innerHTML, which fires a blur event, and that cancels the edit for the next attribute. 159009 2 timothy 2009-10-29 12:23:05 -0700 I have a fix. 159011 3 42125 timothy 2009-10-29 12:27:05 -0700 Created attachment 42125 Proposed Patch 159103 4 timothy 2009-10-29 14:59:59 -0700 Committed r50303: <http://trac.webkit.org/changeset/50303> 42125 2009-10-29 12:27:05 -0700 2009-10-29 14:41:00 -0700 Proposed Patch bug-30429-20091029122703.patch text/plain 2872 timothy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzNiOTIxZS4uYjA5ZTQyOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMC0yOSAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRhYmJpbmcgdGhyb3VnaCBl bGVtZW50IGF0dHJpYnV0ZXMgaW4gdGhlIFdlYiBJbnNlY3Rvci4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA0MjkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRWxl bWVudHNUcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVF bGVtZW50LnByb3RvdHlwZS5fYXR0cmlidXRlRWRpdGluZ0NvbW1pdHRlZCk6IERvbid0IGNhbGwg X3VwZGF0ZVRpdGxlLAorICAgICAgICBpdCBpcyBjYWxsZWQgZm9yIHVzIHdoZW4gcmVtb3ZlQXR0 cmlidXRlIHN1Y2NlZWRzIGluIHRoZSBiYWNrLWVuZC4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5F bGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZS5fdGV4dE5vZGVFZGl0aW5nQ29tbWl0dGVkKTog RGl0dG8gZXhjZXB0IGZvciBub2RlVmFsdWUuCisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVu dHNUcmVlRWxlbWVudC5wcm90b3R5cGUuX2VkaXRpbmdDYW5jZWxsZWQpOiBEb24ndCBjYWxsIF91 cGRhdGVUaXRsZSwgZWRpdGluZyBjb2RlIHJldmVydHMuCisgICAgICAgIChXZWJJbnNwZWN0b3Iu RWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUuX3VwZGF0ZVRpdGxlKTogUmV0dXJuIGVhcmx5 IGlmIHdlIGFyZSBlZGl0aW5nLgorCiAyMDA5LTEwLTI4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IGJl MDE2NDcuLjBhYWQxZTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzCkBAIC03MzEsNyArNzMxLDYgQEAgV2ViSW5zcGVjdG9yLkVs ZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAgICAgICAgIGlmICghcGFyc2VFbGVt ZW50Lmhhc0F0dHJpYnV0ZXMoKSkgewogICAgICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVj dC5yZW1vdmVBdHRyaWJ1dGUoYXR0cmlidXRlTmFtZSk7Ci0gICAgICAgICAgICB0aGlzLl91cGRh dGVUaXRsZSgpOwogICAgICAgICAgICAgbW92ZVRvTmV4dEF0dHJpYnV0ZUlmTmVlZGVkLmNhbGwo dGhpcyk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KQEAgLTc0OCw4ICs3NDcsNiBA QCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAg IGlmICghZm91bmRPcmlnaW5hbEF0dHJpYnV0ZSkKICAgICAgICAgICAgIHRoaXMucmVwcmVzZW50 ZWRPYmplY3QucmVtb3ZlQXR0cmlidXRlKGF0dHJpYnV0ZU5hbWUpOwogCi0gICAgICAgIHRoaXMu X3VwZGF0ZVRpdGxlKCk7Ci0KICAgICAgICAgdGhpcy50cmVlT3V0bGluZS5mb2N1c2VkTm9kZUNo YW5nZWQodHJ1ZSk7CiAKICAgICAgICAgbW92ZVRvTmV4dEF0dHJpYnV0ZUlmTmVlZGVkLmNhbGwo dGhpcyk7CkBAIC03NjgsMTggKzc2NSwyNCBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxl bWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0ZXh0Tm9kZSA9IHRoaXMucmVwcmVzZW50 ZWRPYmplY3Q7CiAKICAgICAgICAgdGV4dE5vZGUubm9kZVZhbHVlID0gbmV3VGV4dDsKLSAgICAg ICAgdGhpcy5fdXBkYXRlVGl0bGUoKTsKKworICAgICAgICAvLyBObyBuZWVkIHRvIGNhbGwgX3Vw ZGF0ZVRpdGxlIGhlcmUsIGl0IHdpbGwgYmUgY2FsbGVkIGFmdGVyIHRoZSBub2RlVmFsdWUgaXMg Y29tbWl0dGVkLgogICAgIH0sCiAKICAgICBfZWRpdGluZ0NhbmNlbGxlZDogZnVuY3Rpb24oZWxl bWVudCwgY29udGV4dCkKICAgICB7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9lZGl0aW5nOwogCi0g ICAgICAgIHRoaXMuX3VwZGF0ZVRpdGxlKCk7CisgICAgICAgIC8vIE5vIG5lZWQgdG8gY2FsbCBf dXBkYXRlVGl0bGUgaGVyZSwgdGhlIGVkaXRpbmcgY29kZSB3aWxsIHJldmVydCB0byB0aGUgb3Jp Z2luYWwgdGV4dC4KICAgICB9LAogCiAgICAgX3VwZGF0ZVRpdGxlOiBmdW5jdGlvbigpCiAgICAg eworICAgICAgICAvLyBJZiB3ZSBhcmUgZWRpdGluZywgcmV0dXJuIGVhcmx5IHRvIHByZXZlbnQg Y2FuY2VsaW5nIHRoZSBlZGl0LgorICAgICAgICAvLyBBZnRlciBlZGl0aW5nIGlzIGNvbW1pdHRl ZCBfdXBkYXRlVGl0bGUgd2lsbCBiZSBjYWxsZWQuCisgICAgICAgIGlmICh0aGlzLl9lZGl0aW5n KQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIHZhciB0aXRsZSA9IHRoaXMuX25vZGVU aXRsZUluZm8odGhpcy5yZXByZXNlbnRlZE9iamVjdCwgdGhpcy5oYXNDaGlsZHJlbiwgV2ViSW5z cGVjdG9yLmxpbmtpZnlVUkwpLnRpdGxlOwogICAgICAgICB0aGlzLnRpdGxlID0gIjxzcGFuIGNs YXNzPVwiaGlnaGxpZ2h0XCI+IiArIHRpdGxlICsgIjwvc3Bhbj4iOwogICAgICAgICBkZWxldGUg dGhpcy5zZWxlY3Rpb25FbGVtZW50Ow==