30427 2009-10-15 21:43:36 -0700 Remove unneeded methods in ChromiumDataObject 2009-10-15 22:19:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED EasyFix, GoogleBug P3 Normal --- 1 rolandsteiner webkit-unassigned commit-queue oldest_to_newest 154999 0 rolandsteiner 2009-10-15 21:43:36 -0700 https://bugs.webkit.org/show_bug.cgi?id=28964 introduced interface methods to ChromiumDataObject. However, as the current plan is to move all clients of this class to the WebKit repository, those methods are no longer essential. 155001 1 41266 rolandsteiner 2009-10-15 21:50:23 -0700 Created attachment 41266 patch - removes methods This patch removes the mentioned methods and restores the original state. 155014 2 41266 commit-queue 2009-10-15 22:19:51 -0700 Comment on attachment 41266 patch - removes methods Clearing flags on attachment: 41266 Committed r49670: <http://trac.webkit.org/changeset/49670> 155015 3 commit-queue 2009-10-15 22:19:55 -0700 All reviewed patches have been landed. Closing bug. 41266 2009-10-15 21:50:23 -0700 2009-10-15 22:19:50 -0700 patch - removes methods retractCDO.patch text/plain 4100 rolandsteiner SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTY2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMTUgIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5l ckBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1ZyAzMDQyNyAtICBSZW1vdmUgdW5uZWVkZWQgbWV0aG9kcyBpbiBDaHJvbWl1bURh dGFPYmplY3QKKyAgICAgICAgKGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMDQyNykKKyAgICAgICAgCisgICAgICAgIFJlbW92ZSBubyBsb25nZXIgbmVlZGVkIG1ldGhv ZHMgZnJvbSBDaHJvbWl1bURhdGFPYmplY3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChubyBm dW5jdGlvbmFsIGNoYW5nZSkKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVt RGF0YU9iamVjdC5oOgorCiAyMDA5LTEwLTE1ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBObyByZXZpZXcsIHJvbGxpbmcgb3V0IHI0OTY0NC4KSW5kZXg6IFdl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bURhdGFPYmplY3QuaAkocmV2aXNp b24gNDk2NjgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVj dC5oCSh3b3JraW5nIGNvcHkpCkBAIC01Niw2MyArNTYsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgICAgIHZvaWQgY2xlYXIoKTsKICAgICAgICAgYm9vbCBoYXNEYXRhKCkgY29uc3Q7CiAK LSAgICAgICAgYm9vbCBjb250YWluc01haW5VUkwoKSBjb25zdCB7IHJldHVybiAhdXJsLmlzRW1w dHkoKTsgfQotICAgICAgICBib29sIGNvbnRhaW5zVmFsaWRNYWluVVJMKCkgY29uc3QgeyByZXR1 cm4gdXJsLmlzVmFsaWQoKTsgfQotICAgICAgICBLVVJMIG1haW5VUkwoKSBjb25zdCB7IHJldHVy biB1cmw7IH0KLSAgICAgICAgdm9pZCBzZXRNYWluVVJMKGNvbnN0IEtVUkwmIG5ld1VSTCkgeyB1 cmwgPSBuZXdVUkw7IH0KLQotICAgICAgICBib29sIGNvbnRhaW5zTWFpblVSTFRpdGxlKCkgY29u c3QgeyByZXR1cm4gIXVybFRpdGxlLmlzRW1wdHkoKTsgfQotICAgICAgICBTdHJpbmcgbWFpblVS TFRpdGxlKCkgY29uc3QgeyByZXR1cm4gdXJsVGl0bGU7IH0KLSAgICAgICAgdm9pZCBzZXRNYWlu VVJMVGl0bGUoY29uc3QgU3RyaW5nJiBuZXdVUkxUaXRsZSkgeyB1cmxUaXRsZSA9IG5ld1VSTFRp dGxlOyB9Ci0KLSAgICAgICAgYm9vbCBjb250YWluc1RleHRQbGFpbigpIGNvbnN0IHsgcmV0dXJu ICFwbGFpblRleHQuaXNFbXB0eSgpOyB9Ci0gICAgICAgIFN0cmluZyB0ZXh0UGxhaW4oKSBjb25z dCB7IHJldHVybiBwbGFpblRleHQ7IH0KLSAgICAgICAgdm9pZCBzZXRUZXh0UGxhaW4oY29uc3Qg U3RyaW5nJiBuZXdUZXh0KSB7IHBsYWluVGV4dCA9IG5ld1RleHQ7IH0KLQotICAgICAgICBib29s IGNvbnRhaW5zVGV4dEhUTUwoKSBjb25zdCB7IHJldHVybiAhdGV4dEh0bWwuaXNFbXB0eSgpOyB9 Ci0gICAgICAgIFN0cmluZyB0ZXh0SFRNTCgpIGNvbnN0IHsgcmV0dXJuIHRleHRIdG1sOyB9Ci0g ICAgICAgIHZvaWQgc2V0VGV4dEhUTUwoY29uc3QgU3RyaW5nJiBuZXdUZXh0KSB7IHRleHRIdG1s ID0gbmV3VGV4dDsgfQotCi0gICAgICAgIGJvb2wgY29udGFpbnNIVE1MQmFzZVVSTCgpIGNvbnN0 IHsgcmV0dXJuICFodG1sQmFzZVVybC5pc0VtcHR5KCk7IH0KLSAgICAgICAgYm9vbCBjb250YWlu c1ZhbGlkSFRNTEJhc2VVUkwoKSBjb25zdCB7IHJldHVybiBodG1sQmFzZVVybC5pc1ZhbGlkKCk7 IH0KLSAgICAgICAgS1VSTCBodG1sQmFzZVVSTCgpIGNvbnN0IHsgcmV0dXJuIGh0bWxCYXNlVXJs OyB9Ci0gICAgICAgIHZvaWQgc2V0SFRNTEJhc2VVUkwoY29uc3QgS1VSTCYgbmV3VVJMKSB7IGh0 bWxCYXNlVXJsID0gbmV3VVJMOyB9Ci0KLSAgICAgICAgYm9vbCBjb250YWluc0NvbnRlbnQoKSBj b25zdCB7IHJldHVybiBmaWxlQ29udGVudDsgfQotICAgICAgICBTaGFyZWRCdWZmZXIqIGNvbnRl bnQoKSBjb25zdCB7IHJldHVybiBmaWxlQ29udGVudC5nZXQoKTsgfQotICAgICAgICBQYXNzUmVm UHRyPFNoYXJlZEJ1ZmZlcj4gcmVsZWFzZUNvbnRlbnQoKSB7IHJldHVybiBmaWxlQ29udGVudC5y ZWxlYXNlKCk7IH0KLSAgICAgICAgdm9pZCBzZXRDb250ZW50KFBhc3NSZWZQdHI8U2hhcmVkQnVm ZmVyPiBuZXdDb250ZW50KSB7IGZpbGVDb250ZW50ID0gbmV3Q29udGVudDsgfQotCi0gICAgICAg IGJvb2wgY29udGFpbnNDb250ZW50RmlsZUV4dGVuc2lvbigpIGNvbnN0IHsgcmV0dXJuICFmaWxl RXh0ZW5zaW9uLmlzRW1wdHkoKTsgfQotICAgICAgICBTdHJpbmcgY29udGVudEZpbGVFeHRlbnNp b24oKSBjb25zdCB7IHJldHVybiBmaWxlRXh0ZW5zaW9uOyB9Ci0gICAgICAgIHZvaWQgc2V0Q29u dGVudEZpbGVFeHRlbnNpb24oY29uc3QgU3RyaW5nJiBuZXdGaWxlRXh0ZW5zaW9uKSB7IGZpbGVF eHRlbnNpb24gPSBuZXdGaWxlRXh0ZW5zaW9uOyB9Ci0KLSAgICAgICAgYm9vbCBjb250YWluc0Nv bnRlbnRGaWxlTmFtZSgpIGNvbnN0IHsgcmV0dXJuICFmaWxlQ29udGVudEZpbGVuYW1lLmlzRW1w dHkoKTsgfQotICAgICAgICBTdHJpbmcgY29udGVudEZpbGVOYW1lKCkgY29uc3QgeyByZXR1cm4g ZmlsZUNvbnRlbnRGaWxlbmFtZTsgfQotICAgICAgICB2b2lkIHNldENvbnRlbnRGaWxlTmFtZShj b25zdCBTdHJpbmcmIG5ld0ZpbGVOYW1lKSB7IGZpbGVDb250ZW50RmlsZW5hbWUgPSBuZXdGaWxl TmFtZTsgfQotCi0gICAgICAgIGJvb2wgY29udGFpbnNGaWxlTmFtZXMoKSBjb25zdCB7IHJldHVy biAhZmlsZW5hbWVzLmlzRW1wdHkoKTsgfQotICAgICAgICBWZWN0b3I8U3RyaW5nPiBmaWxlTmFt ZXMoKSBjb25zdCB7IHJldHVybiBmaWxlbmFtZXM7IH0KLSAgICAgICAgdm9pZCBjbGVhckZpbGVO YW1lcygpIHsgZmlsZW5hbWVzLmNsZWFyKCk7IH0KLSAgICAgICAgc2l6ZV90IGNvdW50RmlsZU5h bWVzKCkgY29uc3QgeyByZXR1cm4gZmlsZW5hbWVzLnNpemUoKTsgfQotICAgICAgICBTdHJpbmcg ZmlsZU5hbWVBdChzaXplX3QgaW5kZXgpIHsgcmV0dXJuIGZpbGVuYW1lcy5hdChpbmRleCk7IH0K LSAgICAgICAgdm9pZCBzZXRGaWxlTmFtZXMoY29uc3QgVmVjdG9yPFN0cmluZz4mIG5ld0ZpbGVO YW1lcykgeyBmaWxlbmFtZXMgPSBuZXdGaWxlTmFtZXM7IH0KLSAgICAgICAgdm9pZCBhcHBlbmRU b0ZpbGVOYW1lcyhjb25zdCBTdHJpbmcmIG5ld0ZpbGVOYW1lKQotICAgICAgICB7Ci0gICAgICAg ICAgICBBU1NFUlQoIW5ld0ZpbGVOYW1lLmlzRW1wdHkoKSk7Ci0gICAgICAgICAgICBmaWxlbmFt ZXMuYXBwZW5kKG5ld0ZpbGVOYW1lKTsKLSAgICAgICAgfQotICAgICAgICBTdHJpbmcgcG9wRmls ZU5hbWUoKSB7Ci0gICAgICAgICAgICBpZiAoZmlsZW5hbWVzLmlzRW1wdHkoKSkKLSAgICAgICAg ICAgICAgICByZXR1cm4gU3RyaW5nKCk7Ci0gICAgICAgICAgICBTdHJpbmcgZmlsZU5hbWU7Ci0g ICAgICAgICAgICBmaWxlTmFtZSA9IGZpbGVuYW1lcy5hdCgwKTsKLSAgICAgICAgICAgIGZpbGVu YW1lcy5yZW1vdmUoMCk7Ci0gICAgICAgICAgICByZXR1cm4gZmlsZU5hbWU7Ci0gICAgICAgIH0K LQotICAgICAgICAvLyBJbnRlcmltIHN0YXRlOiBBbGwgbWVtYmVycyB3aWxsIGJlY29tZSBwcml2 YXRlLCBkbyBOT1QgYWNjZXNzIHRoZW0gZGlyZWN0bHkhIAotICAgICAgICAvLyBSYXRoZXIgdXNl IHRoZSBhYm92ZSBhY2Nlc3NvciBtZXRob2RzIChvciBkZXZpc2UgbmV3IG9uZXMgaWYgbmVjZXNz YXJ5KS4KICAgICAgICAgS1VSTCB1cmw7CiAgICAgICAgIFN0cmluZyB1cmxUaXRsZTsKIAo=