30421 2009-10-15 20:07:00 -0700 Web Inspector: about protocol loads can show up on Cookies list as Local Files 2009-10-20 13:59:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein alice.barraclough aroben joepeck rik timothy oldest_to_newest 154978 0 bweinstein 2009-10-15 20:07:00 -0700 Go to www.google.com, you will see a Local Files entry on the Cookies list of the Web Inspector that has all the same Cookies as Google. Google creates an about:blank in generating their page, and that is being added to the Cookies domain list, when we should only be adding resources that were loaded from HTTP protocols. 154986 1 41261 bweinstein 2009-10-15 20:50:07 -0700 Created attachment 41261 Fix I am not sure if file URLs can create cookies/should show up in the Cookies list, if they should, then the if statement should be changed to: if (protocolInHTTPFamily() || protocolIs("file")), but I'm not sure which of these is correct, this patch works, but will not show cookies from a file URL, I'm not sure if that is correct behavior or not. 155120 2 bweinstein 2009-10-16 10:24:16 -0700 Dan Bernstein sent me a test case that shows that cookies are allowed on file URLs, so it seems that this bug was mistitled, and the code check is doing the wrong thing, we should also support file:// loads to show the cookies from. 155132 3 41295 bweinstein 2009-10-16 10:42:24 -0700 Created attachment 41295 Fix for HTTP + File URLs 155831 4 alice.barraclough 2009-10-19 12:29:27 -0700 r=me 156291 5 bweinstein 2009-10-20 13:59:18 -0700 Landed in http://trac.webkit.org/changeset/49883. 41261 2009-10-15 20:50:07 -0700 2009-10-16 10:24:38 -0700 Fix inspector_localfiles.patch text/plain 2244 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTY2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsNDYgQEAKKzIwMDktMTAtMTUgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzMwNDIxPi4KKyAgICAgICAgV2ViIElucHNl Y3RvcjogTG9jYWwgRmlsZXMgY2FuIHNob3cgdXAgb24gQ29va2llcyBMaXN0IHdpdGggQ29va2ll cyBmcm9tIG90aGVyIERvbWFpbi4KKyAgICAgICAgCisgICAgICAgIFdoZW4gYSBwYWdlIGxpa2Ug R29vZ2xlIGdlbmVyYXRlcyBhbiBhYm91dDpibGFuaywgaXQgc2hvd3MgdXAgYXMgYSBsb2NhbCBm aWxlIG9uCisgICAgICAgIHRoZSBsaXN0IG9mIENvb2tpZSBkb21haW5zLCBidXQgaGFzIGFsbCBv ZiB0aGUgY29va2llcyBvZiBHb29nbGUuIFdoZW4gd2UgYXJlIGFkZGluZworICAgICAgICBjb29r aWUgZG9tYWlucyB0byB0aGUgaW5zcGVjdG9yLCB3ZSBzaG91bGQgb25seSBhZGQgdGhlIGRvbWFp biBpcyB0aGUgVVJMIG9mIHRoZSByZXNvdXJjZQorICAgICAgICBpcyBpbiB0aGUgSFRUUCBwcm90 b2NvbCBmYW1pbHkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpwb3B1bGF0ZVNjcmlw dE9iamVjdHMpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlkRmlu aXNoTG9hZGluZyk6CisKIDIwMDktMTAtMTUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQu b3JnPgogCiAgICAgICAgIE5vIHJldmlldywgcm9sbGluZyBvdXQgcjQ5NjQ0LgpJbmRleDogV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDQ5NjYzKQor KysgV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTY1Myw3ICs2NTMsOCBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnBvcHVsYXRl U2NyaXB0CiAgICAgUmVzb3VyY2VzTWFwOjppdGVyYXRvciByZXNvdXJjZXNFbmQgPSBtX3Jlc291 cmNlcy5lbmQoKTsKICAgICBmb3IgKFJlc291cmNlc01hcDo6aXRlcmF0b3IgaXQgPSBtX3Jlc291 cmNlcy5iZWdpbigpOyBpdCAhPSByZXNvdXJjZXNFbmQ7ICsraXQpIHsKICAgICAgICAgaXQtPnNl Y29uZC0+Y3JlYXRlU2NyaXB0T2JqZWN0KG1fZnJvbnRlbmQuZ2V0KCkpOwotICAgICAgICBtX2Zy b250ZW5kLT5hZGRDb29raWVEb21haW4oaXQtPnNlY29uZC0+ZnJhbWUoKS0+ZG9jdW1lbnQoKS0+ dXJsKCkuaG9zdCgpKTsKKyAgICAgICAgaWYgKGl0LT5zZWNvbmQtPmZyYW1lKCktPmRvY3VtZW50 KCktPnVybCgpLnByb3RvY29sSW5IVFRQRmFtaWx5KCkpCisgICAgICAgICAgICBtX2Zyb250ZW5k LT5hZGRDb29raWVEb21haW4oaXQtPnNlY29uZC0+ZnJhbWUoKS0+ZG9jdW1lbnQoKS0+dXJsKCku aG9zdCgpKTsKICAgICB9CiAKICAgICB1bnNpZ25lZCBtZXNzYWdlQ291bnQgPSBtX2NvbnNvbGVN ZXNzYWdlcy5zaXplKCk7CkBAIC05ODIsNyArOTgzLDggQEAgdm9pZCBJbnNwZWN0b3JDb250cm9s bGVyOjpkaWRGaW5pc2hMb2FkaQogCiAgICAgaWYgKHdpbmRvd1Zpc2libGUoKSkgewogICAgICAg ICByZXNvdXJjZS0+dXBkYXRlU2NyaXB0T2JqZWN0KG1fZnJvbnRlbmQuZ2V0KCkpOwotICAgICAg ICBtX2Zyb250ZW5kLT5hZGRDb29raWVEb21haW4ocmVzb3VyY2UtPmZyYW1lKCktPmRvY3VtZW50 KCktPnVybCgpLmhvc3QoKSk7CisgICAgICAgIGlmIChyZXNvdXJjZS0+ZnJhbWUoKS0+ZG9jdW1l bnQoKS0+dXJsKCkucHJvdG9jb2xJbkhUVFBGYW1pbHkoKSkKKyAgICAgICAgICAgIG1fZnJvbnRl bmQtPmFkZENvb2tpZURvbWFpbihyZXNvdXJjZS0+ZnJhbWUoKS0+ZG9jdW1lbnQoKS0+dXJsKCku aG9zdCgpKTsKICAgICB9CiB9CiAK 41295 2009-10-16 10:42:24 -0700 2009-10-19 12:29:13 -0700 Fix for HTTP + File URLs inspector_localfiles.patch text/plain 2356 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTY2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsNDYgQEAKKzIwMDktMTAtMTUgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzMwNDIxPi4KKyAgICAgICAgV2ViIElucHNl Y3RvcjogTG9jYWwgRmlsZXMgY2FuIHNob3cgdXAgb24gQ29va2llcyBMaXN0IHdpdGggQ29va2ll cyBmcm9tIG90aGVyIERvbWFpbi4KKyAgICAgICAgCisgICAgICAgIFdoZW4gYSBwYWdlIGxpa2Ug R29vZ2xlIGdlbmVyYXRlcyBhbiBhYm91dDpibGFuaywgaXQgc2hvd3MgdXAgYXMgYSBsb2NhbCBm aWxlIG9uCisgICAgICAgIHRoZSBsaXN0IG9mIENvb2tpZSBkb21haW5zLCBidXQgaGFzIGFsbCBv ZiB0aGUgY29va2llcyBvZiBHb29nbGUuIFdoZW4gd2UgYXJlIGFkZGluZworICAgICAgICBjb29r aWUgZG9tYWlucyB0byB0aGUgaW5zcGVjdG9yLCB3ZSBzaG91bGQgb25seSBhZGQgdGhlIGRvbWFp biBpcyB0aGUgVVJMIG9mIHRoZSByZXNvdXJjZQorICAgICAgICBpcyBpbiB0aGUgSFRUUCBwcm90 b2NvbCBmYW1pbHkgb3IgYSBmaWxlIFVSTC4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6 OnBvcHVsYXRlU2NyaXB0T2JqZWN0cyk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250 cm9sbGVyOjpkaWRGaW5pc2hMb2FkaW5nKToKKwogMjAwOS0xMC0xNSAgRGFuaWVsIEJhdGVzICA8 ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTm8gcmV2aWV3LCByb2xsaW5nIG91dCByNDk2 NDQuCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAkocmV2 aXNpb24gNDk2NjMpCisrKyBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNjUzLDcgKzY1Myw5IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJv bGxlcjo6cG9wdWxhdGVTY3JpcHQKICAgICBSZXNvdXJjZXNNYXA6Oml0ZXJhdG9yIHJlc291cmNl c0VuZCA9IG1fcmVzb3VyY2VzLmVuZCgpOwogICAgIGZvciAoUmVzb3VyY2VzTWFwOjppdGVyYXRv ciBpdCA9IG1fcmVzb3VyY2VzLmJlZ2luKCk7IGl0ICE9IHJlc291cmNlc0VuZDsgKytpdCkgewog ICAgICAgICBpdC0+c2Vjb25kLT5jcmVhdGVTY3JpcHRPYmplY3QobV9mcm9udGVuZC5nZXQoKSk7 Ci0gICAgICAgIG1fZnJvbnRlbmQtPmFkZENvb2tpZURvbWFpbihpdC0+c2Vjb25kLT5mcmFtZSgp LT5kb2N1bWVudCgpLT51cmwoKS5ob3N0KCkpOworICAgICAgICBLVVJMIHJlc291cmNlVVJMID0g aXQtPnNlY29uZC0+ZnJhbWUoKS0+ZG9jdW1lbnQoKS0+dXJsKCk7CisgICAgICAgIGlmIChyZXNv dXJjZVVSTC5wcm90b2NvbEluSFRUUEZhbWlseSgpIHx8IHJlc291cmNlVVJMLnByb3RvY29sSXMo ImZpbGUiKSkKKyAgICAgICAgICAgIG1fZnJvbnRlbmQtPmFkZENvb2tpZURvbWFpbihyZXNvdXJj ZVVSTC5ob3N0KCkpOwogICAgIH0KIAogICAgIHVuc2lnbmVkIG1lc3NhZ2VDb3VudCA9IG1fY29u c29sZU1lc3NhZ2VzLnNpemUoKTsKQEAgLTk4Miw3ICs5ODQsOSBAQCB2b2lkIEluc3BlY3RvckNv bnRyb2xsZXI6OmRpZEZpbmlzaExvYWRpCiAKICAgICBpZiAod2luZG93VmlzaWJsZSgpKSB7CiAg ICAgICAgIHJlc291cmNlLT51cGRhdGVTY3JpcHRPYmplY3QobV9mcm9udGVuZC5nZXQoKSk7Ci0g ICAgICAgIG1fZnJvbnRlbmQtPmFkZENvb2tpZURvbWFpbihyZXNvdXJjZS0+ZnJhbWUoKS0+ZG9j dW1lbnQoKS0+dXJsKCkuaG9zdCgpKTsKKyAgICAgICAgS1VSTCByZXNvdXJjZVVSTCA9IHJlc291 cmNlLT5mcmFtZSgpLT5kb2N1bWVudCgpLT51cmwoKTsKKyAgICAgICAgaWYgKHJlc291cmNlVVJM LnByb3RvY29sSW5IVFRQRmFtaWx5KCkgfHwgcmVzb3VyY2VVUkwucHJvdG9jb2xJcygiZmlsZSIp KQorICAgICAgICAgICAgbV9mcm9udGVuZC0+YWRkQ29va2llRG9tYWluKHJlc291cmNlVVJMLmhv c3QoKSk7CiAgICAgfQogfQogCg==