30417 2009-10-15 16:46:30 -0700 Need to properly disable applicationCache at runtime 2009-11-04 16:36:17 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson michaeln jennb levin oldest_to_newest 154946 0 atwilson 2009-10-15 16:46:30 -0700 This if statement should evaluate to false if applicationCache is disabled at runtime: if ('applicationCache' in window) You can look at https://bugs.webkit.org/show_bug.cgi?id=30240 for an example of how this was done for window.Audio(). We probably need to move this setting out of WebCore::Settings and into a global static so it's easily accessible from the V8 bindings. 160516 1 42497 jennb 2009-11-04 11:01:58 -0800 Created attachment 42497 Proposed fix 160518 2 42497 levin 2009-11-04 11:09:35 -0800 Comment on attachment 42497 Proposed fix > Index: WebCore/ChangeLog > + Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures. There is a TAB in the changelog that needs to be removed. Nice start, but this is incomplete as discussed. 160523 3 42499 jennb 2009-11-04 11:16:35 -0800 Created attachment 42499 Revised fix 160528 4 42499 levin 2009-11-04 11:22:33 -0800 Comment on attachment 42499 Revised fix > Index: WebCore/ChangeLog > + Just adding a bit, so new tests. I think you have not really changed the visible functionality so no new tests. > Index: WebCore/bindings/v8/custom/V8CustomBinding.h > #if ENABLE(OFFLINE_WEB_APPLICATIONS) > + DECLARE_ACCESSOR_RUNTIME_ENABLER(DOMApplicationCache); Another TAB to remove. I can fix this on landing. 160657 5 levin 2009-11-04 16:36:17 -0800 Committed as http://trac.webkit.org/changeset/50534. 42497 2009-11-04 11:01:58 -0800 2009-11-04 11:16:35 -0800 Proposed fix AppcacheEnabledPatch.txt text/plain 2362 jennb SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMTEtMDQgIEplbm4gQnJhaXRod2FpdGUgIDxqZW5uYkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTmVlZCB0byBwcm9wZXJseSBkaXNhYmxlIGFwcGxpY2F0aW9uQ2FjaGUgYXQgcnVudGltZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA0MTcKKwor CUFkZGluZyBhcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCBiaXQgdG8gVjggUnVudGltZUVuYWJsZWRG ZWF0dXJlcy4KKwkKKyAgICAgICAgSnVzdCBhZGRpbmcgYSBiaXQsIHNvIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaDoKKyAgICAgICAgKFdlYkNv cmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldEFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKToK KyAgICAgICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmFwcGxpY2F0aW9uQ2Fj aGVFbmFibGVkKToKKwogMjAwOS0xMS0wNCAgVmFkaW0gWmVpdGxpbiAgPHZhZGltQHd4d2lkZ2V0 cy5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3Jl L2JpbmRpbmdzL3Y4L1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAJKHJldmlzaW9uIDUw NDg4KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzcsNSArMzcsNiBAQCBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVy ZXM6OmlzRGF0YWJhc2VFCiBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzTG9jYWxTdG9y YWdlRW5hYmxlZCA9IHRydWU7CiBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzU2Vzc2lv blN0b3JhZ2VFbmFibGVkID0gdHJ1ZTsKIGJvb2wgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNO b3RpZmljYXRpb25zRW5hYmxlZCA9IGZhbHNlOworYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVz Ojppc0FwcGxpY2F0aW9uQ2FjaGVFbmFibGVkID0gZmFsc2U7CiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJl cy5oCShyZXZpc2lvbiA1MDQ4OCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvUnVudGltZUVuYWJs ZWRGZWF0dXJlcy5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw5IEBAIHB1YmxpYzoKICAg ICBzdGF0aWMgdm9pZCBzZXROb3RpZmljYXRpb25zRW5hYmxlZChib29sIGlzRW5hYmxlZCkgeyBp c05vdGlmaWNhdGlvbnNFbmFibGVkID0gaXNFbmFibGVkOyB9CiAgICAgc3RhdGljIGJvb2wgbm90 aWZpY2F0aW9uc0VuYWJsZWQoKSB7IHJldHVybiBpc05vdGlmaWNhdGlvbnNFbmFibGVkOyB9CiAK KyAgICBzdGF0aWMgdm9pZCBzZXRBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZChib29sIGlzRW5hYmxl ZCkgeyBpc0FwcGxpY2F0aW9uQ2FjaGVFbmFibGVkID0gaXNFbmFibGVkOyB9CisgICAgc3RhdGlj IGJvb2wgYXBwbGljYXRpb25DYWNoZUVuYWJsZWQoKSB7IHJldHVybiBpc0FwcGxpY2F0aW9uQ2Fj aGVFbmFibGVkOyB9CisKIHByaXZhdGU6CiAgICAgLy8gTmV2ZXIgaW5zdGFudGlhdGUuCiAgICAg UnVudGltZUVuYWJsZWRGZWF0dXJlcygpIHsgfQpAQCAtNTYsNiArNTksNyBAQCBwcml2YXRlOgog ICAgIHN0YXRpYyBib29sIGlzTG9jYWxTdG9yYWdlRW5hYmxlZDsKICAgICBzdGF0aWMgYm9vbCBp c1Nlc3Npb25TdG9yYWdlRW5hYmxlZDsKICAgICBzdGF0aWMgYm9vbCBpc05vdGlmaWNhdGlvbnNF bmFibGVkOworICAgIHN0YXRpYyBib29sIGlzQXBwbGljYXRpb25DYWNoZUVuYWJsZWQ7CiB9Owog CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 42499 2009-11-04 11:16:35 -0800 2009-11-04 11:22:32 -0800 Revised fix AppcacheEnabledPatch.txt text/plain 4588 jennb SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMTEtMDQgIEplbm4gQnJhaXRod2FpdGUgIDxqZW5uYkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTmVlZCB0byBwcm9wZXJseSBkaXNhYmxlIGFwcGxpY2F0aW9uQ2FjaGUgYXQgcnVudGltZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA0MTcKKwor ICAgICAgICBBZGRpbmcgYXBwbGljYXRpb25DYWNoZUVuYWJsZWQgYml0IHRvIFY4IFJ1bnRpbWVF bmFibGVkRmVhdHVyZXMuCisgICAgICAgIAorICAgICAgICBKdXN0IGFkZGluZyBhIGJpdCwgc28g bmV3IHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJl cy5jcHA6CisgICAgICAgICogYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oOgor ICAgICAgICAoV2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2V0QXBwbGljYXRpb25D YWNoZUVuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6 YXBwbGljYXRpb25DYWNoZUVuYWJsZWQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OEN1c3RvbUJpbmRpbmcuaDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5k b3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6QUNDRVNTT1JfUlVOVElNRV9FTkFCTEVS KToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5pZGw6CisKIDIwMDktMTEtMDMgIEplcmVteSBP cmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g RmlzaGVyLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVz LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1J1bnRpbWVFbmFibGVkRmVh dHVyZXMuY3BwCShyZXZpc2lvbiA1MDQ4OCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvUnVudGlt ZUVuYWJsZWRGZWF0dXJlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDUgKzM3LDYgQEAgYm9v bCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0RhdGFiYXNlRQogYm9vbCBSdW50aW1lRW5hYmxl ZEZlYXR1cmVzOjppc0xvY2FsU3RvcmFnZUVuYWJsZWQgPSB0cnVlOwogYm9vbCBSdW50aW1lRW5h YmxlZEZlYXR1cmVzOjppc1Nlc3Npb25TdG9yYWdlRW5hYmxlZCA9IHRydWU7CiBib29sIFJ1bnRp bWVFbmFibGVkRmVhdHVyZXM6OmlzTm90aWZpY2F0aW9uc0VuYWJsZWQgPSBmYWxzZTsKK2Jvb2wg UnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCA9IGZhbHNl OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1J1 bnRpbWVFbmFibGVkRmVhdHVyZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4 L1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaAkocmV2aXNpb24gNTA0ODgpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3Y4L1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaAkod29ya2luZyBjb3B5KQpAQCAtNDgs NiArNDgsOSBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgc2V0Tm90aWZpY2F0aW9uc0VuYWJs ZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNOb3RpZmljYXRpb25zRW5hYmxlZCA9IGlzRW5hYmxlZDsg fQogICAgIHN0YXRpYyBib29sIG5vdGlmaWNhdGlvbnNFbmFibGVkKCkgeyByZXR1cm4gaXNOb3Rp ZmljYXRpb25zRW5hYmxlZDsgfQogCisgICAgc3RhdGljIHZvaWQgc2V0QXBwbGljYXRpb25DYWNo ZUVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCA9IGlz RW5hYmxlZDsgfQorICAgIHN0YXRpYyBib29sIGFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKCkgeyBy ZXR1cm4gaXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZDsgfQorCiBwcml2YXRlOgogICAgIC8vIE5l dmVyIGluc3RhbnRpYXRlLgogICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXMoKSB7IH0KQEAgLTU2 LDYgKzU5LDcgQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgYm9vbCBpc0xvY2FsU3RvcmFnZUVuYWJs ZWQ7CiAgICAgc3RhdGljIGJvb2wgaXNTZXNzaW9uU3RvcmFnZUVuYWJsZWQ7CiAgICAgc3RhdGlj IGJvb2wgaXNOb3RpZmljYXRpb25zRW5hYmxlZDsKKyAgICBzdGF0aWMgYm9vbCBpc0FwcGxpY2F0 aW9uQ2FjaGVFbmFibGVkOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21CaW5kaW5nLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21CaW5kaW5nLmgJKHJldmlzaW9uIDUw NDg4KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21CaW5kaW5nLmgJKHdv cmtpbmcgY29weSkKQEAgLTY0NCw2ICs2NDQsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAjZW5k aWYgLy8gRU5BQkxFKE5PVElGSUNBVElPTlMpCiAKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQ TElDQVRJT05TKQorCURFQ0xBUkVfQUNDRVNTT1JfUlVOVElNRV9FTkFCTEVSKERPTUFwcGxpY2F0 aW9uQ2FjaGUpOwogICAgICAgICBERUNMQVJFX1BST1BFUlRZX0FDQ0VTU09SKERPTUFwcGxpY2F0 aW9uQ2FjaGVFdmVudEhhbmRsZXIpOwogICAgICAgICBERUNMQVJFX0NBTExCQUNLKERPTUFwcGxp Y2F0aW9uQ2FjaGVBZGRFdmVudExpc3RlbmVyKTsKICAgICAgICAgREVDTEFSRV9DQUxMQkFDSyhE T01BcHBsaWNhdGlvbkNhY2hlUmVtb3ZlRXZlbnRMaXN0ZW5lcik7CkluZGV4OiBXZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCShyZXZpc2lvbiA1 MDQ4OCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzA3LDYgKzMwNywxMyBAQCBBQ0NFU1NPUl9SVU5USU1FX0VO QUJMRVIoRE9NV2luZG93V2Via2l0CiB9CiAjZW5kaWYKIAorI2lmIEVOQUJMRShPRkZMSU5FX1dF Ql9BUFBMSUNBVElPTlMpCitBQ0NFU1NPUl9SVU5USU1FX0VOQUJMRVIoRE9NQXBwbGljYXRpb25D YWNoZSkKK3sKKyAgICByZXR1cm4gUnVudGltZUVuYWJsZWRGZWF0dXJlczo6YXBwbGljYXRpb25D YWNoZUVuYWJsZWQoKTsKK30KKyNlbmRpZgorCiBBQ0NFU1NPUl9HRVRURVIoRE9NV2luZG93SW1h Z2UpCiB7CiAgICAgRE9NV2luZG93KiB3aW5kb3cgPSBWOERPTVdyYXBwZXI6OmNvbnZlcnRUb05h dGl2ZU9iamVjdDxET01XaW5kb3c+KFY4Q2xhc3NJbmRleDo6RE9NV0lORE9XLCBpbmZvLkhvbGRl cigpKTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCShyZXZpc2lvbiA1MDQ4OCkKKysrIFdlYkNvcmUvcGFn ZS9ET01XaW5kb3cuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0xNTcsNyArMTU3LDcgQEAgbW9kdWxl IHdpbmRvdyB7CiAgICAgICAgIFdlYktpdFBvaW50IHdlYmtpdENvbnZlcnRQb2ludEZyb21Ob2Rl VG9QYWdlKGluIE5vZGUgbm9kZSwgaW4gV2ViS2l0UG9pbnQgcCk7CiAKICNpZiBkZWZpbmVkKEVO QUJMRV9PRkZMSU5FX1dFQl9BUFBMSUNBVElPTlMpICYmIEVOQUJMRV9PRkZMSU5FX1dFQl9BUFBM SUNBVElPTlMKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTUFwcGxpY2F0aW9uQ2FjaGUg YXBwbGljYXRpb25DYWNoZTsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtFbmFibGVkQXRS dW50aW1lXSBET01BcHBsaWNhdGlvbkNhY2hlIGFwcGxpY2F0aW9uQ2FjaGU7CiAjZW5kaWYgICAg CiAjaWYgZGVmaW5lZChFTkFCTEVfREFUQUJBU0UpICYmIEVOQUJMRV9EQVRBQkFTRQogICAgICAg ICBbRW5hYmxlZEF0UnVudGltZV0gRGF0YWJhc2Ugb3BlbkRhdGFiYXNlKGluIERPTVN0cmluZyBu YW1lLCBpbiBET01TdHJpbmcgdmVyc2lvbiwgaW4gRE9NU3RyaW5nIGRpc3BsYXlOYW1lLCBpbiB1 bnNpZ25lZCBsb25nIGVzdGltYXRlZFNpemUpCg==