304113 2025-12-13 06:40:08 -0800 Reduce boilerplate in Quirks.cpp with QUIRKS_EARLY_RETURN_IF_DISABLED_WITH_VALUE macro 2025-12-16 06:00:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 brandonstewart brandonstewart webkit-bug-importer oldest_to_newest 2165645 0 brandonstewart 2025-12-13 06:40:08 -0800 Introduce QUIRKS_EARLY_RETURN_IF_DISABLED macro to reduce repetitive boilerplate in Quirks.cpp. This replaces 118 instances of the pattern: if (!needsQuirks()) [[unlikely]] return <value>; with: QUIRKS_EARLY_RETURN_IF_DISABLED(<value>); This reduces the file by ~114 lines and improves consistency. The macro accepts any return value, allowing it to handle the various return types used (bool, String, std::optional, and StorageAccessResult). 2165646 1 webkit-bug-importer 2025-12-13 06:40:14 -0800 <rdar://problem/166445289> 2165647 2 brandonstewart 2025-12-13 06:41:44 -0800 Pull request: https://github.com/WebKit/WebKit/pull/55361 2166205 3 ews-feeder 2025-12-16 06:00:06 -0800 Committed 304509@main (b1538aeb1640): <https://commits.webkit.org/304509@main> Reviewed commits have been landed. Closing PR #55361 and removing active labels.