30410 2009-10-15 15:14:19 -0700 Chromium media controls should display a disabled play button when no src 2009-10-16 13:57:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 scherkus webkit-unassigned commit-queue eric.carlson eric oldest_to_newest 154918 0 scherkus 2009-10-15 15:14:19 -0700 Right now we show an enabled play button even if an audio/video element has no valid src. Bad!! 154966 1 41257 scherkus 2009-10-15 18:16:31 -0700 Created attachment 41257 Round 1 Nice and easy :D 155198 2 eric 2009-10-16 13:35:38 -0700 LGTM. CCing eric so he sees this go by. 155200 3 41257 eric 2009-10-16 13:35:58 -0700 Comment on attachment 41257 Round 1 I'm no expert here, but this looks simple and correct. 155217 4 41257 commit-queue 2009-10-16 13:56:58 -0700 Comment on attachment 41257 Round 1 Clearing flags on attachment: 41257 Committed r49695: <http://trac.webkit.org/changeset/49695> 155218 5 commit-queue 2009-10-16 13:57:02 -0700 All reviewed patches have been landed. Closing bug. 41257 2009-10-15 18:16:31 -0700 2009-10-16 13:56:58 -0700 Round 1 play_button.patch text/plain 1617 scherkus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmVlNWJkMS4uOGFkMWI4ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0xNSAgQW5kcmV3IFNjaGVy a3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBDaHJvbWl1bSBtZWRpYSBjb250cm9scyB0byByZW5k ZXIgYSBkaXNhYmxlZCBwbGF5IGJ1dHRvbiB3aGVuIHRoZSBlbGVtZW50IGlzIHVuaW50aWFsaXpl ZC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA0 MTAKKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIGxheW91dCB0ZXN0cy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6cGFpbnRNZWRpYVBsYXlCdXR0b24pOiBJbmNsdWRlIGNoZWNrIGZvciBORVRXT1JL X0VNUFRZIHRvIHJlbmRlciBkaXNhYmxlZCBwbGF5IGJ1dHRvbi4KKwogMjAwOS0xMC0xNCAgS2V2 aW4gRGVja2VyICA8a2RlY2tlckBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyc3RhbXBlZCBi eSBKb24gSG9uZXljdXR0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVk aWFDb250cm9sc0Nocm9taXVtLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29u dHJvbHNDaHJvbWl1bS5jcHAKaW5kZXggYmJhMmZhMi4uMTg0N2FhZCAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFDb250cm9sc0Nocm9taXVtLmNwcAorKysgYi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwCkBAIC05MSw3ICs5 MSw4IEBAIHN0YXRpYyBib29sIHBhaW50TWVkaWFQbGF5QnV0dG9uKFJlbmRlck9iamVjdCogb2Jq ZWN0LCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50CiAgICAgc3RhdGljIEltYWdlKiBtZWRpYVBh dXNlID0gcGxhdGZvcm1SZXNvdXJjZSgibWVkaWFQYXVzZSIpOwogICAgIHN0YXRpYyBJbWFnZSog bWVkaWFQbGF5RGlzYWJsZWQgPSBwbGF0Zm9ybVJlc291cmNlKCJtZWRpYVBsYXlEaXNhYmxlZCIp OwogCi0gICAgaWYgKG1lZGlhRWxlbWVudC0+bmV0d29ya1N0YXRlKCkgPT0gSFRNTE1lZGlhRWxl bWVudDo6TkVUV09SS19OT19TT1VSQ0UpCisgICAgaWYgKG1lZGlhRWxlbWVudC0+bmV0d29ya1N0 YXRlKCkgPT0gSFRNTE1lZGlhRWxlbWVudDo6TkVUV09SS19FTVBUWSB8fAorICAgICAgICBtZWRp YUVsZW1lbnQtPm5ldHdvcmtTdGF0ZSgpID09IEhUTUxNZWRpYUVsZW1lbnQ6Ok5FVFdPUktfTk9f U09VUkNFKQogICAgICAgICByZXR1cm4gcGFpbnRNZWRpYUJ1dHRvbihwYWludEluZm8uY29udGV4 dCwgcmVjdCwgbWVkaWFQbGF5RGlzYWJsZWQpOwogCiAgICAgcmV0dXJuIHBhaW50TWVkaWFCdXR0 b24ocGFpbnRJbmZvLmNvbnRleHQsIHJlY3QsIG1lZGlhRWxlbWVudC0+cGF1c2VkKCkgPyBtZWRp YVBsYXkgOiBtZWRpYVBhdXNlKTsK