30404 2009-10-15 13:55:00 -0700 Web Inspector: Prevent subsequent tests from failing upon inspector test timeout. 2009-11-08 08:20:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman timothy oldest_to_newest 154890 0 pfeldman 2009-10-15 13:55:00 -0700 When something is broken badly in the front-end, inspector test might timeout. As a result, tear down won't happen and inspector window will stay open. As a result all subsequent tests relying upon 800x600 will fail. 154897 1 41245 pfeldman 2009-10-15 14:11:34 -0700 Created attachment 41245 [PATCH] Short term fix This is a short term fix. Right one is to make sure that inspector is closed after the test it was opened for, but that requires additional state in LayoutTestController. 154898 2 41245 timothy 2009-10-15 14:14:42 -0700 Comment on attachment 41245 [PATCH] Short term fix > + alert("Internal timeout exceeded.") Maybe console.log would be better? 154899 3 pfeldman 2009-10-15 14:25:59 -0700 (In reply to comment #2) > (From update of attachment 41245 [details]) > > > + alert("Internal timeout exceeded.") > > Maybe console.log would be better? They both transform into a text line in the DRT dump. I hesitate to use console since it will also trigger some inspector bits and by this time we know inspector is broken. Anyway, I am not closing this bug since the right solution is on its way... 154900 4 timothy 2009-10-15 14:27:33 -0700 Ok, alert() is fine. 154906 5 pfeldman 2009-10-15 14:39:17 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/evaluate-in-frontend.js Committed r49656 41245 2009-10-15 14:11:34 -0700 2009-10-15 14:38:59 -0700 [PATCH] Short term fix short_term text/plain 1632 pfeldman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2M2EwYmE5Li5iN2UxZjQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAt MTUgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJldmVu dCBzdWJzZXF1ZW50IHRlc3RzIGZyb20gZmFpbGluZyB1cG9uIGluc3BlY3RvcgorICAgICAgICB0 ZXN0IHRpbWVvdXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMwNDA0CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZXZhbHVhdGUtaW4tZnJvbnRlbmQu anM6CisgICAgICAgIChvbmxvYWQuc2V0VGltZW91dCk6CisKIDIwMDktMTAtMTUgIFphbiBEb2Jl cnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0 YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXZhbHVhdGUt aW4tZnJvbnRlbmQuanMgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXZhbHVhdGUtaW4tZnJvbnRl bmQuanMKaW5kZXggMzUyMjQxNy4uYWUxN2Q4MiAxMDA3NTUKLS0tIGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2V2YWx1YXRlLWluLWZyb250ZW5kLmpzCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9ldmFsdWF0ZS1pbi1mcm9udGVuZC5qcwpAQCAtMjIsMTIgKzIyLDE5IEBAIGZ1bmN0aW9uIG9u bG9hZCgpCiAgICAgICAgIHJldHVybjsKICAgICB2YXIgY2FsbElkID0gbGFzdENhbGxJZCsrOwog ICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7Ci0gICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpIHsKLSAgICAgICAgICAgIC8vIGxheW91dFRlc3RDb250cm9sbGVyLnNob3dX ZWJJbnNwZWN0b3IoKTsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK ICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmV2YWx1YXRlSW5XZWJJbnNwZWN0b3Io Y2FsbElkLCBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZnJvbnRlbmQtc2NyaXB0IikudGV4dENv bnRlbnQpOwotICAgICAgICB9CiAgICAgICAgIGRvaXQoKTsKICAgICB9LCAwKTsKKworICAgIC8v IE1ha2Ugc3VyZSB3ZWIgaW5zcGVjdG9yIHdpbmRvdyBpcyBjbG9zZWQgYmVmb3JlIHRoZSB0ZXN0 IGlzIGludGVycnVwdGVkLgorICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgIGFs ZXJ0KCJJbnRlcm5hbCB0aW1lb3V0IGV4Y2VlZGVkLiIpCisgICAgICAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmNs b3NlV2ViSW5zcGVjdG9yKCk7CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3Rp ZnlEb25lKCk7CisgICAgICAgIH0KKyAgICB9LCAxMDAwMCk7CiB9CiAKIGZ1bmN0aW9uIGV2YWx1 YXRlSW5XZWJJbnNwZWN0b3Ioc2NyaXB0LCBjYWxsYmFjaykK