30399 2009-10-15 11:10:16 -0700 <mask> and <pattern> don't handle texts 2010-07-01 09:18:11 -0700 1 1 1 Unclassified WebKit SVG 525.x (Safari 3.1) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 krit webkit-unassigned eric zimmermann oldest_to_newest 154850 0 41236 krit 2009-10-15 11:10:16 -0700 Created attachment 41236 Mask with text Texts in maks are ignored. I thougt that Eric already opened a bug about masking and texts but I couldn't find it. I added a short example. If mask works correctly, you should see a green squarre with the red text "Mask" on it. 163653 1 krit 2009-11-14 00:38:08 -0800 *** Bug 15655 has been marked as a duplicate of this bug. *** 180351 2 krit 2010-01-13 12:41:05 -0800 The problem is in renderSubtreeToImage() (SVGRenderSupport.cpp). We set the paintInfo.rect to en empty IntRect. RenderObject::PaintInfo info(image->context(), IntRect(), PaintPhaseForeground, 0, 0, 0); This causes problems in RenderSVGText::paint(). RenderSVGText::paint() calls RenderBlock::paint(pi, 0, 0); and RenderBlock::paint intersects visibleOverflowRect() with paintInfo.rect and returns if this intersection is empty. But even disabling the return for testing didn't solve the problem. I had to add the paintInfo.rect of the SVGResource and the renderer with the relation to this resource to renderSubtreeToImage() manually to get texts working. Sounds a bit complicated atm :-P 180375 3 zimmermann 2010-01-13 13:18:41 -0800 (In reply to comment #2) > The problem is in renderSubtreeToImage() (SVGRenderSupport.cpp). We set the > paintInfo.rect to en empty IntRect. > > RenderObject::PaintInfo info(image->context(), IntRect(), > PaintPhaseForeground, 0, 0, 0); > > This causes problems in RenderSVGText::paint(). RenderSVGText::paint() calls > > RenderBlock::paint(pi, 0, 0); > > and RenderBlock::paint intersects visibleOverflowRect() with paintInfo.rect and > returns if this intersection is empty. But even disabling the return for > testing didn't solve the problem. I had to add the paintInfo.rect of the > SVGResource and the renderer with the relation to this resource to > renderSubtreeToImage() manually to get texts working. Sounds a bit complicated > atm :-P Yeah, it's a bit involved. We need to fix SVG text renderers first, otherwhise there will be no clean solution available. 245380 4 krit 2010-07-01 09:18:11 -0700 Works in trunk. Closing bug. 41236 2009-10-15 11:10:16 -0700 2009-10-15 11:10:16 -0700 Mask with text mask3.svg image/svg+xml 302 krit PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgo8ZGVmcz4KPG1hc2sgaWQ9 Im0xIj4KPHRleHQgeD0iMTAiIHk9IjcwIiBzdHlsZT0iZm9udC1zaXplOjMwcHg7ZmlsbDp3aGl0 ZTsiPjx0c3Bhbj5NYXNrPC90c3Bhbj48L3RleHQ+CjwvbWFzaz4KPC9kZWZzPgo8cmVjdCB4PSIw IiB5PSIwIiB3aWR0aD0iMTIwIiBoZWlnaHQ9IjEyMCIgZmlsbD0iZ3JlZW4iLz4KPHJlY3QgeD0i MTAiIHk9IjEwIiB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0icmVkIiBtYXNrPSJ1cmwo I20xKSIgLz4KPC9zdmc+Cgo=