303746 2025-12-08 04:13:56 -0800 Improve readability of StyleLogicalHeight by adopting a switch on statement. 2026-02-19 23:12:36 -0800 1 1 1 Unclassified WebKit Tables WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=155919 InRadar P2 Normal --- 1 karlcow webkit-unassigned sam webkit-bug-importer zalan oldest_to_newest 2164091 0 karlcow 2025-12-08 04:13:56 -0800 See Sam Weining comment on https://github.com/WebKit/WebKit/pull/54635#discussion_r2583134648 Please consider using the switchOn() form here. While a bit more verbose, I think it ends up making things more clear. WTF::switchOn(styleLogicalHeight, [&](const Style::PreferredSize::Fixed& fixed) { ... }, [&](Style::IsPercentageOrCalc auto const& percentageOrCalc) { ... }, [&](const CSS::Keyword::FitContent&) { ... }, [&](const CSS::Keyword::WebkitFillAvailable&) { ... }, [&](const CSS::Keyword::MinContent&) { ... }, [&](const CSS::Keyword::MaxContent&) { ... }, [&](const CSS::Keyword::Intrinsic&) { ... }, [&](const CSS::Keyword::MinIntrinsic&) { ... }, [&](const CSS::Keyword::Auto&) { ... } ); 2165883 1 webkit-bug-importer 2025-12-15 04:14:11 -0800 <rdar://problem/166529986> 2183298 2 zakr 2026-02-19 23:12:36 -0800 Pull request: https://github.com/WebKit/WebKit/pull/59062