30374 2009-10-14 21:16:05 -0700 [GStreamer] Doesn't check if caps are valid in ::naturalSize() 2009-10-15 06:25:45 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 slomo webkit-unassigned commit-queue oldest_to_newest 154701 0 slomo 2009-10-14 21:16:05 -0700 ...which leads to assertions: GStreamer-CRITICAL **: gst_caps_is_fixed: assertion `GST_IS_CAPS (caps)' failed aborting... Attached trivial patch fixes this. 154702 1 41204 slomo 2009-10-14 21:18:10 -0700 Created attachment 41204 0003-Check-if-caps-are-valid-before-parsing-them.patch 154703 2 slomo 2009-10-14 21:18:39 -0700 Can be reproduced with http://people.freedesktop.org/~company/stuff/video-demo.html for example 154718 3 41209 slomo 2009-10-14 22:49:00 -0700 Created attachment 41209 0003-Check-if-caps-are-valid-before-parsing-them.patch Updated patch, we also need to check for *fixed* caps there. 154779 4 41209 commit-queue 2009-10-15 06:25:42 -0700 Comment on attachment 41209 0003-Check-if-caps-are-valid-before-parsing-them.patch Clearing flags on attachment: 41209 Committed r49622: <http://trac.webkit.org/changeset/49622> 154780 5 commit-queue 2009-10-15 06:25:45 -0700 All reviewed patches have been landed. Closing bug. 41204 2009-10-14 21:18:10 -0700 2009-10-14 22:49:00 -0700 0003-Check-if-caps-are-valid-before-parsing-them.patch 0003-Check-if-caps-are-valid-before-parsing-them.patch text/plain 2491 slomo RnJvbSBjZGQ5ZjY4YjRjYzliMzFjZjIyMjA4ZTdkY2UyNjI5NTc1NDYwMzliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2ViYXN0aWFuPTIwRHI9QzM9QjZnZT89IDxz ZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KRGF0ZTogVGh1LCAxNSBPY3QgMjAwOSAw NjoxNzozMCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMy8zXSBDaGVjayBpZiBjYXBzIGFyZSB2YWxp ZCBiZWZvcmUgcGFyc2luZyB0aGVtCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMDM3NAoKICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgogICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll clByaXZhdGU6OmR1cmF0aW9uKToKICAgICAgICBDaGVjayBpZiBjYXBzIGFyZSB2YWxpZCBiZWZv cmUgcGFyc2luZyB0aGVtIGluIDo6bmF0dXJhbFNpemUoKS4KICAgICAgICBUaGlzIHByZXZlbnRz IGFzc2VydGlvbnMgaWYgdGhlIG5hdHVyYWwgc2l6ZSBzaG91bGQgYmUgY2FsY3VsYXRlZAogICAg ICAgIGJlZm9yZSB0aGUgdmlkZW8gY2FwcyBhcmUgbmVnb3RpYXRlZC4KLS0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysr KysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAg IHwgICAgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDlkMDU1YjUuLjgzOWFjYTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMTQgIFNlYmFz dGlhbiBEcsO2Z2UgIDxzZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAzNzQKKyAgICAgICAgCisgICAgICAgIENoZWNrIGlm IGNhcHMgYXJlIHZhbGlkIGJlZm9yZSBwYXJzaW5nIHRoZW0KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpkdXJhdGlvbik6CisgICAgICAgIENoZWNrIGlm IGNhcHMgYXJlIHZhbGlkIGJlZm9yZSBwYXJzaW5nIHRoZW0gaW4gOjpuYXR1cmFsU2l6ZSgpLgor ICAgICAgICBUaGlzIHByZXZlbnRzIGFzc2VydGlvbnMgaWYgdGhlIG5hdHVyYWwgc2l6ZSBzaG91 bGQgYmUgY2FsY3VsYXRlZAorICAgICAgICBiZWZvcmUgdGhlIHZpZGVvIGNhcHMgYXJlIG5lZ290 aWF0ZWQuCisKIDIwMDktMTAtMTIgIFNlYmFzdGlhbiBEcsO2Z2UgIDxzZWJhc3RpYW4uZHJvZWdl QGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDdkM2QxZDMuLjc4NTRiYmQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMzMxLDcgKzMzMSw4IEBAIEludFNpemUgTWVkaWFQbGF5 ZXJQcml2YXRlOjpuYXR1cmFsU2l6ZSgpIGNvbnN0CiAgICAgICAgIGdmbG9hdCBwaXhlbEFzcGVj dFJhdGlvOwogICAgICAgICBnaW50IHBpeGVsQXNwZWN0UmF0aW9OdW1lcmF0b3IsIHBpeGVsQXNw ZWN0UmF0aW9EZW5vbWluYXRvcjsKIAotICAgICAgICBpZiAoIWdzdF92aWRlb19mb3JtYXRfcGFy c2VfY2FwcyhjYXBzLCBOVUxMLCAmd2lkdGgsICZoZWlnaHQpIHx8CisgICAgICAgIGlmICghR1NU X0lTX0NBUFMoY2FwcykgfHwKKwkgICAgIWdzdF92aWRlb19mb3JtYXRfcGFyc2VfY2FwcyhjYXBz LCBOVUxMLCAmd2lkdGgsICZoZWlnaHQpIHx8CiAgICAgICAgICAgICAhZ3N0X3ZpZGVvX3BhcnNl X2NhcHNfcGl4ZWxfYXNwZWN0X3JhdGlvKGNhcHMsICZwaXhlbEFzcGVjdFJhdGlvTnVtZXJhdG9y LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAmcGl4ZWxBc3BlY3RSYXRpb0Rlbm9taW5hdG9yKSkgewogICAgICAgICAgICAgZ3N0X29i amVjdF91bnJlZihHU1RfT0JKRUNUKHBhZCkpOwotLSAKMS42LjUKCg== 41209 2009-10-14 22:49:00 -0700 2009-10-15 06:25:41 -0700 0003-Check-if-caps-are-valid-before-parsing-them.patch 0003-Check-if-caps-are-valid-before-parsing-them.patch text/plain 2526 slomo RnJvbSA3ODE2MDdlZTkxNTkzODAzMzBmODBmMTE2MjU1OWIyMzcxYzQ0OGExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2ViYXN0aWFuPTIwRHI9QzM9QjZnZT89IDxz ZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KRGF0ZTogVGh1LCAxNSBPY3QgMjAwOSAw NjoxNzozMCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMy8zXSBDaGVjayBpZiBjYXBzIGFyZSB2YWxp ZCBiZWZvcmUgcGFyc2luZyB0aGVtCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMDM3NAoKICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgogICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll clByaXZhdGU6OmR1cmF0aW9uKToKICAgICAgICBDaGVjayBpZiBjYXBzIGFyZSB2YWxpZCBiZWZv cmUgcGFyc2luZyB0aGVtIGluIDo6bmF0dXJhbFNpemUoKS4KICAgICAgICBUaGlzIHByZXZlbnRz IGFzc2VydGlvbnMgaWYgdGhlIG5hdHVyYWwgc2l6ZSBzaG91bGQgYmUgY2FsY3VsYXRlZAogICAg ICAgIGJlZm9yZSB0aGUgdmlkZW8gY2FwcyBhcmUgbmVnb3RpYXRlZC4KLS0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysr KysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAg IHwgICAgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDlkMDU1YjUuLjgzOWFjYTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMTQgIFNlYmFz dGlhbiBEcsO2Z2UgIDxzZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAzNzQKKyAgICAgICAgCisgICAgICAgIENoZWNrIGlm IGNhcHMgYXJlIHZhbGlkIGJlZm9yZSBwYXJzaW5nIHRoZW0KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpkdXJhdGlvbik6CisgICAgICAgIENoZWNrIGlm IGNhcHMgYXJlIHZhbGlkIGJlZm9yZSBwYXJzaW5nIHRoZW0gaW4gOjpuYXR1cmFsU2l6ZSgpLgor ICAgICAgICBUaGlzIHByZXZlbnRzIGFzc2VydGlvbnMgaWYgdGhlIG5hdHVyYWwgc2l6ZSBzaG91 bGQgYmUgY2FsY3VsYXRlZAorICAgICAgICBiZWZvcmUgdGhlIHZpZGVvIGNhcHMgYXJlIG5lZ290 aWF0ZWQuCisKIDIwMDktMTAtMTIgIFNlYmFzdGlhbiBEcsO2Z2UgIDxzZWJhc3RpYW4uZHJvZWdl QGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDdkM2QxZDMuLjVkMGQ3YmIgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMzMxLDcgKzMzMSw4IEBAIEludFNpemUgTWVkaWFQbGF5 ZXJQcml2YXRlOjpuYXR1cmFsU2l6ZSgpIGNvbnN0CiAgICAgICAgIGdmbG9hdCBwaXhlbEFzcGVj dFJhdGlvOwogICAgICAgICBnaW50IHBpeGVsQXNwZWN0UmF0aW9OdW1lcmF0b3IsIHBpeGVsQXNw ZWN0UmF0aW9EZW5vbWluYXRvcjsKIAotICAgICAgICBpZiAoIWdzdF92aWRlb19mb3JtYXRfcGFy c2VfY2FwcyhjYXBzLCBOVUxMLCAmd2lkdGgsICZoZWlnaHQpIHx8CisgICAgICAgIGlmICghR1NU X0lTX0NBUFMoY2FwcykgfHwgIWdzdF9jYXBzX2lzX2ZpeGVkKGNhcHMpIHx8CisgICAgICAgICAg ICAhZ3N0X3ZpZGVvX2Zvcm1hdF9wYXJzZV9jYXBzKGNhcHMsIE5VTEwsICZ3aWR0aCwgJmhlaWdo dCkgfHwKICAgICAgICAgICAgICFnc3RfdmlkZW9fcGFyc2VfY2Fwc19waXhlbF9hc3BlY3RfcmF0 aW8oY2FwcywgJnBpeGVsQXNwZWN0UmF0aW9OdW1lcmF0b3IsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwaXhlbEFzcGVjdFJhdGlv RGVub21pbmF0b3IpKSB7CiAgICAgICAgICAgICBnc3Rfb2JqZWN0X3VucmVmKEdTVF9PQkpFQ1Qo cGFkKSk7Ci0tIAoxLjYuNQoK