30371 2009-10-14 20:04:35 -0700 Fix media controls rendering for Chromium Mac 2009-10-19 09:08:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 scherkus webkit-unassigned commit-queue eric.carlson eric fishd oldest_to_newest 154694 0 scherkus 2009-10-14 20:04:35 -0700 Boiled down to a GraphicsContextSkia vs. GraphicsContextCG difference with drawRect(). I wasn't drawing with a stroke so switching to fillRect() makes more sense anyway. 154696 1 41201 scherkus 2009-10-14 20:06:35 -0700 Created attachment 41201 Round 1 154855 2 eric 2009-10-15 11:59:00 -0700 It seems that whoever is the gardner needs to be warned about this patch. Sucks that CR test results are not stored @ webkit.org 154857 3 41201 eric 2009-10-15 11:59:33 -0700 Comment on attachment 41201 Round 1 I'm OK with this change. I don't think I should be the one to set cq+ though, since the gardner needs to know about this change before it happens. 154859 4 scherkus 2009-10-15 12:02:46 -0700 No fear!! Rebaseline is ready http://codereview.chromium.org/276041/show I'll ping the gardener 154868 5 eric 2009-10-15 12:49:57 -0700 I am cautious... I have been too oft (and too oft wrongly!) implicated in tree-breaking crimes involving WebKit! :) 155716 6 41201 yong.li.webkit 2009-10-19 08:58:48 -0700 Comment on attachment 41201 Round 1 Let commit bot land it 155724 7 41201 commit-queue 2009-10-19 09:08:29 -0700 Comment on attachment 41201 Round 1 Clearing flags on attachment: 41201 Committed r49787: <http://trac.webkit.org/changeset/49787> 155725 8 commit-queue 2009-10-19 09:08:33 -0700 All reviewed patches have been landed. Closing bug. 41201 2009-10-14 20:06:35 -0700 2009-10-19 09:08:29 -0700 Round 1 fillrect.patch text/plain 1317 scherkus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWRmZjJhZS4uZmRlYTY0OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0xNCAgQW5kcmV3IFNjaGVy a3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBmaWxsUmVjdCgpIGluc3RlYWQgb2YgZHJhd1JlY3Qo KSB0byBmaXggQ2hyb21pdW0gbWVkaWEgY29udHJvbHMgcmVuZGVyaW5nLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDM3MQorCisgICAgICAgIENo cm9taXVtIE1hYyBsYXlvdXQgdGVzdHMgd2lsbCBuZWVkIHRvIGJlIHJlYmFzZWxpbmVkLiAgRXhp c3RpbmcgbGF5b3V0IHRlc3RzIGZvciBMaW51eC9XaW4gc3RpbGwgcGFzcy4KKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6cGFpbnRNZWRpYVNsaWRlcik6IFVzZSBmaWxsUmVjdCgpIGluc3RlYWQgb2YgZHJhd1Jl Y3QoKS4KKwogMjAwOS0xMC0wMSAgWW9uZyBMaSAgPHlvbmcubGlAdG9yY2htb2JpbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlIFBldGVyc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFDb250cm9sc0Nocm9taXVtLmNwcCBiL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHAKaW5kZXggYmJhMmZhMi4uYjJm YWU1YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVkaWFDb250cm9sc0No cm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzQ2hy b21pdW0uY3BwCkBAIC0xMzgsNyArMTM4LDcgQEAgc3RhdGljIGJvb2wgcGFpbnRNZWRpYVNsaWRl cihSZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUmVuZGVyT2JqZWN0OjpQYWludEluZm8KICAg ICAgICAgY29udGV4dC0+c2F2ZSgpOwogICAgICAgICBjb250ZXh0LT5zZXRTdHJva2VTdHlsZShO b1N0cm9rZSk7CiAgICAgICAgIGNvbnRleHQtPnNldEZpbGxHcmFkaWVudChncmFkaWVudCk7Ci0g ICAgICAgIGNvbnRleHQtPmRyYXdSZWN0KGJ1ZmZlcmVkUmVjdCk7CisgICAgICAgIGNvbnRleHQt PmZpbGxSZWN0KGJ1ZmZlcmVkUmVjdCk7CiAgICAgICAgIGNvbnRleHQtPnJlc3RvcmUoKTsKICAg ICB9CiAK