30364 2009-10-14 11:30:21 -0700 GtkLauncher is using a deprecated signal 2009-10-15 10:04:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 jmillan webkit-unassigned eric jmillan xan.lopez oldest_to_newest 154618 0 jmillan 2009-10-14 11:30:21 -0700 GtkLauncher is using title-changed signal, which is deprecated ( http://webkitgtk.org/reference/index-deprecated.html ). 154620 1 41174 jmillan 2009-10-14 11:36:09 -0700 Created attachment 41174 GtkLauncher patch This patch changes the signal which GtkLoader uses to follow the page's title from title-changed to notify::title. It also makes GtkLoader not affected by bug #19843. 154644 2 jmillan 2009-10-14 13:26:46 -0700 Ups, GtkLauncher, not GtkLoader 154662 3 41174 jmalonzo 2009-10-14 15:03:10 -0700 Comment on attachment 41174 GtkLauncher patch r=me. 154664 4 41174 commit-queue 2009-10-14 15:16:45 -0700 Comment on attachment 41174 GtkLauncher patch Rejecting patch 41174 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11436 test cases. fast/css/opacity-float.html -> failed Exiting early after 1 failures. 5146 tests run. 238.99s total testing time 5145 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output 154738 5 xan.lopez 2009-10-15 00:36:52 -0700 Pushed this manually, r49611. 154827 6 eric 2009-10-15 10:04:37 -0700 It looks like this was a false rejection due to bug 30098. My apologies. 41174 2009-10-14 11:36:09 -0700 2009-10-14 15:16:45 -0700 GtkLauncher patch 20091014_gtkloader.patch text/plain 1906 jmillan SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5NTc0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMTQgIEpvc8OpIE1pbGzDoW4gU290 byAgPGptaWxsYW5AaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNb2RpZmllZCBHdGtMYXVuY2hlciB0byB1c2Ugbm90aWZ5Ojp0aXRs ZSBzaWduYWwgaW5zdGVhZCBvZgorICAgICAgICBkZXByZWNhdGVkIHRpdGxlLWNoYW5nZWQgc2ln bmFsCisKKyAgICAgICAgKiBHdGtMYXVuY2hlci9tYWluLmM6CisgICAgICAgIChub3RpZnlfdGl0 bGVfY2IpOgorICAgICAgICAoY3JlYXRlX2Jyb3dzZXIpOgorCiAyMDA5LTEwLTE0ICBCcmFkeSBF aWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vp bmlnLgpJbmRleDogV2ViS2l0VG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdFRvb2xzL0d0a0xhdW5jaGVyL21haW4uYwkocmV2aXNpb24gNDk1MDIpCisrKyBXZWJL aXRUb29scy9HdGtMYXVuY2hlci9tYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTY1LDExICs2NSwx MSBAQCBsaW5rX2hvdmVyX2NiIChXZWJLaXRXZWJWaWV3KiBwYWdlLCBjb25zCiB9CiAKIHN0YXRp YyB2b2lkCi10aXRsZV9jaGFuZ2VfY2IgKFdlYktpdFdlYlZpZXcqIHdlYl92aWV3LCBXZWJLaXRX ZWJGcmFtZSogd2ViX2ZyYW1lLCBjb25zdCBnY2hhciogdGl0bGUsIGdwb2ludGVyIGRhdGEpCitu b3RpZnlfdGl0bGVfY2IgKFdlYktpdFdlYlZpZXcqIHdlYl92aWV3LCBHUGFyYW1TcGVjKiBwc3Bl YywgZ3BvaW50ZXIgZGF0YSkKIHsKICAgICBpZiAobWFpbl90aXRsZSkKICAgICAgICAgZ19mcmVl IChtYWluX3RpdGxlKTsKLSAgICBtYWluX3RpdGxlID0gZ19zdHJkdXAgKHRpdGxlKTsKKyAgICBt YWluX3RpdGxlID0gZ19zdHJkdXAgKHdlYmtpdF93ZWJfdmlld19nZXRfdGl0bGUod2ViX3ZpZXcp KTsKICAgICB1cGRhdGVfdGl0bGUgKEdUS19XSU5ET1cgKG1haW5fd2luZG93KSk7CiB9CiAKQEAg LTExOCw3ICsxMTgsNyBAQCBjcmVhdGVfYnJvd3NlciAoKQogICAgIHdlYl92aWV3ID0gV0VCS0lU X1dFQl9WSUVXICh3ZWJraXRfd2ViX3ZpZXdfbmV3ICgpKTsKICAgICBndGtfY29udGFpbmVyX2Fk ZCAoR1RLX0NPTlRBSU5FUiAoc2Nyb2xsZWRfd2luZG93KSwgR1RLX1dJREdFVCAod2ViX3ZpZXcp KTsKIAotICAgIGdfc2lnbmFsX2Nvbm5lY3QgKHdlYl92aWV3LCAidGl0bGUtY2hhbmdlZCIsIEdf Q0FMTEJBQ0sgKHRpdGxlX2NoYW5nZV9jYiksIHdlYl92aWV3KTsKKyAgICBnX3NpZ25hbF9jb25u ZWN0ICh3ZWJfdmlldywgIm5vdGlmeTo6dGl0bGUiLCBHX0NBTExCQUNLIChub3RpZnlfdGl0bGVf Y2IpLCB3ZWJfdmlldyk7CiAgICAgZ19zaWduYWxfY29ubmVjdCAod2ViX3ZpZXcsICJub3RpZnk6 OmxvYWQtc3RhdHVzIiwgR19DQUxMQkFDSyAobm90aWZ5X2xvYWRfc3RhdHVzX2NiKSwgd2ViX3Zp ZXcpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QgKHdlYl92aWV3LCAibm90aWZ5Ojpwcm9ncmVzcyIs IEdfQ0FMTEJBQ0sgKG5vdGlmeV9wcm9ncmVzc19jYiksIHdlYl92aWV3KTsKICAgICBnX3NpZ25h bF9jb25uZWN0ICh3ZWJfdmlldywgImhvdmVyaW5nLW92ZXItbGluayIsIEdfQ0FMTEJBQ0sgKGxp bmtfaG92ZXJfY2IpLCB3ZWJfdmlldyk7Cg==