30334 2009-10-13 08:21:14 -0700 Collect scope properties only when they are needed for completion 2009-10-15 09:57:00 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys eric pfeldman timothy oldest_to_newest 154336 0 yurys 2009-10-13 08:21:14 -0700 Collect scope properties only when they are needed for completion. There is no need need to serialize and pass them proactively along with call frames. This way all code collecting completion properties will live in InjectedScript.js 154342 1 41104 yurys 2009-10-13 08:50:40 -0700 Created attachment 41104 patch 154344 2 pfeldman 2009-10-13 08:58:41 -0700 Looks good. Thanks for doing this! 154365 3 41104 commit-queue 2009-10-13 09:55:02 -0700 Comment on attachment 41104 patch Rejecting patch 41104 from review queue. pfeldman@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 154549 4 41104 commit-queue 2009-10-14 02:05:25 -0700 Comment on attachment 41104 patch Rejecting patch 41104 from review queue. pfeldman@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 154551 5 pfeldman 2009-10-14 02:17:41 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r49557 154822 6 eric 2009-10-15 09:57:00 -0700 I've restarted the commit-queue, so it should notice the updated commitsers.py and you shouldn't have troubles like this again. 41104 2009-10-13 08:50:40 -0700 2009-10-14 02:05:24 -0700 patch frame-completions.patch text/plain 5522 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmExMDE2OC4uNzFmMGJhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMC0xMyAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBEb24ndCBjb2xsZWN0IGNhbGwgZnJhbWUgcHJvcGVydGllcyB1 bnRpbCB0aGV5J3JlIG5lZWRlZCBmb3IgY29tcGxldGlvbi4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAzMzQKKworICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29s ZVZpZXcucHJvdG90eXBlLmNvbXBsZXRpb25zKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL0luamVjdGVkU2NyaXB0LmpzOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuZ2V0Q29tcGxl dGlvbnMpOiBpZiBjYWxsIGZyYW1lIGlkIGlzIHNwZWNpZmllZCBhbmQgdGhlIGV4cHJlc3Npb24g aXMgZW1wdHkgY29sbGVjdCBmcmFtZSBwcm9wZXJ0aWVzLgorICAgICAgICAoSW5qZWN0ZWRTY3Jp cHQuQ2FsbEZyYW1lUHJveHkucHJvdG90eXBlLl93cmFwU2NvcGVDaGFpbik6IGRvbid0IHNlbmQg Y2FsbCBmcmFtZSBwcm9wZXJ0aWVzIHVudGlsIHRoZXkncmUgbmVlZGVkLgorICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorCiAyMDA5LTEwLTEyICBDYW1lcm9u IE1jQ29ybWFjayAgPGNhbUBtY2MuaWQuYXU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT ZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZp ZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKaW5kZXgg Mzc4MmQzMi4uODA2OGFkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0NvbnNvbGVWaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xl Vmlldy5qcwpAQCAtMjkyLDE2ICsyOTIsNiBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJv dG90eXBlID0gewogICAgICAgICB2YXIgcmVwb3J0Q29tcGxldGlvbnMgPSB0aGlzLl9yZXBvcnRD b21wbGV0aW9ucy5iaW5kKHRoaXMsIGJlc3RNYXRjaE9ubHksIGNvbXBsZXRpb25zUmVhZHlDYWxs YmFjaywgZG90Tm90YXRpb24sIGJyYWNrZXROb3RhdGlvbiwgcHJlZml4KTsKICAgICAgICAgLy8g Q29sbGVjdCBjb21tYSBzZXBhcmF0ZWQgb2JqZWN0IHByb3BlcnRpZXMgZm9yIHRoZSBjb21wbGV0 aW9uLgogCi0gICAgICAgIGlmICghZXhwcmVzc2lvblN0cmluZykgewotICAgICAgICAgICAgaWYg KFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cyAmJiBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlw dHMucGF1c2VkKSB7Ci0gICAgICAgICAgICAgICAgLy8gRXZhbHVhdGUgaW50byBwcm9wZXJ0aWVz IGluIHNjb3BlIG9mIHRoZSBzZWxlY3RlZCBjYWxsIGZyYW1lLgotICAgICAgICAgICAgICAgIHJl cG9ydENvbXBsZXRpb25zKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy52YXJpYWJsZXNJblNl bGVjdGVkQ2FsbEZyYW1lKCkpOwotICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAg IH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgZXhwcmVzc2lvblN0cmluZyA9ICJ0aGlzIjsKLSAg ICAgICAgICAgIH0KLSAgICAgICAgfQotCiAgICAgICAgIHZhciBpbmNsdWRlSW5zcGVjdG9yQ29t bWFuZExpbmVBUEkgPSAoIWRvdE5vdGF0aW9uICYmICFicmFja2V0Tm90YXRpb24pOwogICAgICAg ICBpZiAoV2ViSW5zcGVjdG9yLnBhbmVscy5zY3JpcHRzICYmIFdlYkluc3BlY3Rvci5wYW5lbHMu c2NyaXB0cy5wYXVzZWQpCiAgICAgICAgICAgICB2YXIgY2FsbEZyYW1lSWQgPSBXZWJJbnNwZWN0 b3IucGFuZWxzLnNjcmlwdHMuc2VsZWN0ZWRDYWxsRnJhbWVJZCgpOwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCmluZGV4IDc1YzhjZWQuLjVkM2MwNDIg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5q cworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKQEAg LTUxNywxMiArNTE3LDI4IEBAIEluamVjdGVkU2NyaXB0LmdldENvbXBsZXRpb25zID0gZnVuY3Rp b24oZXhwcmVzc2lvbiwgaW5jbHVkZUluc3BlY3RvckNvbW1hbmRMaW5lCiAgICAgICAgICAgICB2 YXIgY2FsbEZyYW1lID0gSW5qZWN0ZWRTY3JpcHQuX2NhbGxGcmFtZUZvcklkKGNhbGxGcmFtZUlk KTsKICAgICAgICAgICAgIGlmICghY2FsbEZyYW1lKQogICAgICAgICAgICAgICAgIHJldHVybiBw cm9wczsKLSAgICAgICAgICAgIGV4cHJlc3Npb25SZXN1bHQgPSBJbmplY3RlZFNjcmlwdC5fZXZh bHVhdGVPbihjYWxsRnJhbWUuZXZhbHVhdGUsIGNhbGxGcmFtZSwgZXhwcmVzc2lvbik7CisgICAg ICAgICAgICBpZiAoZXhwcmVzc2lvbikKKyAgICAgICAgICAgICAgICBleHByZXNzaW9uUmVzdWx0 ID0gSW5qZWN0ZWRTY3JpcHQuX2V2YWx1YXRlT24oY2FsbEZyYW1lLmV2YWx1YXRlLCBjYWxsRnJh bWUsIGV4cHJlc3Npb24pOworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgLy8g RXZhbHVhdGUgaW50byBwcm9wZXJ0aWVzIGluIHNjb3BlIG9mIHRoZSBzZWxlY3RlZCBjYWxsIGZy YW1lLgorICAgICAgICAgICAgICAgIHZhciBzY29wZUNoYWluID0gY2FsbEZyYW1lLnNjb3BlQ2hh aW47CisgICAgICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBzY29wZUNoYWluLmxlbmd0 aDsgKytpKSB7CisgICAgICAgICAgICAgICAgICAgIHZhciBzY29wZU9iamVjdCA9IHNjb3BlQ2hh aW5baV07CisgICAgICAgICAgICAgICAgICAgIHRyeSB7CisgICAgICAgICAgICAgICAgICAgICAg ICBmb3IgKHZhciBwcm9wZXJ0eU5hbWUgaW4gc2NvcGVPYmplY3QpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcHJvcHNbcHJvcGVydHlOYW1lXSA9IHRydWU7CisgICAgICAgICAgICAgICAg ICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg IH0KKyAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGlmICghZXhw cmVzc2lvbikKKyAgICAgICAgICAgICAgICBleHByZXNzaW9uID0gInRoaXMiOwogICAgICAgICAg ICAgZXhwcmVzc2lvblJlc3VsdCA9IEluamVjdGVkU2NyaXB0Ll9ldmFsdWF0ZU9uKEluamVjdGVk U2NyaXB0Ll93aW5kb3coKS5ldmFsLCBJbmplY3RlZFNjcmlwdC5fd2luZG93KCksIGV4cHJlc3Np b24pOwogICAgICAgICB9Ci0gICAgICAgIGZvciAodmFyIHByb3AgaW4gZXhwcmVzc2lvblJlc3Vs dCkKLSAgICAgICAgICAgIHByb3BzW3Byb3BdID0gdHJ1ZTsKKyAgICAgICAgaWYgKGV4cHJlc3Np b25SZXN1bHQpCisgICAgICAgICAgICBmb3IgKHZhciBwcm9wIGluIGV4cHJlc3Npb25SZXN1bHQp CisgICAgICAgICAgICAgICAgcHJvcHNbcHJvcF0gPSB0cnVlOwogICAgICAgICBpZiAoaW5jbHVk ZUluc3BlY3RvckNvbW1hbmRMaW5lQVBJKQogICAgICAgICAgICAgZm9yICh2YXIgcHJvcCBpbiBJ bmplY3RlZFNjcmlwdC5fd2luZG93KCkuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJKQogICAgICAg ICAgICAgICAgIGlmIChwcm9wLmNoYXJBdCgwKSAhPT0gJ18nKQpAQCAtMTAzMiwxMiArMTA0OCw2 IEBAIEluamVjdGVkU2NyaXB0LkNhbGxGcmFtZVByb3h5LnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgICAgICBzY29wZU9iamVjdFByb3h5LmlzRG9jdW1lbnQgPSB0cnVlOwogICAgICAgICAgICAg ZWxzZSBpZiAoIWZvdW5kTG9jYWxTY29wZSkKICAgICAgICAgICAgICAgICBzY29wZU9iamVjdFBy b3h5LmlzV2l0aEJsb2NrID0gdHJ1ZTsKLSAgICAgICAgICAgIHNjb3BlT2JqZWN0UHJveHkucHJv cGVydGllcyA9IFtdOwotICAgICAgICAgICAgdHJ5IHsKLSAgICAgICAgICAgICAgICBmb3IgKHZh ciBwcm9wZXJ0eU5hbWUgaW4gc2NvcGVPYmplY3QpCi0gICAgICAgICAgICAgICAgICAgIHNjb3Bl T2JqZWN0UHJveHkucHJvcGVydGllcy5wdXNoKHByb3BlcnR5TmFtZSk7Ci0gICAgICAgICAgICB9 IGNhdGNoIChlKSB7Ci0gICAgICAgICAgICB9CiAgICAgICAgICAgICBzY29wZUNoYWluUHJveHku cHVzaChzY29wZU9iamVjdFByb3h5KTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gc2NvcGVD aGFpblByb3h5OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Njcmlw dHNQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMK aW5kZXggMDVlYzE5Ny4uNGFhMGFiMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv U2NyaXB0c1BhbmVsLmpzCkBAIC0zODgsMjIgKzM4OCw2IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRz UGFuZWwucHJvdG90eXBlID0gewogICAgICAgICBJbmplY3RlZFNjcmlwdEFjY2Vzcy5ldmFsdWF0 ZUluQ2FsbEZyYW1lKGNhbGxGcmFtZS5pZCwgY29kZSwgb2JqZWN0R3JvdXAsIGV2YWxDYWxsYmFj ayk7CiAgICAgfSwKIAotICAgIHZhcmlhYmxlc0luU2VsZWN0ZWRDYWxsRnJhbWU6IGZ1bmN0aW9u KCkKLSAgICB7Ci0gICAgICAgIHZhciBzZWxlY3RlZENhbGxGcmFtZSA9IHRoaXMuc2lkZWJhclBh bmVzLmNhbGxzdGFjay5zZWxlY3RlZENhbGxGcmFtZTsKLSAgICAgICAgaWYgKCF0aGlzLl9wYXVz ZWQgfHwgIXNlbGVjdGVkQ2FsbEZyYW1lKQotICAgICAgICAgICAgcmV0dXJuIHt9OwotCi0gICAg ICAgIHZhciByZXN1bHQgPSB7fTsKLSAgICAgICAgdmFyIHNjb3BlQ2hhaW4gPSBzZWxlY3RlZENh bGxGcmFtZS5zY29wZUNoYWluOwotICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHNjb3BlQ2hh aW4ubGVuZ3RoOyArK2kpIHsKLSAgICAgICAgICAgIHZhciBzY29wZU9iamVjdFByb3BlcnRpZXMg PSBzY29wZUNoYWluW2ldLnByb3BlcnRpZXM7Ci0gICAgICAgICAgICBmb3IgKHZhciBqID0gMDsg aiA8IHNjb3BlT2JqZWN0UHJvcGVydGllcy5sZW5ndGg7ICsraikKLSAgICAgICAgICAgICAgICBy ZXN1bHRbc2NvcGVPYmplY3RQcm9wZXJ0aWVzW2pdXSA9IHRydWU7Ci0gICAgICAgIH0KLSAgICAg ICAgcmV0dXJuIHJlc3VsdDsKLSAgICB9LAotCiAgICAgZGVidWdnZXJQYXVzZWQ6IGZ1bmN0aW9u KGNhbGxGcmFtZXMpCiAgICAgewogICAgICAgICB0aGlzLl9wYXVzZWQgPSB0cnVlOwo=