30320 2009-10-12 18:09:51 -0700 Chrome Linux RTL select box displays arrow on wrong side 2009-10-15 10:02:43 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan evan agl dimich eric tony oldest_to_newest 154225 0 evan 2009-10-12 18:09:51 -0700 See screenshot on http://code.google.com/p/chromium/issues/detail?id=23113 . The code is obviously wrong, and easy to fix. 154227 1 41077 evan 2009-10-12 18:16:56 -0700 Created attachment 41077 fixerate 154228 2 41077 evan 2009-10-12 18:17:20 -0700 Comment on attachment 41077 fixerate I'm not sure what I need to do about pixel baselines. Any advice? 154230 3 41079 evan 2009-10-12 18:18:41 -0700 Created attachment 41079 fixerate 154381 4 41115 evan 2009-10-13 11:35:38 -0700 Created attachment 41115 fix the bug and add a layout test 154382 5 evan 2009-10-13 11:38:52 -0700 Note that this test includes a .png baseline (for Mac) and some UTF-8 (for the Arabic text). Not sure those make it through the patch process. :( 154385 6 tony 2009-10-13 12:04:54 -0700 If you use svn-create-patch, it will base64 encode the png into the patch file. Maybe there's something that can do the same for git diffs? 154398 7 evan 2009-10-13 13:06:51 -0700 https://bugs.webkit.org/show_bug.cgi?id=26830 :~( 154413 8 41122 evan 2009-10-13 13:29:53 -0700 Created attachment 41122 fix the bug and note it's covered by an existing test 154414 9 41122 evan 2009-10-13 13:31:50 -0700 Comment on attachment 41122 fix the bug and note it's covered by an existing test I realized that another test actually exhibits the problem too -- the baseline (in the Chrome tree) is wrong. 154492 10 41122 commit-queue 2009-10-13 16:55:58 -0700 Comment on attachment 41122 fix the bug and note it's covered by an existing test Rejecting patch 41122 from review queue. dimich@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 154493 11 41122 dimich 2009-10-13 16:58:52 -0700 Comment on attachment 41122 fix the bug and note it's covered by an existing test Commit Bot has old version of committers.py... heh. Fixing up the flags, will land manually. 154499 12 evan 2009-10-13 17:21:13 -0700 I've seen committers add themselves to the commit bot script without review, too. 154509 13 dimich 2009-10-13 18:17:36 -0700 Landed: http://trac.webkit.org/changeset/49540 154826 14 41122 eric 2009-10-15 10:02:43 -0700 Comment on attachment 41122 fix the bug and note it's covered by an existing test I've restarted the commit-queue, so it should now correctly notice the update to committers.py and dimich@chromium.org should be able to set cq+ w/o problems. If you have any other issues, just drop me a line. 41077 2009-10-12 18:16:56 -0700 2009-10-12 18:18:39 -0700 fixerate bug-30320-20091012181655.patch text/plain 1235 evan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcnRsLXNlbGVjdC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9ydGwtc2VsZWN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uZjVkODFiNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvcnRsLXNlbGVjdC5odG1sCkBAIC0wLDAgKzEsMTUgQEAKKzxtZXRhIGNoYXJzZXQ9 dXRmLTg+Cis8Ym9keSBkaXI9cnRsPgorCis8ZGl2IGRpcj1sdHI+CitUaGlzIHBhZ2UgaXMgaW4g UlRMIG1vZGUgYW5kIGNvbnRhaW5zIGEgPGNvZGU+Jmx0O3NlbGVjdCZndDs8L2NvZGU+LjxwPgor CitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSA8Y29kZT4mbHQ7c2VsZWN0Jmd0OzwvY29kZT4gcmVu ZGVycyBwcm9wZXJseS4KKyhUaGUgZHJvcC1kb3duIGFycm93LCBpZiBhbnksIHNob3VsZCBub3Qg b3ZlcmxhcCB0aGUgdGV4dC4pPHA+Cis8L2Rpdj4KKworPHNlbGVjdD4KKzxvcHRpb24+2KzZhdmE INis2YXYp9mEPC9vcHRpb24+Cis8L3NlbGVjdD4KKworPC9ib2R5PgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCmluZGV4IDNhMzk0MjMuLmZiNDJiYjcg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNw cAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKQEAg LTU4NSw4ICs1ODUsOSBAQCBib29sIFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpwYWludE1lbnVM aXN0KFJlbmRlck9iamVjdCogbywgY29uc3QgUmVuZGVyT2JqZWN0OgogICAgIHBhaW50LnNldEFu dGlBbGlhcyh0cnVlKTsKICAgICBwYWludC5zZXRTdHlsZShTa1BhaW50OjprRmlsbF9TdHlsZSk7 CiAKKyAgICBpbnQgYXJyb3dYUG9zaXRpb24gPSAoby0+c3R5bGUoKS0+ZGlyZWN0aW9uKCkgPT0g UlRMKSA/IHJlY3QueCgpICsgNyA6IHJpZ2h0IC0gMTM7CiAgICAgU2tQYXRoIHBhdGg7Ci0gICAg cGF0aC5tb3ZlVG8ocmlnaHQgLSAxMywgbWlkZGxlIC0gMyk7CisgICAgcGF0aC5tb3ZlVG8oYXJy b3dYUG9zaXRpb24sIG1pZGRsZSAtIDMpOwogICAgIHBhdGguckxpbmVUbyg2LCAwKTsKICAgICBw YXRoLnJMaW5lVG8oLTMsIDYpOwogICAgIHBhdGguY2xvc2UoKTs= 41079 2009-10-12 18:18:41 -0700 2009-10-13 11:35:36 -0700 fixerate bug-30320-20091012181840.patch text/plain 1235 evan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcnRsLXNlbGVjdC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9ydGwtc2VsZWN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uZWY3ZmYwMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvcnRsLXNlbGVjdC5odG1sCkBAIC0wLDAgKzEsMTUgQEAKKzxtZXRhIGNoYXJzZXQ9 dXRmLTg+Cis8Ym9keSBkaXI9cnRsPgorCis8ZGl2IGRpcj1sdHI+CitUaGlzIHBhZ2UgaXMgaW4g UlRMIG1vZGUgYW5kIGNvbnRhaW5zIGEgPGNvZGU+Jmx0O3NlbGVjdCZndDs8L2NvZGU+LjxwPgor CitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSA8Y29kZT4mbHQ7c2VsZWN0Jmd0OzwvY29kZT4gcmVu ZGVycyBwcm9wZXJseS4KKyhUaGUgZHJvcC1kb3duIGFycm93LCBpZiBhbnksIHNob3VsZCBub3Qg b3ZlcmxhcCB0aGUgdGV4dC4pPHA+Cis8L2Rpdj4KKworPHNlbGVjdD4KKzxvcHRpb24+2KzZhdmE INis2YXZitmEPC9vcHRpb24+Cis8L3NlbGVjdD4KKworPC9ib2R5PgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCmluZGV4IDNhMzk0MjMuLmZiNDJiYjcg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNw cAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKQEAg LTU4NSw4ICs1ODUsOSBAQCBib29sIFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpwYWludE1lbnVM aXN0KFJlbmRlck9iamVjdCogbywgY29uc3QgUmVuZGVyT2JqZWN0OgogICAgIHBhaW50LnNldEFu dGlBbGlhcyh0cnVlKTsKICAgICBwYWludC5zZXRTdHlsZShTa1BhaW50OjprRmlsbF9TdHlsZSk7 CiAKKyAgICBpbnQgYXJyb3dYUG9zaXRpb24gPSAoby0+c3R5bGUoKS0+ZGlyZWN0aW9uKCkgPT0g UlRMKSA/IHJlY3QueCgpICsgNyA6IHJpZ2h0IC0gMTM7CiAgICAgU2tQYXRoIHBhdGg7Ci0gICAg cGF0aC5tb3ZlVG8ocmlnaHQgLSAxMywgbWlkZGxlIC0gMyk7CisgICAgcGF0aC5tb3ZlVG8oYXJy b3dYUG9zaXRpb24sIG1pZGRsZSAtIDMpOwogICAgIHBhdGguckxpbmVUbyg2LCAwKTsKICAgICBw YXRoLnJMaW5lVG8oLTMsIDYpOwogICAgIHBhdGguY2xvc2UoKTs= 41115 2009-10-13 11:35:38 -0700 2009-10-13 13:29:48 -0700 fix the bug and add a layout test bug-30320-20091013113537.patch text/plain 5116 evan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxNGUwNzg4Li5iYWQ0MDY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTAt MTMgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBjb250YWluaW5nIGFuIFJUTCA8c2Vs ZWN0PiB3aWRnZXQgdG8gdmVyaWZ5IHJlbmRlcmluZy4KKyAgICAgICAgCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDMyMAorCisgICAgICAgICogZmFz dC9mb3Jtcy9ydGwtc2VsZWN0Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9m YXN0L2Zvcm1zL3J0bC1zZWxlY3QtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAq IHBsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL3J0bC1zZWxlY3QtZXhwZWN0ZWQucG5nOiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9mb3Jtcy9ydGwtc2VsZWN0LWV4cGVjdGVkLnR4 dDogQWRkZWQuCisKIDIwMDktMTAtMDkgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkgRWlkc29uLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9ydGwtc2VsZWN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3J0bC1zZWxlY3QuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5l ZjdmZjAxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9ydGwtc2Vs ZWN0Lmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPG1ldGEgY2hhcnNldD11dGYtOD4KKzxib2R5IGRp cj1ydGw+CisKKzxkaXYgZGlyPWx0cj4KK1RoaXMgcGFnZSBpcyBpbiBSVEwgbW9kZSBhbmQgY29u dGFpbnMgYSA8Y29kZT4mbHQ7c2VsZWN0Jmd0OzwvY29kZT4uPHA+CisKK1RoaXMgdGVzdCBwYXNz ZXMgaWYgdGhlIDxjb2RlPiZsdDtzZWxlY3QmZ3Q7PC9jb2RlPiByZW5kZXJzIHByb3Blcmx5Lgor KFRoZSBkcm9wLWRvd24gYXJyb3csIGlmIGFueSwgc2hvdWxkIG5vdCBvdmVybGFwIHRoZSB0ZXh0 Lik8cD4KKzwvZGl2PgorCis8c2VsZWN0PgorPG9wdGlvbj7YrNmF2YQg2KzZhdmK2YQ8L29wdGlv bj4KKzwvc2VsZWN0PgorCis8L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC9mb3Jtcy9ydGwtc2VsZWN0LWV4cGVjdGVkLmNoZWNrc3VtIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvcnRsLXNlbGVjdC1leHBlY3RlZC5jaGVja3N1bQpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jMWYyNTIwCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvcnRsLXNlbGVjdC1leHBl Y3RlZC5jaGVja3N1bQpAQCAtMCwwICsxIEBACiswMTQ3OTU4Yjg0NWExMGVhZDA3MWI0Mzk4NzA1 MGVlYwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL3J0bC1zZWxlY3QtZXhwZWN0ZWQucG5nIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvcnRsLXNlbGVjdC1leHBlY3RlZC5wbmcKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOGQyODRlOQpCaW5hcnkgZmlsZXMgL2Rl di9udWxsIGFuZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL3J0bC1zZWxl Y3QtZXhwZWN0ZWQucG5nIGRpZmZlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2Zhc3QvZm9ybXMvcnRsLXNlbGVjdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvZmFzdC9mb3Jtcy9ydGwtc2VsZWN0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi41YTdlOTI5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvcnRsLXNlbGVjdC1leHBlY3RlZC50eHQKQEAg LTAsMCArMSwzMCBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcg YXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVu ZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JP RFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAorICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAs MCkgc2l6ZSA3ODR4NTIKKyAgICAgICAgUmVuZGVyQmxvY2sgKGFub255bW91cykgYXQgKDAsMCkg c2l6ZSA3ODR4MTgKKyAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAy NjR4MTgKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDI2NDogIlRoaXMgcGFn ZSBpcyBpbiBSVEwgbW9kZSBhbmQgY29udGFpbnMgYSAiCisgICAgICAgICAgUmVuZGVySW5saW5l IHtDT0RFfSBhdCAoMCwwKSBzaXplIDY0eDE1CisgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4 dH0gYXQgKDI2NCwyKSBzaXplIDY0eDE1CisgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgyNjQs Mikgd2lkdGggNjQ6ICI8c2VsZWN0PiIKKyAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQg KDMyOCwwKSBzaXplIDR4MTgKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgzMjgsMCkgd2lkdGgg NDogIi4iCisgICAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwzNCkgc2l6ZSA3ODR4MTgKKyAg ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAxMzd4MTgKKyAgICAgICAg ICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDEzNzogIlRoaXMgdGVzdCBwYXNzZXMgaWYgdGhl ICIKKyAgICAgICAgICBSZW5kZXJJbmxpbmUge0NPREV9IGF0ICgwLDApIHNpemUgNjR4MTUKKyAg ICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMTM3LDIpIHNpemUgNjR4MTUKKyAgICAg ICAgICAgICAgdGV4dCBydW4gYXQgKDEzNywyKSB3aWR0aCA2NDogIjxzZWxlY3Q+IgorICAgICAg ICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMjAxLDApIHNpemUgNDg4eDE4CisgICAgICAgICAg ICB0ZXh0IHJ1biBhdCAoMjAxLDApIHdpZHRoIDQ4ODogIiByZW5kZXJzIHByb3Blcmx5LiAoVGhl IGRyb3AtZG93biBhcnJvdywgaWYgYW55LCBzaG91bGQgbm90IG92ZXJsYXAgdGhlIHRleHQuKSIK KyAgICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDY4KSBzaXplIDc4NHgwCisgICAgICBSZW5k ZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoMCw2OCkgc2l6ZSA3ODR4MjIKKyAgICAgICAgUmVuZGVy TWVudUxpc3Qge1NFTEVDVH0gYXQgKDcxNSwyKSBzaXplIDY3eDE4IFtiZ2NvbG9yPSNGRkZGRkZd CisgICAgICAgICAgUmVuZGVyQmxvY2sgKGFub255bW91cykgYXQgKDAsMCkgc2l6ZSA2N3gxOAor ICAgICAgICAgICAgUmVuZGVyVGV4dCBhdCAoOCwyKSBzaXplIDM2eDEzCisgICAgICAgICAgICAg IHRleHQgcnVuIGF0ICg4LDIpIHdpZHRoIDM2IFJUTDogIlx4ezYyQ31ceHs2NDV9XHh7NjQ0fSBc eHs2MkN9XHh7NjQ1fVx4ezY0QX1ceHs2NDR9IgorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0g YXQgKDAsMCkgc2l6ZSAweDAKKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNp emUgMHgwCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDJjZTYzNTAuLjkzN2ZkMjEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMTMgIEV2YW4g TWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hyb21lJ3MgIlNraWEiIHRoZW1lIHBhaW50cyBzZWxlY3Qg Y29udHJvbHMgYmFja3dhcmRzIGluIFJUTC4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDMyMAorCisgICAgICAgIFRlc3Q6IGZhc3Qv Zm9ybXMvcnRsLXNlbGVjdC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVD aHJvbWl1bVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bVNr aWE6OnBhaW50TWVudUxpc3QpOgorCiAyMDA5LTEwLTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAgYi9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKaW5kZXggM2EzOTQyMy4uZmI0 MmJiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNr aWEuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNw cApAQCAtNTg1LDggKzU4NSw5IEBAIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OnBhaW50 TWVudUxpc3QoUmVuZGVyT2JqZWN0KiBvLCBjb25zdCBSZW5kZXJPYmplY3Q6CiAgICAgcGFpbnQu c2V0QW50aUFsaWFzKHRydWUpOwogICAgIHBhaW50LnNldFN0eWxlKFNrUGFpbnQ6OmtGaWxsX1N0 eWxlKTsKIAorICAgIGludCBhcnJvd1hQb3NpdGlvbiA9IChvLT5zdHlsZSgpLT5kaXJlY3Rpb24o KSA9PSBSVEwpID8gcmVjdC54KCkgKyA3IDogcmlnaHQgLSAxMzsKICAgICBTa1BhdGggcGF0aDsK LSAgICBwYXRoLm1vdmVUbyhyaWdodCAtIDEzLCBtaWRkbGUgLSAzKTsKKyAgICBwYXRoLm1vdmVU byhhcnJvd1hQb3NpdGlvbiwgbWlkZGxlIC0gMyk7CiAgICAgcGF0aC5yTGluZVRvKDYsIDApOwog ICAgIHBhdGguckxpbmVUbygtMywgNik7CiAgICAgcGF0aC5jbG9zZSgpOw== 41122 2009-10-13 13:29:53 -0700 2009-10-15 10:02:43 -0700 fix the bug and note it's covered by an existing test bug-30320-20091013132951.patch text/plain 1380 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmNlNjM1MC4uMjZiOTNlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0xMyAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDaHJvbWUncyAiU2tpYSIgdGhlbWUgcGFpbnRzIHNlbGVjdCBjb250cm9s cyBiYWNrd2FyZHMgaW4gUlRMLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMzIwCisKKyAgICAgICAgVGVzdDogZmFzdC90ZXh0L2lu dGVybmF0aW9uYWwvYmlkaS1tZW51bGlzdC5odG1sCisgICAgICAgIChUaGUgdGVzdCBpcyBhYm91 dCBzb21ldGhpbmcgZWxzZSwgYnV0IGl0IGluY2x1ZGVzIFJUTCBzZWxlY3RzLikKKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6cGFpbnRNZW51TGlzdCk6CisKIDIwMDktMTAt MDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q2hyb21pdW1Ta2lhLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1T a2lhLmNwcAppbmRleCAzYTM5NDIzLi5mYjQyYmI3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCkBAIC01ODUsOCArNTg1LDkgQEAgYm9vbCBSZW5k ZXJUaGVtZUNocm9taXVtU2tpYTo6cGFpbnRNZW51TGlzdChSZW5kZXJPYmplY3QqIG8sIGNvbnN0 IFJlbmRlck9iamVjdDoKICAgICBwYWludC5zZXRBbnRpQWxpYXModHJ1ZSk7CiAgICAgcGFpbnQu c2V0U3R5bGUoU2tQYWludDo6a0ZpbGxfU3R5bGUpOwogCisgICAgaW50IGFycm93WFBvc2l0aW9u ID0gKG8tPnN0eWxlKCktPmRpcmVjdGlvbigpID09IFJUTCkgPyByZWN0LngoKSArIDcgOiByaWdo dCAtIDEzOwogICAgIFNrUGF0aCBwYXRoOwotICAgIHBhdGgubW92ZVRvKHJpZ2h0IC0gMTMsIG1p ZGRsZSAtIDMpOworICAgIHBhdGgubW92ZVRvKGFycm93WFBvc2l0aW9uLCBtaWRkbGUgLSAzKTsK ICAgICBwYXRoLnJMaW5lVG8oNiwgMCk7CiAgICAgcGF0aC5yTGluZVRvKC0zLCA2KTsKICAgICBw YXRoLmNsb3NlKCk7