30316 2009-10-12 16:12:08 -0700 Build scripts: unchecked return value in call to system() 2009-10-14 14:41:11 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mseaborn webkit-unassigned commit-queue jorlow oldest_to_newest 154193 0 mseaborn 2009-10-12 16:12:08 -0700 gperf is invoked via system() in the Perl build script WebCore/css/makevalues.pl, but the return value is not checked. This means that if gperf is not installed, makevalues.pl will not fail properly and will produce incomplete output. This causes build errors later on, and installing gperf does not fix the build because the build system is not aware that makevalues.pl's dependencies have changed. There is a similar unchecked system() call in WebCore/css/makegrammar.pl. 154198 1 41066 mseaborn 2009-10-12 16:27:21 -0700 Created attachment 41066 Patch v1 154206 2 41068 mseaborn 2009-10-12 17:16:40 -0700 Created attachment 41068 Die if gperf fails 154657 3 41068 commit-queue 2009-10-14 14:41:08 -0700 Comment on attachment 41068 Die if gperf fails Clearing flags on attachment: 41068 Committed r49584: <http://trac.webkit.org/changeset/49584> 154658 4 commit-queue 2009-10-14 14:41:11 -0700 All reviewed patches have been landed. Closing bug. 41066 2009-10-12 16:27:21 -0700 2009-10-12 16:29:47 -0700 Patch v1 bug-30316-20091012162720.patch text/plain 2569 mseaborn PyAgICAgIGd0ay1kb2MubWFrZQo/ICAgICAgSU5TVEFMTAo/ICAgICAgUkVBRE1FCj8gICAgICBh dXRvdG9vbHNjb25maWcuaC5pbgo/ICAgICAgV2ViS2l0L2d0ay9kb2NzL0dOVW1ha2VmaWxlLmlu Cj8gICAgICBhdXRvdG9vbHMvZGVwY29tcAo/ICAgICAgYXV0b3Rvb2xzL2d0ay1kb2MubTQKPyAg ICAgIGF1dG90b29scy9jb21waWxlCj8gICAgICBhdXRvdG9vbHMvbWlzc2luZwo/ICAgICAgYXV0 b3Rvb2xzL2NvbmZpZy5ndWVzcwo/ICAgICAgYXV0b3Rvb2xzL2x0bWFpbi5zaAo/ICAgICAgYXV0 b3Rvb2xzL2NvbmZpZy5zdWIKPyAgICAgIGF1dG90b29scy9pbnN0YWxsLXNoCkluZGV4OiBXZWJD b3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24g NDk0NjEpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIw IEBACisyMDA5LTEwLTEyICBNYXJrIFNlYWJvcm4gIDxtc2VhYm9ybkBnb29nbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjaGVja3Mg Zm9yIGVycm9yIHJldHVybiB2YWx1ZXMgdG8gUGVybCBidWlsZCBzY3JpcHRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDMxNgorCisgICAgICAgIEZp eGVzIGEgY291cGxlIG9mIGNhbGxzIHRvIHN5c3RlbSgpIGluIFBlcmwgYnVpbGQgc2NyaXB0cyB0 byBjaGVjaworICAgICAgICByZXR1cm4gdmFsdWVzLiAgV2l0aG91dCB0aGVzZSBjaGVja3MsIGlm IGdwZXJmIG9yIGJpc29uIGFyZSBub3QKKyAgICAgICAgaW5zdGFsbGVkLCB0aGUgYnVpbGQgZmFp bHMgd2l0aCBlcnJvcnMgdGhhdCBkbyBub3QgbWFrZSBpdCBvYnZpb3VzCisgICAgICAgIHRoYXQg dGhlcmUgYXJlIG1pc3NpbmcgZGVwZW5kZW5jaWVzLgorCisgICAgICAgIE5vIHRlc3QgYmVjYXVz ZSB0aGlzIGlzIHBhcnQgb2YgdGhlIGJ1aWxkIHN5c3RlbS4KKworICAgICAgICAqIGNzcy9tYWtl Z3JhbW1hci5wbDogQWRkIGNoZWNrIHRvIGJpc29uIGludm9jYXRpb24uCisgICAgICAgICogY3Nz L21ha2V2YWx1ZXMucGw6IEFkZCBjaGVjayB0byBncGVyZiBpbnZvY2F0aW9uLgorCiAyMDA5LTEw LTEyICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvY3NzL21ha2VncmFtbWFyLnBsCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvY3NzL21ha2VncmFtbWFyLnBsCShyZXZpc2lvbiA0OTQ0MykKKysr IFdlYkNvcmUvY3NzL21ha2VncmFtbWFyLnBsCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw3ICsyNCw3 IEBAIHVzZSB3YXJuaW5nczsKIG15ICRncmFtbWFyID0gJEFSR1ZbMF07CiBteSAkZmlsZUJhc2Ug PSAkQVJHVlsxXTsKIAotc3lzdGVtKCJiaXNvbiAtZCAtcCBjc3N5eSAiIC4gJGdyYW1tYXIgLiAi IC1vICIgLiAkZmlsZUJhc2UgLiAiLnRhYi5jIik7CitzeXN0ZW0oImJpc29uIC1kIC1wIGNzc3l5 ICIgLiAkZ3JhbW1hciAuICIgLW8gIiAuICRmaWxlQmFzZSAuICIudGFiLmMiKSB8fCBkaWUgImNh bGxpbmcgYmlzb24gZmFpbGVkOiAkPyI7CiAKIG9wZW4gSEVBREVSLCAiPiIgLiAkZmlsZUJhc2Ug LiAiLmgiIG9yIGRpZTsKIHByaW50IEhFQURFUiA8PCAiRU9GIjsKSW5kZXg6IFdlYkNvcmUvY3Nz L21ha2V2YWx1ZXMucGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbAko cmV2aXNpb24gNDk0NDMpCisrKyBXZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBsCSh3b3JraW5nIGNv cHkpCkBAIC04Niw3ICs4Niw3IEBAIGNvbnN0IGNoYXIqIGdldFZhbHVlTmFtZSh1bnNpZ25lZCBz aG9ydCAKIEVPRgogY2xvc2UgSEVBREVSOwogCi1zeXN0ZW0oImdwZXJmIC1MIEFOU0ktQyAtRSAt QyAtbiAtbyAtdCAtLWtleS1wb3NpdGlvbnM9XCIqXCIgLU5maW5kVmFsdWUgLUhoYXNoX3ZhbCAt V3dvcmRsaXN0X3ZhbHVlIC1EIENTU1ZhbHVlS2V5d29yZHMuZ3BlcmYgPiBDU1NWYWx1ZUtleXdv cmRzLmMiKTsKK3N5c3RlbSgiZ3BlcmYgLUwgQU5TSS1DIC1FIC1DIC1uIC1vIC10IC0ta2V5LXBv c2l0aW9ucz1cIipcIiAtTmZpbmRWYWx1ZSAtSGhhc2hfdmFsIC1Xd29yZGxpc3RfdmFsdWUgLUQg Q1NTVmFsdWVLZXl3b3Jkcy5ncGVyZiA+IENTU1ZhbHVlS2V5d29yZHMuYyIpID09IDAgfHwgZGll ICJjYWxsaW5nIGdwZXJmIGZhaWxlZDogJD8iOwogCiBvcGVuIEMsICI+PkNTU1ZhbHVlS2V5d29y ZHMuYyIgfHwgZGllICJDb3VsZCBub3Qgb3BlbiBDU1NWYWx1ZUtleXdvcmRzLmMgZm9yIHdyaXRp bmciOwogcHJpbnQgQyAgInN0YXRpYyBjb25zdCBjaGFyICogY29uc3QgdmFsdWVMaXN0W10gPSB7 XG4iOw== 41068 2009-10-12 17:16:40 -0700 2009-10-14 14:41:08 -0700 Die if gperf fails webkit.patch text/plain 1264 mseaborn SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTQ4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMTIgIE1hcmsgU2VhYm9ybiAgPG1zZWFib3JuQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2hlY2sgZXJyb3IgcmV0dXJuIHZhbHVlIGluIFBlcmwgYnVpbGQgc2NyaXB0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDMxNgorCisgICAgICAgICog Y3NzL21ha2V2YWx1ZXMucGw6IERpZSBpZiBncGVyZiBmYWlscy4KKwogMjAwOS0xMC0xMiAgS2Vu bmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3JlL2Nzcy9tYWtldmFsdWVz LnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL21ha2V2YWx1ZXMucGwJKHJldmlzaW9uIDQ5 NDA1KQorKysgV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbAkod29ya2luZyBjb3B5KQpAQCAtODYs NyArODYsNyBAQAogRU9GCiBjbG9zZSBIRUFERVI7CiAKLXN5c3RlbSgiZ3BlcmYgLUwgQU5TSS1D IC1FIC1DIC1uIC1vIC10IC0ta2V5LXBvc2l0aW9ucz1cIipcIiAtTmZpbmRWYWx1ZSAtSGhhc2hf dmFsIC1Xd29yZGxpc3RfdmFsdWUgLUQgQ1NTVmFsdWVLZXl3b3Jkcy5ncGVyZiA+IENTU1ZhbHVl S2V5d29yZHMuYyIpOworc3lzdGVtKCJncGVyZiAtTCBBTlNJLUMgLUUgLUMgLW4gLW8gLXQgLS1r ZXktcG9zaXRpb25zPVwiKlwiIC1OZmluZFZhbHVlIC1IaGFzaF92YWwgLVd3b3JkbGlzdF92YWx1 ZSAtRCBDU1NWYWx1ZUtleXdvcmRzLmdwZXJmID4gQ1NTVmFsdWVLZXl3b3Jkcy5jIikgPT0gMCB8 fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7CiAKIG9wZW4gQywgIj4+Q1NTVmFsdWVL ZXl3b3Jkcy5jIiB8fCBkaWUgIkNvdWxkIG5vdCBvcGVuIENTU1ZhbHVlS2V5d29yZHMuYyBmb3Ig d3JpdGluZyI7CiBwcmludCBDICAic3RhdGljIGNvbnN0IGNoYXIgKiBjb25zdCB2YWx1ZUxpc3Rb XSA9IHtcbiI7Cg==