30307 2009-10-12 08:50:03 -0700 [GStreamer] Missing sentinel in g_object_set() call 2009-10-12 11:09:28 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 slomo webkit-unassigned commit-queue oldest_to_newest 154068 0 slomo 2009-10-12 08:50:03 -0700 [...] CXX WebCore/platform/graphics/gtk/libWebCore_la-DataSourceGStreamer.lo WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp: In function ‘gboolean webkit_data_src_uri_set_uri(GstURIHandler*, const gchar*)’: WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp:217: warning: missing sentinel in function call Problem is, that 0 is an integer and integers are passed as 32 bit values on x86-64 while the function expects a 64 bit 0 as sentinel. This will cause crashes and havoc. Attached trivial patch fixes this. 154072 1 41046 slomo 2009-10-12 08:55:21 -0700 Created attachment 41046 0001-Fix-0-sentinel-for-g_object_set-function-call.patch 154104 2 41046 gustavo 2009-10-12 10:49:26 -0700 Comment on attachment 41046 0001-Fix-0-sentinel-for-g_object_set-function-call.patch I'm not sure about the reasoning. I'm pretty sure gcc will complain about this, but I don't think we ever had a crash related to this. The patch is good, though. 154109 3 41046 commit-queue 2009-10-12 11:09:24 -0700 Comment on attachment 41046 0001-Fix-0-sentinel-for-g_object_set-function-call.patch Clearing flags on attachment: 41046 Committed r49445: <http://trac.webkit.org/changeset/49445> 154110 4 commit-queue 2009-10-12 11:09:28 -0700 All reviewed patches have been landed. Closing bug. 41046 2009-10-12 08:55:21 -0700 2009-10-12 11:09:24 -0700 0001-Fix-0-sentinel-for-g_object_set-function-call.patch 0001-Fix-0-sentinel-for-g_object_set-function-call.patch text/plain 2341 slomo RnJvbSBlYTE4ZGZiMTQyMjQ0Y2E5NWQxNTcyYjBhMWM4MmNiYThkZDUwM2MxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2ViYXN0aWFuPTIwRHI9QzM9QjZnZT89IDxz ZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KRGF0ZTogTW9uLCAxMiBPY3QgMjAwOSAx Nzo1NDowOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCAwIHNlbnRpbmVsIGZvciBnX29iamVj dF9zZXQoKSBmdW5jdGlvbiBjYWxsCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMDMwNwoKICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9EYXRh U291cmNlR1N0cmVhbWVyLmNwcDoKICAgICAgICAod2Via2l0X2RhdGFfc3JjX3VyaV9zZXRfdXJp KToKICAgICAgICAwIGlzIHBhc3NlZCBhcyAzMiBiaXQgdmFsdWUgb24geDg2LTY0IGluIHZhcmFy ZyBmdW5jdGlvbnMsIGJ1dAogICAgICAgIGdfb2JqZWN0X3NldCgpIGV4cGVjdHMgYSA2NCBiaXQg MC4gVGhpcyB3aWxsIGNhdXNlIGNyYXNoZXMuCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIC4uLi9wbGF0 Zm9ybS9ncmFwaGljcy9ndGsvRGF0YVNvdXJjZUdTdHJlYW1lci5jcHAgIHwgICAgMiArLQogMiBm aWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWU4NzEyZi4u OTFhNDNhYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0xMC0xMiAgU2ViYXN0aWFuIERyw7ZnZSAgPHNl YmFzdGlhbi5kcm9lZ2VAY29sbGFib3JhLmNvLnVrPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMDMwNworICAgICAgICAKKyAgICAgICAgRml4IDAgc2VudGluZWwgZm9yIGdfb2Jq ZWN0X3NldCgpIGZ1bmN0aW9uIGNhbGwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9n dGsvRGF0YVNvdXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgICh3ZWJraXRfZGF0YV9zcmNfdXJp X3NldF91cmkpOgorICAgICAgICAwIGlzIHBhc3NlZCBhcyAzMiBiaXQgdmFsdWUgb24geDg2LTY0 IGluIHZhcmFyZyBmdW5jdGlvbnMsIGJ1dAorICAgICAgICBnX29iamVjdF9zZXQoKSBleHBlY3Rz IGEgNjQgYml0IDAuIFRoaXMgd2lsbCBjYXVzZSBjcmFzaGVzLgorCisyMDA5LTEwLTEyICBTZWJh c3RpYW4gRHLDtmdlICA8c2ViYXN0aWFuLmRyb2VnZUBjb2xsYWJvcmEuY28udWs+CisKICAgICAg ICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTk5OApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ndGsvRGF0YVNvdXJjZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2d0ay9EYXRhU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCBhNmMyZGZiLi41 NjdkYTc0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9EYXRhU291 cmNlR1N0cmVhbWVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9EYXRh U291cmNlR1N0cmVhbWVyLmNwcApAQCAtMjE0LDcgKzIxNCw3IEBAIHN0YXRpYyBnYm9vbGVhbiB3 ZWJraXRfZGF0YV9zcmNfdXJpX3NldF91cmkoR3N0VVJJSGFuZGxlciogaGFuZGxlciwgY29uc3Qg Z2NoYXIqCiAgICAgICAgICAgICBHSW5wdXRTdHJlYW0qIHN0cmVhbSA9IGdfbWVtb3J5X2lucHV0 X3N0cmVhbV9uZXdfZnJvbV9kYXRhKGRlY29kZWRfZGF0YSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVjb2Rl ZF9zaXplLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBnX2ZyZWUpOwotICAgICAgICAgICAgZ19vYmplY3Rfc2V0 KHNyYy0+a2lkLCAic3RyZWFtIiwgc3RyZWFtLCAwKTsKKyAgICAgICAgICAgIGdfb2JqZWN0X3Nl dChzcmMtPmtpZCwgInN0cmVhbSIsIHN0cmVhbSwgTlVMTCk7CiAgICAgICAgICAgICBnX29iamVj dF91bnJlZihzdHJlYW0pOwogCiAgICAgICAgICAgICBpZiAoc3JjLT51cmkpIHsKLS0gCjEuNi40 LjMKCg==