30300 2009-10-12 02:45:10 -0700 Web Inspector: Enforce async interaction between inspector controller and frontend 2009-10-13 01:17:24 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman timothy oldest_to_newest 154011 0 pfeldman 2009-10-12 02:45:10 -0700 I think we should eliminate the possibility of reentering inspector controller code via frontend (this is actually important for layout tests harness to have no reenterability). It can be implemented in two ways: 1) wrap all calls to InspectorController within frontend with setTimeouted(0) or 2) wrap frontend's dispatch I think (2) is more appropriate at this moment. 154012 1 41027 pfeldman 2009-10-12 02:47:00 -0700 Created attachment 41027 patch 154096 2 41027 timothy 2009-10-12 10:15:18 -0700 Comment on attachment 41027 patch > + function delayDispatch() { Brace should be on new line. > + } > + setTimeout(delayDispatch, 0); Put a new line after the brace. 154294 3 pfeldman 2009-10-13 01:17:24 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r49493 41027 2009-10-12 02:47:00 -0700 2009-10-12 10:15:18 -0700 patch async text/plain 1431 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmUxNDA0Zi4uMjFiNmI0OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0xMiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBFbmZvcmNlIGFzeW5jIGludGVyYWN0 aW9uIGJldHdlZW4gaW5zcGVjdG9yIGNvbnRyb2xsZXIgYW5kIGZyb250ZW5kLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDMwMAorCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuZGlzcGF0Y2guZGVsYXlEaXNwYXRjaCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuZGlzcGF0 Y2gpOgorCiAyMDA5LTEwLTExICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanMKaW5kZXggNzY0NzNhYi4uNWViMmI2MSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC00ODYsNyArNDg2LDEzIEBAIHdpbmRvdy5hZGRF dmVudExpc3RlbmVyKCJsb2FkIiwgd2luZG93TG9hZGVkLCBmYWxzZSk7CiBXZWJJbnNwZWN0b3Iu ZGlzcGF0Y2ggPSBmdW5jdGlvbigpIHsKICAgICB2YXIgbWV0aG9kTmFtZSA9IGFyZ3VtZW50c1sw XTsKICAgICB2YXIgcGFyYW1ldGVycyA9IEFycmF5LnByb3RvdHlwZS5zbGljZS5jYWxsKGFyZ3Vt ZW50cywgMSk7Ci0gICAgV2ViSW5zcGVjdG9yW21ldGhvZE5hbWVdLmFwcGx5KHRoaXMsIHBhcmFt ZXRlcnMpOworCisgICAgLy8gV2UnZCBsaWtlIHRvIGVuZm9yY2UgYXN5bmNocm9ub3VzIGludGVy YWN0aW9uIGJldHdlZW4gdGhlIGluc3BlY3RvciBjb250cm9sbGVyIGFuZCB0aGUgZnJvbnRlbmQu CisgICAgLy8gVGhpcyBpcyBpbXBvcnRhbnQgdG8gTGF5b3V0VGVzdHMuCisgICAgZnVuY3Rpb24g ZGVsYXlEaXNwYXRjaCgpIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yW21ldGhvZE5hbWVdLmFwcGx5 KFdlYkluc3BlY3RvciwgcGFyYW1ldGVycyk7CisgICAgfQorICAgIHNldFRpbWVvdXQoZGVsYXlE aXNwYXRjaCwgMCk7CiB9CiAKIFdlYkluc3BlY3Rvci53aW5kb3dVbmxvYWQgPSBmdW5jdGlvbihl dmVudCkK