30299 2009-10-12 02:38:26 -0700 Fix profile grouping in the Profiles panel sidebar tree 2009-10-13 01:20:04 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 30253 0 apavlov webkit-unassigned pfeldman timothy oldest_to_newest 154009 0 apavlov 2009-10-12 02:38:26 -0700 Currently, grouping of the profiles with the same title is broken Test case: In the Console, enter the following series of commands: console.profile('foo') console.profileEnd() console.profile('foo') console.profileEnd() The second profile node becomes a child of the first one's in the sidebar tree, while they should both become children named "Run N" of a new common parent node named "foo". 154013 1 41028 apavlov 2009-10-12 02:47:35 -0700 Created attachment 41028 patch Use the right parent when adding a new group node to the sidebar tree. 154296 2 pfeldman 2009-10-13 01:20:04 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ProfilesPanel.js Committed r49494 41028 2009-10-12 02:47:35 -0700 2009-10-12 10:17:04 -0700 patch fixgroups.patch text/plain 1954 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmUxNDA0Zi4uNTM2ODdiMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0xMiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBzYW1lLW5hbWVkIHByb2ZpbGVzIGdyb3VwaW5nIGlu IHRoZSBQcm9maWxlcyBwYW5lbC4KKworICAgICAgICBUaGUgdHJlZSBub2RlIHJlLXBhcmVudGlu ZyB3aGlsZSBhZGRpbmcgYSBuZXcgZ3JvdXAgbm9kZSB3YXMgYnJva2VuLgorICAgICAgICAgCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDI5OQorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlLmFkZFByb2ZpbGUpOgorCiAyMDA5 LTEwLTExICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1Byb2ZpbGVzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmls ZXNQYW5lbC5qcwppbmRleCAzYmQ0NDY0Li5hYjIzZjFmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwpAQCAtMTgyLDEyICsxODIsMTIgQEAgV2ViSW5z cGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGdyb3Vw Ll9wcm9maWxlc1RyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5Qcm9maWxlR3JvdXBTaWRl YmFyVHJlZUVsZW1lbnQocHJvZmlsZS50aXRsZSk7CiAKICAgICAgICAgICAgICAgICAvLyBJbnNl cnQgYXQgdGhlIHNhbWUgaW5kZXggZm9yIHRoZSBmaXJzdCBwcm9maWxlIG9mIHRoZSBncm91cC4K LSAgICAgICAgICAgICAgICB2YXIgaW5kZXggPSB0aGlzLnNpZGViYXJUcmVlLmNoaWxkcmVuLmlu ZGV4T2YoZ3JvdXBbMF0uX3Byb2ZpbGVzVHJlZUVsZW1lbnQpOwotICAgICAgICAgICAgICAgIHRo aXMuc2lkZWJhclRyZWUuaW5zZXJ0Q2hpbGQoZ3JvdXAuX3Byb2ZpbGVzVHJlZUVsZW1lbnQsIGlu ZGV4KTsKKyAgICAgICAgICAgICAgICB2YXIgaW5kZXggPSBzaWRlYmFyUGFyZW50LmNoaWxkcmVu LmluZGV4T2YoZ3JvdXBbMF0uX3Byb2ZpbGVzVHJlZUVsZW1lbnQpOworICAgICAgICAgICAgICAg IHNpZGViYXJQYXJlbnQuaW5zZXJ0Q2hpbGQoZ3JvdXAuX3Byb2ZpbGVzVHJlZUVsZW1lbnQsIGlu ZGV4KTsKIAogICAgICAgICAgICAgICAgIC8vIE1vdmUgdGhlIGZpcnN0IHByb2ZpbGUgdG8gdGhl IGdyb3VwLgogICAgICAgICAgICAgICAgIHZhciBzZWxlY3RlZCA9IGdyb3VwWzBdLl9wcm9maWxl c1RyZWVFbGVtZW50LnNlbGVjdGVkOwotICAgICAgICAgICAgICAgIHRoaXMuc2lkZWJhclRyZWUu cmVtb3ZlQ2hpbGQoZ3JvdXBbMF0uX3Byb2ZpbGVzVHJlZUVsZW1lbnQpOworICAgICAgICAgICAg ICAgIHNpZGViYXJQYXJlbnQucmVtb3ZlQ2hpbGQoZ3JvdXBbMF0uX3Byb2ZpbGVzVHJlZUVsZW1l bnQpOwogICAgICAgICAgICAgICAgIGdyb3VwLl9wcm9maWxlc1RyZWVFbGVtZW50LmFwcGVuZENo aWxkKGdyb3VwWzBdLl9wcm9maWxlc1RyZWVFbGVtZW50KTsKICAgICAgICAgICAgICAgICBpZiAo c2VsZWN0ZWQpIHsKICAgICAgICAgICAgICAgICAgICAgZ3JvdXBbMF0uX3Byb2ZpbGVzVHJlZUVs ZW1lbnQuc2VsZWN0KCk7Cg==