30298 2009-10-12 02:01:53 -0700 Web Inspector: Use proper web view in inspector layout tests for windows. 2009-10-13 01:28:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman aroben timothy oldest_to_newest 154007 0 pfeldman 2009-10-12 02:01:53 -0700 Currently stub instance is being created instead of querying one from the frame. (I was going to submit it with the 'enable tests' change, but there is a blocking network-related issue there so I think it is worth submitting this independently). 154008 1 41026 pfeldman 2009-10-12 02:10:21 -0700 Created attachment 41026 patch 154151 2 pfeldman 2009-10-12 13:39:26 -0700 There are no changes to semantics there. I just did not wire it to the proper webview instance in the first place, was creating a dummy object instead. Now all pieces are in place and we are ready to enable tests. Tests now work in DRT mode on windows, so we are all set. (The application/octet-stream road block has been resolved by itself). 154242 3 41026 aroben 2009-10-12 20:02:22 -0700 Comment on attachment 41026 patch r=me 154298 4 pfeldman 2009-10-13 01:28:58 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp Committed r49496 41026 2009-10-12 02:10:21 -0700 2009-10-12 20:02:22 -0700 patch win_drt text/plain 2924 pfeldman ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkY2U2YzNlLi44MGIyZDE1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTAt MTIgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXNlIHBy b3BlciB3ZWIgdmlldyBpbiBpbnNwZWN0b3IgbGF5b3V0CisgICAgICAgIHRlc3RzIGZvciB3aW5k b3dzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MDI5OAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVy V2luLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzaG93V2ViSW5zcGVjdG9y KToKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpjbG9zZVdlYkluc3BlY3Rvcik6Cisg ICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZXZhbHVhdGVJbldlYkluc3BlY3Rvcik6CisK IDIwMDktMTAtMTEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLiAgQWRkIENvbGxpbiB0byBjb21taXR0ZXJzLnB5LgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVyV2luLmNwcCBi L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9MYXlvdXRUZXN0Q29udHJvbGxlcldpbi5j cHAKaW5kZXggZTkzMzhjZS4uYTIzMGZiMCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVyV2luLmNwcAorKysgYi9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRyb2xsZXJXaW4uY3BwCkBAIC04NzYs MzQgKzg3Niw0NiBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjphZGRVc2VyU3R5bGVTaGVl dChKU1N0cmluZ1JlZiBzb3VyY2UpCiAKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNob3dX ZWJJbnNwZWN0b3IoKQogewotICAgIENPTVB0cjxJV2ViVmlld1ByaXZhdGU+IHdlYlZpZXc7Ci0g ICAgaWYgKEZBSUxFRChXZWJLaXRDcmVhdGVJbnN0YW5jZShfX3V1aWRvZihXZWJWaWV3KSwgMCwg X191dWlkb2Yod2ViVmlldyksIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoqPigmd2ViVmlldykpKSkK KyAgICBDT01QdHI8SVdlYlZpZXc+IHdlYlZpZXc7CisgICAgaWYgKEZBSUxFRChmcmFtZS0+d2Vi Vmlldygmd2ViVmlldykpKQorICAgICAgICByZXR1cm47CisKKyAgICBDT01QdHI8SVdlYlZpZXdQ cml2YXRlPiB2aWV3UHJpdmF0ZShRdWVyeSwgd2ViVmlldyk7CisgICAgaWYgKCF2aWV3UHJpdmF0 ZSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQ09NUHRyPElXZWJJbnNwZWN0b3I+IGluc3BlY3Rv cjsKLSAgICBpZiAoU1VDQ0VFREVEKHdlYlZpZXctPmluc3BlY3RvcigmaW5zcGVjdG9yKSkpCisg ICAgaWYgKFNVQ0NFRURFRCh2aWV3UHJpdmF0ZS0+aW5zcGVjdG9yKCZpbnNwZWN0b3IpKSkKICAg ICAgICAgaW5zcGVjdG9yLT5zaG93KCk7CiB9CiAKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6 OmNsb3NlV2ViSW5zcGVjdG9yKCkKIHsKLSAgICBDT01QdHI8SVdlYlZpZXdQcml2YXRlPiB3ZWJW aWV3OwotICAgIGlmIChGQUlMRUQoV2ViS2l0Q3JlYXRlSW5zdGFuY2UoX191dWlkb2YoV2ViVmll dyksIDAsIF9fdXVpZG9mKHdlYlZpZXcpLCByZWludGVycHJldF9jYXN0PHZvaWQqKj4oJndlYlZp ZXcpKSkpCisgICAgQ09NUHRyPElXZWJWaWV3PiB3ZWJWaWV3OworICAgIGlmIChGQUlMRUQoZnJh bWUtPndlYlZpZXcoJndlYlZpZXcpKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgQ09NUHRyPElX ZWJWaWV3UHJpdmF0ZT4gdmlld1ByaXZhdGUoUXVlcnksIHdlYlZpZXcpOworICAgIGlmICghdmll d1ByaXZhdGUpCiAgICAgICAgIHJldHVybjsKIAogICAgIENPTVB0cjxJV2ViSW5zcGVjdG9yPiBp bnNwZWN0b3I7Ci0gICAgaWYgKFNVQ0NFRURFRCh3ZWJWaWV3LT5pbnNwZWN0b3IoJmluc3BlY3Rv cikpKQorICAgIGlmIChTVUNDRUVERUQodmlld1ByaXZhdGUtPmluc3BlY3RvcigmaW5zcGVjdG9y KSkpCiAgICAgICAgIGluc3BlY3Rvci0+Y2xvc2UoKTsKIH0KIAogdm9pZCBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6ZXZhbHVhdGVJbldlYkluc3BlY3Rvcihsb25nIGNhbGxJZCwgSlNTdHJpbmdSZWYg c2NyaXB0KQogewotICAgIENPTVB0cjxJV2ViVmlld1ByaXZhdGU+IHdlYlZpZXc7Ci0gICAgaWYg KEZBSUxFRChXZWJLaXRDcmVhdGVJbnN0YW5jZShfX3V1aWRvZihXZWJWaWV3KSwgMCwgX191dWlk b2Yod2ViVmlldyksIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoqPigmd2ViVmlldykpKSkKKyAgICBD T01QdHI8SVdlYlZpZXc+IHdlYlZpZXc7CisgICAgaWYgKEZBSUxFRChmcmFtZS0+d2ViVmlldygm d2ViVmlldykpKQorICAgICAgICByZXR1cm47CisKKyAgICBDT01QdHI8SVdlYlZpZXdQcml2YXRl PiB2aWV3UHJpdmF0ZShRdWVyeSwgd2ViVmlldyk7CisgICAgaWYgKCF2aWV3UHJpdmF0ZSkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgQ09NUHRyPElXZWJJbnNwZWN0b3I+IGluc3BlY3RvcjsKLSAg ICBpZiAoRkFJTEVEKHdlYlZpZXctPmluc3BlY3RvcigmaW5zcGVjdG9yKSkpCisgICAgaWYgKEZB SUxFRCh2aWV3UHJpdmF0ZS0+aW5zcGVjdG9yKCZpbnNwZWN0b3IpKSkKICAgICAgICAgcmV0dXJu OwogCiAgICAgQ09NUHRyPElXZWJJbnNwZWN0b3JQcml2YXRlPiBpbnNwZWN0b3JQcml2YXRlKFF1 ZXJ5LCBpbnNwZWN0b3IpOwo=