30297 2009-10-12 00:04:55 -0700 SVG - crash on feMerge when input not available 2014-05-12 05:54:35 -0700 1 1 1 Unclassified WebKit SVG 525.x (Safari 3.1) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 68469 26389 1 krit webkit-unassigned jeffschiller oldest_to_newest 153996 0 krit 2009-10-12 00:04:55 -0700 SVG - crash on feMerge when input not available 153997 1 41020 krit 2009-10-12 00:11:02 -0700 Created attachment 41020 fix for feMerge if one effect doesn't exist fix for feMerge if one effect doesn't exist. I'll create test results at home. 154047 2 41020 eric 2009-10-12 07:06:59 -0700 Comment on attachment 41020 fix for feMerge if one effect doesn't exist The change and test looks fine. But it looks like you need layout test results. Please add results and update the ChangeLog accordingly before landing. 154048 3 41020 eric 2009-10-12 07:08:06 -0700 Comment on attachment 41020 fix for feMerge if one effect doesn't exist Also, ideally the test case woudl make clear that it's just not supposed to crash. Probably a comment in the SVG file woudl help. Adding text to the SVG file would make the results platform specific. You could also add a 100x100 green square to the SVG, so that people looking at it visually would know that it passes. 154162 4 krit 2009-10-12 14:20:50 -0700 landed in r49472. 41020 2009-10-12 00:11:02 -0700 2009-10-12 07:08:06 -0700 fix for feMerge if one effect doesn't exist feMerge-fix.patch text/plain 2457 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTQzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMTEgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVkcg LSBjcmFzaCBvbiBmZU1lcmdlIHdoZW4gaW5wdXQgbm90IGF2YWlsYWJsZQorICAgICAgICBbaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMjk3XQorCisgICAgICAgIE1h a2UgYSBlYXJseSByZXR1cm4gaW4gU1ZHRkVNZXJnZUVsZW1lbnQgaWYgdGhlIG5lZWRlZAorICAg ICAgICBmaWx0ZXIgZWZmZWN0IGRvZXNuJ3QgZXhpc3QuCisKKyAgICAgICAgVGVzdDogc3ZnL2Zp bHRlcnMvZmVNZXJnZS13cm9uZy1pbnB1dC5zdmcKKworICAgICAgICAqIHN2Zy9TVkdGRU1lcmdl RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdGRU1lcmdlRWxlbWVudDo6YnVpbGQp OgorCiAyMDA5LTEwLTExICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9zdmcvU1ZHRkVNZXJn ZUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3ZnL1NWR0ZFTWVyZ2VFbGVtZW50 LmNwcAkocmV2aXNpb24gNDk0MDEpCisrKyBXZWJDb3JlL3N2Zy9TVkdGRU1lcmdlRWxlbWVudC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDYgKzQ1LDggQEAgYm9vbCBTVkdGRU1lcmdlRWxlbWVu dDo6YnVpbGQoU1ZHUmVzb3VyYwogICAgIGZvciAoTm9kZSogbiA9IGZpcnN0Q2hpbGQoKTsgbiAh PSAwOyBuID0gbi0+bmV4dFNpYmxpbmcoKSkgewogICAgICAgICBpZiAobi0+aGFzVGFnTmFtZShT VkdOYW1lczo6ZmVNZXJnZU5vZGVUYWcpKSB7CiAgICAgICAgICAgICBGaWx0ZXJFZmZlY3QqIG1l cmdlRWZmZWN0ID0gZmlsdGVyUmVzb3VyY2UtPmJ1aWxkZXIoKS0+Z2V0RWZmZWN0QnlJZChzdGF0 aWNfY2FzdDxTVkdGRU1lcmdlTm9kZUVsZW1lbnQqPihuKS0+aW4xKCkpOworICAgICAgICAgICAg aWYgKCFtZXJnZUVmZmVjdCkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAg ICAgICBtZXJnZUlucHV0cy5hcHBlbmQobWVyZ2VFZmZlY3QpOwogICAgICAgICB9CiAgICAgfQpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gNDk0MzQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0xMC0xMSAgRGlyayBTY2h1bHplICA8a3Jp dEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGZlTWVyZ2VOb2QgaGFzIGEgcmVmZXJlbmNlIHRvIGFuIGVmZmVjdCB0aGF0IGRvZXNu J3QgZXhpc3QuIFRoaXMgdGVzdCB3aWxsCisgICAgICAgIGNoZWNrIGlmIFNWR0ZFTWVyZ2VFbGVt ZW50IGhhbmRsZXMgdGhpcyBjb3JyZWN0bHkgYW5kIHN0b3BzIHRoZSBmaWx0ZXIgcHJvY2Vzcy4K KworICAgICAgICAqIHN2Zy9maWx0ZXJzL2ZlTWVyZ2Utd3JvbmctaW5wdXQuc3ZnOiBBZGRlZC4K KwogMjAwOS0xMC0xMSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9maWx0ZXJz L2ZlTWVyZ2Utd3JvbmctaW5wdXQuc3ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9m aWx0ZXJzL2ZlTWVyZ2Utd3JvbmctaW5wdXQuc3ZnCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvc3ZnL2ZpbHRlcnMvZmVNZXJnZS13cm9uZy1pbnB1dC5zdmcJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMTAgQEAKKzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KKzxk ZWZzPgorPGZpbHRlciBpZD0iZmlsdGVyIiBwcmltaXRpdmVVbml0cz0ib2JqZWN0Qm91bmRpbmdC b3giPgorPGZlTWVyZ2U+Cis8ZmVNZXJnZU5vZGUgaW49ImRvZXMtbm90LWV4aXN0Ii8+Cis8L2Zl TWVyZ2U+Cis8L2ZpbHRlcj4KKzwvZGVmcz4KKzxnIGZpbHRlcj0idXJsKCNmaWx0ZXIpIi8+Cis8 L3N2Zz4K