30296 2009-10-11 21:22:59 -0700 [Qt] Add some initial autotests for QWebPage's ErrorPageExtention 2009-10-15 10:18:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 tonikitoo tonikitoo hausmann oldest_to_newest 153990 0 tonikitoo 2009-10-11 21:22:59 -0700 i just came up w/ some basic auto tests for errorpage extension. At this iteraction the autotest just sets an error page, checks if it is what is shown afterwards and if back/forward history is in the right state after the error handling. ps: i have noticed some problems w/ back/forward history that i will cover in another bug. 153991 1 41018 tonikitoo 2009-10-11 21:30:29 -0700 Created attachment 41018 landed in r49498 - patch 0.1 - error page extension 154266 2 41018 hausmann 2009-10-12 22:29:43 -0700 Comment on attachment 41018 landed in r49498 - patch 0.1 - error page extension r=me > + ErrorPage(QWidget *parent = 0): QWebPage(parent) Please fix the * position before landing. Thanks for adding this test! 154313 3 tonikitoo 2009-10-13 04:36:24 -0700 (In reply to comment #2) > (From update of attachment 41018 [details]) > r=me > > > + ErrorPage(QWidget *parent = 0): QWebPage(parent) > > Please fix the * position before landing. > > Thanks for adding this test! thx simon, landed in r49498 154833 4 41018 tonikitoo 2009-10-15 10:18:51 -0700 Comment on attachment 41018 landed in r49498 - patch 0.1 - error page extension clearing r+ flag since patch has landed 41018 2009-10-11 21:30:29 -0700 2009-10-15 10:18:51 -0700 landed in r49498 - patch 0.1 - error page extension 0001--Qt-Add-some-initial-autotests-for-QWebPage-s-Error.patch text/plain 3565 tonikitoo RnJvbSAwN2RmZjdkYmZmOGViYWY4MmE5ZjcxZmNhOTA1YThlNWYwZGUzZGZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAxMiBPY3QgMjAwOSAwMDoyNTowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gQWRkIHNvbWUgaW5pdGlhbCBhdXRvdGVzdHMgZm9yIFFXZWJQYWdlJ3MgRXJyb3JQYWdlRXh0 ZW50aW9uCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAyOTYKClBh dGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPiBvbiAyMDA5LTEwLTEx ClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBh Z2UuY3BwOgooRXJyb3JQYWdlOjpFcnJvclBhZ2UpOgooRXJyb3JQYWdlOjpzdXBwb3J0c0V4dGVu c2lvbik6CihFcnJvclBhZ2U6OmV4dGVuc2lvbik6Cih0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4 dGVuc2lvbik6Ci0tLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg fCAgIDEzICsrKysrKysKIFdlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3Bw IHwgICA1MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA2 MyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9D aGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDhhNWE0MzAuLmFkNWM4YjkgMTAw NjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDA5LTEwLTExICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBBZGQgc29tZSBpbml0aWFsIGF1dG90ZXN0cyBmb3IgUVdlYlBhZ2UncyBFcnJvclBh Z2VFeHRlbnRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMwMjk2CisKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOgor ICAgICAgICAoRXJyb3JQYWdlOjpFcnJvclBhZ2UpOgorICAgICAgICAoRXJyb3JQYWdlOjpzdXBw b3J0c0V4dGVuc2lvbik6CisgICAgICAgIChFcnJvclBhZ2U6OmV4dGVuc2lvbik6CisgICAgICAg ICh0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbik6CisKIDIwMDktMTAtMDggIEFudG9u aW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3Rf cXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAK aW5kZXggYTlmOWYxNi4uMTYxMGUzNCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJw YWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9x d2VicGFnZS5jcHAKQEAgLTExNiw2ICsxMTYsNyBAQCBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQg dGVzdEVuYWJsZVBlcnNpc3RlbnRTdG9yYWdlKCk7CiAgICAgdm9pZCBjb25zb2xlT3V0cHV0KCk7 CiAgICAgdm9pZCBpbnB1dE1ldGhvZHMoKTsKKyAgICB2b2lkIGVycm9yUGFnZUV4dGVuc2lvbigp OwogCiAgICAgdm9pZCBjcmFzaFRlc3RzX0xhenlJbml0aWFsaXphdGlvbk9mTWFpbkZyYW1lKCk7 CiAKQEAgLTE0MDAsNiArMTQwMSw1NSBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6dGVzdEVuYWJsZVBl cnNpc3RlbnRTdG9yYWdlKCkKICAgICBRVkVSSUZZKCF3ZWJQYWdlLnNldHRpbmdzKCktPmljb25E YXRhYmFzZVBhdGgoKS5pc0VtcHR5KCkpOwogfQogCitjbGFzcyBFcnJvclBhZ2UgOiBwdWJsaWMg UVdlYlBhZ2UKK3sKK3B1YmxpYzoKKworICAgIEVycm9yUGFnZShRV2lkZ2V0ICpwYXJlbnQgPSAw KTogUVdlYlBhZ2UocGFyZW50KQorICAgIHsKKyAgICB9CisKKyAgICB2aXJ0dWFsIGJvb2wgc3Vw cG9ydHNFeHRlbnNpb24oRXh0ZW5zaW9uIGV4dGVuc2lvbikgY29uc3QKKyAgICB7CisgICAgICAg IHJldHVybiBleHRlbnNpb24gPT0gRXJyb3JQYWdlRXh0ZW5zaW9uOworICAgIH0KKworICAgIHZp cnR1YWwgYm9vbCBleHRlbnNpb24oRXh0ZW5zaW9uLCBjb25zdCBFeHRlbnNpb25PcHRpb24gKm9w dGlvbiwgRXh0ZW5zaW9uUmV0dXJuICpvdXRwdXQpCisgICAgeworICAgICAgICBjb25zdCBFcnJv clBhZ2VFeHRlbnNpb25PcHRpb24qIGluZm8gPSBzdGF0aWNfY2FzdDxjb25zdCBFcnJvclBhZ2VF eHRlbnNpb25PcHRpb24qPihvcHRpb24pOworICAgICAgICBFcnJvclBhZ2VFeHRlbnNpb25SZXR1 cm4qIGVycm9yUGFnZSA9IHN0YXRpY19jYXN0PEVycm9yUGFnZUV4dGVuc2lvblJldHVybio+KG91 dHB1dCk7CisKKyAgICAgICAgaWYgKGluZm8tPmZyYW1lID09IG1haW5GcmFtZSgpKSB7CisgICAg ICAgICAgICBlcnJvclBhZ2UtPmNvbnRlbnQgPSAiZGF0YTp0ZXh0L2h0bWwsZXJyb3IiOworICAg ICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgfQorfTsKKwordm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbigpCit7 CisgICAgRXJyb3JQYWdlKiBwYWdlID0gbmV3IEVycm9yUGFnZTsKKyAgICBtX3ZpZXctPnNldFBh Z2UocGFnZSk7CisKKyAgICBRU2lnbmFsU3B5IHNweUxvYWRGaW5pc2hlZChtX3ZpZXcsIFNJR05B TChsb2FkRmluaXNoZWQoYm9vbCkpKTsKKworICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5sb2FkKFFV cmwoInFyYzovLy9mcmFtZXRlc3QvaW5kZXguaHRtbCIpKTsKKyAgICBRVFJZX0NPTVBBUkUoc3B5 TG9hZEZpbmlzaGVkLmNvdW50KCksIDEpOworCisgICAgcGFnZS0+bWFpbkZyYW1lKCktPnNldFVy bChRVXJsKCJodHRwOi8vbm9uLmV4aXN0ZW50L3VybCIpKTsKKyAgICBRVGVzdDo6cVdhaXQoMjAw MCk7CisgICAgUVRSWV9DT01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAyKTsKKyAgICBR Q09NUEFSRShwYWdlLT5tYWluRnJhbWUoKS0+dG9QbGFpblRleHQoKSwgUVN0cmluZygiZGF0YTp0 ZXh0L2h0bWwsZXJyb3IiKSk7CisgICAgUUNPTVBBUkUocGFnZS0+aGlzdG9yeSgpLT5jb3VudCgp LCAyKTsKKyAgICBRQ09NUEFSRShwYWdlLT5oaXN0b3J5KCktPmN1cnJlbnRJdGVtKCkudXJsKCks IFFVcmwoImh0dHA6Ly9ub24uZXhpc3RlbnQvdXJsIikpOworICAgIFFDT01QQVJFKHBhZ2UtPmhp c3RvcnkoKS0+Y2FuR29CYWNrKCksIHRydWUpOworICAgIFFDT01QQVJFKHBhZ2UtPmhpc3Rvcnko KS0+Y2FuR29Gb3J3YXJkKCksIGZhbHNlKTsKKworICAgIG1fdmlldy0+c2V0UGFnZSgwKTsKK30K Kwogdm9pZCB0c3RfUVdlYlBhZ2U6OmNyYXNoVGVzdHNfTGF6eUluaXRpYWxpemF0aW9uT2ZNYWlu RnJhbWUoKQogewogICAgIHsKLS0gCjEuNi4wLjQKCg==