30294 2009-10-11 19:57:54 -0700 [V8] Revision 49420 breaks V8 bindings adding CanvasActiveInfo 2009-10-11 20:30:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 dominicc webkit-unassigned commit-queue dglazkov oldest_to_newest 153962 0 dominicc 2009-10-11 19:57:54 -0700 Revision 49420 <http://build.chromium.org/buildbot/waterfall.fyi/changes/3610> adds an IDL-defined CanvasActiveInfo type and a couple of methods to CanvasGraphicsContext3D which return them. These methods break the V8 bindings because there's no V8 CanvasActiveInfo binding. 153964 1 41011 dominicc 2009-10-11 20:09:12 -0700 Created attachment 41011 Proposed fix. Includes CanvasActiveInfo in V8 binding generation. 153966 2 41011 abarth 2009-10-11 20:13:03 -0700 Comment on attachment 41011 Proposed fix. Includes CanvasActiveInfo in V8 binding generation. Thanks for the build fix! 153974 3 41011 commit-queue 2009-10-11 20:30:46 -0700 Comment on attachment 41011 Proposed fix. Includes CanvasActiveInfo in V8 binding generation. Clearing flags on attachment: 41011 Committed r49432: <http://trac.webkit.org/changeset/49432> 153975 4 commit-queue 2009-10-11 20:30:51 -0700 All reviewed patches have been landed. Closing bug. 41011 2009-10-11 20:09:12 -0700 2009-10-11 20:30:46 -0700 Proposed fix. Includes CanvasActiveInfo in V8 binding generation. 30294a.patch text/plain 4807 dominicc RnJvbSBlZThlOTUzNTFkZDdkOTA4NDg3YmYwZDRjMTQ2NmJlYWMyMzljNDNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEb21pbmljIENvb25leSA8ZG9taW5pY2NAZ29vZ2xlLmNvbT4K RGF0ZTogU3VuLCAxMSBPY3QgMjAwOSAyMDowNTozNSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFBy b3Bvc2VkIHBhdGNoIGZvciBidWcgMzAyOTQuCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIxICsrKysrKysrKysrKysrKysrKysrKwogV2Vi Q29yZS9XZWJDb3JlLmd5cGkgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDEgKwogV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSAgICB8ICAgIDEgKwogV2Vi Q29yZS9iaW5kaW5ncy92OC9ET01PYmplY3RzSW5jbHVkZS5oICAgICAgICB8ICAgIDEgKwogV2Vi Q29yZS9iaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcCB8ICAgIDEgKwogV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEluZGV4LmNwcCAgICAgICAgICAgICAgICB8ICAgIDEgKwogV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEluZGV4LmggICAgICAgICAgICAgICAgICB8ICAgIDEgKwogNyBm aWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQwYTRiZC4u NThjYTkwMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOS0xMC0xMSAgRG9taW5pYyBDb29uZXkgIDxkb21p bmljY0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeGVzIGEgYnVpbGQgYnJlYWsgaW4gdGhlIFY4IGJpbmRpbmdzIGNhdXNlZCBi eSByZXZpc2lvbiA0OTQyMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMwMjk0CisKKyAgICAgICAgUmV2aXNpb24gNDk0MjAgaW50cm9kdWNlcyBhbiBJ REwtZGVmaW5lZCBDYW52YXNBY3RpdmVJbmZvCisgICAgICAgIHR5cGUuIFRoaXMgY2F1c2VzIGEg YnVpbGQgYnJlYWsgaW4gdGhlIFY4IGJpbmRpbmdzIHdoZXJlCisgICAgICAgIENhbnZhc0dyYXBo aWNzQ29udGV4dDNEIG5haXZlbHkgcmVmZXJzIHRvIENhbnZhc0FjdGl2ZUluZm8gYXMgYQorICAg ICAgICBub24tcmVmIHR5cGUuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6IEluY2x1ZGUgQ2Fu dmFzQWN0aXZlSW5mby5pZGwgaW4gYnVpbGQuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG06IENhbnZhc0FjdGl2ZUluZm8gaXMgYSByZWYKKyAgICAgICAgICBw dHIgdHlwZS4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01PYmplY3RzSW5jbHVkZS5oOiBJbmNs dWRlIGdlbmVyYXRlZAorICAgICAgICAgIENhbnZhc0FjdGl2ZUluZm8gZmlsZXMuCisgICAgICAg ICogYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHA6CisgICAgICAgICogYmlu ZGluZ3MvdjgvVjhJbmRleC5jcHA6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhJbmRleC5oOgor CiAyMDA5LTEwLTExICBTw7hyZW4gR2plc3NlICA8c2dqZXNzZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29y ZS5neXBpIGIvV2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggYTYyNjE5Yi4uZmJjNWU3ZCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLmd5cGkKKysrIGIvV2ViQ29yZS9XZWJDb3JlLmd5cGkK QEAgLTc3LDYgKzc3LDcgQEAKICAgICAgICAgICAgICdkb20vV2ViS2l0QW5pbWF0aW9uRXZlbnQu aWRsJywKICAgICAgICAgICAgICdkb20vV2ViS2l0VHJhbnNpdGlvbkV2ZW50LmlkbCcsCiAgICAg ICAgICAgICAnZG9tL1doZWVsRXZlbnQuaWRsJywKKyAgICAgICAgICAgICdodG1sL2NhbnZhcy9D YW52YXNBY3RpdmVJbmZvLmlkbCcsCiAgICAgICAgICAgICAnaHRtbC9jYW52YXMvQ2FudmFzQXJy YXkuaWRsJywKICAgICAgICAgICAgICdodG1sL2NhbnZhcy9DYW52YXNBcnJheUJ1ZmZlci5pZGwn LAogICAgICAgICAgICAgJ2h0bWwvY2FudmFzL0NhbnZhc0J1ZmZlci5pZGwnLApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggN2U5MGVjNy4uZWIzM2M2 NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0x NjI0LDYgKzE2MjQsNyBAQCBzdWIgSXNSZWZQdHJUeXBlCiB7CiAgICAgbXkgJHR5cGUgPSBzaGlm dDsKICAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQXR0ciI7CisgICAgcmV0dXJuIDEgaWYgJHR5 cGUgZXEgIkNhbnZhc0FjdGl2ZUluZm8iOwogICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJDYW52 YXNBcnJheSI7CiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkNhbnZhc0FycmF5QnVmZmVyIjsK ICAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQ2FudmFzQm9vbGVhbkFycmF5IjsKZGlmZiAtLWdp dCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NT2JqZWN0c0luY2x1ZGUuaCBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvRE9NT2JqZWN0c0luY2x1ZGUuaAppbmRleCAyMmU0MTM5Li4yYmFiNWM3IDEwMDY0 NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTU9iamVjdHNJbmNsdWRlLmgKKysrIGIvV2Vi Q29yZS9iaW5kaW5ncy92OC9ET01PYmplY3RzSW5jbHVkZS5oCkBAIC0zNCw2ICszNCw3IEBACiAj aW5jbHVkZSAiQWJzdHJhY3RXb3JrZXIuaCIKICNpbmNsdWRlICJCYXJJbmZvLmgiCiAjaW5jbHVk ZSAiQmVmb3JlTG9hZEV2ZW50LmgiCisjaW5jbHVkZSAiQ2FudmFzQWN0aXZlSW5mby5oIgogI2lu Y2x1ZGUgIkNhbnZhc0FycmF5LmgiCiAjaW5jbHVkZSAiQ2FudmFzQXJyYXlCdWZmZXIuaCIKICNp bmNsdWRlICJDYW52YXNCdWZmZXIuaCIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mvdjgv RGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L0Rlcml2ZWRT b3VyY2VzQWxsSW5PbmUuY3BwCmluZGV4IDJmOGRiNTYuLjA2OTFkZDMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHAKKysrIGIvV2ViQ29y ZS9iaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcApAQCAtMzUsNiArMzUsNyBA QAogI2luY2x1ZGUgImJpbmRpbmdzL1Y4QXR0ci5jcHAiCiAjaW5jbHVkZSAiYmluZGluZ3MvVjhC YXJJbmZvLmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOEJlZm9yZUxvYWRFdmVudC5jcHAiCisj aW5jbHVkZSAiYmluZGluZ3MvVjhDYW52YXNBY3RpdmVJbmZvLmNwcCIKICNpbmNsdWRlICJiaW5k aW5ncy9WOENhbnZhc0FycmF5LmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOENhbnZhc0FycmF5 QnVmZmVyLmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOENhbnZhc0J1ZmZlci5jcHAiCmRpZmYg LS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5kZXguY3BwIGIvV2ViQ29yZS9iaW5kaW5n cy92OC9WOEluZGV4LmNwcAppbmRleCA3NTg0NGI4Li43ZjJiNDRjIDEwMDY0NAotLS0gYS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4SW5kZXguY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJ bmRleC5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJWOEF0dHIuaCIKICNpbmNsdWRl ICJWOEJhckluZm8uaCIKICNpbmNsdWRlICJWOEJlZm9yZUxvYWRFdmVudC5oIgorI2luY2x1ZGUg IlY4Q2FudmFzQWN0aXZlSW5mby5oIgogI2luY2x1ZGUgIlY4Q2FudmFzUmVuZGVyaW5nQ29udGV4 dC5oIgogI2luY2x1ZGUgIlY4Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmgiCiAjaW5jbHVkZSAi VjhDYW52YXNHcmFkaWVudC5oIgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOElu ZGV4LmggYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5kZXguaAppbmRleCA0OTBhOWNlLi45MzY4 MzE4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5kZXguaAorKysgYi9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4SW5kZXguaApAQCAtNDUwLDYgKzQ1MCw3IEBAIHR5cGVkZWYgdjg6 OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVtcGxhdGU+ICgqRnVuY3Rpb25UZW1wbGF0ZUZhY3Rv cnkpKCk7CiAKICNpZiBFTkFCTEUoM0RfQ0FOVkFTKQogI2RlZmluZSBET01fT0JKRUNUXzNEX0NB TlZBU19UWVBFUyhWKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgIFYo Q0FOVkFTQUNUSVZFSU5GTywgQ2FudmFzQWN0aXZlSW5mbykgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXAogICAgIFYoQ0FOVkFTQVJSQVksIENhbnZhc0FycmF5KSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgIFYoQ0FOVkFTQVJSQVlCVUZGRVIsIENh bnZhc0FycmF5QnVmZmVyKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgIFYoQ0FO VkFTQlVGRkVSLCBDYW52YXNCdWZmZXIpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgXAotLSAKMS42LjAKCg==