30292 2009-10-11 18:51:28 -0700 Inconsistent handling of gettext domain can cause compile failure 2009-10-19 04:51:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://permalink.gmane.org/gmane.os.apple.fink.general/28859 P2 Normal --- 0 dmacks webkit-unassigned commit-queue oldest_to_newest 153959 0 dmacks 2009-10-11 18:51:28 -0700 Several makefiles hardcode the gettext domain in the .pot filename ("webkit.pot") but other parts of the makefiles (and the code that accesses them) use a variable. The following is using webkit-1.1.10 release, but the code that triggers the problem appears the same in svn trunk. All support pkgs supplied via fink at the level of GNOME2.26, and gettext 0.14.5: 1. Edit configure -GETTEXT_PACKAGE=$PACKAGE +GETTEXT_PACKAGE="${PACKAGE}-1.0.2" 2. Build the package ./configure --prefix=/sw --disable-dependency-tracking \ --enable-gtk-doc \ --disable-video \ --disable-jit \ PKG_CONFIG_PATH="/sw/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH" \ XT_CFLAGS=" " XT_LIBS=-lXt mkdir DerivedSources make make -C WebKit/gtk/docs Build failure (reported by several users on multiple OSX versions): /sw/bin/msgmerge --update de.po webkit-1.0.2.pot /sw/bin/msgmerge: error while opening "webkit-1.0.2.pot" for reading: No such file or directory make[1]: *** [WebKit/gtk/po/de.po] Error 1 make: *** [all] Error 2 The bug is that the make recipe for the "webkit-1.0.2.pot" target generates "webkit.pot": /sw/bin/xgettext --default-domain=webkit-1.0.2 --directory=. \ --add-comments=TRANSLATORS: \ --files-from=./WebKit/gtk/po/POTFILES \ --copyright-holder='' \ --msgid-bugs-address="$msgid_bugs_address" \ --keyword=_ --keyword=N_ -o ./WebKit/gtk/po/webkit.pot The -o flag is hardcoded instead of using the $DOMAIN variable. 154634 1 41181 dmacks 2009-10-14 12:51:03 -0700 Created attachment 41181 Use DOMAIN variable instead of hard-coded value 155577 2 41181 abarth 2009-10-18 23:08:01 -0700 Comment on attachment 41181 Use DOMAIN variable instead of hard-coded value ok. 155657 3 41181 commit-queue 2009-10-19 04:51:03 -0700 Comment on attachment 41181 Use DOMAIN variable instead of hard-coded value Clearing flags on attachment: 41181 Committed r49773: <http://trac.webkit.org/changeset/49773> 155658 4 commit-queue 2009-10-19 04:51:06 -0700 All reviewed patches have been landed. Closing bug. 41181 2009-10-14 12:51:03 -0700 2009-10-19 04:51:02 -0700 Use DOMAIN variable instead of hard-coded value potfile-fix.patch text/plain 1661 dmacks SW5kZXg6IFdlYktpdC9ndGsvcG8vQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2d0 ay9wby9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ5NTgxKQ0KKysrIFdlYktpdC9ndGsvcG8vQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpDQpAQCAtMSwzICsxLDEyIEBADQorMjAwOS0xMC0xNCAgRGFuaWVs IE1hY2tzICA8ZG1hY2tzQG5ldHNwYWNlLm9yZz4NCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgSW5jb25zaXN0ZW50IGhhbmRsaW5nIG9mIGdldHRl eHQgZG9tYWluIGNhbiBjYXVzZSBjb21waWxlIGZhaWx1cmUNCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDI5Mg0KKw0KKyAgICAgICAgKiBHTlVtYWtl ZmlsZS5hbTogVXNlIERPTUFJTiB2YXJpYWJsZSBpbnN0ZWFkIG9mIGhhcmQtY29kZWQgdmFsdWUN CisNCiAyMDA5LTEwLTA5ICBSaW1hcyBLdWRlbGlzICA8cnFAYWtsLmx0Pg0KIA0KICAgICAgICAg UnViYmVyLXN0YW1wZWQgYnkgR3VzdGF2byBOb3JvbmhhDQpJbmRleDogV2ViS2l0L2d0ay9wby9H TlVtYWtlZmlsZS5hbQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9ndGsvcG8vR05VbWFrZWZpbGUu YW0JKHJldmlzaW9uIDQ5NTgxKQ0KKysrIFdlYktpdC9ndGsvcG8vR05VbWFrZWZpbGUuYW0JKHdv cmtpbmcgY29weSkNCkBAIC03Myw3ICs3Myw3IEBAICQoRE9NQUlOKS5wb3QtdXBkYXRlOiAkKFBP VEZJTEVTKSAkKHNyY2QNCiAJICAgICAgLS1maWxlcy1mcm9tPSQoc3JjZGlyKS9XZWJLaXQvZ3Rr L3BvL1BPVEZJTEVTIFwNCiAJICAgICAgLS1jb3B5cmlnaHQtaG9sZGVyPSckKENPUFlSSUdIVF9I T0xERVIpJyBcDQogCSAgICAgIC0tbXNnaWQtYnVncy1hZGRyZXNzPSIkJG1zZ2lkX2J1Z3NfYWRk cmVzcyIgXA0KLQkgICAgICAtLWtleXdvcmQ9XyAtLWtleXdvcmQ9Tl8gLW8gJChzcmNkaXIpL1dl YktpdC9ndGsvcG8vd2Via2l0LnBvdCBcDQorCSAgICAgIC0ta2V5d29yZD1fIC0ta2V5d29yZD1O XyAtbyAkKHNyY2RpcikvV2ViS2l0L2d0ay9wby8kKERPTUFJTikucG90IFwNCiAJICAgIDs7IFwN CiAJICAqKSBcDQogCSAgICAkKFhHRVRURVhUKSAtLWRlZmF1bHQtZG9tYWluPSQoRE9NQUlOKSAt LWRpcmVjdG9yeT0kKHNyY2RpcikgXA0KQEAgLTgzLDcgKzgzLDcgQEAgJChET01BSU4pLnBvdC11 cGRhdGU6ICQoUE9URklMRVMpICQoc3JjZA0KIAkgICAgICAtLXBhY2thZ2UtbmFtZT0iJCR7cGFj a2FnZV9nbnV9QFBBQ0tBR0VAIiBcDQogCSAgICAgIC0tcGFja2FnZS12ZXJzaW9uPSdAVkVSU0lP TkAnIFwNCiAJICAgICAgLS1tc2dpZC1idWdzLWFkZHJlc3M9IiQkbXNnaWRfYnVnc19hZGRyZXNz IiBcDQotCSAgICAgIC0ta2V5d29yZD1fIC0ta2V5d29yZD1OXyAtbyAkKHNyY2RpcikvV2ViS2l0 L2d0ay9wby93ZWJraXQucG90IFwNCisJICAgICAgLS1rZXl3b3JkPV8gLS1rZXl3b3JkPU5fIC1v ICQoc3JjZGlyKS9XZWJLaXQvZ3RrL3BvLyQoRE9NQUlOKS5wb3QgXA0KIAkgICAgOzsgXA0KIAll c2FjDQogDQo=