30290 2009-10-11 17:19:44 -0700 Log mixed content warnings to console 2009-10-11 20:15:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED https://crypto.stanford.edu/~collinj/research/mixed-content/ P3 Enhancement --- 1 collinj collinj abarth commit-queue oldest_to_newest 153955 0 collinj 2009-10-11 17:19:44 -0700 Mixed content warnings are often hard to debug, since the insecure content is buried in some obscure stylesheet or iframe. By logging information about a mixed content event as a console warning, we can make removing mixed content easier for site developers. The most important pieces of information that we can log are the URL of the page that's attempting to include insecure content, and the URL of the content. I'm not sure if the console message type should be error or warning, but I'm leaning towards warning. Chrome used a warning before the mixed content detection was moved into WebKit. 153956 1 41009 collinj 2009-10-11 17:22:35 -0700 Created attachment 41009 patch I ran the existing mixed content http tests and they passed. 153961 2 41009 abarth 2009-10-11 19:49:50 -0700 Comment on attachment 41009 patch Thanks Collin! 153967 3 41009 commit-queue 2009-10-11 20:15:18 -0700 Comment on attachment 41009 patch Clearing flags on attachment: 41009 Committed r49431: <http://trac.webkit.org/changeset/49431> 153968 4 commit-queue 2009-10-11 20:15:22 -0700 All reviewed patches have been landed. Closing bug. 41009 2009-10-11 17:22:35 -0700 2009-10-11 20:15:18 -0700 patch mixed-content.patch text/plain 1761 collinj SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTQyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMTEgIENvbGxpbiBKYWNrc29uICA8Y29sbGluakB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IExvZyBtaXhlZCBjb250ZW50IHdhcm5pbmdzIHRvIGNvbnNvbGUKKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAyOTAKKworICAgICAgICAqIGxvYWRl ci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2hlY2tJ ZkRpc3BsYXlJbnNlY3VyZUNvbnRlbnQpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6 OmNoZWNrSWZSdW5JbnNlY3VyZUNvbnRlbnQpOgorCiAyMDA5LTEwLTExICBTw7hyZW4gR2plc3Nl ICA8c2dqZXNzZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0 aC4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDQ5NDI0KQorKysgV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDA4LDYgKzE0MDgs MTAgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2hlY2tJZkRpc3BsYXlJbnNlY3VyZQogICAgIGlmICgh aXNNaXhlZENvbnRlbnQoY29udGV4dCwgdXJsKSkKICAgICAgICAgcmV0dXJuOwogCisgICAgU3Ry aW5nIG1lc3NhZ2UgPSBTdHJpbmc6OmZvcm1hdCgiVGhlIHBhZ2UgYXQgJXMgZGlzcGxheWVkIGlu c2VjdXJlIGNvbnRlbnQgZnJvbSAlcy5cbiIsCisgICAgICAgIG1fVVJMLnN0cmluZygpLnV0Zjgo KS5kYXRhKCksIHVybC5zdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBtX2ZyYW1lLT5kb21X aW5kb3coKS0+Y29uc29sZSgpLT5hZGRNZXNzYWdlKEhUTUxNZXNzYWdlU291cmNlLCBMb2dNZXNz YWdlVHlwZSwgV2FybmluZ01lc3NhZ2VMZXZlbCwgbWVzc2FnZSwgMSwgU3RyaW5nKCkpOworCiAg ICAgbV9jbGllbnQtPmRpZERpc3BsYXlJbnNlY3VyZUNvbnRlbnQoKTsKIH0KIApAQCAtMTQxNiw2 ICsxNDIwLDEwIEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNoZWNrSWZSdW5JbnNlY3VyZUNvbnQKICAg ICBpZiAoIWlzTWl4ZWRDb250ZW50KGNvbnRleHQsIHVybCkpCiAgICAgICAgIHJldHVybjsKIAor ICAgIFN0cmluZyBtZXNzYWdlID0gU3RyaW5nOjpmb3JtYXQoIlRoZSBwYWdlIGF0ICVzIHJhbiBp bnNlY3VyZSBjb250ZW50IGZyb20gJXMuXG4iLAorICAgICAgICBtX1VSTC5zdHJpbmcoKS51dGY4 KCkuZGF0YSgpLCB1cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CisgICAgbV9mcmFtZS0+ZG9t V2luZG93KCktPmNvbnNvbGUoKS0+YWRkTWVzc2FnZShIVE1MTWVzc2FnZVNvdXJjZSwgTG9nTWVz c2FnZVR5cGUsIFdhcm5pbmdNZXNzYWdlTGV2ZWwsIG1lc3NhZ2UsIDEsIFN0cmluZygpKTsKKwog ICAgIG1fY2xpZW50LT5kaWRSdW5JbnNlY3VyZUNvbnRlbnQoY29udGV4dCk7CiB9CiAK