30281 2009-10-10 18:04:04 -0700 LayoutTests/fast/cookies/local-file-can-set-cookies.html fails when cookies for document already exist 2009-10-19 15:44:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P4 Trivial --- 1 tailofthesun webkit-unassigned andersca aroben commit-queue darin ddkilzer eric kmccullough oldest_to_newest 153891 0 40995 tailofthesun 2009-10-10 18:04:04 -0700 Created attachment 40995 patch against r49292 Tested on r49292, LayoutTests/fast/cookies/local-file-can-set-cookies-expected.txt will fail if there are other local file cookies already set on the path the test is being run from. On my machine, the path was "/" and there were other cookies set already. This results in a failure because the test checks document.cookie to make sure "ppkcookie1=testcookie" is the only cookie set. The attached patch changes this to check to use document.cookie.indexOf instead of the equality of document.cookie. 153896 1 40995 eric 2009-10-10 19:45:38 -0700 Comment on attachment 40995 patch against r49292 Seems fine to me, but needs a ChangeLog. Also whoever wrote this test shoudl probably be CC'd on this bug. 153897 2 eric 2009-10-10 19:46:37 -0700 CCing Dave (the author) and Anders (the reviewer). Was added by: http://trac.webkit.org/changeset/35534 153898 3 eric 2009-10-10 19:48:06 -0700 Sorry, I was wrong. It was added as: http://trac.webkit.org/changeset/25110 153900 4 40997 tailofthesun 2009-10-10 20:09:06 -0700 Created attachment 40997 Updated ChangeLog Updated ChangeLog and tested against r49422. 153901 5 40998 tailofthesun 2009-10-10 20:10:02 -0700 Created attachment 40998 Updated ChangeLog As a patch this time. 153902 6 eric 2009-10-10 20:21:20 -0700 I believe that DumpRenderTree is supposed to clear cookies between test runs, or at least store cookies separately from any system cookies. This may just be a bug in Qt's DumpRenderTree, or whichever you're using? 153903 7 tailofthesun 2009-10-10 20:33:52 -0700 I'm running this test on Mac OS X 10.6.1. I can reproduce the issue without the patch with the following steps: 1) Create cookie in the same test case (e.g., document.cookie = 'test=broken; expires=Fri, 1 Jan 2010 01:01:01 UTC';) 2) Run test case, expect failure. 3) Remove test cookie from test case. 4) Re-run test case, test still fails with "FAIL document.cookie should be ppkcookie1=testcookie. Was ppkcookie1=testcookie; test=broken." 154083 8 40998 darin 2009-10-12 09:21:57 -0700 Comment on attachment 40998 Updated ChangeLog This is OK, but if we're going to change the test like this I also suggest that the test do this before setting document.cookie: shouldBe("document.cookie.indexOf('ppkcookie1=testcookie')", "-1"); To make sure we are actually setting the cookie. I'll do r=me like this, but you could consider my suggestion. I also suggest making per-file comments in change log. 154226 9 tailofthesun 2009-10-12 18:14:39 -0700 I agree that the test should make sure the cookie isn't already set, however the current cookie has an expiration time of 60 seconds, which can make the test fail if run the test multiple times before the cookie has expired yet. I've also changed the behavior so that the cookie is set only for the duration of the session. I'll attach a new patch with your suggestions. 154229 10 41078 tailofthesun 2009-10-12 18:18:23 -0700 Created attachment 41078 Incorporated suggests from Darin. Patch against r49487. 155701 11 41078 yong.li.webkit 2009-10-19 08:49:15 -0700 Comment on attachment 41078 Incorporated suggests from Darin. Patch against r49487. Let commit bot land it 155800 12 41078 eric 2009-10-19 11:41:25 -0700 Comment on attachment 41078 Incorporated suggests from Darin. Patch against r49487. The ChangeLog has a leading space, causing the commit-queue to fail (silently). Fixing the commit-queue, but this Change will need a new ChagneLog. 155939 13 41456 tailofthesun 2009-10-19 15:13:04 -0700 Created attachment 41456 Fixed spacing in ChangeLog 155954 14 41456 eric 2009-10-19 15:22:39 -0700 Comment on attachment 41456 Fixed spacing in ChangeLog Normally you would need to mark this r=? and cq=? in order for anyone to see this and land it. I just happened to open the bug this afternoon. 155967 15 41456 commit-queue 2009-10-19 15:44:28 -0700 Comment on attachment 41456 Fixed spacing in ChangeLog Clearing flags on attachment: 41456 Committed r49819: <http://trac.webkit.org/changeset/49819> 155968 16 commit-queue 2009-10-19 15:44:32 -0700 All reviewed patches have been landed. Closing bug. 40995 2009-10-10 18:04:04 -0700 2009-10-10 20:10:02 -0700 patch against r49292 local_file_cookies_r49292.patch text/plain 1266 tailofthesun SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2ll cy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jb29raWVzL2xv Y2FsLWZpbGUtY2FuLXNldC1jb29raWVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNDkyOTIpCisr KyBMYXlvdXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMtZXhw ZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zLDcgKzMsNyBAQCBUaGlzIHRlc3QgY2hlY2tz IHRoYXQgYSBsb2NhbCBmaWxlIGNhbiBzCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAot UEFTUyBkb2N1bWVudC5jb29raWUgaXMgJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZScKK1BBU1MgZG9j dW1lbnQuY29va2llLmluZGV4T2YoJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZScpID49IDAgaXMgdHJ1 ZQogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4t c2V0LWNvb2tpZXMuaHRtbAkocmV2aXNpb24gNDkyOTIpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nv b2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MTQsNyArMTQsNyBAQAogICAgIHZhciBkYXRlID0gbmV3IERhdGUoKTsKICAgICBkYXRlLnNldFRp bWUoZGF0ZS5nZXRUaW1lKCkgKyAoNjAqMTAwMCkpOwogICAgIGRvY3VtZW50LmNvb2tpZSA9ICdw cGtjb29raWUxPXRlc3Rjb29raWU7IGV4cGlyZXM9JyArIGRhdGUudG9HTVRTdHJpbmcoKTsKLSAg ICBzaG91bGRCZSgiZG9jdW1lbnQuY29va2llIiwgIidwcGtjb29raWUxPXRlc3Rjb29raWUnIik7 CisgICAgc2hvdWxkQmVUcnVlKCJkb2N1bWVudC5jb29raWUuaW5kZXhPZigncHBrY29va2llMT10 ZXN0Y29va2llJykgPj0gMCIpOwogCiAgICAgdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7 CiA8L3NjcmlwdD4K 40997 2009-10-10 20:09:06 -0700 2009-10-10 20:10:02 -0700 Updated ChangeLog local_file_cookies_r49422.patch application/octet-stream 1987 tailofthesun SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5NDIyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMTAgIEphc29uIFlhbiAgPHRhaWxv ZnRoZXN1bkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4ZWQgaXNzdWUgd2l0aCBMYXlvdXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9j YWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMuaHRtbAorICAgICAgICB3aGljaCBjYW4gZmFpbCB3aGVu IHRoZSBzeXN0ZW0gdW5kZXIgdGVzdCBoYXMgbG9jYWwgZmlsZSBjb29raWVzIHNldCBhbHJlYWR5 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAyODEK KworICAgICAgICAqIGZhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy1leHBl Y3RlZC50eHQ6CisgICAgICAgICogZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29r aWVzLmh0bWw6CisKIDIwMDktMTAtMTAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29v a2llcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQ5NDIyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9j b29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMyw3ICszLDcgQEAgVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEgbG9jYWwgZmlsZSBj YW4gcwogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgZG9jdW1lbnQuY29va2ll IGlzICdwcGtjb29raWUxPXRlc3Rjb29raWUnCitQQVNTIGRvY3VtZW50LmNvb2tpZS5pbmRleE9m KCdwcGtjb29raWUxPXRlc3Rjb29raWUnKSA+PSAwIGlzIHRydWUKIFBBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9j b29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLmh0bWwJKHJl dmlzaW9uIDQ5NDIyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2Fu LXNldC1jb29raWVzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE0LDcgKzE0LDcgQEAKICAgICB2 YXIgZGF0ZSA9IG5ldyBEYXRlKCk7CiAgICAgZGF0ZS5zZXRUaW1lKGRhdGUuZ2V0VGltZSgpICsg KDYwKjEwMDApKTsKICAgICBkb2N1bWVudC5jb29raWUgPSAncHBrY29va2llMT10ZXN0Y29va2ll OyBleHBpcmVzPScgKyBkYXRlLnRvR01UU3RyaW5nKCk7Ci0gICAgc2hvdWxkQmUoImRvY3VtZW50 LmNvb2tpZSIsICIncHBrY29va2llMT10ZXN0Y29va2llJyIpOworICAgIHNob3VsZEJlVHJ1ZSgi ZG9jdW1lbnQuY29va2llLmluZGV4T2YoJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZScpID49IDAiKTsK IAogICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwogPC9zY3JpcHQ+Cg== 40998 2009-10-10 20:10:02 -0700 2009-10-12 18:18:23 -0700 Updated ChangeLog local_file_cookies_r49422.patch text/plain 1987 tailofthesun SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5NDIyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMTAgIEphc29uIFlhbiAgPHRhaWxv ZnRoZXN1bkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4ZWQgaXNzdWUgd2l0aCBMYXlvdXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9j YWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMuaHRtbAorICAgICAgICB3aGljaCBjYW4gZmFpbCB3aGVu IHRoZSBzeXN0ZW0gdW5kZXIgdGVzdCBoYXMgbG9jYWwgZmlsZSBjb29raWVzIHNldCBhbHJlYWR5 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAyODEK KworICAgICAgICAqIGZhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy1leHBl Y3RlZC50eHQ6CisgICAgICAgICogZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29r aWVzLmh0bWw6CisKIDIwMDktMTAtMTAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29v a2llcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQ5NDIyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9j b29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMyw3ICszLDcgQEAgVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEgbG9jYWwgZmlsZSBj YW4gcwogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgZG9jdW1lbnQuY29va2ll IGlzICdwcGtjb29raWUxPXRlc3Rjb29raWUnCitQQVNTIGRvY3VtZW50LmNvb2tpZS5pbmRleE9m KCdwcGtjb29raWUxPXRlc3Rjb29raWUnKSA+PSAwIGlzIHRydWUKIFBBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9j b29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLmh0bWwJKHJl dmlzaW9uIDQ5NDIyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2Fu LXNldC1jb29raWVzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE0LDcgKzE0LDcgQEAKICAgICB2 YXIgZGF0ZSA9IG5ldyBEYXRlKCk7CiAgICAgZGF0ZS5zZXRUaW1lKGRhdGUuZ2V0VGltZSgpICsg KDYwKjEwMDApKTsKICAgICBkb2N1bWVudC5jb29raWUgPSAncHBrY29va2llMT10ZXN0Y29va2ll OyBleHBpcmVzPScgKyBkYXRlLnRvR01UU3RyaW5nKCk7Ci0gICAgc2hvdWxkQmUoImRvY3VtZW50 LmNvb2tpZSIsICIncHBrY29va2llMT10ZXN0Y29va2llJyIpOworICAgIHNob3VsZEJlVHJ1ZSgi ZG9jdW1lbnQuY29va2llLmluZGV4T2YoJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZScpID49IDAiKTsK IAogICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwogPC9zY3JpcHQ+Cg== 41078 2009-10-12 18:18:23 -0700 2009-10-19 15:13:04 -0700 Incorporated suggests from Darin. Patch against r49487. local_file_cookies_r49487.patch text/plain 2440 tailofthesun SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5NDg3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKyAyMDA5LTEwLTEyICBKYXNvbiBZYW4gIDx0YWls b2Z0aGVzdW5AZ21haWwuY29tPgorIAorICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgCisgICAgICAgICBGaXhlZCBpc3N1ZSB3aXRoIExheW91dFRlc3RzL2Zhc3QvY29va2ll cy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy5odG1sCisgICAgICAgICB3aGljaCBjYW4gZmFp bCB3aGVuIHRoZSBzeXN0ZW0gdW5kZXIgdGVzdCBoYXMgbG9jYWwgZmlsZSBjb29raWVzIHNldCBh bHJlYWR5LgorICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMwMjgxCisgCisgICAgICAgICAqIGZhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29v a2llcy1leHBlY3RlZC50eHQ6IE1vZGlmaWVkLiBVcGRhdGVkIGV4cGVjdGVkIHJlc3VsdHMuCisg ICAgICAgICAqIGZhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy5odG1sOiBN b2RpZmllZC4gQ2hlY2sgZm9yIGV4aXN0aW5nIGNvb2tpZSBhbmQgc2V0IG5vbi1wZXJzaXN0ZW50 IGNvb2tpZS4KKwogMjAwOS0xMC0xMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9j b29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA0OTQ4NykKKysrIExheW91dFRlc3RzL2Zhc3QvY29va2ll cy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkK QEAgLTMsNyArMyw4IEBAIFRoaXMgdGVzdCBjaGVja3MgdGhhdCBhIGxvY2FsIGZpbGUgY2FuIHMK IE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAogCi1QQVNTIGRvY3VtZW50LmNvb2tpZSBpcyAn cHBrY29va2llMT10ZXN0Y29va2llJworUEFTUyBkb2N1bWVudC5jb29raWUuaW5kZXhPZigncHBr Y29va2llMT10ZXN0Y29va2llJykgaXMgLTEKK1BBU1MgZG9jdW1lbnQuY29va2llLmluZGV4T2Yo J3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZScpID49IDAgaXMgdHJ1ZQogUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nv b2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMuaHRtbAkocmV2 aXNpb24gNDk0ODcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nvb2tpZXMvbG9jYWwtZmlsZS1jYW4t c2V0LWNvb2tpZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTEsMTAgKzExLDkgQEAKIDxzY3Jp cHQ+CiAgICAgZGVzY3JpcHRpb24oJ1RoaXMgdGVzdCBjaGVja3MgdGhhdCBhIGxvY2FsIGZpbGUg Y2FuIHNldCBjb29raWVzLiAgU2VlOiByZGFyOi8vcHJvYmxlbS81Mzc5MDkwIFJFR1JFU1NJT046 IENhbm5vdCBzZXQgY29va2llcyBmb3IgbG9jYWwgZmlsZXMnKTsKIAotICAgIHZhciBkYXRlID0g bmV3IERhdGUoKTsKLSAgICBkYXRlLnNldFRpbWUoZGF0ZS5nZXRUaW1lKCkgKyAoNjAqMTAwMCkp OwotICAgIGRvY3VtZW50LmNvb2tpZSA9ICdwcGtjb29raWUxPXRlc3Rjb29raWU7IGV4cGlyZXM9 JyArIGRhdGUudG9HTVRTdHJpbmcoKTsKLSAgICBzaG91bGRCZSgiZG9jdW1lbnQuY29va2llIiwg IidwcGtjb29raWUxPXRlc3Rjb29raWUnIik7CisgICAgc2hvdWxkQmUoImRvY3VtZW50LmNvb2tp ZS5pbmRleE9mKCdwcGtjb29raWUxPXRlc3Rjb29raWUnKSIsICItMSIpOworICAgIGRvY3VtZW50 LmNvb2tpZSA9ICdwcGtjb29raWUxPXRlc3Rjb29raWUnOworICAgIHNob3VsZEJlVHJ1ZSgiZG9j dW1lbnQuY29va2llLmluZGV4T2YoJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZScpID49IDAiKTsKIAog ICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwogPC9zY3JpcHQ+Cg== 41456 2009-10-19 15:13:04 -0700 2009-10-19 15:44:28 -0700 Fixed spacing in ChangeLog local_file_cookies_r49487_2.patch text/plain 2439 tailofthesun SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5NDg3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMTIgIEphc29uIFlhbiAgPHRhaWxv ZnRoZXN1bkBnbWFpbC5jb20+CisgCisgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAKKyAgICAgICAgIEZpeGVkIGlzc3VlIHdpdGggTGF5b3V0VGVzdHMvZmFzdC9jb29raWVz L2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLmh0bWwKKyAgICAgICAgIHdoaWNoIGNhbiBmYWls IHdoZW4gdGhlIHN5c3RlbSB1bmRlciB0ZXN0IGhhcyBsb2NhbCBmaWxlIGNvb2tpZXMgc2V0IGFs cmVhZHkuCisgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzAyODEKKyAKKyAgICAgICAgICogZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29r aWVzLWV4cGVjdGVkLnR4dDogTW9kaWZpZWQuIFVwZGF0ZWQgZXhwZWN0ZWQgcmVzdWx0cy4KKyAg ICAgICAgICogZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLmh0bWw6IE1v ZGlmaWVkLiBDaGVjayBmb3IgZXhpc3RpbmcgY29va2llIGFuZCBzZXQgbm9uLXBlcnNpc3RlbnQg Y29va2llLgorCiAyMDA5LTEwLTEyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nv b2tpZXMvbG9jYWwtZmlsZS1jYW4tc2V0LWNvb2tpZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDQ5NDg3KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jb29raWVz L2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA QCAtMyw3ICszLDggQEAgVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEgbG9jYWwgZmlsZSBjYW4gcwog T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKLVBBU1MgZG9jdW1lbnQuY29va2llIGlzICdw cGtjb29raWUxPXRlc3Rjb29raWUnCitQQVNTIGRvY3VtZW50LmNvb2tpZS5pbmRleE9mKCdwcGtj b29raWUxPXRlc3Rjb29raWUnKSBpcyAtMQorUEFTUyBkb2N1bWVudC5jb29raWUuaW5kZXhPZign cHBrY29va2llMT10ZXN0Y29va2llJykgPj0gMCBpcyB0cnVlCiBQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY29v a2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy5odG1sCShyZXZp c2lvbiA0OTQ4NykKKysrIExheW91dFRlc3RzL2Zhc3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1z ZXQtY29va2llcy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMSwxMCArMTEsOSBAQAogPHNjcmlw dD4KICAgICBkZXNjcmlwdGlvbignVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEgbG9jYWwgZmlsZSBj YW4gc2V0IGNvb2tpZXMuICBTZWU6IHJkYXI6Ly9wcm9ibGVtLzUzNzkwOTAgUkVHUkVTU0lPTjog Q2Fubm90IHNldCBjb29raWVzIGZvciBsb2NhbCBmaWxlcycpOwogCi0gICAgdmFyIGRhdGUgPSBu ZXcgRGF0ZSgpOwotICAgIGRhdGUuc2V0VGltZShkYXRlLmdldFRpbWUoKSArICg2MCoxMDAwKSk7 Ci0gICAgZG9jdW1lbnQuY29va2llID0gJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZTsgZXhwaXJlcz0n ICsgZGF0ZS50b0dNVFN0cmluZygpOwotICAgIHNob3VsZEJlKCJkb2N1bWVudC5jb29raWUiLCAi J3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZSciKTsKKyAgICBzaG91bGRCZSgiZG9jdW1lbnQuY29va2ll LmluZGV4T2YoJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZScpIiwgIi0xIik7CisgICAgZG9jdW1lbnQu Y29va2llID0gJ3Bwa2Nvb2tpZTE9dGVzdGNvb2tpZSc7CisgICAgc2hvdWxkQmVUcnVlKCJkb2N1 bWVudC5jb29raWUuaW5kZXhPZigncHBrY29va2llMT10ZXN0Y29va2llJykgPj0gMCIpOwogCiAg ICAgdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CiA8L3NjcmlwdD4K