30278 2009-10-10 08:16:18 -0700 Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH 2009-10-15 09:55:08 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned eric zecke oldest_to_newest 153876 0 laszlo.gombos 2009-10-10 08:16:18 -0700 I would propose the following changes: - Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH out from Gtk and Qt make system into port independent common code (Platform.h). This would also cut down on the length of the command line for compilation - which still seems to be a challenge in some embedded systems. - Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH even if NETSCAPE_PLUGIN_API support is not enabled - this would allow removing some stubs from PluginPackageNone.cpp. - Remove notImplemented() from PluginPackageNone.cpp and PluginDataNone.cpp - make them just empty functions (see also bug 30275 why this is desired) 153884 1 40993 laszlo.gombos 2009-10-10 12:24:24 -0700 Created attachment 40993 first try 153895 2 40993 eric 2009-10-10 19:44:15 -0700 Comment on attachment 40993 first try tools like bugzilla-tool post-diff and git-send-bugzilla will automatically check the "patch" checkbox for you during upload. Otherwise you'll need to do it yourself. :) 154263 3 40993 hausmann 2009-10-12 22:24:18 -0700 Comment on attachment 40993 first try Nice cleanup :) 154322 4 40993 commit-queue 2009-10-13 06:32:05 -0700 Comment on attachment 40993 first try Rejecting patch 40993 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Last 500 characters of output: Queue/LayoutTests Testing 11423 test cases. http/tests/history/redirect-302.pl -> timed out Sampling process 7317 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 7317 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 8478 tests run. 514.97s total testing time 8477 test cases (99%) succeeded 1 test case (<1%) timed out 4 test cases (<1%) had stderr output 154445 5 40993 laszlo.gombos 2009-10-13 14:51:31 -0700 Comment on attachment 40993 first try Will land manually. 154462 6 laszlo.gombos 2009-10-13 15:22:49 -0700 Landed as http://trac.webkit.org/changeset/49515. 154821 7 eric 2009-10-15 09:55:08 -0700 The problem here is a flakey test. Sigh. In these cases you're welcome to land it manually, or simply set cq+ again. The commit-queue has no way to distinguish between flakey tests and real failures, so it always assumes failures are real. We need to get rid of all our flakey tests :( Filed bug 30391. 40993 2009-10-10 12:24:24 -0700 2009-10-13 15:22:18 -0700 first try patch_patch_30278.txt text/plain 4960 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ5NDE2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMTAgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yIEVOQUJMRV9QTFVHSU5fUEFDS0FH RV9TSU1QTEVfSEFTSAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzAyNzgKKworICAgICAgICBNb3ZlIHRoZSBkZWZpbml0aW9uIG9mIEVOQUJMRV9QTFVH SU5fUEFDS0FHRV9TSU1QTEVfSEFTSAorICAgICAgICBmcm9tIHRoZSBtYWtlIHN5c3RlbSBpbnRv IGNvbW1vbiBjb2RlLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMDktMTAtMDkg IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBPbGl2ZXIgSHVudC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA0OTQxNCkK KysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC04MjEs NiArODIxLDEwIEBAIG9uIE1pbkdXLiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2gKICNk ZWZpbmUgV0FSTl9VTlVTRURfUkVUVVJOCiAjZW5kaWYKIAorI2lmICFFTkFCTEUoTkVUU0NBUEVf UExVR0lOX0FQSSkgfHwgKEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKSAmJiAoKFBMQVRGT1JN KFVOSVgpICYmIFBMQVRGT1JNKFFUKSkgfHwgUExBVEZPUk0oR1RLKSkpCisjZGVmaW5lIEVOQUJM RV9QTFVHSU5fUEFDS0FHRV9TSU1QTEVfSEFTSCAxCisjZW5kaWYKKwogLyogU2V0IHVwIGEgZGVm aW5lIGZvciBhIGNvbW1vbiBlcnJvciB0aGF0IGlzIGludGVuZGVkIHRvIGNhdXNlIGEgYnVpbGQg ZXJyb3IgLS0gdGh1cyB0aGUgc3BhY2UgYWZ0ZXIgRXJyb3IuICovCiAjZGVmaW5lIFdURl9QTEFU Rk9STV9DRk5FVFdPUksgRXJyb3IgVVNFX21hY3JvX3Nob3VsZF9iZV91c2VkX3dpdGhfQ0ZORVRX T1JLCiAKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiA0OTQxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMDktMTAtMTAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlZmFjdG9yIEVOQUJMRV9QTFVHSU5fUEFDS0FHRV9TSU1QTEVfSEFTSAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAyNzgKKwor ICAgICAgICBNb3ZlIHRoZSBkZWZpbml0aW9uIG9mIEVOQUJMRV9QTFVHSU5fUEFDS0FHRV9TSU1Q TEVfSEFTSCAKKyAgICAgICAgZnJvbSB0aGUgbWFrZSBzeXN0ZW0gaW50byBjb21tb24gY29kZS4K KworICAgICAgICBFbmFibGUgRU5BQkxFX1BMVUdJTl9QQUNLQUdFX1NJTVBMRV9IQVNIIGlmIE5F VFNDQVBFX1BMVUdJTl9BUEkgCisgICAgICAgIHN1cHBvcnQgaXMgbm90IGVuYWJsZWQuCisKKyAg ICAgICAgUmVtb3ZlIG5vdEltcGxlbWVudGVkKCkgZnJvbSBQbHVnaW5QYWNrYWdlTm9uZS5jcHAg YW5kIAorICAgICAgICBQbHVnaW5EYXRhTm9uZS5jcHAgbWFrZSB0aGVtIGp1c3QgZW1wdHkgZnVu Y3Rpb25zLgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogV2ViQ29yZS5w cm86CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5EYXRhTm9uZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpQbHVnaW5EYXRhOjppbml0UGx1Z2lucyk6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5E YXRhOjpyZWZyZXNoKToKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyk6CisgICAg ICAgIChXZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjpmZXRjaEluZm8pOgorICAgICAgICAoV2ViQ29y ZTo6UGx1Z2luUGFja2FnZTo6bG9hZCk6CisKIDIwMDktMTAtMDkgIERhcmluIEZpc2hlciAgPGRh cmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5k ZXg6IFdlYkNvcmUvR05VbWFrZWZpbGUuYW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9HTlVtYWtl ZmlsZS5hbQkocmV2aXNpb24gNDk0MTQpCisrKyBXZWJDb3JlL0dOVW1ha2VmaWxlLmFtCSh3b3Jr aW5nIGNvcHkpCkBAIC01NCw3ICs1NCw2IEBAIHdlYmNvcmVfY3BwZmxhZ3MgKz0gXAogCiB3ZWJj b3JlZ3RrX2NwcGZsYWdzICs9IFwKIAktRFdURl9VU0VfU09VUD0xIFwKLSAgICAgICAgLURFTkFC TEVfUExVR0lOX1BBQ0tBR0VfU0lNUExFX0hBU0g9MSBcCiAJLUkkKHNyY2RpcikvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2d0ayBcCiAJLUkkKHNyY2RpcikvV2ViQ29yZS9sb2FkZXIvZ3RrIFwKIAkt SSQoc3JjZGlyKS9XZWJDb3JlL3BhZ2UvZ3RrIFwKSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5wcm8K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnBybwkocmV2aXNpb24gNDk0MTQpCisrKyBX ZWJDb3JlL1dlYkNvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0yNDU3LDggKzI0NTcsNiBAQCBj b250YWlucyhERUZJTkVTLCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOCiAgICAgU09VUkNFUyArPSBw bHVnaW5zL25wYXBpLmNwcAogCiAgICAgdW5peCB7Ci0gICAgICAgIERFRklORVMgKz0gRU5BQkxF X1BMVUdJTl9QQUNLQUdFX1NJTVBMRV9IQVNIPTEKLQogICAgICAgICBtYWMgewogICAgICAgICAg ICAgU09VUkNFUyArPSBcCiAgICAgICAgICAgICAgICAgcGx1Z2lucy9tYWMvUGx1Z2luUGFja2Fn ZU1hYy5jcHAgXApJbmRleDogV2ViQ29yZS9wbHVnaW5zL1BsdWdpbkRhdGFOb25lLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YU5vbmUuY3BwCShyZXZpc2lvbiA0 OTQxNCkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhTm9uZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI3LDE4ICsyNywxNCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlBs dWdpbkRhdGEuaCIKIAotI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCi0KIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiB7Ci0gICAgbm90SW1w bGVtZW50ZWQoKTsKIH0KIAogdm9pZCBQbHVnaW5EYXRhOjpyZWZyZXNoKCkKIHsKLSAgICBub3RJ bXBsZW1lbnRlZCgpOwogfQogCiB9OwpJbmRleDogV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2th Z2VOb25lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5v bmUuY3BwCShyZXZpc2lvbiA0OTQxNCkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdl Tm9uZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDUyICsyNiwyMCBAQAogI2luY2x1ZGUgImNv bmZpZy5oIgogI2luY2x1ZGUgIlBsdWdpblBhY2thZ2UuaCIKIAotI2luY2x1ZGUgIkNTdHJpbmcu aCIKLSNpbmNsdWRlICJNSU1FVHlwZVJlZ2lzdHJ5LmgiCi0jaW5jbHVkZSAiTm90SW1wbGVtZW50 ZWQuaCIKLSNpbmNsdWRlICJucHJ1bnRpbWVfaW1wbC5oIgotI2luY2x1ZGUgIlBsdWdpbkRhdGFi YXNlLmgiCi0jaW5jbHVkZSAiUGx1Z2luRGVidWcuaCIKLQogbmFtZXNwYWNlIFdlYkNvcmUgewog CiB2b2lkIFBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyhjb25zdCBTdHJpbmcmKQogewot ICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZv KCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwogICAgIHJldHVybiBmYWxzZTsKIH0KIAogYm9v bCBQbHVnaW5QYWNrYWdlOjpsb2FkKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJl dHVybiBmYWxzZTsKLX0KLQotI2lmICFFTkFCTEUoUExVR0lOX1BBQ0tBR0VfU0lNUExFX0hBU0gp Ci11bnNpZ25lZCBQbHVnaW5QYWNrYWdlOjpoYXNoKCkgY29uc3QKLXsgCi0gICAgbm90SW1wbGVt ZW50ZWQoKTsKLQotICAgIHJldHVybiAwOwotfQotCi1ib29sIFBsdWdpblBhY2thZ2U6OmVxdWFs KGNvbnN0IFBsdWdpblBhY2thZ2UmLCBjb25zdCBQbHVnaW5QYWNrYWdlJikKLXsKLSAgICBub3RJ bXBsZW1lbnRlZCgpOwogICAgIHJldHVybiBmYWxzZTsKIH0KIAotaW50IFBsdWdpblBhY2thZ2U6 OmNvbXBhcmVGaWxlVmVyc2lvbihjb25zdCBQbGF0Zm9ybU1vZHVsZVZlcnNpb24mKSBjb25zdAot ewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIDA7Ci19Ci0KLSNlbmRpZgotCiB9 Cg==