30250 2009-10-09 05:06:59 -0700 [V8] Add a context scope in JS listener destructor 2014-12-16 00:48:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 sgjesse webkit-unassigned abarth ager commit-queue dglazkov eric oldest_to_newest 153657 0 sgjesse 2009-10-09 05:06:59 -0700 When a page is unloaded the JS listener destructor might be called without an active context. See http//crbug.com/24200. 153658 1 40943 sgjesse 2009-10-09 05:08:53 -0700 Created attachment 40943 patch 153660 2 40944 sgjesse 2009-10-09 05:23:12 -0700 Created attachment 40944 patch 153700 3 eric 2009-10-09 09:42:19 -0700 CCing reviewers who know v8. 153943 4 40944 commit-queue 2009-10-11 15:49:01 -0700 Comment on attachment 40944 patch Clearing flags on attachment: 40944 Committed r49429: <http://trac.webkit.org/changeset/49429> 153944 5 commit-queue 2009-10-11 15:49:05 -0700 All reviewed patches have been landed. Closing bug. 154166 6 dglazkov 2009-10-12 14:32:03 -0700 Has this been tested? It broke the following layout tests across all platforms: LayoutTests/fast/dom/onload-open.html = CRASH LayoutTests/fast/dom/resource-locations-in-created-html-document.html = CRASH LayoutTests/fast/events/invalid-001.html = CRASH LayoutTests/fast/events/keypress-focus-change.html = CRASH LayoutTests/fast/events/mouseover-mouseout.html = CRASH LayoutTests/fast/events/mouseover-mouseout2.html = CRASH LayoutTests/http/tests/loading/gmail-assert-on-load.html = CRASH LayoutTests/http/tests/xmlhttprequest/frame-unload-abort-crash.html = CRASH LayoutTests/http/tests/xmlhttprequest/web-apps/012.html = CRASH LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg = CRASH LayoutTests/svg/custom/js-update-transform-changes.svg = CRASH Can we please, please test before submitting changes? Rolled out in http://trac.webkit.org/changeset/49473. 1055945 7 burg 2014-12-16 00:48:23 -0800 Closing some V8-related work items. 40943 2009-10-09 05:08:53 -0700 2009-10-09 05:22:29 -0700 patch 24200.patch text/plain 1317 sgjesse SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTM4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMDkgIFPDuHJlbiBHamVzc2UgIDxzZ2plc3NlQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbVjhdIEFkZCBhIGNvbnRleHQgc2NvcGUgaW4gSlMgbGlzdGVuZXIgZGVzdHJ1Y3Rvci4gVGhl IGRlc3RydWN0b3IgY29kZSB1c2VzIHRoZSBjb3RleHQuIFNlZSBodHRwOi8vY3JidWcuY29tLzI0 MjAwLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6On5WOEFic3RyYWN0 RXZlbnRMaXN0ZW5lcik6CisKIDIwMDktMTAtMDkgIEdpcmlzaCBSYW1ha3Jpc2huYW4gIDxnaXJp c2hAZm9yd2FyZGJpYXMuaW4+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4u CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVy LmNwcAkocmV2aXNpb24gNDkzODUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RF dmVudExpc3RlbmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzYsNyArNzYsOCBAQCBWOEFic3Ry YWN0RXZlbnRMaXN0ZW5lcjo6VjhBYnN0cmFjdEV2ZW50CiBWOEFic3RyYWN0RXZlbnRMaXN0ZW5l cjo6flY4QWJzdHJhY3RFdmVudExpc3RlbmVyKCkKIHsKICAgICBpZiAoIW1fbGlzdGVuZXIuSXNF bXB0eSgpKSB7Ci0gICAgICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKKyAgICAgICAgdjg6Okhh bmRsZVNjb3BlIGhhbmRsZVNjb3BlOworICAgICAgICB2ODo6Q29udGV4dDo6U2NvcGUgc2NvcGUo bV9jb250ZXh0LT5nZXQoKSk7CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBsaXN0ZW5l ciA9IHY4OjpMb2NhbDx2ODo6T2JqZWN0Pjo6TmV3KG1fbGlzdGVuZXIpOwogICAgICAgICBWOEV2 ZW50TGlzdGVuZXJMaXN0OjpjbGVhcldyYXBwZXIobGlzdGVuZXIsIG1faXNBdHRyaWJ1dGUpOwog ICAgIH0K 40944 2009-10-09 05:23:12 -0700 2010-06-10 19:16:51 -0700 patch 24200.patch text/plain 1372 sgjesse SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTM4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMDkgIFPDuHJlbiBHamVzc2UgIDxzZ2plc3NlQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbVjhdIEFkZCBhIGNvbnRleHQgc2NvcGUgaW4gSlMgbGlzdGVuZXIgZGVzdHJ1Y3Rvci4gVGhl IGRlc3RydWN0b3IgY29kZSB1c2VzIHRoZSBjb3RleHQuIFNlZSBodHRwOi8vY3JidWcuY29tLzI0 MjAwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAy NTAKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjp+VjhBYnN0cmFjdEV2 ZW50TGlzdGVuZXIpOgorCiAyMDA5LTEwLTA5ICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNo QGZvcndhcmRiaWFzLmluPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5j cHAJKHJldmlzaW9uIDQ5Mzg1KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZl bnRMaXN0ZW5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc2LDcgKzc2LDggQEAgVjhBYnN0cmFj dEV2ZW50TGlzdGVuZXI6OlY4QWJzdHJhY3RFdmVudAogVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6 On5WOEFic3RyYWN0RXZlbnRMaXN0ZW5lcigpCiB7CiAgICAgaWYgKCFtX2xpc3RlbmVyLklzRW1w dHkoKSkgewotICAgICAgICB2ODo6SGFuZGxlU2NvcGUgc2NvcGU7CisgICAgICAgIHY4OjpIYW5k bGVTY29wZSBoYW5kbGVTY29wZTsKKyAgICAgICAgdjg6OkNvbnRleHQ6OlNjb3BlIHNjb3BlKG1f Y29udGV4dC0+Z2V0KCkpOwogICAgICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gbGlzdGVuZXIg PSB2ODo6TG9jYWw8djg6Ok9iamVjdD46Ok5ldyhtX2xpc3RlbmVyKTsKICAgICAgICAgVjhFdmVu dExpc3RlbmVyTGlzdDo6Y2xlYXJXcmFwcGVyKGxpc3RlbmVyLCBtX2lzQXR0cmlidXRlKTsKICAg ICB9Cg==