30244 2009-10-08 21:51:02 -0700 Wrong Position of #endif in Document::finishedParsing() 2009-10-11 15:34:18 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 lyon.chen webkit-unassigned commit-queue oldest_to_newest 153607 0 lyon.chen 2009-10-08 21:51:02 -0700 In WebCore\dom\Document.cpp, the position of #endif is wrong. if (Frame* f = frame()) { f->loader()->finishedParsing(); #if ENABLE(INSPECTOR) if (!page()) return; if (InspectorController* controller = page()->inspectorController()) controller->mainResourceFiredDOMContentEvent(f->loader()->documentLoader(), url()); } #endif Should be changed to: if (Frame* f = frame()) { f->loader()->finishedParsing(); #if ENABLE(INSPECTOR) if (!page()) return; if (InspectorController* controller = page()->inspectorController()) controller->mainResourceFiredDOMContentEvent(f->loader()->documentLoader(), url()); #endif } 153608 1 40928 lyon.chen 2009-10-08 22:02:30 -0700 Created attachment 40928 Patch for bug 30244 This patch fix the error. 153670 2 40946 lyon.chen 2009-10-09 06:07:38 -0700 Created attachment 40946 Patch for bug 30244 with change log. 153797 3 40946 ap 2009-10-09 16:16:58 -0700 Comment on attachment 40946 Patch for bug 30244 with change log. To make sure that your patch isn't overlooked, please set review flag to "?" next time. r=me 153940 4 40946 commit-queue 2009-10-11 15:34:13 -0700 Comment on attachment 40946 Patch for bug 30244 with change log. Clearing flags on attachment: 40946 Committed r49428: <http://trac.webkit.org/changeset/49428> 153941 5 commit-queue 2009-10-11 15:34:18 -0700 All reviewed patches have been landed. Closing bug. 40928 2009-10-08 22:02:30 -0700 2009-10-08 22:02:30 -0700 Patch for bug 30244 PatchFor30244.patch text/plain 450 lyon.chen SW5kZXg6IGRvbS9Eb2N1bWVudC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBkb20vRG9jdW1lbnQuY3Bw CShyZXZpc2lvbiA0OTM3MSkNCisrKyBkb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpDQpA QCAtNDAyNSw4ICs0MDI1LDggQEANCiAKICAgICAgICAgaWYgKEluc3BlY3RvckNvbnRyb2xsZXIq IGNvbnRyb2xsZXIgPSBwYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIoKSkKICAgICAgICAgICAg IGNvbnRyb2xsZXItPm1haW5SZXNvdXJjZUZpcmVkRE9NQ29udGVudEV2ZW50KGYtPmxvYWRlcigp LT5kb2N1bWVudExvYWRlcigpLCB1cmwoKSk7CisjZW5kaWYKICAgICB9Ci0jZW5kaWYKIH0KIAog VmVjdG9yPFN0cmluZz4gRG9jdW1lbnQ6OmZvcm1FbGVtZW50c1N0YXRlKCkgY29uc3QK 40946 2009-10-09 06:07:38 -0700 2009-10-11 15:34:13 -0700 Patch for bug 30244 with change log. ParchFor30244.txt text/plain 1182 lyon.chen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTM4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMDkgIEx5b24gQ2hlbiAgPGx5b24uY2hlbkB0b3JjaG1v YmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ29ycmVjdCB0aGUgcG9zaXRpb24gb2YgI2VuZGlmIHNlbnRlbmNlIGluc2lkZSBXZWJDb3Jl OjpEb2N1bWVudDo6ZmluaXNoZWRQYXJzaW5nKCkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMjQ0CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgcmVx dWlyZXMgbm8gdGVzdCBjYXNlIGFzIGl0IGZpeCBhIGNvbXBpbGluZyBlcnJvci4KKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6ZmluaXNo ZWRQYXJzaW5nKToKKwogMjAwOS0xMC0wOSAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBm b3J3YXJkYmlhcy5pbj4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5k ZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAJKHJldmlzaW9uIDQ5MzcxKQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00MDI1LDggKzQwMjUsOCBAQCB2b2lkIERvY3VtZW50OjpmaW5p c2hlZFBhcnNpbmcoKQogCiAgICAgICAgIGlmIChJbnNwZWN0b3JDb250cm9sbGVyKiBjb250cm9s bGVyID0gcGFnZSgpLT5pbnNwZWN0b3JDb250cm9sbGVyKCkpCiAgICAgICAgICAgICBjb250cm9s bGVyLT5tYWluUmVzb3VyY2VGaXJlZERPTUNvbnRlbnRFdmVudChmLT5sb2FkZXIoKS0+ZG9jdW1l bnRMb2FkZXIoKSwgdXJsKCkpOwotICAgIH0KICNlbmRpZgorICAgIH0KIH0KIAogVmVjdG9yPFN0 cmluZz4gRG9jdW1lbnQ6OmZvcm1FbGVtZW50c1N0YXRlKCkgY29uc3QK