30235 2009-10-08 14:28:17 -0700 [Qt] beforeload event does not fire on script elements in XML 2009-10-09 05:32:16 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jwieczorek webkit-unassigned commit-queue oldest_to_newest 153541 0 jwieczorek 2009-10-08 14:28:17 -0700 https://bugs.webkit.org/show_bug.cgi?id=30131 made the beforeload event fire on script elements but only performed the necessary change to XMLTokenizerLibxml2.cpp, omitting the Qt tokenizer. Affected test: fast/dom/beforeload/script-before-load-xhtml.xhtml 153542 1 40912 jwieczorek 2009-10-08 14:31:45 -0700 Created attachment 40912 proposed patch 153656 2 40912 hausmann 2009-10-09 04:56:28 -0700 Comment on attachment 40912 proposed patch Good catch, thanks! 153662 3 40912 commit-queue 2009-10-09 05:32:13 -0700 Comment on attachment 40912 proposed patch Clearing flags on attachment: 40912 Committed r49388: <http://trac.webkit.org/changeset/49388> 153663 4 commit-queue 2009-10-09 05:32:16 -0700 All reviewed patches have been landed. Closing bug. 40912 2009-10-08 14:31:45 -0700 2009-10-09 05:32:13 -0700 proposed patch 0001-Qt-beforeload-event-does-not-fire-on-script-elements.patch text/plain 1953 jwieczorek RnJvbSA3Mzg1YWJjMmI0NTgzNmIwMTY5YTdhN2NlNjZiNzZiYWQzYjViZWVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IEZyaSwgOSBPY3QgMjAwOSAwMTowMTo0NiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0g YmVmb3JlbG9hZCBldmVudCBkb2VzIG5vdCBmaXJlIG9uIHNjcmlwdCBlbGVtZW50cyBpbiBYTUwK IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDIzNQoKcjQ5MTk0IHdh cyBsYWNraW5nIGEgY2hhbmdlIHRvIFhNTFRva2VuaXplclF0LmNwcCwgZXF1aXZhbGVudCB0byB0 aGUgb25lCm1hZGUgaW4gWE1MVG9rZW5pemVyTGlieG1sMi5jcHAuCi0tLQogV2ViQ29yZS9DaGFu Z2VMb2cgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJDb3JlL2RvbS9YTUxU b2tlbml6ZXJRdC5jcHAgfCAgICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggMTVkNTUxYy4uZjVkMzY0MiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAw OS0xMC0wOCAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIGJlZm9yZWxvYWQgZXZl bnQgZG9lcyBub3QgZmlyZSBvbiBzY3JpcHQgZWxlbWVudHMgaW4gWE1MCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDIzNQorCisgICAgICAgIHI0OTE5 NCB3YXMgbGFja2luZyBhIGNoYW5nZSB0byBYTUxUb2tlbml6ZXJRdC5jcHAsIGVxdWl2YWxlbnQg dG8gdGhlIG9uZQorICAgICAgICBtYWRlIGluIFhNTFRva2VuaXplckxpYnhtbDIuY3BwLgorCisg ICAgICAgICogZG9tL1hNTFRva2VuaXplclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhNTFRv a2VuaXplcjo6cGFyc2VFbmRFbGVtZW50KToKKwogMjAwOS0xMC0wOCAgRGF2ZSBIeWF0dCAgPGh5 YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvZG9tL1hNTFRva2VuaXplclF0LmNwcCBiL1dlYkNvcmUvZG9tL1hNTFRv a2VuaXplclF0LmNwcAppbmRleCAwNDQwNWQ2Li5jYjM0ODMyIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2RvbS9YTUxUb2tlbml6ZXJRdC5jcHAKKysrIGIvV2ViQ29yZS9kb20vWE1MVG9rZW5pemVyUXQu Y3BwCkBAIC02MTEsNyArNjExLDggQEAgdm9pZCBYTUxUb2tlbml6ZXI6OnBhcnNlRW5kRWxlbWVu dCgpCiAgICAgICAgIGlmICghc2NyaXB0SHJlZi5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgIC8v IHdlIGhhdmUgYSBzcmMgYXR0cmlidXRlIAogICAgICAgICAgICAgU3RyaW5nIHNjcmlwdENoYXJz ZXQgPSBzY3JpcHRFbGVtZW50LT5zY3JpcHRDaGFyc2V0KCk7Ci0gICAgICAgICAgICBpZiAoKG1f cGVuZGluZ1NjcmlwdCA9IG1fZG9jLT5kb2NMb2FkZXIoKS0+cmVxdWVzdFNjcmlwdChzY3JpcHRI cmVmLCBzY3JpcHRDaGFyc2V0KSkpIHsKKyAgICAgICAgICAgIGlmIChlbGVtZW50LT5kaXNwYXRj aEJlZm9yZUxvYWRFdmVudChzY3JpcHRIcmVmKSAmJgorICAgICAgICAgICAgICAgIChtX3BlbmRp bmdTY3JpcHQgPSBtX2RvYy0+ZG9jTG9hZGVyKCktPnJlcXVlc3RTY3JpcHQoc2NyaXB0SHJlZiwg c2NyaXB0Q2hhcnNldCkpKSB7CiAgICAgICAgICAgICAgICAgbV9zY3JpcHRFbGVtZW50ID0gZWxl bWVudDsKICAgICAgICAgICAgICAgICBtX3BlbmRpbmdTY3JpcHQtPmFkZENsaWVudCh0aGlzKTsK IAotLSAKMS42LjQuNAoK