30220 2009-10-08 10:01:11 -0700 [GTK] middle-click-onpaste.html test does not work 2009-10-08 14:12:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 alex webkit-unassigned commit-queue vandebo xan.lopez zan oldest_to_newest 153422 0 40885 alex 2009-10-08 10:01:11 -0700 Created attachment 40885 Patch proposed to support the parameter in mouseDown function We have two problems with this tests: - DRT EventSend mouseDown does not support the parameter setting the button that was pressed. - The expected result has a line in the bottom that we are not generating. I have a patch for the first point (Zan Dobersek could you review it) and for the second point I added Steve VanDeBogart (the developer that added this example), Steve is it a problem if we add that line to the end of the file? 153427 1 xan.lopez 2009-10-08 10:09:23 -0700 Also, adding tests to platform/gtk that fail in the WebKitGTK+ port shouldn't be done. If the tests can be shared between Chrome/GTK+ and WebKitGTK+ then that's great, but otherwise they should go elsewhere. In this case it seems this test was depending on some DRT functionality not present in our port, so it couldn't have possibly worked. 153430 2 vandebo 2009-10-08 10:16:50 -0700 I don't see what line you are proposing to add. Xan: This was part of my first change in webkit, so I certainly could have added it in the wrong place. The test works in the chromium test shell, but I didn't try it in DRT. 153432 3 40889 alex 2009-10-08 10:23:05 -0700 Created attachment 40889 Patch reviewed Fixed the style and added the exception handling. 153434 4 alex 2009-10-08 10:30:08 -0700 (In reply to comment #2) > I don't see what line you are proposing to add. > I meant adding one line here in the bottom of this file: WebKit$ cat platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt Test that middle click triggers the onpaste event On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS pasteCount is 1 PASS successfullyParsed is true TEST COMPLETE ------> One new line here <--------- We need to add it to pass the test so if you could add that line and your test is still ok it will help us. 153439 5 vandebo 2009-10-08 10:43:47 -0700 (In reply to comment #4) > (In reply to comment #2) > > I don't see what line you are proposing to add. > > I meant adding one line here in the bottom of this file: > > TEST COMPLETE > ------> One new line here <--------- > > We need to add it to pass the test so if you could add that line and your test > is still ok it will help us. That white space doesn't affect my test run. Go ahead and add it. 153445 6 alex 2009-10-08 11:03:21 -0700 (In reply to comment #5) > That white space doesn't affect my test run. Go ahead and add it. Ok, thanks for the information, I'm going to upload a patch for this. 153446 7 40892 alex 2009-10-08 11:05:17 -0700 Created attachment 40892 Add line to the expected result 153447 8 40893 alex 2009-10-08 11:08:08 -0700 Created attachment 40893 Added bug URL to the Changelog 153450 9 40892 xan.lopez 2009-10-08 11:12:07 -0700 Comment on attachment 40892 Add line to the expected result r=me 153452 10 40893 eric 2009-10-08 11:14:47 -0700 Comment on attachment 40893 Added bug URL to the Changelog Personally I don't find g_return_val_if_fail very readable. if (!exception || !*exception) return JSValueMakeUndefined(context); is the same number of characters, split over 2 lines, and much more readable to those of us who don't hack on gtk normally. :) Also, I think that this should just assert(!exception) instead. The testing tool is allowed to fail hard in cases like this. 153454 11 40893 xan.lopez 2009-10-08 11:23:37 -0700 Comment on attachment 40893 Added bug URL to the Changelog I disagree with Eric. The code already uses g_return_val_if_fail everywhere, so if we were to change it we should do it all at once. Besides, I don't think it makes any sense to let DRT do stupid things (or crash) when you already know the input is wrong. This is what g_return_* is for. In any case the logic in these checks is wrong, so we are going to do another patch to change them all at once. I'm going to r+ this now so we can pass the tests. 153455 12 alex 2009-10-08 11:27:20 -0700 (In reply to comment #10) > (From update of attachment 40893 [details]) > Personally I don't find g_return_val_if_fail very readable. > > if (!exception || !*exception) > return JSValueMakeUndefined(context); > is the same number of characters, split over 2 lines, and much more readable to > those of us who don't hack on gtk normally. :) > Well, I'm not the one deciding about using or not the return if fail, they are all over the code, maybe you should open a bug to discuss this. > Also, I think that this should just assert(!exception) instead. The testing > tool is allowed to fail hard in cases like this. I agree with you here :), I copied the tests that were done in all this code for the exceptions and they do not look right. I'll upload a new bug to change all the checks for once. 153473 13 alex 2009-10-08 12:19:23 -0700 Added the bug 30229 regarding the handling of the exceptions. 153527 14 40892 commit-queue 2009-10-08 14:05:12 -0700 Comment on attachment 40892 Add line to the expected result Clearing flags on attachment: 40892 Committed r49316: <http://trac.webkit.org/changeset/49316> 153530 15 40893 commit-queue 2009-10-08 14:12:28 -0700 Comment on attachment 40893 Added bug URL to the Changelog Clearing flags on attachment: 40893 Committed r49318: <http://trac.webkit.org/changeset/49318> 153531 16 commit-queue 2009-10-08 14:12:31 -0700 All reviewed patches have been landed. Closing bug. 40885 2009-10-08 10:01:11 -0700 2009-10-08 10:23:05 -0700 Patch proposed to support the parameter in mouseDown function middle_button_test.patch text/plain 1729 alex ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZDliOWNiLi40MDk3NGQ5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAt MDggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQWRkZWQgc3VwcG9ydCBm b3IgYSBwYXJhbWV0ZXIgc2V0dGluZyB0aGUgYnV0dG9uIHRoYXQgd2FzCisgICAgICAgIHByZXNz ZWQgaW4gdGhlIG1vdXNlRG93biBmdW5jdGlvbi4KKworICAgICAgICAqIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHA6CisKIDIwMDktMTAtMDYgIEpha3ViIFdp ZWN6b3JlayAgPGZhdzIxN0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24g SGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZl bnRTZW5kZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVy LmNwcAppbmRleCA4ZWU3NGM4Li5kMmQ0ZjlmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKQEAgLTEzOSw3ICsxMzksOCBAQCBzdGF0aWMgSlNW YWx1ZVJlZiBtb3VzZURvd25DYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RS ZWYgZnVuY3Rpb24sCiAgICAgR2RrRXZlbnQgZXZlbnQ7CiAgICAgbWVtc2V0KCZldmVudCwgMCwg c2l6ZW9mKGV2ZW50KSk7CiAgICAgZXZlbnQudHlwZSA9IEdES19CVVRUT05fUFJFU1M7Ci0gICAg ZXZlbnQuYnV0dG9uLmJ1dHRvbiA9IDE7CisgICAgaWYgKGFyZ3VtZW50Q291bnQgPT0gMSkKKyAg ICAgIGV2ZW50LmJ1dHRvbi5idXR0b24gPSAoaW50KUpTVmFsdWVUb051bWJlcihjb250ZXh0LCBh cmd1bWVudHNbMF0sIGV4Y2VwdGlvbikrMTsKICAgICBldmVudC5idXR0b24ueCA9IGxhc3RNb3Vz ZVBvc2l0aW9uWDsKICAgICBldmVudC5idXR0b24ueSA9IGxhc3RNb3VzZVBvc2l0aW9uWTsKICAg ICBldmVudC5idXR0b24ud2luZG93ID0gR1RLX1dJREdFVCh2aWV3KS0+d2luZG93OwpAQCAtMTc2 LDcgKzE3Nyw4IEBAIHN0YXRpYyBKU1ZhbHVlUmVmIG1vdXNlVXBDYWxsYmFjayhKU0NvbnRleHRS ZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24sIEpTCiAgICAgR2RrRXZlbnQgZXZlbnQ7 CiAgICAgbWVtc2V0KCZldmVudCwgMCwgc2l6ZW9mKGV2ZW50KSk7CiAgICAgZXZlbnQudHlwZSA9 IEdES19CVVRUT05fUkVMRUFTRTsKLSAgICBldmVudC5idXR0b24uYnV0dG9uID0gMTsKKyAgICBp ZiAoYXJndW1lbnRDb3VudCA9PSAxKQorICAgICAgZXZlbnQuYnV0dG9uLmJ1dHRvbiA9IChpbnQp SlNWYWx1ZVRvTnVtYmVyKGNvbnRleHQsIGFyZ3VtZW50c1swXSwgZXhjZXB0aW9uKSsxOwogICAg IGV2ZW50LmJ1dHRvbi54ID0gbGFzdE1vdXNlUG9zaXRpb25YOwogICAgIGV2ZW50LmJ1dHRvbi55 ID0gbGFzdE1vdXNlUG9zaXRpb25ZOwogICAgIGV2ZW50LmJ1dHRvbi53aW5kb3cgPSBHVEtfV0lE R0VUKHZpZXcpLT53aW5kb3c7Cg== 40889 2009-10-08 10:23:05 -0700 2009-10-08 11:08:08 -0700 Patch reviewed middle_button_test.patch text/plain 1939 alex ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZDliOWNiLi40MDk3NGQ5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAt MDggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQWRkZWQgc3VwcG9ydCBm b3IgYSBwYXJhbWV0ZXIgc2V0dGluZyB0aGUgYnV0dG9uIHRoYXQgd2FzCisgICAgICAgIHByZXNz ZWQgaW4gdGhlIG1vdXNlRG93biBmdW5jdGlvbi4KKworICAgICAgICAqIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHA6CisKIDIwMDktMTAtMDYgIEpha3ViIFdp ZWN6b3JlayAgPGZhdzIxN0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24g SGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZl bnRTZW5kZXIuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVy LmNwcAppbmRleCA4ZWU3NGM4Li4zNmRkY2ViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKQEAgLTEzOSw3ICsxMzksMTAgQEAgc3RhdGljIEpT VmFsdWVSZWYgbW91c2VEb3duQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0 UmVmIGZ1bmN0aW9uLAogICAgIEdka0V2ZW50IGV2ZW50OwogICAgIG1lbXNldCgmZXZlbnQsIDAs IHNpemVvZihldmVudCkpOwogICAgIGV2ZW50LnR5cGUgPSBHREtfQlVUVE9OX1BSRVNTOwotICAg IGV2ZW50LmJ1dHRvbi5idXR0b24gPSAxOworICAgIGlmIChhcmd1bWVudENvdW50ID09IDEpIHsK KyAgICAgICAgZXZlbnQuYnV0dG9uLmJ1dHRvbiA9IChpbnQpSlNWYWx1ZVRvTnVtYmVyKGNvbnRl eHQsIGFyZ3VtZW50c1swXSwgZXhjZXB0aW9uKSArIDE7CisgICAgICAgIGdfcmV0dXJuX3ZhbF9p Zl9mYWlsKCghZXhjZXB0aW9uIHx8ICEqZXhjZXB0aW9uKSwgSlNWYWx1ZU1ha2VVbmRlZmluZWQo Y29udGV4dCkpOworICAgIH0KICAgICBldmVudC5idXR0b24ueCA9IGxhc3RNb3VzZVBvc2l0aW9u WDsKICAgICBldmVudC5idXR0b24ueSA9IGxhc3RNb3VzZVBvc2l0aW9uWTsKICAgICBldmVudC5i dXR0b24ud2luZG93ID0gR1RLX1dJREdFVCh2aWV3KS0+d2luZG93OwpAQCAtMTc2LDcgKzE3OSwx MCBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBtb3VzZVVwQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRl eHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKUwogICAgIEdka0V2ZW50IGV2ZW50OwogICAgIG1l bXNldCgmZXZlbnQsIDAsIHNpemVvZihldmVudCkpOwogICAgIGV2ZW50LnR5cGUgPSBHREtfQlVU VE9OX1JFTEVBU0U7Ci0gICAgZXZlbnQuYnV0dG9uLmJ1dHRvbiA9IDE7CisgICAgaWYgKGFyZ3Vt ZW50Q291bnQgPT0gMSkgeworICAgICAgICBldmVudC5idXR0b24uYnV0dG9uID0gKGludClKU1Zh bHVlVG9OdW1iZXIoY29udGV4dCwgYXJndW1lbnRzWzBdLCBleGNlcHRpb24pICsgMTsKKyAgICAg ICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoKCFleGNlcHRpb24gfHwgISpleGNlcHRpb24pLCBKU1Zh bHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KSk7CisgICAgfQogICAgIGV2ZW50LmJ1dHRvbi54ID0g bGFzdE1vdXNlUG9zaXRpb25YOwogICAgIGV2ZW50LmJ1dHRvbi55ID0gbGFzdE1vdXNlUG9zaXRp b25ZOwogICAgIGV2ZW50LmJ1dHRvbi53aW5kb3cgPSBHVEtfV0lER0VUKHZpZXcpLT53aW5kb3c7 Cg== 40892 2009-10-08 11:05:17 -0700 2009-10-08 14:05:12 -0700 Add line to the expected result middle_button_add_line.patch text/plain 1067 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9lZGl0aW5nL3Bhc3RlYm9hcmQv bWlkZGxlLWNsaWNrLW9ucGFzdGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL2VkaXRpbmcvcGFzdGVib2FyZC9taWRkbGUtY2xpY2stb25wYXN0ZS1leHBlY3RlZC50eHQK aW5kZXggZDhjMjBkNy4uZmNiMjQ4OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL2VkaXRpbmcvcGFzdGVib2FyZC9taWRkbGUtY2xpY2stb25wYXN0ZS1leHBlY3RlZC50eHQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2VkaXRpbmcvcGFzdGVib2FyZC9taWRkbGUt Y2xpY2stb25wYXN0ZS1leHBlY3RlZC50eHQKQEAgLTcsMyArNyw0IEBAIFBBU1MgcGFzdGVDb3Vu dCBpcyAxCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK KwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCmluZGV4IGVkOWI5Y2IuLmJmMzEzMTAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5n ZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0x MC0wOCAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBBZGRlZCBhIGxpbmUg dG8gdGhlIGJvdHRvbSBvZiB0aGUgZXhwZWN0ZWQgcmVzdWx0IHRvIG1hdGNoCisgICAgICAgIHRo ZSBvdXRwdXQgb2YgdGhlIHRlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMDIyMAorCisgICAgICAgICogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L2VkaXRpbmcvcGFzdGVib2FyZC9taWRkbGUtY2xpY2stb25wYXN0ZS0KKyAgICAgICAgZXhwZWN0 ZWQudHh0OgorCiAyMDA5LTEwLTA2ICBKYWt1YiBXaWVjem9yZWsgIDxmYXcyMTdAZ21haWwuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgo= 40893 2009-10-08 11:08:08 -0700 2009-10-08 14:12:28 -0700 Added bug URL to the Changelog middle_button_test.patch text/plain 1994 alex ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZDliOWNiLi4wMTNmNWIzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAt MDggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQWRkZWQgc3VwcG9ydCBm b3IgYSBwYXJhbWV0ZXIgc2V0dGluZyB0aGUgYnV0dG9uIHRoYXQgd2FzCisgICAgICAgIHByZXNz ZWQgaW4gdGhlIG1vdXNlRG93biBmdW5jdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMjIwCisKKyAgICAgICAgKiBXZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwOgorCiAyMDA5LTEwLTA2ICBKYWt1YiBXaWVj em9yZWsgIDxmYXcyMTdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhh dXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50 U2VuZGVyLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5j cHAKaW5kZXggOGVlNzRjOC4uMzZkZGNlYiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCkBAIC0xMzksNyArMTM5LDEwIEBAIHN0YXRpYyBKU1Zh bHVlUmVmIG1vdXNlRG93bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJl ZiBmdW5jdGlvbiwKICAgICBHZGtFdmVudCBldmVudDsKICAgICBtZW1zZXQoJmV2ZW50LCAwLCBz aXplb2YoZXZlbnQpKTsKICAgICBldmVudC50eXBlID0gR0RLX0JVVFRPTl9QUkVTUzsKLSAgICBl dmVudC5idXR0b24uYnV0dG9uID0gMTsKKyAgICBpZiAoYXJndW1lbnRDb3VudCA9PSAxKSB7Cisg ICAgICAgIGV2ZW50LmJ1dHRvbi5idXR0b24gPSAoaW50KUpTVmFsdWVUb051bWJlcihjb250ZXh0 LCBhcmd1bWVudHNbMF0sIGV4Y2VwdGlvbikgKyAxOworICAgICAgICBnX3JldHVybl92YWxfaWZf ZmFpbCgoIWV4Y2VwdGlvbiB8fCAhKmV4Y2VwdGlvbiksIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNv bnRleHQpKTsKKyAgICB9CiAgICAgZXZlbnQuYnV0dG9uLnggPSBsYXN0TW91c2VQb3NpdGlvblg7 CiAgICAgZXZlbnQuYnV0dG9uLnkgPSBsYXN0TW91c2VQb3NpdGlvblk7CiAgICAgZXZlbnQuYnV0 dG9uLndpbmRvdyA9IEdUS19XSURHRVQodmlldyktPndpbmRvdzsKQEAgLTE3Niw3ICsxNzksMTAg QEAgc3RhdGljIEpTVmFsdWVSZWYgbW91c2VVcENhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0 LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlMKICAgICBHZGtFdmVudCBldmVudDsKICAgICBtZW1z ZXQoJmV2ZW50LCAwLCBzaXplb2YoZXZlbnQpKTsKICAgICBldmVudC50eXBlID0gR0RLX0JVVFRP Tl9SRUxFQVNFOwotICAgIGV2ZW50LmJ1dHRvbi5idXR0b24gPSAxOworICAgIGlmIChhcmd1bWVu dENvdW50ID09IDEpIHsKKyAgICAgICAgZXZlbnQuYnV0dG9uLmJ1dHRvbiA9IChpbnQpSlNWYWx1 ZVRvTnVtYmVyKGNvbnRleHQsIGFyZ3VtZW50c1swXSwgZXhjZXB0aW9uKSArIDE7CisgICAgICAg IGdfcmV0dXJuX3ZhbF9pZl9mYWlsKCghZXhjZXB0aW9uIHx8ICEqZXhjZXB0aW9uKSwgSlNWYWx1 ZU1ha2VVbmRlZmluZWQoY29udGV4dCkpOworICAgIH0KICAgICBldmVudC5idXR0b24ueCA9IGxh c3RNb3VzZVBvc2l0aW9uWDsKICAgICBldmVudC5idXR0b24ueSA9IGxhc3RNb3VzZVBvc2l0aW9u WTsKICAgICBldmVudC5idXR0b24ud2luZG93ID0gR1RLX1dJREdFVCh2aWV3KS0+d2luZG93Owo=