30217 2009-10-08 09:43:50 -0700 SVGURIReference Build problem for V8 2009-10-08 14:20:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 johnnyg johnnyg atwilson oldest_to_newest 153409 0 johnnyg 2009-10-08 09:43:50 -0700 We don't need to directly build SVGURIReference in V8 - these properties are only accessed by inheritance; it used to be harmless but recent changes cause it to fail in compile. 153415 1 40881 johnnyg 2009-10-08 09:55:31 -0700 Created attachment 40881 patch 153416 2 johnnyg 2009-10-08 09:56:53 -0700 To be more specific, the fix is to not generate and compile in code directly from SVGURIReference.idl. The interface therein should only be used through derived classes. 153417 3 40881 eric 2009-10-08 09:56:55 -0700 Comment on attachment 40881 patch Tab in ChangeLog will cause commit to fail. Normally I don't put anything around urls, the [] seem superfluous to me. LGTM. 153419 4 40882 johnnyg 2009-10-08 09:58:10 -0700 Created attachment 40882 better patch 153503 5 40906 johnnyg 2009-10-08 13:25:54 -0700 Created attachment 40906 patch part 2 A second patch is required to fix this problem, as the .h file is still referenced. 153507 6 40906 dglazkov 2009-10-08 13:30:39 -0700 Comment on attachment 40906 patch part 2 r=me. 153532 7 40882 johnnyg 2009-10-08 14:17:13 -0700 Comment on attachment 40882 better patch already applied. 153534 8 atwilson 2009-10-08 14:20:05 -0700 Landed as r49319 40881 2009-10-08 09:55:31 -0700 2009-10-08 09:58:10 -0700 patch bug30217.diff text/plain 1620 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTMwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMDggIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGJ1aWxkIHByb2JsZW0gd2l0aCBTVkdVUklSZWZlcmVuY2UgaW4gVjguCisJW2h0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDIxN10KKworICAgICAgICBObyBuZXcgdGVz dHMsIGp1c3QgYSBidWlsZCBmaXguCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAgICAg ICogYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHA6CisKIDIwMDktMTAtMDgg IERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5neXBpCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvV2ViQ29yZS5neXBpCShyZXZpc2lvbiA0OTMwNSkKKysrIFdlYkNvcmUvV2ViQ29yZS5n eXBpCSh3b3JraW5nIGNvcHkpCkBAIC0zNDYsNyArMzQ2LDYgQEAKICAgICAgICAgICAgICdzdmcv U1ZHVHJhbnNmb3JtLmlkbCcsCiAgICAgICAgICAgICAnc3ZnL1NWR1RyYW5zZm9ybUxpc3QuaWRs JywKICAgICAgICAgICAgICdzdmcvU1ZHVHJhbnNmb3JtYWJsZS5pZGwnLAotICAgICAgICAgICAg J3N2Zy9TVkdVUklSZWZlcmVuY2UuaWRsJywKICAgICAgICAgICAgICdzdmcvU1ZHVW5pdFR5cGVz LmlkbCcsCiAgICAgICAgICAgICAnc3ZnL1NWR1VzZUVsZW1lbnQuaWRsJywKICAgICAgICAgICAg ICdzdmcvU1ZHVmlld0VsZW1lbnQuaWRsJywKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvRGVy aXZlZFNvdXJjZXNBbGxJbk9uZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92 OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcAkocmV2aXNpb24gNDkzMDUpCisrKyBXZWJDb3Jl L2JpbmRpbmdzL3Y4L0Rlcml2ZWRTb3VyY2VzQWxsSW5PbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zMjIsNyArMzIyLDYgQEAKICNpbmNsdWRlICJiaW5kaW5ncy9WOFNWR1RSZWZFbGVtZW50LmNw cCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFNWR1RTcGFuRWxlbWVudC5jcHAiCiAjaW5jbHVkZSAi YmluZGluZ3MvVjhTVkdVbml0VHlwZXMuY3BwIgotI2luY2x1ZGUgImJpbmRpbmdzL1Y4U1ZHVVJJ UmVmZXJlbmNlLmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFNWR1VzZUVsZW1lbnQuY3BwIgog I2luY2x1ZGUgImJpbmRpbmdzL1Y4U1ZHVmlld0VsZW1lbnQuY3BwIgogI2luY2x1ZGUgImJpbmRp bmdzL1Y4U1ZHWm9vbUV2ZW50LmNwcCIK 40882 2009-10-08 09:58:10 -0700 2009-10-08 14:17:13 -0700 better patch bug30217.diff text/plain 1625 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTMwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMDggIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGJ1aWxkIHByb2JsZW0gd2l0aCBTVkdVUklSZWZlcmVuY2UgaW4gVjguCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDIxNworCisgICAgICAgIE5vIG5l dyB0ZXN0cywganVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIFdlYkNvcmUuZ3lwaToKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcDoKKwogMjAwOS0x MC0wOCAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLmd5cGkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9XZWJDb3JlLmd5cGkJKHJldmlzaW9uIDQ5MzA1KQorKysgV2ViQ29yZS9XZWJD b3JlLmd5cGkJKHdvcmtpbmcgY29weSkKQEAgLTM0Niw3ICszNDYsNiBAQAogICAgICAgICAgICAg J3N2Zy9TVkdUcmFuc2Zvcm0uaWRsJywKICAgICAgICAgICAgICdzdmcvU1ZHVHJhbnNmb3JtTGlz dC5pZGwnLAogICAgICAgICAgICAgJ3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmlkbCcsCi0gICAgICAg ICAgICAnc3ZnL1NWR1VSSVJlZmVyZW5jZS5pZGwnLAogICAgICAgICAgICAgJ3N2Zy9TVkdVbml0 VHlwZXMuaWRsJywKICAgICAgICAgICAgICdzdmcvU1ZHVXNlRWxlbWVudC5pZGwnLAogICAgICAg ICAgICAgJ3N2Zy9TVkdWaWV3RWxlbWVudC5pZGwnLApJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92 OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRp bmdzL3Y4L0Rlcml2ZWRTb3VyY2VzQWxsSW5PbmUuY3BwCShyZXZpc2lvbiA0OTMwNSkKKysrIFdl YkNvcmUvYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9uZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMyMiw3ICszMjIsNiBAQAogI2luY2x1ZGUgImJpbmRpbmdzL1Y4U1ZHVFJlZkVsZW1l bnQuY3BwIgogI2luY2x1ZGUgImJpbmRpbmdzL1Y4U1ZHVFNwYW5FbGVtZW50LmNwcCIKICNpbmNs dWRlICJiaW5kaW5ncy9WOFNWR1VuaXRUeXBlcy5jcHAiCi0jaW5jbHVkZSAiYmluZGluZ3MvVjhT VkdVUklSZWZlcmVuY2UuY3BwIgogI2luY2x1ZGUgImJpbmRpbmdzL1Y4U1ZHVXNlRWxlbWVudC5j cHAiCiAjaW5jbHVkZSAiYmluZGluZ3MvVjhTVkdWaWV3RWxlbWVudC5jcHAiCiAjaW5jbHVkZSAi YmluZGluZ3MvVjhTVkdab29tRXZlbnQuY3BwIgo= 40906 2009-10-08 13:25:54 -0700 2009-10-08 14:20:18 -0700 patch part 2 bug_30217b.diff text/plain 1040 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTMxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMDggIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU1ZH VVJJUmVmZXJlbmNlIEJ1aWxkIHByb2JsZW0gZm9yIFY4LiAgQW4gYWRkaXRpb25hbCBzdGFsZSBy ZWZlcmVuY2UgdG8gU1ZHVVJJUmVmZXJlbmNlIGJpbmRpbmdzCisgICAgICAgIHdoaWNoIHdhc24n dCBleHBvc2VkIHVudGlsIGEgY2xlYW4gYnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDIxNworCisgICAgICAgIE5vIG5ldyB0ZXN0cywganVz dCBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4SW5kZXguY3BwOgorCiAy MDA5LTEwLTA4ICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9WOEluZGV4LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5kZXguY3BwCShyZXZpc2lv biA0OTMxMykKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhJbmRleC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM2Nyw3ICszNjcsNiBAQAogI2luY2x1ZGUgIlY4U1ZHVHJhbnNmb3JtLmgiCiAjaW5j bHVkZSAiVjhTVkdUcmFuc2Zvcm1MaXN0LmgiCiAjaW5jbHVkZSAiVjhTVkdVbml0VHlwZXMuaCIK LSNpbmNsdWRlICJWOFNWR1VSSVJlZmVyZW5jZS5oIgogI2luY2x1ZGUgIlY4U1ZHWm9vbUV2ZW50 LmgiCiAjZW5kaWYKIAo=